31724 2009-11-20 09:11:05 -0800 Make commit-queue and style-queue show up in help 2009-11-20 11:06:28 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned commit-queue oldest_to_newest 165322 0 43586 abarth 2009-11-20 09:11:05 -0800 Created attachment 43586 Patch Eric forgot to add cls.name to CommitQueue and StyleQueue when he converted the Commands to auto-register themselves. 165323 1 43587 abarth 2009-11-20 09:12:16 -0800 Created attachment 43587 Patch 165358 2 43587 eric 2009-11-20 10:46:49 -0800 Comment on attachment 43587 Patch LGTM. 165366 3 43587 commit-queue 2009-11-20 11:06:21 -0800 Comment on attachment 43587 Patch Clearing flags on attachment: 43587 Committed r51244: <http://trac.webkit.org/changeset/51244> 165367 4 commit-queue 2009-11-20 11:06:28 -0800 All reviewed patches have been landed. Closing bug. 43586 2009-11-20 09:11:05 -0800 2009-11-20 09:12:12 -0800 Patch 20091120091103.patch text/plain 3128 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbCBiL1dlYktpdFRv b2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbAppbmRleCA5MjI1OTVhLi42ZDhiZmVmIDEwMDc1NQot LS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL2J1Z3ppbGxhLXRvb2wKKysrIGIvV2ViS2l0VG9vbHMv U2NyaXB0cy9idWd6aWxsYS10b29sCkBAIC02MzIsMzAgKzYzMiwyOSBAQCBjbGFzcyBUcmVlU3Rh dHVzKENvbW1hbmQpOgogCiAKIGNsYXNzIEFic3RyYWN0UXVldWUoQ29tbWFuZCwgV29ya1F1ZXVl RGVsZWdhdGUpOgotICAgIGRlZiBfX2luaXRfXyhzZWxmLCBuYW1lKToKLSAgICAgICAgc2VsZi5f bmFtZSA9IG5hbWUKKyAgICBkZWYgX19pbml0X18oc2VsZik6CiAgICAgICAgIG9wdGlvbnMgPSBb CiAgICAgICAgICAgICBtYWtlX29wdGlvbigiLS1uby1jb25maXJtIiwgYWN0aW9uPSJzdG9yZV9m YWxzZSIsIGRlc3Q9ImNvbmZpcm0iLCBkZWZhdWx0PVRydWUsIGhlbHA9IkRvIG5vdCBhc2sgdGhl IHVzZXIgZm9yIGNvbmZpcm1hdGlvbiBiZWZvcmUgcnVubmluZyB0aGUgcXVldWUuICBEYW5nZXJv dXMhIiksCiAgICAgICAgICAgICBtYWtlX29wdGlvbigiLS1zdGF0dXMtaG9zdCIsIGFjdGlvbj0i c3RvcmUiLCB0eXBlPSJzdHJpbmciLCBkZXN0PSJzdGF0dXNfaG9zdCIsIGRlZmF1bHQ9U3RhdHVz Qm90LmRlZmF1bHRfaG9zdCwgaGVscD0iSG9zdG5hbWUgKGUuZy4gbG9jYWxob3N0IG9yIGNvbW1p dC53ZWJraXQub3JnKSB3aGVyZSBzdGF0dXMgdXBkYXRlcyBzaG91bGQgYmUgcG9zdGVkLiIpLAog ICAgICAgICBdCi0gICAgICAgIENvbW1hbmQuX19pbml0X18oc2VsZiwgIlJ1biB0aGUgJXMuIiAl IHNlbGYuX25hbWUsIG9wdGlvbnM9b3B0aW9ucykKKyAgICAgICAgQ29tbWFuZC5fX2luaXRfXyhz ZWxmLCAiUnVuIHRoZSAlcy4iICUgc2VsZi5uYW1lLCBvcHRpb25zPW9wdGlvbnMpCiAKICAgICBk ZWYgcXVldWVfbG9nX3BhdGgoc2VsZik6Ci0gICAgICAgIHJldHVybiAiJXMubG9nIiAlIHNlbGYu X25hbWUKKyAgICAgICAgcmV0dXJuICIlcy5sb2ciICUgc2VsZi5uYW1lCiAKICAgICBkZWYgd29y a19sb2dzX2RpcmVjdG9yeShzZWxmKToKLSAgICAgICAgcmV0dXJuICIlcy1sb2dzIiAlIHNlbGYu X25hbWUKKyAgICAgICAgcmV0dXJuICIlcy1sb2dzIiAlIHNlbGYubmFtZQogCiAgICAgZGVmIHN0 YXR1c19ob3N0KHNlbGYpOgogICAgICAgICByZXR1cm4gc2VsZi5vcHRpb25zLnN0YXR1c19ob3N0 CiAKICAgICBkZWYgYmVnaW5fd29ya19xdWV1ZShzZWxmKToKLSAgICAgICAgbG9nKCJDQVVUSU9O OiAlcyB3aWxsIGRpc2NhcmQgYWxsIGxvY2FsIGNoYW5nZXMgaW4gJXMiICUgKHNlbGYuX25hbWUs IHNlbGYudG9vbC5zY20oKS5jaGVja291dF9yb290KSkKKyAgICAgICAgbG9nKCJDQVVUSU9OOiAl cyB3aWxsIGRpc2NhcmQgYWxsIGxvY2FsIGNoYW5nZXMgaW4gJXMiICUgKHNlbGYubmFtZSwgc2Vs Zi50b29sLnNjbSgpLmNoZWNrb3V0X3Jvb3QpKQogICAgICAgICBpZiBzZWxmLm9wdGlvbnMuY29u ZmlybToKICAgICAgICAgICAgIHJlc3BvbnNlID0gcmF3X2lucHV0KCJBcmUgeW91IHN1cmU/ICBU eXBlIFwieWVzXCIgdG8gY29udGludWU6ICIpCiAgICAgICAgICAgICBpZiAocmVzcG9uc2UgIT0g InllcyIpOgogICAgICAgICAgICAgICAgIGVycm9yKCJVc2VyIGRlY2xpbmVkLiIpCi0gICAgICAg IGxvZygiUnVubmluZyBXZWJLaXQgJXMuICVzIiAlIChzZWxmLl9uYW1lLCBkYXRldGltZS5ub3co KS5zdHJmdGltZShXb3JrUXVldWUubG9nX2RhdGVfZm9ybWF0KSkpCisgICAgICAgIGxvZygiUnVu bmluZyBXZWJLaXQgJXMuICVzIiAlIChzZWxmLm5hbWUsIGRhdGV0aW1lLm5vdygpLnN0cmZ0aW1l KFdvcmtRdWV1ZS5sb2dfZGF0ZV9mb3JtYXQpKSkKIAogICAgIGRlZiBzaG91bGRfY29udGludWVf d29ya19xdWV1ZShzZWxmKToKICAgICAgICAgcmV0dXJuIFRydWUKQEAgLTY3OSw3ICs2NzgsNyBA QCBjbGFzcyBBYnN0cmFjdFF1ZXVlKENvbW1hbmQsIFdvcmtRdWV1ZURlbGVnYXRlKToKICAgICAg ICAgV2ViS2l0TGFuZGluZ1NjcmlwdHMucnVuX2FuZF90aHJvd19pZl9mYWlsKGJ1Z3ppbGxhX3Rv b2xfYXJncykKIAogICAgIGRlZiBsb2dfcHJvZ3Jlc3Moc2VsZiwgcGF0Y2hfaWRzKToKLSAgICAg ICAgbG9nKCIlcyBpbiAlcyBbJXNdIiAlIChwbHVyYWxpemUoInBhdGNoIiwgbGVuKHBhdGNoX2lk cykpLCBzZWxmLl9uYW1lLCAiLCAiLmpvaW4ocGF0Y2hfaWRzKSkpCisgICAgICAgIGxvZygiJXMg aW4gJXMgWyVzXSIgJSAocGx1cmFsaXplKCJwYXRjaCIsIGxlbihwYXRjaF9pZHMpKSwgc2VsZi5u YW1lLCAiLCAiLmpvaW4ocGF0Y2hfaWRzKSkpCiAKICAgICBkZWYgZXhlY3V0ZShzZWxmLCBvcHRp b25zLCBhcmdzLCB0b29sKToKICAgICAgICAgc2VsZi5vcHRpb25zID0gb3B0aW9ucwpAQCAtNjg5 LDggKzY4OCw5IEBAIGNsYXNzIEFic3RyYWN0UXVldWUoQ29tbWFuZCwgV29ya1F1ZXVlRGVsZWdh dGUpOgogCiAKIGNsYXNzIENvbW1pdFF1ZXVlKEFic3RyYWN0UXVldWUpOgorICAgIG5hbWUgPSAi Y29tbWl0LXF1ZXVlIgogICAgIGRlZiBfX2luaXRfXyhzZWxmKToKLSAgICAgICAgQWJzdHJhY3RR dWV1ZS5fX2luaXRfXyhzZWxmLCAiY29tbWl0LXF1ZXVlIikKKyAgICAgICAgQWJzdHJhY3RRdWV1 ZS5fX2luaXRfXyhzZWxmKQogCiAgICAgZGVmIGJlZ2luX3dvcmtfcXVldWUoc2VsZik6CiAgICAg ICAgIEFic3RyYWN0UXVldWUuYmVnaW5fd29ya19xdWV1ZShzZWxmKQpAQCAtNzE4LDggKzcxOCw5 IEBAIGNsYXNzIENvbW1pdFF1ZXVlKEFic3RyYWN0UXVldWUpOgogCiAKIGNsYXNzIFN0eWxlUXVl dWUoQWJzdHJhY3RRdWV1ZSk6CisgICAgbmFtZSA9ICJzdHlsZS1xdWV1ZSIKICAgICBkZWYgX19p bml0X18oc2VsZik6Ci0gICAgICAgIEFic3RyYWN0UXVldWUuX19pbml0X18oc2VsZiwgInN0eWxl LXF1ZXVlIikKKyAgICAgICAgQWJzdHJhY3RRdWV1ZS5fX2luaXRfXyhzZWxmKQogCiAgICAgZGVm IHN0YXR1c19ob3N0KHNlbGYpOgogICAgICAgICByZXR1cm4gTm9uZSAjIEZJWE1FOiBBIGhhY2sg dW50aWwgd2UgY29tZSB1cCB3aXRoIGEgbW9yZSBnZW5lcmljIHN0YXR1cyBwYWdlLgo= 43587 2009-11-20 09:12:16 -0800 2009-11-20 11:06:20 -0800 Patch bug-31724-20091120091215.patch text/plain 3815 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlOWU1ZTJkLi4xOWQwZGI4IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTggQEAKIAogICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBNYWtlIGNvbW1pdC1xdWV1 ZSBhbmQgc3R5bGUtcXVldWUgc2hvdyB1cCBpbiBoZWxwCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTcyNAorCisgICAgICAgIFdlIG5lZWQgdG8gc3Rv cmUgdGhlaXIgbmFtZXMgb24gdGhlaXIgY2xhc3MgdG8gbWFrZSB0aGVzZSBjb21tYW5kcworICAg ICAgICBwcm9wZXJseSByZWdpc3RlciB0aGVtc2VsdmVzIHdpdGggTXVsdGlDb21tYW5kVG9vbC4K KworICAgICAgICAqIFNjcmlwdHMvYnVnemlsbGEtdG9vbDoKKworMjAwOS0xMS0yMCAgQWRhbSBC YXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCiAgICAgICAgIEltcGxlbWVudCBidWd6aWxsYS10b29sIGJ1aWxkLWF0dGFjaG1l bnQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNzIy CiAKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbCBiL1dlYktp dFRvb2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbAppbmRleCA5MjI1OTVhLi42ZDhiZmVmIDEwMDc1 NQotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL2J1Z3ppbGxhLXRvb2wKKysrIGIvV2ViS2l0VG9v bHMvU2NyaXB0cy9idWd6aWxsYS10b29sCkBAIC02MzIsMzAgKzYzMiwyOSBAQCBjbGFzcyBUcmVl U3RhdHVzKENvbW1hbmQpOgogCiAKIGNsYXNzIEFic3RyYWN0UXVldWUoQ29tbWFuZCwgV29ya1F1 ZXVlRGVsZWdhdGUpOgotICAgIGRlZiBfX2luaXRfXyhzZWxmLCBuYW1lKToKLSAgICAgICAgc2Vs Zi5fbmFtZSA9IG5hbWUKKyAgICBkZWYgX19pbml0X18oc2VsZik6CiAgICAgICAgIG9wdGlvbnMg PSBbCiAgICAgICAgICAgICBtYWtlX29wdGlvbigiLS1uby1jb25maXJtIiwgYWN0aW9uPSJzdG9y ZV9mYWxzZSIsIGRlc3Q9ImNvbmZpcm0iLCBkZWZhdWx0PVRydWUsIGhlbHA9IkRvIG5vdCBhc2sg dGhlIHVzZXIgZm9yIGNvbmZpcm1hdGlvbiBiZWZvcmUgcnVubmluZyB0aGUgcXVldWUuICBEYW5n ZXJvdXMhIiksCiAgICAgICAgICAgICBtYWtlX29wdGlvbigiLS1zdGF0dXMtaG9zdCIsIGFjdGlv bj0ic3RvcmUiLCB0eXBlPSJzdHJpbmciLCBkZXN0PSJzdGF0dXNfaG9zdCIsIGRlZmF1bHQ9U3Rh dHVzQm90LmRlZmF1bHRfaG9zdCwgaGVscD0iSG9zdG5hbWUgKGUuZy4gbG9jYWxob3N0IG9yIGNv bW1pdC53ZWJraXQub3JnKSB3aGVyZSBzdGF0dXMgdXBkYXRlcyBzaG91bGQgYmUgcG9zdGVkLiIp LAogICAgICAgICBdCi0gICAgICAgIENvbW1hbmQuX19pbml0X18oc2VsZiwgIlJ1biB0aGUgJXMu IiAlIHNlbGYuX25hbWUsIG9wdGlvbnM9b3B0aW9ucykKKyAgICAgICAgQ29tbWFuZC5fX2luaXRf XyhzZWxmLCAiUnVuIHRoZSAlcy4iICUgc2VsZi5uYW1lLCBvcHRpb25zPW9wdGlvbnMpCiAKICAg ICBkZWYgcXVldWVfbG9nX3BhdGgoc2VsZik6Ci0gICAgICAgIHJldHVybiAiJXMubG9nIiAlIHNl bGYuX25hbWUKKyAgICAgICAgcmV0dXJuICIlcy5sb2ciICUgc2VsZi5uYW1lCiAKICAgICBkZWYg d29ya19sb2dzX2RpcmVjdG9yeShzZWxmKToKLSAgICAgICAgcmV0dXJuICIlcy1sb2dzIiAlIHNl bGYuX25hbWUKKyAgICAgICAgcmV0dXJuICIlcy1sb2dzIiAlIHNlbGYubmFtZQogCiAgICAgZGVm IHN0YXR1c19ob3N0KHNlbGYpOgogICAgICAgICByZXR1cm4gc2VsZi5vcHRpb25zLnN0YXR1c19o b3N0CiAKICAgICBkZWYgYmVnaW5fd29ya19xdWV1ZShzZWxmKToKLSAgICAgICAgbG9nKCJDQVVU SU9OOiAlcyB3aWxsIGRpc2NhcmQgYWxsIGxvY2FsIGNoYW5nZXMgaW4gJXMiICUgKHNlbGYuX25h bWUsIHNlbGYudG9vbC5zY20oKS5jaGVja291dF9yb290KSkKKyAgICAgICAgbG9nKCJDQVVUSU9O OiAlcyB3aWxsIGRpc2NhcmQgYWxsIGxvY2FsIGNoYW5nZXMgaW4gJXMiICUgKHNlbGYubmFtZSwg c2VsZi50b29sLnNjbSgpLmNoZWNrb3V0X3Jvb3QpKQogICAgICAgICBpZiBzZWxmLm9wdGlvbnMu Y29uZmlybToKICAgICAgICAgICAgIHJlc3BvbnNlID0gcmF3X2lucHV0KCJBcmUgeW91IHN1cmU/ ICBUeXBlIFwieWVzXCIgdG8gY29udGludWU6ICIpCiAgICAgICAgICAgICBpZiAocmVzcG9uc2Ug IT0gInllcyIpOgogICAgICAgICAgICAgICAgIGVycm9yKCJVc2VyIGRlY2xpbmVkLiIpCi0gICAg ICAgIGxvZygiUnVubmluZyBXZWJLaXQgJXMuICVzIiAlIChzZWxmLl9uYW1lLCBkYXRldGltZS5u b3coKS5zdHJmdGltZShXb3JrUXVldWUubG9nX2RhdGVfZm9ybWF0KSkpCisgICAgICAgIGxvZygi UnVubmluZyBXZWJLaXQgJXMuICVzIiAlIChzZWxmLm5hbWUsIGRhdGV0aW1lLm5vdygpLnN0cmZ0 aW1lKFdvcmtRdWV1ZS5sb2dfZGF0ZV9mb3JtYXQpKSkKIAogICAgIGRlZiBzaG91bGRfY29udGlu dWVfd29ya19xdWV1ZShzZWxmKToKICAgICAgICAgcmV0dXJuIFRydWUKQEAgLTY3OSw3ICs2Nzgs NyBAQCBjbGFzcyBBYnN0cmFjdFF1ZXVlKENvbW1hbmQsIFdvcmtRdWV1ZURlbGVnYXRlKToKICAg ICAgICAgV2ViS2l0TGFuZGluZ1NjcmlwdHMucnVuX2FuZF90aHJvd19pZl9mYWlsKGJ1Z3ppbGxh X3Rvb2xfYXJncykKIAogICAgIGRlZiBsb2dfcHJvZ3Jlc3Moc2VsZiwgcGF0Y2hfaWRzKToKLSAg ICAgICAgbG9nKCIlcyBpbiAlcyBbJXNdIiAlIChwbHVyYWxpemUoInBhdGNoIiwgbGVuKHBhdGNo X2lkcykpLCBzZWxmLl9uYW1lLCAiLCAiLmpvaW4ocGF0Y2hfaWRzKSkpCisgICAgICAgIGxvZygi JXMgaW4gJXMgWyVzXSIgJSAocGx1cmFsaXplKCJwYXRjaCIsIGxlbihwYXRjaF9pZHMpKSwgc2Vs Zi5uYW1lLCAiLCAiLmpvaW4ocGF0Y2hfaWRzKSkpCiAKICAgICBkZWYgZXhlY3V0ZShzZWxmLCBv cHRpb25zLCBhcmdzLCB0b29sKToKICAgICAgICAgc2VsZi5vcHRpb25zID0gb3B0aW9ucwpAQCAt Njg5LDggKzY4OCw5IEBAIGNsYXNzIEFic3RyYWN0UXVldWUoQ29tbWFuZCwgV29ya1F1ZXVlRGVs ZWdhdGUpOgogCiAKIGNsYXNzIENvbW1pdFF1ZXVlKEFic3RyYWN0UXVldWUpOgorICAgIG5hbWUg PSAiY29tbWl0LXF1ZXVlIgogICAgIGRlZiBfX2luaXRfXyhzZWxmKToKLSAgICAgICAgQWJzdHJh Y3RRdWV1ZS5fX2luaXRfXyhzZWxmLCAiY29tbWl0LXF1ZXVlIikKKyAgICAgICAgQWJzdHJhY3RR dWV1ZS5fX2luaXRfXyhzZWxmKQogCiAgICAgZGVmIGJlZ2luX3dvcmtfcXVldWUoc2VsZik6CiAg ICAgICAgIEFic3RyYWN0UXVldWUuYmVnaW5fd29ya19xdWV1ZShzZWxmKQpAQCAtNzE4LDggKzcx OCw5IEBAIGNsYXNzIENvbW1pdFF1ZXVlKEFic3RyYWN0UXVldWUpOgogCiAKIGNsYXNzIFN0eWxl UXVldWUoQWJzdHJhY3RRdWV1ZSk6CisgICAgbmFtZSA9ICJzdHlsZS1xdWV1ZSIKICAgICBkZWYg X19pbml0X18oc2VsZik6Ci0gICAgICAgIEFic3RyYWN0UXVldWUuX19pbml0X18oc2VsZiwgInN0 eWxlLXF1ZXVlIikKKyAgICAgICAgQWJzdHJhY3RRdWV1ZS5fX2luaXRfXyhzZWxmKQogCiAgICAg ZGVmIHN0YXR1c19ob3N0KHNlbGYpOgogICAgICAgICByZXR1cm4gTm9uZSAjIEZJWE1FOiBBIGhh Y2sgdW50aWwgd2UgY29tZSB1cCB3aXRoIGEgbW9yZSBnZW5lcmljIHN0YXR1cyBwYWdlLgo=