31717 2009-11-20 04:14:15 -0800 [GTK] DRT release event does not create the state correctly 2009-11-20 09:45:42 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 alex webkit-unassigned commit-queue xan.lopez oldest_to_newest 165271 0 alex 2009-11-20 04:14:15 -0800 The release events we synthesize in the DRT do not consider the state of the mouse, it is more correct to add the same state we add to the motion events. Apparently this is not causing any problem though. 165280 1 43572 alex 2009-11-20 05:06:02 -0800 Created attachment 43572 Proposed patch, adds state info to release events 165281 2 43572 xan.lopez 2009-11-20 05:12:16 -0800 Comment on attachment 43572 Proposed patch, adds state info to release events LGTM. 165283 3 43572 commit-queue 2009-11-20 05:18:01 -0800 Comment on attachment 43572 Proposed patch, adds state info to release events Rejecting patch 43572 from commit-queue. Unexpected failure when landing patch! Please file a bug against bugzilla-tool. Failed to run "['WebKitTools/Scripts/bugzilla-tool', 'land-attachment', '--force-clean', '--non-interactive', '--quiet', '43572']" exit_code: 1 Last 500 characters of output: ingsequence.py", line 49, in run self.test() File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 113, in test LandingSequence.test(self) File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 81, in test WebKitScripts.run_webkit_tests(launch_safari=not options.non_interactive, fail_fast=options.non_interactive, quiet=options.quiet, port=port) NameError: global name 'WebKitScripts' is not defined 165334 4 43572 xan.lopez 2009-11-20 09:36:15 -0800 Comment on attachment 43572 Proposed patch, adds state info to release events Let's try again... 165336 5 43572 commit-queue 2009-11-20 09:45:38 -0800 Comment on attachment 43572 Proposed patch, adds state info to release events Clearing flags on attachment: 43572 Committed r51239: <http://trac.webkit.org/changeset/51239> 165337 6 commit-queue 2009-11-20 09:45:42 -0800 All reviewed patches have been landed. Closing bug. 43572 2009-11-20 05:06:02 -0800 2009-11-20 09:45:38 -0800 Proposed patch, adds state info to release events DRT-release-events.patch text/plain 2803 alex ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAzOTg1YTJiLi40ZGY1MzVlIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMTEt MjAgIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gRFJUIHJlbGVhc2UgZXZl bnQgZG9lcyBub3QgY3JlYXRlIHRoZSBzdGF0ZSBjb3JyZWN0bHkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNzE3CisKKyAgICAgICAgKiBXZWJLaXRU b29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRXZlbnRTZW5kZXIuY3BwOgorCiAyMDA5LTExLTIwICBB ZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJp YyBTZWlkZWwuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRXZl bnRTZW5kZXIuY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0V2ZW50U2VuZGVy LmNwcAppbmRleCBmNDI5MjhjLi42MjY4YjViIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1w UmVuZGVyVHJlZS9ndGsvRXZlbnRTZW5kZXIuY3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5k ZXJUcmVlL2d0ay9FdmVudFNlbmRlci5jcHAKQEAgLTIwMCw2ICsyMDAsMjMgQEAgc3RhdGljIEpT VmFsdWVSZWYgbW91c2VEb3duQ2FsbGJhY2soSlNDb250ZXh0UmVmIGNvbnRleHQsIEpTT2JqZWN0 UmVmIGZ1bmN0aW9uLAogICAgIHJldHVybiBKU1ZhbHVlTWFrZVVuZGVmaW5lZChjb250ZXh0KTsK IH0KIAorc3RhdGljIGd1aW50IGdldFN0YXRlRmxhZ3MoKQoreworICAgIGd1aW50IHN0YXRlID0g MDsKKworICAgIGlmIChkb3duKSB7CisgICAgICAgIGlmIChjdXJyZW50RXZlbnRCdXR0b24gPT0g MSkKKyAgICAgICAgICAgIHN0YXRlID0gR0RLX0JVVFRPTjFfTUFTSzsKKyAgICAgICAgZWxzZSBp ZiAoY3VycmVudEV2ZW50QnV0dG9uID09IDIpCisgICAgICAgICAgICBzdGF0ZSA9IEdES19CVVRU T04yX01BU0s7CisgICAgICAgIGVsc2UgaWYgKGN1cnJlbnRFdmVudEJ1dHRvbiA9PSAzKQorICAg ICAgICAgICAgc3RhdGUgPSBHREtfQlVUVE9OM19NQVNLOworICAgIH0gZWxzZQorICAgICAgICBz dGF0ZSA9IDA7CisKKyAgICByZXR1cm4gc3RhdGU7Cit9CisKIHN0YXRpYyBKU1ZhbHVlUmVmIG1v dXNlVXBDYWxsYmFjayhKU0NvbnRleHRSZWYgY29udGV4dCwgSlNPYmplY3RSZWYgZnVuY3Rpb24s IEpTT2JqZWN0UmVmIHRoaXNPYmplY3QsIHNpemVfdCBhcmd1bWVudENvdW50LCBjb25zdCBKU1Zh bHVlUmVmIGFyZ3VtZW50c1tdLCBKU1ZhbHVlUmVmKiBleGNlcHRpb24pCiB7CiAKQEAgLTIwNyw4 ICsyMjQsNiBAQCBzdGF0aWMgSlNWYWx1ZVJlZiBtb3VzZVVwQ2FsbGJhY2soSlNDb250ZXh0UmVm IGNvbnRleHQsIEpTT2JqZWN0UmVmIGZ1bmN0aW9uLCBKUwogICAgIGlmICghdmlldykKICAgICAg ICAgcmV0dXJuIEpTVmFsdWVNYWtlVW5kZWZpbmVkKGNvbnRleHQpOwogCi0gICAgZG93biA9IGZh bHNlOwotCiAgICAgR2RrRXZlbnQgZXZlbnQ7CiAgICAgbWVtc2V0KCZldmVudCwgMCwgc2l6ZW9m KGV2ZW50KSk7CiAgICAgZXZlbnQudHlwZSA9IEdES19CVVRUT05fUkVMRUFTRTsKQEAgLTIyNiw2 ICsyNDEsOSBAQCBzdGF0aWMgSlNWYWx1ZVJlZiBtb3VzZVVwQ2FsbGJhY2soSlNDb250ZXh0UmVm IGNvbnRleHQsIEpTT2JqZWN0UmVmIGZ1bmN0aW9uLCBKUwogICAgIGV2ZW50LmJ1dHRvbi53aW5k b3cgPSBHVEtfV0lER0VUKHZpZXcpLT53aW5kb3c7CiAgICAgZXZlbnQuYnV0dG9uLnRpbWUgPSBH REtfQ1VSUkVOVF9USU1FOwogICAgIGV2ZW50LmJ1dHRvbi5kZXZpY2UgPSBnZGtfZGV2aWNlX2dl dF9jb3JlX3BvaW50ZXIoKTsKKyAgICBldmVudC5idXR0b24uc3RhdGUgPSBnZXRTdGF0ZUZsYWdz KCk7CisKKyAgICBkb3duID0gZmFsc2U7CiAKICAgICBpbnQgeF9yb290LCB5X3Jvb3Q7CiAjaWYg R1RLX0NIRUNLX1ZFUlNJT04oMiwxNywzKQpAQCAtMjg2LDE2ICszMDQsOCBAQCBzdGF0aWMgSlNW YWx1ZVJlZiBtb3VzZU1vdmVUb0NhbGxiYWNrKEpTQ29udGV4dFJlZiBjb250ZXh0LCBKU09iamVj dFJlZiBmdW5jdGlvbgogCiAgICAgZXZlbnQubW90aW9uLnhfcm9vdCA9IHhfcm9vdDsKICAgICBl dmVudC5tb3Rpb24ueV9yb290ID0geV9yb290OwotCi0gICAgaWYgKGRvd24pIHsKLSAgICAgICAg aWYgKGN1cnJlbnRFdmVudEJ1dHRvbiA9PSAxKQotICAgICAgICAgICAgZXZlbnQubW90aW9uLnN0 YXRlID0gR0RLX0JVVFRPTjFfTUFTSzsKLSAgICAgICAgZWxzZSBpZiAoY3VycmVudEV2ZW50QnV0 dG9uID09IDIpCi0gICAgICAgICAgICBldmVudC5tb3Rpb24uc3RhdGUgPSBHREtfQlVUVE9OMl9N QVNLOwotICAgICAgICBlbHNlIGlmIChjdXJyZW50RXZlbnRCdXR0b24gPT0gMykKLSAgICAgICAg ICAgIGV2ZW50Lm1vdGlvbi5zdGF0ZSA9IEdES19CVVRUT04zX01BU0s7Ci0gICAgfSBlbHNlCi0g ICAgICAgIGV2ZW50Lm1vdGlvbi5zdGF0ZSA9IDA7CisgICAgCisgICAgZXZlbnQubW90aW9uLnN0 YXRlID0gZ2V0U3RhdGVGbGFncygpOwogCiAgICAgaWYgKGRyYWdNb2RlICYmIGRvd24gJiYgIXJl cGxheWluZ1NhdmVkRXZlbnRzKSB7CiAgICAgICAgIG1zZ1F1ZXVlW2VuZE9mUXVldWVdLmV2ZW50 ID0gZXZlbnQ7Cg==