31715 2009-11-20 03:26:19 -0800 [Android] Android port lacks implementation of atomicIncrement and atomicDecrement 2009-11-23 03:30:38 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 steveblock steveblock android-webkit-unforking steveblock oldest_to_newest 165264 0 steveblock 2009-11-20 03:26:19 -0800 The Android port lacks implementation of atomicIncrement and atomicDecrement. See JavaScriptCore/wtf/Threading.h. 165267 1 43570 steveblock 2009-11-20 03:59:38 -0800 Created attachment 43570 Patch 1 for Bug 31715 165606 2 43570 eric 2009-11-21 07:19:13 -0800 Comment on attachment 43570 Patch 1 for Bug 31715 I'm surprised that you don't use < > for the system header include: 77 #include "cutils/atomic.h" But otherwise this looks fine. 165814 3 steveblock 2009-11-23 03:30:38 -0800 > I'm surprised that you don't use < > for the system header include: > 77 #include "cutils/atomic.h" Fixed Submitted as http://trac.webkit.org/changeset/51305 43570 2009-11-20 03:59:38 -0800 2009-11-21 07:19:12 -0800 Patch 1 for Bug 31715 implementAtomicIncrement.txt text/plain 1842 steveblock SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUxMjM0KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTEtMjAgIFN0ZXZlIEJs b2NrICA8c3RldmVibG9ja0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFuZHJvaWQgcG9ydCBsYWNrcyBpbXBsZW1lbnRhdGlvbiBv ZiBhdG9taWNJbmNyZW1lbnQgYW5kIGF0b21pY0RlY3JlbWVudC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNzE1CisKKyAgICAgICAgKiB3dGYvVGhy ZWFkaW5nLmg6IE1vZGlmaWVkLgorICAgICAgICAoV1RGOjphdG9taWNJbmNyZW1lbnQpOiBBZGRl ZCBBbmRyb2lkIGltcGxlbWVudGF0aW9uLgorICAgICAgICAoV1RGOjphdG9taWNEZWNyZW1lbnQp OiBBZGRlZCBBbmRyb2lkIGltcGxlbWVudGF0aW9uLgorCiAyMDA5LTExLTE5ICBTdGV2ZSBCbG9j ayAgPHN0ZXZlYmxvY2tAZ29vZ2xlLmNvbT4KIAogICAgICAgICBBbmRyb2lkIHBvcnQgbGFja3Mg Y29uZmlndXJhdGlvbiBpbiBQbGF0Zm9ybS5oIGFuZCBjb25maWcuaC4KSW5kZXg6IEphdmFTY3Jp cHRDb3JlL3d0Zi9UaHJlYWRpbmcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYv VGhyZWFkaW5nLmgJKHJldmlzaW9uIDUxMjMzKQorKysgSmF2YVNjcmlwdENvcmUvd3RmL1RocmVh ZGluZy5oCSh3b3JraW5nIGNvcHkpCkBAIC03Myw2ICs3Myw4IEBACiAjaW5jbHVkZSA8d2luZG93 cy5oPgogI2VsaWYgUExBVEZPUk0oREFSV0lOKQogI2luY2x1ZGUgPGxpYmtlcm4vT1NBdG9taWMu aD4KKyNlbGlmIFBMQVRGT1JNKEFORFJPSUQpCisjaW5jbHVkZSAiY3V0aWxzL2F0b21pYy5oIgog I2VsaWYgQ09NUElMRVIoR0NDKQogI2lmIChfX0dOVUNfXyA+IDQpIHx8ICgoX19HTlVDX18gPT0g NCkgJiYgKF9fR05VQ19NSU5PUl9fID49IDIpKQogI2luY2x1ZGUgPGV4dC9hdG9taWNpdHkuaD4K QEAgLTIzMiw2ICsyMzQsMTEgQEAgaW5saW5lIGludCBhdG9taWNEZWNyZW1lbnQoaW50IHZvbGF0 aWxlKgogaW5saW5lIGludCBhdG9taWNJbmNyZW1lbnQoaW50IHZvbGF0aWxlKiBhZGRlbmQpIHsg cmV0dXJuIE9TQXRvbWljSW5jcmVtZW50MzJCYXJyaWVyKGNvbnN0X2Nhc3Q8aW50Kj4oYWRkZW5k KSk7IH0KIGlubGluZSBpbnQgYXRvbWljRGVjcmVtZW50KGludCB2b2xhdGlsZSogYWRkZW5kKSB7 IHJldHVybiBPU0F0b21pY0RlY3JlbWVudDMyQmFycmllcihjb25zdF9jYXN0PGludCo+KGFkZGVu ZCkpOyB9CiAKKyNlbGlmIFBMQVRGT1JNKEFORFJPSUQpCisKK2lubGluZSBpbnQgYXRvbWljSW5j cmVtZW50KGludCB2b2xhdGlsZSogYWRkZW5kKSB7IHJldHVybiBhbmRyb2lkX2F0b21pY19pbmMo YWRkZW5kKTsgfQoraW5saW5lIGludCBhdG9taWNEZWNyZW1lbnQoaW50IHZvbGF0aWxlKiBhZGRl bmQpIHsgcmV0dXJuIGFuZHJvaWRfYXRvbWljX2RlYyhhZGRlbmQpOyB9CisKICNlbGlmIENPTVBJ TEVSKEdDQykgJiYgIVBMQVRGT1JNKFNQQVJDNjQpIC8vIHNpemVvZihfQXRvbWljX3dvcmQpICE9 IHNpemVvZihpbnQpIG9uIHNwYXJjNjQgZ2NjCiAjZGVmaW5lIFdURl9VU0VfTE9DS0ZSRUVfVEhS RUFEU0FGRVNIQVJFRCAxCiAK