31712 2009-11-20 01:02:12 -0800 [Chromium] Ignore line-height CSS property for PushButton 2009-11-27 22:15:23 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Windows Vista RESOLVED FIXED P2 Normal --- 1 tkent tkent commit-queue hamaji oldest_to_newest 165246 0 tkent 2009-11-20 01:02:12 -0800 http://crbug.com/20551 LayoutTests/fast/forms/control-restrict-line-height.html checks that the following controls should ignore line-height CSS property, and Chromium/Windows and Chromium/Linux don't ignore it for button and search. - <select> - <input type=button> - <input type=search> This bug addresses the button case. 165253 1 43566 tkent 2009-11-20 01:14:33 -0800 Created attachment 43566 Proposed patch 165605 2 43566 eric 2009-11-21 07:18:09 -0800 Comment on attachment 43566 Proposed patch Your ChangeLog should document which tests cover this change. Otherwise this looks fine. 165970 3 43744 tkent 2009-11-23 17:48:12 -0800 Created attachment 43744 Proposed patch (rev.2) * Improved ChangeLog 166006 4 tkent 2009-11-23 23:06:37 -0800 I forgot to mention that this change didn't break existing LayoutTests. 166834 5 43744 eric 2009-11-26 21:41:24 -0800 Comment on attachment 43744 Proposed patch (rev.2) LGTM. 166840 6 43744 commit-queue 2009-11-26 22:00:03 -0800 Comment on attachment 43744 Proposed patch (rev.2) Clearing flags on attachment: 43744 Committed r51428: <http://trac.webkit.org/changeset/51428> 166842 7 commit-queue 2009-11-26 22:00:08 -0800 All reviewed patches have been landed. Closing bug. 167001 8 hamaji 2009-11-27 22:15:23 -0800 Committed r51455: <http://trac.webkit.org/changeset/51455> 43566 2009-11-20 01:14:33 -0800 2009-11-23 17:48:12 -0800 Proposed patch 0001-line-height-1.patch text/plain 2495 tkent RnJvbSBjN2FhZDI2ZjA0NGJkNzhkMTkyZWQ0NDgyMGVjNzI1NDQ5MWY2NzU0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW50IFRhbXVyYSA8dGtlbnRAY2hyb21pdW0ub3JnPgpEYXRl OiBGcmksIDIwIE5vdiAyMDA5IDE4OjEwOjUyICswOTAwClN1YmplY3Q6IFtQQVRDSF0gbGluZS1o ZWlnaHQtMQoKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgfCAgIDEwICsrKysrKysrKysKIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21p dW1Ta2lhLmNwcCB8ICAgIDkgKysrKysrKysrCiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVt ZUNocm9taXVtU2tpYS5oICAgfCAgICAxICsKIDMgZmlsZXMgY2hhbmdlZCwgMjAgaW5zZXJ0aW9u cygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dl YkNvcmUvQ2hhbmdlTG9nCmluZGV4IGJmYjkzY2IuLjNmYmU4NDAgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIw MDktMTEtMjAgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gSWdub3JlIGxp bmUtaGVpZ2h0IENTUyBwcm9wZXJ0eSBzcGVjaWZpZWQgdG8gcHVzaCBidXR0b25zIG9uIFdpbmRv d3MgYW5kIExpbnV4LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzE3MTIKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtU2tp YS5jcHA6IEltcGxlbWVudCBhZGp1c3RCdXR0b25TdHlsZSgpIHRvIGlnbm9yZSBsaW5lLWhlaWdo dC4KKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVNraWEuaDogRGVjbGFy ZSBhZGp1c3RCdXR0b25TdHlsZSgpLgorCiAyMDA5LTExLTE5ICBKb3NlcGggUGVjb3Jhcm8gIDxq b2VwZWNrQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVGltb3RoeSBIYXRjaGVy LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVNraWEu Y3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVNraWEuY3BwCmluZGV4 IGI1ODJjMTguLmZhMzQxODYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRo ZW1lQ2hyb21pdW1Ta2lhLmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNo cm9taXVtU2tpYS5jcHAKQEAgLTM0OCw2ICszNDgsMTUgQEAgYm9vbCBSZW5kZXJUaGVtZUNocm9t aXVtU2tpYTo6cGFpbnRCdXR0b24oUmVuZGVyT2JqZWN0KiBvLCBjb25zdCBSZW5kZXJPYmplY3Q6 OlAKICAgICByZXR1cm4gZmFsc2U7CiB9CiAKK3ZvaWQgUmVuZGVyVGhlbWVDaHJvbWl1bVNraWE6 OmFkanVzdEJ1dHRvblN0eWxlKENTU1N0eWxlU2VsZWN0b3IqLCBSZW5kZXJTdHlsZSogc3R5bGUs IEVsZW1lbnQqKSBjb25zdDsKK3sKKyAgICBpZiAoc3R5bGUtPmFwcGVhcmFuY2UoKSA9PSBQdXNo QnV0dG9uUGFydCkgeworICAgICAgICAvLyBJZ25vcmUgbGluZS1oZWlnaHQuCisgICAgICAgIHN0 eWxlLT5zZXRMaW5lSGVpZ2h0KFJlbmRlclN0eWxlOjppbml0aWFsTGluZUhlaWdodCgpKTsKKyAg ICB9Cit9CisKKwogYm9vbCBSZW5kZXJUaGVtZUNocm9taXVtU2tpYTo6cGFpbnRUZXh0RmllbGQo UmVuZGVyT2JqZWN0KiBvLCBjb25zdCBSZW5kZXJPYmplY3Q6OlBhaW50SW5mbyYgaSwgY29uc3Qg SW50UmVjdCYgcmVjdCkKIHsKICAgICByZXR1cm4gdHJ1ZTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1Ta2lhLmggYi9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJUaGVtZUNocm9taXVtU2tpYS5oCmluZGV4IDk4ZTNhMzUuLjQ2YWEzYTQgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1Ta2lhLmgKKysrIGIvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVNraWEuaApAQCAtNzEsNiArNzEsNyBA QCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHZpcnR1YWwgdm9pZCBzZXRSYWRpb1NpemUo UmVuZGVyU3R5bGUqKSBjb25zdDsKIAogICAgICAgICB2aXJ0dWFsIGJvb2wgcGFpbnRCdXR0b24o UmVuZGVyT2JqZWN0KiwgY29uc3QgUmVuZGVyT2JqZWN0OjpQYWludEluZm8mLCBjb25zdCBJbnRS ZWN0Jik7CisgICAgICAgIHZpcnR1YWwgdm9pZCBhZGp1c3RCdXR0b25TdHlsZShDU1NTdHlsZVNl bGVjdG9yKiwgUmVuZGVyU3R5bGUqLCBFbGVtZW50KikgY29uc3Q7CiAKICAgICAgICAgdmlydHVh bCBib29sIHBhaW50VGV4dEZpZWxkKFJlbmRlck9iamVjdCosIGNvbnN0IFJlbmRlck9iamVjdDo6 UGFpbnRJbmZvJiwgY29uc3QgSW50UmVjdCYpOwogCi0tIAoxLjYuMy4zCgo= 43744 2009-11-23 17:48:12 -0800 2009-11-26 22:00:03 -0800 Proposed patch (rev.2) 0001-line-height-2.patch text/plain 2440 tkent ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2ZmYmExZC4uZWFjNDRiNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAwOS0xMS0yMCAgS2VudCBUYW11cmEg IDx0a2VudEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBJZ25vcmUgbGluZS1oZWlnaHQgQ1NTIHByb3BlcnR5 IHNwZWNpZmllZCB0byBwdXNoIGJ1dHRvbnMgb24KKyAgICAgICAgV2luZG93cyBhbmQgTGludXgu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTcxMgor CisgICAgICAgIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvY29udHJvbC1yZXN0cmljdC1saW5lLWhl aWdodC5odG1sIGNoZWNrcyB0aGF0IHRoZQorICAgICAgICBmb2xsb3dpbmcgY29udHJvbHMgc2hv dWxkIGlnbm9yZSBsaW5lLWhlaWdodCBDU1MgcHJvcGVydHkuCisgICAgICAgICAtIDxzZWxlY3Q+ CisgICAgICAgICAtIDxpbnB1dCB0eXBlPWJ1dHRvbj4KKyAgICAgICAgIC0gPGlucHV0IHR5cGU9 c2VhcmNoPgorICAgICAgICBUaGlzIGNoYW5nZSBhZGRyZXNzZXMgdGhlIDxpbnB1dCB0eXBlPWJ1 dHRvbj4gaXNzdWUgd2l0aCBDaHJvbWl1bS9XaW5kb3dzCisgICAgICAgIGFuZCBDaHJvbWl1bS9M aW51eC4KKyAgICAgICAgCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1T a2lhLmNwcDogSW1wbGVtZW50IGFkanVzdEJ1dHRvblN0eWxlKCkgdG8gaWdub3JlIGxpbmUtaGVp Z2h0LgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtU2tpYS5oOiBEZWNs YXJlIGFkanVzdEJ1dHRvblN0eWxlKCkuCisKIDIwMDktMTEtMjMgIEFhcm9uIEdvbGRlbiAgPGFn b2xkZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFr b3YuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtU2tp YS5jcHAgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtU2tpYS5jcHAKaW5k ZXggYjU4MmMxOC4uZmEzNDE4NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy VGhlbWVDaHJvbWl1bVNraWEuY3BwCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1l Q2hyb21pdW1Ta2lhLmNwcApAQCAtMzQ4LDYgKzM0OCwxNSBAQCBib29sIFJlbmRlclRoZW1lQ2hy b21pdW1Ta2lhOjpwYWludEJ1dHRvbihSZW5kZXJPYmplY3QqIG8sIGNvbnN0IFJlbmRlck9iamVj dDo6UAogICAgIHJldHVybiBmYWxzZTsKIH0KIAordm9pZCBSZW5kZXJUaGVtZUNocm9taXVtU2tp YTo6YWRqdXN0QnV0dG9uU3R5bGUoQ1NTU3R5bGVTZWxlY3RvciosIFJlbmRlclN0eWxlKiBzdHls ZSwgRWxlbWVudCopIGNvbnN0OworeworICAgIGlmIChzdHlsZS0+YXBwZWFyYW5jZSgpID09IFB1 c2hCdXR0b25QYXJ0KSB7CisgICAgICAgIC8vIElnbm9yZSBsaW5lLWhlaWdodC4KKyAgICAgICAg c3R5bGUtPnNldExpbmVIZWlnaHQoUmVuZGVyU3R5bGU6OmluaXRpYWxMaW5lSGVpZ2h0KCkpOwor ICAgIH0KK30KKworCiBib29sIFJlbmRlclRoZW1lQ2hyb21pdW1Ta2lhOjpwYWludFRleHRGaWVs ZChSZW5kZXJPYmplY3QqIG8sIGNvbnN0IFJlbmRlck9iamVjdDo6UGFpbnRJbmZvJiBpLCBjb25z dCBJbnRSZWN0JiByZWN0KQogewogICAgIHJldHVybiB0cnVlOwpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVNraWEuaCBiL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlclRoZW1lQ2hyb21pdW1Ta2lhLmgKaW5kZXggOThlM2EzNS4uNDZhYTNhNCAxMDA2NDQK LS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVNraWEuaAorKysgYi9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtU2tpYS5oCkBAIC03MSw2ICs3MSw3 IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdmlydHVhbCB2b2lkIHNldFJhZGlvU2l6 ZShSZW5kZXJTdHlsZSopIGNvbnN0OwogCiAgICAgICAgIHZpcnR1YWwgYm9vbCBwYWludEJ1dHRv bihSZW5kZXJPYmplY3QqLCBjb25zdCBSZW5kZXJPYmplY3Q6OlBhaW50SW5mbyYsIGNvbnN0IElu dFJlY3QmKTsKKyAgICAgICAgdmlydHVhbCB2b2lkIGFkanVzdEJ1dHRvblN0eWxlKENTU1N0eWxl U2VsZWN0b3IqLCBSZW5kZXJTdHlsZSosIEVsZW1lbnQqKSBjb25zdDsKIAogICAgICAgICB2aXJ0 dWFsIGJvb2wgcGFpbnRUZXh0RmllbGQoUmVuZGVyT2JqZWN0KiwgY29uc3QgUmVuZGVyT2JqZWN0 OjpQYWludEluZm8mLCBjb25zdCBJbnRSZWN0Jik7CiAKLS0gCjEuNi4zLjMKCg==