<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>31707</bug_id>
          
          <creation_ts>2009-11-19 22:45:07 -0800</creation_ts>
          <short_desc>Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand</short_desc>
          <delta_ts>2009-11-19 23:01:42 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Adam Barth">abarth</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>eric</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>165221</commentid>
    <comment_count>0</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-11-19 22:45:07 -0800</bug_when>
    <thetext>To prepare for build-attachment</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>165222</commentid>
    <comment_count>1</comment_count>
      <attachid>43555</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-11-19 22:49:56 -0800</bug_when>
    <thetext>Created attachment 43555
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>165226</commentid>
    <comment_count>2</comment_count>
      <attachid>43555</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-11-19 23:01:36 -0800</bug_when>
    <thetext>Comment on attachment 43555
Patch

Clearing flags on attachment: 43555

Committed r51232: &lt;http://trac.webkit.org/changeset/51232&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>165227</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-11-19 23:01:42 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>43555</attachid>
            <date>2009-11-19 22:49:56 -0800</date>
            <delta_ts>2009-11-19 23:01:35 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-31707-20091119224955.patch</filename>
            <type>text/plain</type>
            <size>4472</size>
            <attacher name="Adam Barth">abarth</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZwppbmRleCA4N2JiNDk2Li4wMjdlNTExIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM
b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTEt
MTkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBYnN0cmFjdCBBYnN0cmFjdFBhdGNoUHJvY2Vz
c2luZ0NvbW1hbmQgZnJvbSBBYnN0cmFjdFBhdGNoTGFuZGluZ0NvbW1hbmQKKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNzA3CisKKyAgICAgICAgVGhp
cyBpcyB0byBoZWxwIHdoZW4gd2UgaW1wbGVtZW50IGJ1aWxkLWF0dGFjaG1lbnQuCisKKyAgICAg
ICAgKiBTY3JpcHRzL2J1Z3ppbGxhLXRvb2w6CisKIDIwMDktMTEtMTkgIFpvbHRhbiBIb3J2YXRo
ICA8em9sdGFuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4K
ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbCBiL1dlYktpdFRv
b2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbAppbmRleCBjZTJhNzhkLi42YTM4NDk3IDEwMDc1NQot
LS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL2J1Z3ppbGxhLXRvb2wKKysrIGIvV2ViS2l0VG9vbHMv
U2NyaXB0cy9idWd6aWxsYS10b29sCkBAIC0zODgsMTMgKzM4OCwxNCBAQCBjbGFzcyBMYW5kRGlm
ZihDb21tYW5kKToKICAgICAgICAgICAgIGxvZygiTm8gYnVnIGlkIHByb3ZpZGVkLiIpCiAKIAot
Y2xhc3MgQWJzdHJhY3RQYXRjaExhbmRpbmdDb21tYW5kKENvbW1hbmQpOgotICAgIGRlZiBfX2lu
aXRfXyhzZWxmLCBkZXNjcmlwdGlvbiwgYXJnc19kZXNjcmlwdGlvbik6Ci0gICAgICAgIG9wdGlv
bnMgPSBXZWJLaXRMYW5kaW5nU2NyaXB0cy5jbGVhbmluZ19vcHRpb25zKCkgKyBXZWJLaXRMYW5k
aW5nU2NyaXB0cy5sYW5kX29wdGlvbnMoKQorY2xhc3MgQWJzdHJhY3RQYXRjaFByb2Nlc3NpbmdD
b21tYW5kKENvbW1hbmQpOgorICAgIGRlZiBfX2luaXRfXyhzZWxmLCBkZXNjcmlwdGlvbiwgYXJn
c19kZXNjcmlwdGlvbiwgb3B0aW9ucyk6CiAgICAgICAgIENvbW1hbmQuX19pbml0X18oc2VsZiwg
ZGVzY3JpcHRpb24sIGFyZ3NfZGVzY3JpcHRpb24sIG9wdGlvbnM9b3B0aW9ucykKIAotICAgIEBz
dGF0aWNtZXRob2QKLSAgICBkZWYgX2ZldGNoX2xpc3Rfb2ZfcGF0Y2hlc190b19sYW5kKG9wdGlv
bnMsIGFyZ3MsIHRvb2wpOgorICAgIGRlZiBfZmV0Y2hfbGlzdF9vZl9wYXRjaGVzX3RvX3Byb2Nl
c3Moc2VsZiwgb3B0aW9ucywgYXJncywgdG9vbCk6CisgICAgICAgIHJhaXNlIE5vdEltcGxlbWVu
dGVkRXJyb3IsICJzdWJjbGFzc2VzIG11c3QgaW1wbGVtZW50IgorCisgICAgZGVmIF9wcmVwYXJl
X3RvX3Byb2Nlc3Moc2VsZiwgb3B0aW9ucywgYXJncywgdG9vbCk6CiAgICAgICAgIHJhaXNlIE5v
dEltcGxlbWVudGVkRXJyb3IsICJzdWJjbGFzc2VzIG11c3QgaW1wbGVtZW50IgogCiAgICAgQHN0
YXRpY21ldGhvZApAQCAtNDA5LDI2ICs0MTAsMzYgQEAgY2xhc3MgQWJzdHJhY3RQYXRjaExhbmRp
bmdDb21tYW5kKENvbW1hbmQpOgogICAgICAgICBpZiBub3QgYXJnczoKICAgICAgICAgICAgIGVy
cm9yKCIlcyByZXF1aXJlZCIgJSBzZWxmLmFyZ3VtZW50X25hbWVzKQogCi0gICAgICAgICMgQ2hl
Y2sgdGhlIHRyZWUgc3RhdHVzIGZpcnN0IHNvIHdlIGNhbiBmYWlsIGVhcmx5LgotICAgICAgICBX
ZWJLaXRMYW5kaW5nU2NyaXB0cy5lbnN1cmVfYnVpbGRlcnNfYXJlX2dyZWVuKHRvb2wuYnVpbGRi
b3QsIG9wdGlvbnMpCi0gICAgICAgIFdlYktpdExhbmRpbmdTY3JpcHRzLnByZXBhcmVfY2xlYW5f
d29ya2luZ19kaXJlY3RvcnkodG9vbC5zY20oKSwgb3B0aW9ucykKLQotICAgICAgICBwYXRjaGVz
ID0gc2VsZi5fZmV0Y2hfbGlzdF9vZl9wYXRjaGVzX3RvX2xhbmQob3B0aW9ucywgYXJncywgdG9v
bCkKKyAgICAgICAgc2VsZi5fcHJlcGFyZV90b19wcm9jZXNzKG9wdGlvbnMsIGFyZ3MsIHRvb2wp
CisgICAgICAgIHBhdGNoZXMgPSBzZWxmLl9mZXRjaF9saXN0X29mX3BhdGNoZXNfdG9fcHJvY2Vz
cyhvcHRpb25zLCBhcmdzLCB0b29sKQogCiAgICAgICAgICMgSXQncyBuaWNlIHRvIHByaW50IG91
dCB0b3RhbCBzdGF0aXN0aWNzLgogICAgICAgICBidWdzX3RvX3BhdGNoZXMgPSBzZWxmLl9jb2xs
ZWN0X3BhdGNoZXNfYnlfYnVnKHBhdGNoZXMpCi0gICAgICAgIGxvZygiTGFuZGluZyAlcyBmcm9t
ICVzLiIgJSAocGx1cmFsaXplKCJwYXRjaCIsIGxlbihwYXRjaGVzKSksIHBsdXJhbGl6ZSgiYnVn
IiwgbGVuKGJ1Z3NfdG9fcGF0Y2hlcykpKSkKKyAgICAgICAgbG9nKCJQcm9jZXNzaW5nICVzIGZy
b20gJXMuIiAlIChwbHVyYWxpemUoInBhdGNoIiwgbGVuKHBhdGNoZXMpKSwgcGx1cmFsaXplKCJi
dWciLCBsZW4oYnVnc190b19wYXRjaGVzKSkpKQogCiAgICAgICAgIGZvciBwYXRjaCBpbiBwYXRj
aGVzOgotICAgICAgICAgICAgV2ViS2l0TGFuZGluZ1NjcmlwdHMubGFuZF9wYXRjaF9hbmRfaGFu
ZGxlX2Vycm9ycyhwYXRjaCwgb3B0aW9ucywgdG9vbCkKKyAgICAgICAgICAgIHNlbGYuX3Byb2Nl
c3NfcGF0Y2gocGF0Y2gsIG9wdGlvbnMsIGFyZ3MsIHRvb2wpCisKKworY2xhc3MgQWJzdHJhY3RQ
YXRjaExhbmRpbmdDb21tYW5kKEFic3RyYWN0UGF0Y2hQcm9jZXNzaW5nQ29tbWFuZCk6CisgICAg
ZGVmIF9faW5pdF9fKHNlbGYsIGRlc2NyaXB0aW9uLCBhcmdzX2Rlc2NyaXB0aW9uKToKKyAgICAg
ICAgb3B0aW9ucyA9IFdlYktpdExhbmRpbmdTY3JpcHRzLmNsZWFuaW5nX29wdGlvbnMoKSArIFdl
YktpdExhbmRpbmdTY3JpcHRzLmxhbmRfb3B0aW9ucygpCisgICAgICAgIEFic3RyYWN0UGF0Y2hQ
cm9jZXNzaW5nQ29tbWFuZC5fX2luaXRfXyhzZWxmLCBkZXNjcmlwdGlvbiwgYXJnc19kZXNjcmlw
dGlvbiwgb3B0aW9ucykKKworICAgIGRlZiBfcHJlcGFyZV90b19wcm9jZXNzKHNlbGYsIG9wdGlv
bnMsIGFyZ3MsIHRvb2wpOgorICAgICAgICAjIENoZWNrIHRoZSB0cmVlIHN0YXR1cyBmaXJzdCBz
byB3ZSBjYW4gZmFpbCBlYXJseS4KKyAgICAgICAgV2ViS2l0TGFuZGluZ1NjcmlwdHMuZW5zdXJl
X2J1aWxkZXJzX2FyZV9ncmVlbih0b29sLmJ1aWxkYm90LCBvcHRpb25zKQorICAgICAgICBXZWJL
aXRMYW5kaW5nU2NyaXB0cy5wcmVwYXJlX2NsZWFuX3dvcmtpbmdfZGlyZWN0b3J5KHRvb2wuc2Nt
KCksIG9wdGlvbnMpCisKKyAgICBkZWYgX3Byb2Nlc3NfcGF0Y2goc2VsZiwgcGF0Y2gsIG9wdGlv
bnMsIGFyZ3MsIHRvb2wpOgorICAgICAgICBXZWJLaXRMYW5kaW5nU2NyaXB0cy5sYW5kX3BhdGNo
X2FuZF9oYW5kbGVfZXJyb3JzKHBhdGNoLCBvcHRpb25zLCB0b29sKQogCiAKIGNsYXNzIExhbmRB
dHRhY2htZW50KEFic3RyYWN0UGF0Y2hMYW5kaW5nQ29tbWFuZCk6CiAgICAgZGVmIF9faW5pdF9f
KHNlbGYpOgogICAgICAgICBBYnN0cmFjdFBhdGNoTGFuZGluZ0NvbW1hbmQuX19pbml0X18oc2Vs
ZiwgIkxhbmRzIGEgcGF0Y2hlcyBmcm9tIGJ1Z3ppbGxhLCBvcHRpb25hbGx5IGJ1aWxkaW5nIGFu
ZCB0ZXN0aW5nIHRoZW0gZmlyc3QiLCAiQVRUQUNITUVOVF9JRCBbQVRUQUNITUVOVF9JRFNdIikK
IAotICAgIEBzdGF0aWNtZXRob2QKLSAgICBkZWYgX2ZldGNoX2xpc3Rfb2ZfcGF0Y2hlc190b19s
YW5kKG9wdGlvbnMsIGFyZ3MsIHRvb2wpOgorICAgIGRlZiBfZmV0Y2hfbGlzdF9vZl9wYXRjaGVz
X3RvX3Byb2Nlc3Moc2VsZiwgb3B0aW9ucywgYXJncywgdG9vbCk6CiAgICAgICAgIHJldHVybiBt
YXAobGFtYmRhIHBhdGNoX2lkOiB0b29sLmJ1Z3MuZmV0Y2hfYXR0YWNobWVudChwYXRjaF9pZCks
IGFyZ3MpCiAKIApAQCAtNDM2LDggKzQ0Nyw3IEBAIGNsYXNzIExhbmRQYXRjaGVzKEFic3RyYWN0
UGF0Y2hMYW5kaW5nQ29tbWFuZCk6CiAgICAgZGVmIF9faW5pdF9fKHNlbGYpOgogICAgICAgICBB
YnN0cmFjdFBhdGNoTGFuZGluZ0NvbW1hbmQuX19pbml0X18oc2VsZiwgIkxhbmRzIGFsbCBwYXRj
aGVzIG9uIHRoZSBnaXZlbiBidWdzLCBvcHRpb25hbGx5IGJ1aWxkaW5nIGFuZCB0ZXN0aW5nIHRo
ZW0gZmlyc3QiLCAiQlVHSUQgW0JVR0lEU10iKQogCi0gICAgQHN0YXRpY21ldGhvZAotICAgIGRl
ZiBfZmV0Y2hfbGlzdF9vZl9wYXRjaGVzX3RvX2xhbmQob3B0aW9ucywgYXJncywgdG9vbCk6Cisg
ICAgZGVmIF9mZXRjaF9saXN0X29mX3BhdGNoZXNfdG9fcHJvY2VzcyhzZWxmLCBvcHRpb25zLCBh
cmdzLCB0b29sKToKICAgICAgICAgYWxsX3BhdGNoZXMgPSBbXQogICAgICAgICBmb3IgYnVnX2lk
IGluIGFyZ3M6CiAgICAgICAgICAgICBwYXRjaGVzID0gdG9vbC5idWdzLmZldGNoX3Jldmlld2Vk
X3BhdGNoZXNfZnJvbV9idWcoYnVnX2lkKQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>