31693 2009-11-19 15:17:12 -0800 isMainThread() on Chromium (Mac and Linux) is so slow it timeouts LayoutTests.. 2009-11-19 15:33:56 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dimich webkit-unassigned ap dglazkov levin oldest_to_newest 165116 0 dimich 2009-11-19 15:17:12 -0800 http://trac.webkit.org/changeset/51158 added ASSERT(isMainThread()) to TreeShared methods. This practically didn't slow down debug build on Mac and Windows, but on Chromium some layout tests started to timeout. For example, editing/selection/extend-selection.html execution time grew 15 times (!). This test operates with selection and it does a lot of operations like Position::previous() that churns refcout on Nodes. Turned out the isMainThread() on pthread-based Chromium (Mac and Linux) involves mapping through threadMap, which in turn takes 2 Mutexes to lock - in identifierByPthreadHandle() and in iterator code. By comparing handle itself rather then mapped Id the time required by isMainThread() goes back to reasonable. Patch is coming. 165117 1 43530 dimich 2009-11-19 15:21:03 -0800 Created attachment 43530 Proposed patch. 165120 2 43530 ap 2009-11-19 15:26:36 -0800 Comment on attachment 43530 Proposed patch. I wonder why you chose to rename the variable to mainThreadHandle. Mac man page for pthread_self says "returns the thread ID of the calling thread". Of course, "identifier" is taken already, but it's not a handle either. 165126 3 dimich 2009-11-19 15:33:56 -0800 Landed: http://trac.webkit.org/changeset/51211 43530 2009-11-19 15:21:03 -0800 2009-11-19 15:26:36 -0800 Proposed patch. patch.txt text/plain 1949 dimich ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAxNGExMjkwLi4xMDkzNTUwIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMDktMTEtMTkgIERtaXRyeSBUaXRvdiAgPGRpbWljaEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaXNNYWluVGhyZWFk KCkgb24gQ2hyb21pdW0gKE1hYyBhbmQgTGludXgpIGlzIHNvIHNsb3cgaXQgdGltZW91dHMgTGF5 b3V0VGVzdHMuLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzE2OTMKKworICAgICAgICAqIHd0Zi9UaHJlYWRpbmdQdGhyZWFkcy5jcHA6CisgICAgICAg IChXVEY6OmluaXRpYWxpemVUaHJlYWRpbmcpOiBncmFiIGFuZCB1c2UgdGhlIHB0aHJlYWRfdCBv ZiB0aGUgbWFpbiB0aHJlYWQgaW5zdGVhZCBvZiBUaHJlYWRJZGVudGlmaWVyLgorICAgICAgICAo V1RGOjppc01haW5UaHJlYWQpOiBEaXR0by4KKwogMjAwOS0xMS0xOSAgTGFzemxvIEdvbWJvcyAg PGxhc3psby4xLmdvbWJvc0Bub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4g QWRsZXIuCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkaW5nUHRocmVhZHMu Y3BwIGIvSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGluZ1B0aHJlYWRzLmNwcAppbmRleCA2Y2Fk NWUzLi41YTFhZTBjIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkaW5nUHRo cmVhZHMuY3BwCisrKyBiL0phdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRpbmdQdGhyZWFkcy5jcHAK QEAgLTU2LDcgKzU2LDcgQEAgdHlwZWRlZiBIYXNoTWFwPFRocmVhZElkZW50aWZpZXIsIHB0aHJl YWRfdD4gVGhyZWFkTWFwOwogc3RhdGljIE11dGV4KiBhdG9taWNhbGx5SW5pdGlhbGl6ZWRTdGF0 aWNNdXRleDsKIAogI2lmICFQTEFURk9STShEQVJXSU4pIHx8IFBMQVRGT1JNKENIUk9NSVVNKQot c3RhdGljIFRocmVhZElkZW50aWZpZXIgbWFpblRocmVhZElkZW50aWZpZXI7IC8vIFRoZSB0aHJl YWQgdGhhdCB3YXMgdGhlIGZpcnN0IHRvIGNhbGwgaW5pdGlhbGl6ZVRocmVhZGluZygpLCB3aGlj aCBtdXN0IGJlIHRoZSBtYWluIHRocmVhZC4KK3N0YXRpYyBwdGhyZWFkX3QgbWFpblRocmVhZEhh bmRsZTsgLy8gVGhlIHRocmVhZCB0aGF0IHdhcyB0aGUgZmlyc3QgdG8gY2FsbCBpbml0aWFsaXpl VGhyZWFkaW5nKCksIHdoaWNoIG11c3QgYmUgdGhlIG1haW4gdGhyZWFkLgogI2VuZGlmCiAKIHN0 YXRpYyBNdXRleCYgdGhyZWFkTWFwTXV0ZXgoKQpAQCAtNzIsNyArNzIsNyBAQCB2b2lkIGluaXRp YWxpemVUaHJlYWRpbmcoKQogICAgICAgICB0aHJlYWRNYXBNdXRleCgpOwogICAgICAgICBpbml0 aWFsaXplUmFuZG9tTnVtYmVyR2VuZXJhdG9yKCk7CiAjaWYgIVBMQVRGT1JNKERBUldJTikgfHwg UExBVEZPUk0oQ0hST01JVU0pCi0gICAgICAgIG1haW5UaHJlYWRJZGVudGlmaWVyID0gY3VycmVu dFRocmVhZCgpOworICAgICAgICBtYWluVGhyZWFkSGFuZGxlID0gcHRocmVhZF9zZWxmKCk7CiAj ZW5kaWYKICAgICAgICAgaW5pdGlhbGl6ZU1haW5UaHJlYWQoKTsKICAgICB9CkBAIC0yMzIsNyAr MjMyLDcgQEAgYm9vbCBpc01haW5UaHJlYWQoKQogI2lmIFBMQVRGT1JNKERBUldJTikgJiYgIVBM QVRGT1JNKENIUk9NSVVNKQogICAgIHJldHVybiBwdGhyZWFkX21haW5fbnAoKTsKICNlbHNlCi0g ICAgcmV0dXJuIGN1cnJlbnRUaHJlYWQoKSA9PSBtYWluVGhyZWFkSWRlbnRpZmllcjsKKyAgICBy ZXR1cm4gcHRocmVhZF9lcXVhbChwdGhyZWFkX3NlbGYoKSwgbWFpblRocmVhZEhhbmRsZSk7CiAj ZW5kaWYKIH0KIAo=