31679 2009-11-19 12:38:02 -0800 commit-queue empty queue logs twice 2009-11-19 13:02:53 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth commit-queue oldest_to_newest 165057 0 eric 2009-11-19 12:38:02 -0800 commit-queue empty queue logs twice It didn't used to. We don't need the "0 patches in commit-queue []" log. Empty queue. Sleeping until 2009-11-19 12:35:37 (5 mins). 0 patches in commit-queue [] Empty queue. Sleeping until 2009-11-19 12:40:40 (5 mins). Probably should be some refactoring done to WorkQueue to better handle this case for all queues, but that's probably best done when we actually have other queues up and running. 165058 1 43517 eric 2009-11-19 12:38:38 -0800 Created attachment 43517 Patch 165062 2 eric 2009-11-19 12:44:48 -0800 Darin is a machine! Thanks! 165068 3 43517 commit-queue 2009-11-19 13:02:43 -0800 Comment on attachment 43517 Patch Clearing flags on attachment: 43517 Committed r51203: <http://trac.webkit.org/changeset/51203> 165069 4 commit-queue 2009-11-19 13:02:53 -0800 All reviewed patches have been landed. Closing bug. 43517 2009-11-19 12:38:38 -0800 2009-11-19 13:02:42 -0800 Patch bug-31679-20091119123836.patch text/plain 1305 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA1M2E1YTM5Li5iYzkyZGMzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMDktMTEt MTkgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNvbW1pdC1xdWV1ZSBlbXB0eSBxdWV1ZSBsb2dz IHR3aWNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z MTY3OQorCisgICAgICAgICogU2NyaXB0cy9idWd6aWxsYS10b29sOgorCisyMDA5LTExLTE5ICBF cmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBEYXJp biBBZGxlci4KIAogICAgICAgICBidWd6aWxsYS10b29sJ3MgcmV2aWV3ZXIvY29tbWl0dGVyIHJl amVjdGlvbiBtZXNzYWdlIHNob3VsZCBiZSBjbGVhcmVyCmRpZmYgLS1naXQgYS9XZWJLaXRUb29s cy9TY3JpcHRzL2J1Z3ppbGxhLXRvb2wgYi9XZWJLaXRUb29scy9TY3JpcHRzL2J1Z3ppbGxhLXRv b2wKaW5kZXggYmYwNWJiNS4uYjE4NzFkNCAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0 cy9idWd6aWxsYS10b29sCisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbApA QCAtNzg4LDggKzc4OCwxMSBAQCBjbGFzcyBDb21taXRRdWV1ZShBYnN0cmFjdFF1ZXVlKToKIAog ICAgIGRlZiBuZXh0X3dvcmtfaXRlbShzZWxmKToKICAgICAgICAgcGF0Y2hlcyA9IHNlbGYudG9v bC5idWdzLmZldGNoX3BhdGNoZXNfZnJvbV9jb21taXRfcXVldWUocmVqZWN0X2ludmFsaWRfcGF0 Y2hlcz1UcnVlKQorICAgICAgICBpZiBub3QgcGF0Y2hlczoKKyAgICAgICAgICAgIHJldHVybiBO b25lCisgICAgICAgICMgT25seSBib3RoZXIgbG9nZ2luZyBpZiB3ZSBoYXZlIHBhdGNoZXMgaW4g dGhlIHF1ZXVlLgogICAgICAgICBzZWxmLmxvZ19wcm9ncmVzcyhbcGF0Y2hbJ2lkJ10gZm9yIHBh dGNoIGluIHBhdGNoZXNdKQotICAgICAgICByZXR1cm4gcGF0Y2hlc1swXSBpZiBwYXRjaGVzIGVs c2UgTm9uZQorICAgICAgICByZXR1cm4gcGF0Y2hlc1swXQogCiAgICAgZGVmIHNob3VsZF9wcm9j ZWVkX3dpdGhfd29ya19pdGVtKHNlbGYsIHBhdGNoKToKICAgICAgICAgcmVkX2J1aWxkZXJzX25h bWVzID0gc2VsZi50b29sLmJ1aWxkYm90LnJlZF9jb3JlX2J1aWxkZXJzX25hbWVzKCkK