<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>31671</bug_id>
          
          <creation_ts>2009-11-19 09:53:42 -0800</creation_ts>
          <short_desc>Android port lacks configuration in Platform.h and config.h</short_desc>
          <delta_ts>2009-11-19 22:03:29 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Other</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Steve Block">steveblock</reporter>
          <assigned_to name="Steve Block">steveblock</assigned_to>
          <cc>android-webkit-unforking</cc>
    
    <cc>commit-queue</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>165006</commentid>
    <comment_count>0</comment_count>
    <who name="Steve Block">steveblock</who>
    <bug_when>2009-11-19 09:53:42 -0800</bug_when>
    <thetext>Android port lacks configuration in Platform.h and config.h</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>165038</commentid>
    <comment_count>1</comment_count>
      <attachid>43515</attachid>
    <who name="Steve Block">steveblock</who>
    <bug_when>2009-11-19 11:43:52 -0800</bug_when>
    <thetext>Created attachment 43515
Patch 1 for Bug 31671</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>165199</commentid>
    <comment_count>2</comment_count>
      <attachid>43515</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-11-19 21:45:06 -0800</bug_when>
    <thetext>Comment on attachment 43515
Patch 1 for Bug 31671

What&apos;s an inval?

 541 // This prevents unnecessary invals.

Wow, I didn&apos;t nkow this was in config.h:
 79 #define WEBCORE_NAVIGATOR_VENDOR &quot;Google Inc.&quot;

Seems slightly lame to add.

I clearly should look at config.h again, because this all looks very strange.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>165205</commentid>
    <comment_count>3</comment_count>
      <attachid>43515</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-11-19 22:03:24 -0800</bug_when>
    <thetext>Comment on attachment 43515
Patch 1 for Bug 31671

Clearing flags on attachment: 43515

Committed r51228: &lt;http://trac.webkit.org/changeset/51228&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>165206</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-11-19 22:03:29 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>43515</attachid>
            <date>2009-11-19 11:43:52 -0800</date>
            <delta_ts>2009-11-19 22:03:24 -0800</delta_ts>
            <desc>Patch 1 for Bug 31671</desc>
            <filename>addConfiguration.txt</filename>
            <type>text/plain</type>
            <size>4886</size>
            <attacher name="Steve Block">steveblock</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUxMTk0KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTAgQEAKKzIwMDktMTEtMTkgIFN0ZXZlIEJs
b2NrICA8c3RldmVibG9ja0Bnb29nbGUuY29tPgorCisgICAgICAgIEFuZHJvaWQgcG9ydCBsYWNr
cyBjb25maWd1cmF0aW9uIGluIFBsYXRmb3JtLmggYW5kIGNvbmZpZy5oLgorICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE2NzEKKworICAgICAgICAqIHd0
Zi9QbGF0Zm9ybS5oOiBNb2RpZmllZC4gQWRkZWQgQW5kcm9pZC1zcGVjaWZpYyBjb25maWd1cmF0
aW9uLgorCiAyMDA5LTExLTE5ICBUaGlhZ28gTWFjaWVpcmEgPHRoaWFnby5tYWNpZWlyYUBub2tp
YS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCkluZGV4OiBKYXZh
U2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93
dGYvUGxhdGZvcm0uaAkocmV2aXNpb24gNTExODcpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYvUGxh
dGZvcm0uaAkod29ya2luZyBjb3B5KQpAQCAtMTMyLDcgKzEzMiw4IEBACiAgICB8fCBkZWZpbmVk
KF9fdW5peF9fKSAgICBcCiAgICB8fCBkZWZpbmVkKF9BSVgpICAgICAgICBcCiAgICB8fCBkZWZp
bmVkKF9fSEFJS1VfXykgICBcCi0gICB8fCBkZWZpbmVkKF9fUU5YTlRPX18pCisgICB8fCBkZWZp
bmVkKF9fUU5YTlRPX18pICBcCisgICB8fCBkZWZpbmVkKEFORFJPSUQpCiAjZGVmaW5lIFdURl9Q
TEFURk9STV9VTklYIDEKICNlbmRpZgogCkBAIC0xODIsNiArMTgzLDExIEBACiAjZGVmaW5lIFdU
Rl9QTEFURk9STV9JUEhPTkUgMAogI2VuZGlmCiAKKy8qIFBMQVRGT1JNKEFORFJPSUQpICovCisj
aWYgZGVmaW5lZChBTkRST0lEKQorI2RlZmluZSBXVEZfUExBVEZPUk1fQU5EUk9JRCAxCisjZW5k
aWYKKwogLyogR3JhcGhpY3MgZW5naW5lcyAqLwogCiAvKiBQTEFURk9STShDRykgYW5kIFBMQVRG
T1JNKENJKSAqLwpAQCAtMjA1LDcgKzIxMSw3IEBACiAKIC8qIE1ha2VzIFBMQVRGT1JNKFdJTikg
ZGVmYXVsdCB0byBQTEFURk9STShDQUlSTykgKi8KIC8qIEZJWE1FOiBUaGlzIHNob3VsZCBiZSBj
aGFuZ2VkIGZyb20gYSBibGFja2xpc3QgdG8gYSB3aGl0ZWxpc3QgKi8KLSNpZiAhUExBVEZPUk0o
TUFDKSAmJiAhUExBVEZPUk0oUVQpICYmICFQTEFURk9STShXWCkgJiYgIVBMQVRGT1JNKENIUk9N
SVVNKSAmJiAhUExBVEZPUk0oV0lOQ0UpICYmICFQTEFURk9STShIQUlLVSkKKyNpZiAhUExBVEZP
Uk0oTUFDKSAmJiAhUExBVEZPUk0oUVQpICYmICFQTEFURk9STShXWCkgJiYgIVBMQVRGT1JNKENI
Uk9NSVVNKSAmJiAhUExBVEZPUk0oV0lOQ0UpICYmICFQTEFURk9STShIQUlLVSkgJiYgIVBMQVRG
T1JNKEFORFJPSUQpCiAjZGVmaW5lIFdURl9QTEFURk9STV9DQUlSTyAxCiAjZW5kaWYKIApAQCAt
MjUyLDcgKzI1OCw4IEBACiAKICNlbGlmICFkZWZpbmVkKF9fQVJNX0VBQklfXykgXAogICAgJiYg
IWRlZmluZWQoX19FQUJJX18pIFwKLSAgICYmICFkZWZpbmVkKF9fVkZQX0ZQX18pCisgICAmJiAh
ZGVmaW5lZChfX1ZGUF9GUF9fKSBcCisgICAmJiAhZGVmaW5lZChBTkRST0lEKQogI2RlZmluZSBX
VEZfUExBVEZPUk1fTUlERExFX0VORElBTiAxCiAKICNlbmRpZgpAQCAtNTI0LDYgKzUzMSwxOCBA
QAogI2RlZmluZSBIQVZFX1BUSFJFQURfUldMT0NLIDEKICNlbmRpZgogCisjaWYgUExBVEZPUk0o
QU5EUk9JRCkKKyNkZWZpbmUgV1RGX1VTRV9QVEhSRUFEUyAxCisjZGVmaW5lIFdURl9QTEFURk9S
TV9TR0wgMQorI2RlZmluZSBVU0VfU1lTVEVNX01BTExPQyAxCisjZGVmaW5lIEVOQUJMRV9NQUNf
SkFWQV9CUklER0UgMQorI2RlZmluZSBMT0dfRElTQUJMRUQgMQorLy8gUHJldmVudHMgV2Via2l0
IGZyb20gZHJhd2luZyB0aGUgY2FyZXQgaW4gdGV4dGZpZWxkcyBhbmQgdGV4dGFyZWFzCisvLyBU
aGlzIHByZXZlbnRzIHVubmVjZXNzYXJ5IGludmFscy4KKyNkZWZpbmUgRU5BQkxFX1RFWFRfQ0FS
RVQgMQorI2RlZmluZSBFTkFCTEVfSkFWQVNDUklQVF9ERUJVR0dFUiAwCisjZW5kaWYKKwogI2lm
IFBMQVRGT1JNKFdJTikKICNkZWZpbmUgV1RGX1VTRV9XSU5JTkVUIDEKICNlbmRpZgpAQCAtNTU5
LDcgKzU3OCw4IEBACiAjZW5kaWYKIAogI2lmICFQTEFURk9STShXSU5fT1MpICYmICFQTEFURk9S
TShTT0xBUklTKSAmJiAhUExBVEZPUk0oUU5YKSBcCi0gICAgJiYgIVBMQVRGT1JNKFNZTUJJQU4p
ICYmICFQTEFURk9STShIQUlLVSkgJiYgIUNPTVBJTEVSKFJWQ1QpCisgICAgJiYgIVBMQVRGT1JN
KFNZTUJJQU4pICYmICFQTEFURk9STShIQUlLVSkgJiYgIUNPTVBJTEVSKFJWQ1QpIFwKKyAgICAm
JiAhUExBVEZPUk0oQU5EUk9JRCkKICNkZWZpbmUgSEFWRV9UTV9HTVRPRkYgMQogI2RlZmluZSBI
QVZFX1RNX1pPTkUgMQogI2RlZmluZSBIQVZFX1RJTUVHTSAxCkBAIC02MTksNiArNjM5LDE2IEBA
CiAjZGVmaW5lIEhBVkVfU1lTX1BBUkFNX0ggMQogI2RlZmluZSBIQVZFX1NZU19USU1FX0ggMQog
CisjZWxpZiBQTEFURk9STShBTkRST0lEKQorCisjZGVmaW5lIEhBVkVfRVJSTk9fSCAxCisjZGVm
aW5lIEhBVkVfTEFOR0lORk9fSCAwCisjZGVmaW5lIEhBVkVfTU1BUCAxCisjZGVmaW5lIEhBVkVf
U0JSSyAxCisjZGVmaW5lIEhBVkVfU1RSSU5HU19IIDEKKyNkZWZpbmUgSEFWRV9TWVNfUEFSQU1f
SCAxCisjZGVmaW5lIEhBVkVfU1lTX1RJTUVfSCAxCisKICNlbHNlCiAKIC8qIEZJWE1FOiBpcyB0
aGlzIGFjdHVhbGx5IHVzZWQgb3IgZG8gb3RoZXIgcGxhdGZvcm1zIGdlbmVyYXRlIHRoZWlyIG93
biBjb25maWcuaD8gKi8KSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl
YkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiA1MTE5NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3
b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTEtMTkgIFN0ZXZlIEJsb2NrICA8
c3RldmVibG9ja0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q
UyEpLgorCisgICAgICAgIEFuZHJvaWQgcG9ydCBsYWNrcyBjb25maWd1cmF0aW9uIGluIFBsYXRm
b3JtLmggYW5kIGNvbmZpZy5oLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MzE2NzEKKworICAgICAgICBCdWlsZCBjaGFuZ2Ugb25seS4gTm8gbmV3IHRl
c3RzIHBvc3NpYmxlLgorCisgICAgICAgICogY29uZmlnLmg6IE1vZGlmaWVkLiBBZGRlZCBBbmRy
b2lkLXNwZWNpZmljIGNvbmZpZ3VyYXRpb24uCisKIDIwMDktMTEtMTkgIFNpbW9uIEZyYXNlciAg
PHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVs
ZG1hbi4KSW5kZXg6IFdlYkNvcmUvY29uZmlnLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9jb25m
aWcuaAkocmV2aXNpb24gNTExODcpCisrKyBXZWJDb3JlL2NvbmZpZy5oCSh3b3JraW5nIGNvcHkp
CkBAIC03NSw2ICs3NSwzNCBAQAogCiAjZW5kaWYgLyogUExBVEZPUk0oV0lOX09TKSAqLwogCisj
aWYgUExBVEZPUk0oQU5EUk9JRCkKKyNkZWZpbmUgV0VCQ09SRV9OQVZJR0FUT1JfVkVORE9SICJH
b29nbGUgSW5jLiIKKy8vIFRoaXMgbXVzdCBiZSBkZWZpbmVkIGJlZm9yZSB3ZSBpbmNsdWRlIEZh
c3RNYWxsb2MuaCwgYmVsb3cuCisjZGVmaW5lIFVTRV9TWVNURU1fTUFMTE9DIDEKKyNkZWZpbmUg
TE9HX0RJU0FCTEVEIDEKKyNpbmNsdWRlIDx3dGYvQXNzZXJ0aW9ucy5oPgorLy8gQ2VudHJhbCBw
bGFjZSB0byBzZXQgd2hpY2ggb3B0aW9uYWwgZmVhdHVyZXMgQW5kcm9pZCB1c2VzLgorI2RlZmlu
ZSBFTkFCTEVfQ0hBTk5FTF9NRVNTQUdJTkcgMQorI2RlZmluZSBFTkFCTEVfRE9NX1NUT1JBR0Ug
MQorI3VuZGVmIEVOQUJMRV9GVFBESVIgIC8vIEVuYWJsZWQgYnkgZGVmYXVsdCBpbiBQbGF0Zm9y
bS5oCisjZGVmaW5lIEVOQUJMRV9GVFBESVIgMAorI2lmbmRlZiBFTkFCTEVfU1ZHCisjZGVmaW5l
IEVOQUJMRV9TVkcgMAorI2VuZGlmCisjZGVmaW5lIEVOQUJMRV9WSURFTyAxCisjZGVmaW5lIEVO
QUJMRV9XT1JLRVJTIDEKKyNkZWZpbmUgRU5BQkxFX1hCTCAwCisjZGVmaW5lIEVOQUJMRV9YUEFU
SCAwCisjZGVmaW5lIEVOQUJMRV9YU0xUIDAKKyNkZWZpbmUgRU5BQkxFX0FSQ0hJVkUgMAorI2Rl
ZmluZSBFTkFCTEVfT0ZGTElORV9XRUJfQVBQTElDQVRJT05TIDEKKyN1bmRlZiBFTkFCTEVfR0VP
TE9DQVRJT04gIC8vIERpc2FibGVkIGJ5IGRlZmF1bHQgaW4gUGxhdGZvcm0uaAorI2RlZmluZSBF
TkFCTEVfR0VPTE9DQVRJT04gMQorI3VuZGVmIEVOQUJMRV9JTlNQRUNUT1IgIC8vIEVuYWJsZWQg
YnkgZGVmYXVsdCBpbiBQbGF0Zm9ybS5oCisjZGVmaW5lIEVOQUJMRV9JTlNQRUNUT1IgMAorI2Rl
ZmluZSBFTkFCTEVfRVZFTlRfU09VUkNFIDAKKyNlbmRpZiAvKiBQTEFURk9STShBTkRST0lEKSAq
LworCiAjaWZkZWYgX19jcGx1c3BsdXMKIAogLy8gVGhlc2UgdW5kZWZzIG1hdGNoIHVwIHdpdGgg
ZGVmaW5lcyBpbiBXZWJDb3JlUHJlZml4LmggZm9yIE1hYyBPUyBYLgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>