31668 2009-11-19 07:44:40 -0800 Remove HAVE(STRING_H) guard from JavaScriptCore 2009-11-19 12:12:57 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned commit-queue oldest_to_newest 164973 0 laszlo.gombos 2009-11-19 07:44:40 -0800 HAVE(FLOAT_H) is meant to guard <strting.h> includes. It is not used consistently and it always defined (see JavaScriptCore/config.h), so I do not think this adds any value. I propose to remove it - patch will follow. This guard is not used by WebCore or any other parts of WebKit, this is why the bug report is only written against JavaScriptCore. 164975 1 43503 laszlo.gombos 2009-11-19 07:48:47 -0800 Created attachment 43503 proposed patch 164983 2 laszlo.gombos 2009-11-19 08:18:35 -0800 (In reply to comment #0) > HAVE(FLOAT_H) is meant to guard <strting.h> includes. I meant to say HAVE(STRING_H) is meant to guard <string.h> includes. 165050 3 43503 commit-queue 2009-11-19 12:12:50 -0800 Comment on attachment 43503 proposed patch Clearing flags on attachment: 43503 Committed r51199: <http://trac.webkit.org/changeset/51199> 165051 4 commit-queue 2009-11-19 12:12:57 -0800 All reviewed patches have been landed. Closing bug. 43503 2009-11-19 07:48:47 -0800 2009-11-19 12:12:49 -0800 proposed patch 31668.patch text/plain 1514 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUxMTg3KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTEtMTkgIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBIQVZFKFNUUklOR19IKSBndWFyZCBm cm9tIEphdmFTY3JpcHRDb3JlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zMTY2OAorCisgICAgICAgICogY29uZmlnLmg6CisgICAgICAgICogcnVudGlt ZS9VU3RyaW5nLmNwcDoKKwogMjAwOS0xMS0xOSAgVGhpYWdvIE1hY2llaXJhIDx0aGlhZ28ubWFj aWVpcmFAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpJ bmRleDogSmF2YVNjcmlwdENvcmUvY29uZmlnLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENv cmUvY29uZmlnLmgJKHJldmlzaW9uIDUxMTg3KQorKysgSmF2YVNjcmlwdENvcmUvY29uZmlnLmgJ KHdvcmtpbmcgY29weSkKQEAgLTU3LDcgKzU3LDYgQEAKIAogLyogRklYTUU6IGlmIGFsbCBwbGF0 Zm9ybXMgaGF2ZSB0aGVzZSwgZG8gdGhleSByZWFsbHkgbmVlZCAjZGVmaW5lcz8gKi8KICNkZWZp bmUgSEFWRV9TVERJTlRfSCAxCi0jZGVmaW5lIEhBVkVfU1RSSU5HX0ggMQogCiAjZGVmaW5lIFdU Rl9DSEFOR0VTIDEKIApJbmRleDogSmF2YVNjcmlwdENvcmUvcnVudGltZS9VU3RyaW5nLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL1VTdHJpbmcuY3BwCShyZXZpc2lv biA1MTE4NykKKysrIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvVVN0cmluZy5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTM2LDYgKzM2LDcgQEAKICNpbmNsdWRlIDxtYXRoLmg+CiAjaW5jbHVkZSA8c3Rk aW8uaD4KICNpbmNsdWRlIDxzdGRsaWIuaD4KKyNpbmNsdWRlIDxzdHJpbmcuaD4KICNpbmNsdWRl IDx3dGYvQVNDSUlDVHlwZS5oPgogI2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+CiAjaW5jbHVk ZSA8d3RmL01hdGhFeHRyYXMuaD4KQEAgLTQ0LDkgKzQ1LDYgQEAKICNpbmNsdWRlIDx3dGYvdW5p Y29kZS9VVEY4Lmg+CiAjaW5jbHVkZSA8d3RmL1N0cmluZ0V4dHJhcy5oPgogCi0jaWYgSEFWRShT VFJJTkdfSCkKLSNpbmNsdWRlIDxzdHJpbmcuaD4KLSNlbmRpZgogI2lmIEhBVkUoU1RSSU5HU19I KQogI2luY2x1ZGUgPHN0cmluZ3MuaD4KICNlbmRpZgo=