31664 2009-11-19 04:36:24 -0800 [Qt] QWebInspector access its memory after being deleted 2010-01-28 02:24:26 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt P2 Major --- 1 jturcotte webkit-unassigned commit-queue florianlink oldest_to_newest 164948 0 jturcotte 2009-11-19 04:36:24 -0800 If we have a QWebPage that created its own QWebInspector, it will delete it in destructor of QWebPage. The problem is that its deleted in QWebPagePrivate::setInspector, itself called by QWebPage::d->inspector->setPage(0). When setPage resumes, it tries to access its memory which can lead to a crash. 164949 1 43496 jturcotte 2009-11-19 04:39:19 -0800 Created attachment 43496 Bug fix patch 164950 2 43497 jturcotte 2009-11-19 04:43:08 -0800 Created attachment 43497 Autotests patch Other Qt tests have a section in the .pro file specific to symbian that looks like: symbian { TARGET.UID3 = 0xA000E540 TARGET.CAPABILITY = ReadUserData WriteUserData NetworkServices } I'm not sure about what to put in the UID3 field so I omitted it from the patch. Please tell me if you have an idea. 164959 3 43496 commit-queue 2009-11-19 06:04:40 -0800 Comment on attachment 43496 Bug fix patch Clearing flags on attachment: 43496 Committed r51185: <http://trac.webkit.org/changeset/51185> 164960 4 43497 commit-queue 2009-11-19 06:12:20 -0800 Comment on attachment 43497 Autotests patch Clearing flags on attachment: 43497 Committed r51186: <http://trac.webkit.org/changeset/51186> 164961 5 commit-queue 2009-11-19 06:12:32 -0800 All reviewed patches have been landed. Closing bug. 185397 6 florianlink 2010-01-28 02:24:26 -0800 *** Bug 34244 has been marked as a duplicate of this bug. *** 43496 2009-11-19 04:39:19 -0800 2009-11-19 06:04:39 -0800 Bug fix patch qwebinspector_internaldestruction.patch text/plain 1221 jturcotte ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIGIvV2ViS2l0L3F0L0FwaS9x d2VicGFnZS5jcHAKaW5kZXggODQ5OWUxMC4uZThjM2EwMCAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0 L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKQEAgLTE2 OTgsOCArMTY5OCwxNCBAQCBRV2ViUGFnZTo6flFXZWJQYWdlKCkKICAgICBGcmFtZUxvYWRlciAq bG9hZGVyID0gZC0+bWFpbkZyYW1lLT5kLT5mcmFtZS0+bG9hZGVyKCk7CiAgICAgaWYgKGxvYWRl cikKICAgICAgICAgbG9hZGVyLT5kZXRhY2hGcm9tUGFyZW50KCk7Ci0gICAgaWYgKGQtPmluc3Bl Y3RvcikKLSAgICAgICAgZC0+aW5zcGVjdG9yLT5zZXRQYWdlKDApOworICAgIGlmIChkLT5pbnNw ZWN0b3IpIHsKKyAgICAgICAgLy8gU2luY2Ugd2UgaGF2ZSB0byBkZWxldGUgYW4gaW50ZXJuYWwg aW5zcGVjdG9yLAorICAgICAgICAvLyBjYWxsIHNldEluc3BlY3RvcigwKSBkaXJlY3RseSB0byBw cmV2ZW50IHBvdGVudGlhbCBjcmFzaGVzCisgICAgICAgIGlmIChkLT5pbnNwZWN0b3JJc0ludGVy bmFsT25seSkKKyAgICAgICAgICAgIGQtPnNldEluc3BlY3RvcigwKTsKKyAgICAgICAgZWxzZQor ICAgICAgICAgICAgZC0+aW5zcGVjdG9yLT5zZXRQYWdlKDApOworICAgIH0KICAgICBkZWxldGUg ZDsKIH0KIApkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0NoYW5nZUxvZyBiL1dlYktpdC9xdC9DaGFu Z2VMb2cKaW5kZXggOWIzMDAzZi4uNzlmNGFiYSAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L0NoYW5n ZUxvZworKysgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTEt MTkgIEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRlQG5va2lhLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEZpeCBRV2Vi SW5zcGVjdG9yIGRlc3RydWN0aW9uIHByb2JsZW0uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTY2NAorCisgICAgICAgICogQXBpL3F3ZWJwYWdlLmNw cDoKKyAgICAgICAgKFFXZWJQYWdlOjp+UVdlYlBhZ2UpOgorCiAyMDA5LTExLTA5ICBMYXN6bG8g R29tYm9zICA8bGFzemxvLjEuZ29tYm9zQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBLZW5uZXRoIENocmlzdGlhbnNlbi4K 43497 2009-11-19 04:43:08 -0800 2009-11-19 06:12:18 -0800 Autotests patch tst_qwebinspector.patch text/plain 4242 jturcotte ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IDliMzAwM2YuLjUxOTlmZjIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDA5LTExLTE5ICBKb2Nl bHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBBZGQgaW5zdGFudGlhdGlv biB0ZXN0cyBmb3IgUVdlYkluc3BlY3Rvci4KKworICAgICAgICAqIHRlc3RzL3F3ZWJpbnNwZWN0 b3IvcXdlYmluc3BlY3Rvci5wcm86IEFkZGVkLgorICAgICAgICAqIHRlc3RzL3F3ZWJpbnNwZWN0 b3IvdHN0X3F3ZWJpbnNwZWN0b3IuY3BwOiBBZGRlZC4KKyAgICAgICAgKHRzdF9RV2ViSW5zcGVj dG9yOjphdHRhY2hBbmREZXN0cm95KToKKyAgICAgICAgKiB0ZXN0cy90ZXN0cy5wcm86CisKIDIw MDktMTEtMDkgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggQ2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0IGEvV2Vi S2l0L3F0L3Rlc3RzL3F3ZWJpbnNwZWN0b3IvcXdlYmluc3BlY3Rvci5wcm8gYi9XZWJLaXQvcXQv dGVzdHMvcXdlYmluc3BlY3Rvci9xd2ViaW5zcGVjdG9yLnBybwpuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwLi41MjA4ODdlCi0tLSAvZGV2L251bGwKKysrIGIvV2ViS2l0L3F0L3Rl c3RzL3F3ZWJpbnNwZWN0b3IvcXdlYmluc3BlY3Rvci5wcm8KQEAgLTAsMCArMSw2IEBACitURU1Q TEFURSA9IGFwcAorVEFSR0VUID0gdHN0X3F3ZWJpbnNwZWN0b3IKK2luY2x1ZGUoLi4vLi4vLi4v Li4vV2ViS2l0LnByaSkKK1NPVVJDRVMgICs9IHRzdF9xd2ViaW5zcGVjdG9yLmNwcAorUVQgKz0g dGVzdGxpYiBuZXR3b3JrCitRTUFLRV9SUEFUSERJUiA9ICQkT1VUUFVUX0RJUi9saWIgJCRRTUFL RV9SUEFUSERJUgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJpbnNwZWN0b3IvdHN0 X3F3ZWJpbnNwZWN0b3IuY3BwIGIvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJpbnNwZWN0b3IvdHN0X3F3 ZWJpbnNwZWN0b3IuY3BwCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjEyY2Q2 MzAKLS0tIC9kZXYvbnVsbAorKysgYi9XZWJLaXQvcXQvdGVzdHMvcXdlYmluc3BlY3Rvci90c3Rf cXdlYmluc3BlY3Rvci5jcHAKQEAgLTAsMCArMSw2OCBAQAorLyoKKyAgICBDb3B5cmlnaHQgKEMp IDIwMDggTm9raWEgQ29ycG9yYXRpb24gYW5kL29yIGl0cyBzdWJzaWRpYXJ5KC1pZXMpCisKKyAg ICBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQg YW5kL29yCisgICAgbW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIExpYnJhcnkg R2VuZXJhbCBQdWJsaWMKKyAgICBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieSB0aGUgRnJlZSBTb2Z0 d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIKKyAgICB2ZXJzaW9uIDIgb2YgdGhlIExpY2Vuc2UsIG9y IChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uCisKKyAgICBUaGlzIGxpYnJhcnkg aXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwKKyAgICBi dXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50 eSBvZgorICAgIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVS UE9TRS4gIFNlZSB0aGUgR05VCisgICAgTGlicmFyeSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZv ciBtb3JlIGRldGFpbHMuCisKKyAgICBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9m IHRoZSBHTlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlCisgICAgYWxvbmcgd2l0aCB0 aGlzIGxpYnJhcnk7IHNlZSB0aGUgZmlsZSBDT1BZSU5HLkxJQi4gIElmIG5vdCwgd3JpdGUgdG8K KyAgICB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuLCA1MSBGcmFua2xpbiBTdHJl ZXQsIEZpZnRoIEZsb29yLAorICAgIEJvc3RvbiwgTUEgMDIxMTAtMTMwMSwgVVNBLgorKi8KKwor I2luY2x1ZGUgPFF0VGVzdC9RdFRlc3Q+CisKKyNpbmNsdWRlIDxxZGlyLmg+CisjaW5jbHVkZSA8 cXdlYmluc3BlY3Rvci5oPgorI2luY2x1ZGUgPHF3ZWJwYWdlLmg+CisjaW5jbHVkZSA8cXdlYnNl dHRpbmdzLmg+CisKK2NsYXNzIHRzdF9RV2ViSW5zcGVjdG9yIDogcHVibGljIFFPYmplY3Qgewor ICAgIFFfT0JKRUNUCisKK3ByaXZhdGUgc2xvdHM6CisgICAgdm9pZCBhdHRhY2hBbmREZXN0cm95 KCk7Cit9OworCit2b2lkIHRzdF9RV2ViSW5zcGVjdG9yOjphdHRhY2hBbmREZXN0cm95KCkKK3sK KyAgICB7ICAgLy8gRXh0ZXJuYWwgaW5zcGVjdG9yICsgbWFudWFsIGRlc3RydWN0aW9uIG9mIHBh Z2UgZmlyc3QKKyAgICAgICAgUVdlYlBhZ2UqIHBhZ2UgPSBuZXcgUVdlYlBhZ2UoKTsKKyAgICAg ICAgcGFnZS0+c2V0dGluZ3MoKS0+c2V0QXR0cmlidXRlKFFXZWJTZXR0aW5nczo6RGV2ZWxvcGVy RXh0cmFzRW5hYmxlZCwgdHJ1ZSk7CisgICAgICAgIFFXZWJJbnNwZWN0b3IqIGluc3BlY3RvciA9 IG5ldyBRV2ViSW5zcGVjdG9yKCk7CisgICAgICAgIGluc3BlY3Rvci0+c2V0UGFnZShwYWdlKTsK KyAgICAgICAgcGFnZS0+dXBkYXRlUG9zaXRpb25EZXBlbmRlbnRBY3Rpb25zKFFQb2ludCgwLCAw KSk7CisgICAgICAgIHBhZ2UtPnRyaWdnZXJBY3Rpb24oUVdlYlBhZ2U6Okluc3BlY3RFbGVtZW50 KTsKKworICAgICAgICBkZWxldGUgcGFnZTsKKyAgICAgICAgZGVsZXRlIGluc3BlY3RvcjsKKyAg ICB9CisgICAgeyAgIC8vIEV4dGVybmFsIGluc3BlY3RvciArIG1hbnVhbCBkZXN0cnVjdGlvbiBv ZiBpbnNwZWN0b3IgZmlyc3QKKyAgICAgICAgUVdlYlBhZ2UqIHBhZ2UgPSBuZXcgUVdlYlBhZ2Uo KTsKKyAgICAgICAgcGFnZS0+c2V0dGluZ3MoKS0+c2V0QXR0cmlidXRlKFFXZWJTZXR0aW5nczo6 RGV2ZWxvcGVyRXh0cmFzRW5hYmxlZCwgdHJ1ZSk7CisgICAgICAgIFFXZWJJbnNwZWN0b3IqIGlu c3BlY3RvciA9IG5ldyBRV2ViSW5zcGVjdG9yKCk7CisgICAgICAgIGluc3BlY3Rvci0+c2V0UGFn ZShwYWdlKTsKKyAgICAgICAgcGFnZS0+dXBkYXRlUG9zaXRpb25EZXBlbmRlbnRBY3Rpb25zKFFQ b2ludCgwLCAwKSk7CisgICAgICAgIHBhZ2UtPnRyaWdnZXJBY3Rpb24oUVdlYlBhZ2U6Okluc3Bl Y3RFbGVtZW50KTsKKworICAgICAgICBkZWxldGUgaW5zcGVjdG9yOworICAgICAgICBkZWxldGUg cGFnZTsKKyAgICB9CisgICAgeyAgIC8vIEludGVybmFsIGluc3BlY3RvcgorICAgICAgICBRV2Vi UGFnZSBwYWdlOworICAgICAgICBwYWdlLnNldHRpbmdzKCktPnNldEF0dHJpYnV0ZShRV2ViU2V0 dGluZ3M6OkRldmVsb3BlckV4dHJhc0VuYWJsZWQsIHRydWUpOworICAgICAgICBwYWdlLnVwZGF0 ZVBvc2l0aW9uRGVwZW5kZW50QWN0aW9ucyhRUG9pbnQoMCwgMCkpOworICAgICAgICBwYWdlLnRy aWdnZXJBY3Rpb24oUVdlYlBhZ2U6Okluc3BlY3RFbGVtZW50KTsKKyAgICB9Cit9CisKK1FURVNU X01BSU4odHN0X1FXZWJJbnNwZWN0b3IpCisKKyNpbmNsdWRlICJ0c3RfcXdlYmluc3BlY3Rvci5t b2MiCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvdGVzdHMvdGVzdHMucHJvIGIvV2ViS2l0L3F0L3Rl c3RzL3Rlc3RzLnBybwppbmRleCA5MzljZDIyLi5iOTY3Y2E5IDEwMDY0NAotLS0gYS9XZWJLaXQv cXQvdGVzdHMvdGVzdHMucHJvCisrKyBiL1dlYktpdC9xdC90ZXN0cy90ZXN0cy5wcm8KQEAgLTEs NCArMSw0IEBACiAKIFRFTVBMQVRFID0gc3ViZGlycwotU1VCRElSUyA9IHF3ZWJmcmFtZSBxd2Vi cGFnZSBxd2ViZWxlbWVudCBxZ3JhcGhpY3N3ZWJ2aWV3IHF3ZWJoaXN0b3J5aW50ZXJmYWNlIHF3 ZWJ2aWV3IHF3ZWJoaXN0b3J5CitTVUJESVJTID0gcXdlYmZyYW1lIHF3ZWJwYWdlIHF3ZWJlbGVt ZW50IHFncmFwaGljc3dlYnZpZXcgcXdlYmhpc3RvcnlpbnRlcmZhY2UgcXdlYnZpZXcgcXdlYmhp c3RvcnkgcXdlYmluc3BlY3RvcgogZ3JlYXRlclRoYW4oUVRfTUlOT1JfVkVSU0lPTiwgNCk6IFNV QkRJUlMgKz0gYmVuY2htYXJrcy9wYWludGluZy90c3RfcGFpbnRpbmcucHJvIGJlbmNobWFya3Mv bG9hZGluZy90c3RfbG9hZGluZy5wcm8K