31662 2009-11-19 00:11:30 -0800 Don't run websocket tests when run-webkit-tests --no-http 2009-11-19 18:49:20 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ukai webkit-unassigned oldest_to_newest 164926 0 ukai 2009-11-19 00:11:30 -0800 If run-webkit-tests --no-http, it should also disable websocket tests. cf. https://bugs.webkit.org/show_bug.cgi?id=31425 file:// documents should not be able to open WebSocket connections 164928 1 43491 ukai 2009-11-19 00:16:11 -0800 Created attachment 43491 Ignore websocket tests when --no-http is specified. 164934 2 43491 eric 2009-11-19 01:05:37 -0800 Comment on attachment 43491 Ignore websocket tests when --no-http is specified. LGTM. 164940 3 ukai 2009-11-19 02:42:49 -0800 Committed r51180: <http://trac.webkit.org/changeset/51180> 165002 4 ap 2009-11-19 09:49:30 -0800 If we make the http option affect websocket tests (which is not necessarily the right thing to do IMO), then we should update run-webkit-tests help output: --[no-]http Run (or do not run) http tests (default: run) 165171 5 ukai 2009-11-19 18:49:20 -0800 (In reply to comment #4) > If we make the http option affect websocket tests (which is not necessarily the > right thing to do IMO), then we should update run-webkit-tests help output: > > --[no-]http Run (or do not run) http tests (default: run) Sorry. is it ok to update help output only, or better to add new flag for -[no-]websocket, instead of ignoring websocket by --no-http? 43491 2009-11-19 00:16:11 -0800 2009-11-19 01:05:37 -0800 Ignore websocket tests when --no-http is specified. bug-31662-20091119171609.patch text/plain 821 ukai ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBiMDM2YmE4Li5iM2U5MDJlIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTEgQEAKKzIwMDktMTEt MTkgIEZ1bWl0b3NoaSBVa2FpICA8dWthaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWdub3JlIHdlYnNvY2tldCB0ZXN0cyB3 aGVuIC0tbm8taHR0cCBpcyBzcGVjaWZpZWQuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi13ZWJr aXQtdGVzdHM6CisKIDIwMDktMTEtMTggIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBBbmRlcnMgQ2FybHNzb24uCmRpZmYgLS1naXQgYS9XZWJLaXRU b29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMgYi9XZWJLaXRUb29scy9TY3JpcHRzL3J1bi13 ZWJraXQtdGVzdHMKaW5kZXggYjQzMGNmNy4uMWUzNzI4NiAxMDA3NTUKLS0tIGEvV2ViS2l0VG9v bHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzCisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvcnVu LXdlYmtpdC10ZXN0cwpAQCAtNDE3LDYgKzQxNyw3IEBAIGlmIChjaGVja1dlYkNvcmVTVkdTdXBw b3J0KDApKSB7CiAKIGlmICghJHRlc3RIVFRQKSB7CiAgICAgJGlnbm9yZWREaXJlY3Rvcmllc3sn aHR0cCd9ID0gMTsKKyAgICAkaWdub3JlZERpcmVjdG9yaWVzeyd3ZWJzb2NrZXQnfSA9IDE7CiB9 CiAKIGlmICghJHRlc3RNZWRpYSkgewo=