31661 2009-11-18 22:50:28 -0800 Remove HAVE(FLOAT_H) guard 2009-11-19 11:55:03 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned commit-queue tkent oldest_to_newest 164918 0 laszlo.gombos 2009-11-18 22:50:28 -0800 HAVE(FLOAT_H) is meant to guard <float.h> includes. As of now the number of _unguarded_ <float.h> includes is 13; there is only 2 locations where float.h is guarded. Based on these numbers it seems clear that neither JavaScriptCore nor WebCore would not build without float.h available. All build would have to define HAVE(FLOAT_H), which is not the case today - and this sometimes leads to build inconsistencies (e.g. http://trac.webkit.org/changeset/51170). I would proposed to remove the HAVE(FLOAT_H) - as this seems to be a hard dependency for all WebKit components. Patch will follow. 164964 1 43498 laszlo.gombos 2009-11-19 06:51:46 -0800 Created attachment 43498 proposed patch 165043 2 43498 commit-queue 2009-11-19 11:54:57 -0800 Comment on attachment 43498 proposed patch Clearing flags on attachment: 43498 Committed r51197: <http://trac.webkit.org/changeset/51197> 165044 3 commit-queue 2009-11-19 11:55:03 -0800 All reviewed patches have been landed. Closing bug. 43498 2009-11-19 06:51:46 -0800 2009-11-19 11:54:57 -0800 proposed patch 31661.patch text/plain 4485 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUxMTg3KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMDktMTEtMTkgIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBIQVZFKEZMT0FUX0gpIGd1YXJkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTY2MQorCisg ICAgICAgIEphdmFTY3JpcHRDb3JlIGhhcyBhIGRlcGVuZGVuY3kgb24gZmxvYXQuaCwgdGhlcmUg aXMKKyAgICAgICAgbm8gbmVlZCB0byBndWFyZCBmbG9hdC5oLgorCisgICAgICAgICogcnVudGlt ZS9EYXRlUHJvdG90eXBlLmNwcDogUmVtb3ZlIGluY2x1ZGUgZGlyZWN0aXZlIAorICAgICAgICBm b3IgZmxvYXQuaCBhcyBpdCBpcyBpbmNsdWRlZCBpbiBNYXRoRXh0cmFzLmggYWxyZWFkeS4KKyAg ICAgICAgKiBydW50aW1lL09wZXJhdGlvbnMuY3BwOiBEaXR0by4KKyAgICAgICAgKiBydW50aW1l L1VTdHJpbmcuY3BwOiBEaXR0by4KKyAgICAgICAgKiB3dGYvZHRvYS5jcHA6IERpdHRvLgorICAg ICAgICAqIHd0Zi9NYXRoRXh0cmFzLmg6IFJlbW92ZSBIQVZFKEZMT0FUX0gpIGd1YXJkLgorICAg ICAgICAqIHd0Zi9QbGF0Zm9ybS5oOiBEaXR0by4KKwogMjAwOS0xMS0xOSAgVGhpYWdvIE1hY2ll aXJhIDx0aGlhZ28ubWFjaWVpcmFAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNp bW9uIEhhdXNtYW5uLgpJbmRleDogSmF2YVNjcmlwdENvcmUvcnVudGltZS9EYXRlUHJvdG90eXBl LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0RhdGVQcm90b3R5cGUu Y3BwCShyZXZpc2lvbiA1MTE4NykKKysrIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvRGF0ZVByb3Rv dHlwZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI4LDcgKzI4LDYgQEAKICNpbmNsdWRlICJKU1N0 cmluZy5oIgogI2luY2x1ZGUgIk9iamVjdFByb3RvdHlwZS5oIgogI2luY2x1ZGUgIkRhdGVJbnN0 YW5jZS5oIgotI2luY2x1ZGUgPGZsb2F0Lmg+CiAKICNpZiAhUExBVEZPUk0oTUFDKSAmJiBIQVZF KExBTkdJTkZPX0gpCiAjaW5jbHVkZSA8bGFuZ2luZm8uaD4KSW5kZXg6IEphdmFTY3JpcHRDb3Jl L3J1bnRpbWUvT3BlcmF0aW9ucy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvcnVu dGltZS9PcGVyYXRpb25zLmNwcAkocmV2aXNpb24gNTExODcpCisrKyBKYXZhU2NyaXB0Q29yZS9y dW50aW1lL09wZXJhdGlvbnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOSwxMCArMjksNiBAQAog I2luY2x1ZGUgPHN0ZGlvLmg+CiAjaW5jbHVkZSA8d3RmL01hdGhFeHRyYXMuaD4KIAotI2lmIEhB VkUoRkxPQVRfSCkKLSNpbmNsdWRlIDxmbG9hdC5oPgotI2VuZGlmCi0KIG5hbWVzcGFjZSBKU0Mg ewogCiBib29sIEpTVmFsdWU6OmVxdWFsU2xvd0Nhc2UoRXhlY1N0YXRlKiBleGVjLCBKU1ZhbHVl IHYxLCBKU1ZhbHVlIHYyKQpJbmRleDogSmF2YVNjcmlwdENvcmUvcnVudGltZS9VU3RyaW5nLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL1VTdHJpbmcuY3BwCShyZXZp c2lvbiA1MTE4NykKKysrIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvVVN0cmluZy5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTMwLDcgKzMwLDYgQEAKICNpbmNsdWRlICJJZGVudGlmaWVyLmgiCiAjaW5j bHVkZSAiT3BlcmF0aW9ucy5oIgogI2luY2x1ZGUgPGN0eXBlLmg+Ci0jaW5jbHVkZSA8ZmxvYXQu aD4KICNpbmNsdWRlIDxsaW1pdHMuaD4KICNpbmNsdWRlIDxsaW1pdHM+CiAjaW5jbHVkZSA8bWF0 aC5oPgpJbmRleDogSmF2YVNjcmlwdENvcmUvd3RmL01hdGhFeHRyYXMuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBKYXZhU2NyaXB0Q29yZS93dGYvTWF0aEV4dHJhcy5oCShyZXZpc2lvbiA1MTE4NykKKysrIEph dmFTY3JpcHRDb3JlL3d0Zi9NYXRoRXh0cmFzLmgJKHdvcmtpbmcgY29weSkKQEAgLTI2LDYgKzI2 LDcgQEAKICNpZm5kZWYgV1RGX01hdGhFeHRyYXNfaAogI2RlZmluZSBXVEZfTWF0aEV4dHJhc19o CiAKKyNpbmNsdWRlIDxmbG9hdC5oPgogI2luY2x1ZGUgPG1hdGguaD4KICNpbmNsdWRlIDxzdGRs aWIuaD4KIApAQCAtNDMsMTEgKzQ0LDYgQEAKICNpbmNsdWRlIDxzdGRsaWIuaD4KICNlbmRpZgog I2luY2x1ZGUgPGxpbWl0cz4KLQotI2lmIEhBVkUoRkxPQVRfSCkKLSNpbmNsdWRlIDxmbG9hdC5o PgotI2VuZGlmCi0KICNlbmRpZgogCiAjaWZuZGVmIE1fUEkKSW5kZXg6IEphdmFTY3JpcHRDb3Jl L3d0Zi9QbGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9y bS5oCShyZXZpc2lvbiA1MTE4NykKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCSh3 b3JraW5nIGNvcHkpCkBAIC01ODksNyArNTg5LDYgQEAKIAogI2VsaWYgUExBVEZPUk0oV0lOX09T KQogCi0jZGVmaW5lIEhBVkVfRkxPQVRfSCAxCiAjaWYgUExBVEZPUk0oV0lOQ0UpCiAjZGVmaW5l IEhBVkVfRVJSTk9fSCAwCiAjZWxzZQpJbmRleDogSmF2YVNjcmlwdENvcmUvd3RmL2R0b2EuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9kdG9hLmNwcAkocmV2aXNpb24gNTEx ODcpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYvZHRvYS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0 MCw3ICsxNDAsNiBAQAogI2Vsc2UKICNkZWZpbmUgTk9fRVJSTk8KICNlbmRpZgotI2luY2x1ZGUg PGZsb2F0Lmg+CiAjaW5jbHVkZSA8bWF0aC5oPgogI2luY2x1ZGUgPHN0ZGludC5oPgogI2luY2x1 ZGUgPHN0ZGxpYi5oPgpJbmRleDogV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUxMTg3KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdv cmtpbmcgY29weSkKQEAgLTEsMyArMSwxOCBAQAorMjAwOS0xMS0xOSAgTGFzemxvIEdvbWJvcyAg PGxhc3psby4xLmdvbWJvc0Bub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIEhBVkUoRkxPQVRfSCkgZ3VhcmQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNjYxCisKKyAgICAgICAg V2ViQ29yZSBoYXMgYSBkZXBlbmRlbmN5IG9uIGZsb2F0LmgsIHRoZXJlIGlzCisgICAgICAgIG5v IG5lZWQgdG8gZ3VhcmQgZmxvYXQuaC4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgdGhlcmUg aXMgbm8gZnVuY3Rpb25hbCBjaGFuZ2UuCisKKyAgICAgICAgKiBodG1sL0hUTUxJbnB1dEVsZW1l bnQuY3BwOiBSZW1vdmUgaW5jbHVkZSBkaXJlY3RpdmUKKyAgICAgICAgZm9yIGZsb2F0LmggYXMg aXQgaXMgaW5jbHVkZWQgaW4gTWF0aEV4dHJhcy5oIGFscmVhZHkuCisKIDIwMDktMTEtMTkgIE9s aXZpZXIgR29mZmFydCAgPG9nb2ZmYXJ0QHRyb2xsdGVjaC5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgU2ltb24gSGF1c21hbm4uCkluZGV4OiBXZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVu dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCShy ZXZpc2lvbiA1MTE4NykKKysrIFdlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAkod29y a2luZyBjb3B5KQpAQCAtNjIsNyArNjIsNiBAQAogI2luY2x1ZGUgIlJlbmRlclRoZW1lLmgiCiAj aW5jbHVkZSAiU3RyaW5nSGFzaC5oIgogI2luY2x1ZGUgIlRleHRFdmVudC5oIgotI2luY2x1ZGUg PGZsb2F0Lmg+CiAjaW5jbHVkZSA8d3RmL0hhc2hNYXAuaD4KICNpbmNsdWRlIDx3dGYvTWF0aEV4 dHJhcy5oPgogI2luY2x1ZGUgPHd0Zi9TdGRMaWJFeHRyYXMuaD4K