31659 2009-11-18 20:53:36 -0800 Connection must be closed in case of Web Socket handshake error 2009-11-30 15:49:43 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 yuzo ap ap eric ukai yuzo oldest_to_newest 164889 0 yuzo 2009-11-18 20:53:36 -0800 Currently, WebKit times out in case of Web Socket handshake error (as caught by LayoutTests/websocket/tests/handshake-error.html) It must close the connection instead. http://www.w3.org/TR/2009/WD-websockets-20091029/ 4 The WebSocket interface ... If the "establish a Web Socket connection" algorithm fails, it triggers the "fail the Web Socket connection" algorithm, which then invokes the "close the Web Socket connection" algorithm, which then establishes that the "Web Socket connection is closed", which fires the close event as described below. 164896 1 yuzo 2009-11-18 21:29:09 -0800 Note: this bug was found while examining: https://bugs.webkit.org/show_bug.cgi?id=31465 Yuzo 166781 2 ap 2009-11-26 13:03:34 -0800 I don't understand what exactly fails here. According to <http://build.webkit.org/waterfall>, all tests currently pass. Does this particular test have identical output in success and failure cases? Or does it only fail with a patch from bug 31465 applied? 166797 3 yuzo 2009-11-26 16:43:55 -0800 Without 31465, the server calls a non-existent method, raises exception, and closes the socket. With 31645, the server writes an invalid handshake response to the socket. It seems that the client side can handle the socket closure case properly but not the invalid response case -- the client times out for the latter. Yuzo 166798 4 yuzo 2009-11-26 16:45:44 -0800 Sorry, s/31645/31465/g in #3. 167444 5 44045 ap 2009-11-30 15:44:49 -0800 Created attachment 44045 proposed fix 167445 6 44045 oliver 2009-11-30 15:45:58 -0800 Comment on attachment 44045 proposed fix r=me 167449 7 ap 2009-11-30 15:49:43 -0800 Committed <http://trac.webkit.org/changeset/51516>. 44045 2009-11-30 15:44:49 -0800 2009-11-30 15:45:58 -0800 proposed fix didClose.txt text/plain 2543 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTUxNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMTEtMzAgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNjU5CisgICAgICAgIENv bm5lY3Rpb24gbXVzdCBiZSBjbG9zZWQgaW4gY2FzZSBvZiBXZWIgU29ja2V0IGhhbmRzaGFrZSBl cnJvcgorCisgICAgICAgIFRoZSBuZXR3b3JrIGNvbm5lY3Rpb24gd2FzIGNsb3NlZCwgYnV0IHRo ZSBjbG9zZSBldmVudCB3YXNuJ3QgZGlzcGF0Y2hlZC4KKworICAgICAgICAqIHBsYXRmb3JtL25l dHdvcmsvY2YvU29ja2V0U3RyZWFtSGFuZGxlQ0ZOZXQuY3BwOiAoV2ViQ29yZTo6U29ja2V0U3Ry ZWFtSGFuZGxlOjpwbGF0Zm9ybUNsb3NlKToKKyAgICAgICAgQ2FsbCBjbGllbnQgZGlkSGFuZGxl KCkgbWV0aG9kLiBUaGlzIGxvb2tzIHN0cmFuZ2UgaW4gQ0ZOZXR3b3JrIGltcGxlbWVudGF0aW9u LCBiZWNhdXNlCisgICAgICAgIGl0J3MgdGhlIGNsaWVudCB0aGF0IGFza2VkIHRvIGNsb3NlIHRo ZSBzdHJlYW0sIHNvIGl0IHNob3VsZG4ndCBuZWVkIHRoZSBjYWxsYmFjay4gSXQgbWFrZXMKKyAg ICAgICAgbW9yZSBzZW5zZSBpbiBjcm9zcy1wcm9jZXNzIGltcGxlbWVudGF0aW9uLCBiZWNhdXNl IGNsb3NpbmcgaXMgYXN5bmMgdGhlcmUuCisKIDIwMDktMTEtMjQgIEdhdmluIEJhcnJhY2xvdWdo ICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdlb2ZmIEdh cmVuLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1NvY2tldFN0cmVhbUhhbmRs ZUNGTmV0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvU29j a2V0U3RyZWFtSGFuZGxlQ0ZOZXQuY3BwCShyZXZpc2lvbiA1MTUxMCkKKysrIFdlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9jZi9Tb2NrZXRTdHJlYW1IYW5kbGVDRk5ldC5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTYxNCw2ICs2MTQsOCBAQCB2b2lkIFNvY2tldFN0cmVhbUhhbmRsZTo6cGxhdGZvcm1D bG9zZSgpCiAgICAgCiAgICAgbV9yZWFkU3RyZWFtID0gMDsKICAgICBtX3dyaXRlU3RyZWFtID0g MDsKKworICAgIG1fY2xpZW50LT5kaWRDbG9zZSh0aGlzKTsKIH0KIAogdm9pZCBTb2NrZXRTdHJl YW1IYW5kbGU6OnJlY2VpdmVkQ3JlZGVudGlhbChjb25zdCBBdXRoZW50aWNhdGlvbkNoYWxsZW5n ZSYsIGNvbnN0IENyZWRlbnRpYWwmKQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNTE1MTUpCisrKyBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAwOS0x MS0zMCAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzE2NTkKKyAgICAgICAgQ29ubmVjdGlvbiBtdXN0IGJlIGNsb3Nl ZCBpbiBjYXNlIG9mIFdlYiBTb2NrZXQgaGFuZHNoYWtlIGVycm9yCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9tYWMvU2tpcHBlZDogVW4tc2tpcCB3ZWJzb2NrZXQvdGVzdHMvaGFuZHNoYWtlLWVycm9y Lmh0bWwuCisKIDIwMDktMTEtMzAgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgpJbmRleDogTGF5b3V0VGVz dHMvcGxhdGZvcm0vbWFjL1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjL1NraXBwZWQJKHJldmlzaW9uIDUxNTEwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0v bWFjL1NraXBwZWQJKHdvcmtpbmcgY29weSkKQEAgLTEwOCw2ICsxMDgsMyBAQCBwbHVnaW5zL3Jl bG9hZHBsdWdpbnMtbm8tcGFnZXMuaHRtbAogCiAjIFRoZXNlIHRlc3QgcmVxdWlyZSBRdCBXaWRn ZXRzCiBwbHVnaW5zL3F0LXF3aWRnZXQtcGx1Z2luLmh0bWwKLQotIyBTa2lwcGVkIHVudGlsIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTY1OSBpcyBmaXhlZC4KLXdl YnNvY2tldC90ZXN0cy9oYW5kc2hha2UtZXJyb3IuaHRtbAo=