31656 2009-11-18 18:22:06 -0800 -webkit-user-drag: element Drag images include overflow decorations from incorrect nodes 2009-11-19 14:05:24 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 oliver webkit-unassigned mitz oldest_to_newest 164866 0 oliver 2009-11-18 18:22:06 -0800 Drag images should not include overflow decorations from nodes that are not children 164898 1 43484 oliver 2009-11-18 21:32:36 -0800 Created attachment 43484 Patch 164917 2 43484 mitz 2009-11-18 22:46:54 -0800 Comment on attachment 43484 Patch > + if (hasOverflowClip() && style()->visibility() == VISIBLE && (phase == PaintPhaseBlockBackground || phase == PaintPhaseChildBlockBackground)) { > + if (!paintInfo.paintingRoot || isDescendantOf(paintInfo.paintingRoot)) > + layer()->paintOverflowControls(paintInfo.context, tx, ty, paintInfo.rect); > + } Can’t use use shouldPaintWithinRoot? You are never supposed to be a proper descendant of the painting root. You should just add the test to the first if’s condition instead of nesting like that. It would be good to have a manual test case for this. I don’t think it necessarily has to be checked in, but at least attach it to the bug, if possible, for future reference. r- because I think you don’t need to call isDescendantOf(). 165046 3 43516 oliver 2009-11-19 12:00:20 -0800 Created attachment 43516 Patch 165061 4 43516 hyatt 2009-11-19 12:43:39 -0800 Comment on attachment 43516 Patch r=me 165086 5 oliver 2009-11-19 14:05:24 -0800 Committed r51205 43484 2009-11-18 21:32:36 -0800 2009-11-19 12:00:14 -0800 Patch bug-31656-20091118213235.patch text/plain 1788 oliver ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjczN2E0Yi4uOTFiZGU0NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0xMS0xOCAgT2xpdmVyIEh1bnQg IDxvbGl2ZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIC13ZWJraXQtdXNlci1kcmFnOiBlbGVtZW50IERyYWcgaW1hZ2VzIGluY2x1 ZGUgb3ZlcmZsb3cgZGVjb3JhdGlvbnMgZnJvbSBpbmNvcnJlY3Qgbm9kZXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNjU2CisKKyAgICAgICAgTWFr ZSBzdXJlIHdlJ3JlIGEgY2hpbGQgb2YgdGhlIHBhaW50aW5nIHJvb3QgYmVmb3JlIGRyYXdpbmcg b3ZlcmZsb3cgZmVhdHVyZXMuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2suY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OnBhaW50KToKKwogMjAwOS0xMS0xOCAg RG1pdHJ5IFRpdG92ICA8ZGltaWNoQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2Nr LmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAppbmRleCBhODQwN2QxLi40 ZGE4MWJiIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKKysr IGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCkBAIC0xNTIzLDggKzE1MjMsMTAg QEAgdm9pZCBSZW5kZXJCbG9jazo6cGFpbnQoUGFpbnRJbmZvJiBwYWludEluZm8sIGludCB0eCwg aW50IHR5KQogICAgIC8vIE91ciBzY3JvbGxiYXIgd2lkZ2V0cyBwYWludCBleGFjdGx5IHdoZW4g d2UgdGVsbCB0aGVtIHRvLCBzbyB0aGF0IHRoZXkgd29yayBwcm9wZXJseSB3aXRoCiAgICAgLy8g ei1pbmRleC4gIFdlIHBhaW50IGFmdGVyIHdlIHBhaW50ZWQgdGhlIGJhY2tncm91bmQvYm9yZGVy LCBzbyB0aGF0IHRoZSBzY3JvbGxiYXJzIHdpbGwKICAgICAvLyBzaXQgYWJvdmUgdGhlIGJhY2tn cm91bmQvYm9yZGVyLgotICAgIGlmIChoYXNPdmVyZmxvd0NsaXAoKSAmJiBzdHlsZSgpLT52aXNp YmlsaXR5KCkgPT0gVklTSUJMRSAmJiAocGhhc2UgPT0gUGFpbnRQaGFzZUJsb2NrQmFja2dyb3Vu ZCB8fCBwaGFzZSA9PSBQYWludFBoYXNlQ2hpbGRCbG9ja0JhY2tncm91bmQpKQotICAgICAgICBs YXllcigpLT5wYWludE92ZXJmbG93Q29udHJvbHMocGFpbnRJbmZvLmNvbnRleHQsIHR4LCB0eSwg cGFpbnRJbmZvLnJlY3QpOworICAgIGlmIChoYXNPdmVyZmxvd0NsaXAoKSAmJiBzdHlsZSgpLT52 aXNpYmlsaXR5KCkgPT0gVklTSUJMRSAmJiAocGhhc2UgPT0gUGFpbnRQaGFzZUJsb2NrQmFja2dy b3VuZCB8fCBwaGFzZSA9PSBQYWludFBoYXNlQ2hpbGRCbG9ja0JhY2tncm91bmQpKSB7CisgICAg ICAgIGlmICghcGFpbnRJbmZvLnBhaW50aW5nUm9vdCB8fCBpc0Rlc2NlbmRhbnRPZihwYWludElu Zm8ucGFpbnRpbmdSb290KSkKKyAgICAgICAgICAgIGxheWVyKCktPnBhaW50T3ZlcmZsb3dDb250 cm9scyhwYWludEluZm8uY29udGV4dCwgdHgsIHR5LCBwYWludEluZm8ucmVjdCk7CisgICAgfQog fQogCiB2b2lkIFJlbmRlckJsb2NrOjpwYWludENvbHVtblJ1bGVzKFBhaW50SW5mbyYgcGFpbnRJ bmZvLCBpbnQgdHgsIGludCB0eSkK 43516 2009-11-19 12:00:20 -0800 2009-11-19 12:43:39 -0800 Patch bug-31656-20091119120019.patch text/plain 2410 oliver ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjczN2E0Yi4uMGY2NWQ1OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0xMS0xOSAgT2xpdmVyIEh1bnQg IDxvbGl2ZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIC13ZWJraXQtdXNlci1kcmFnOiBlbGVtZW50IERyYWcgaW1hZ2VzIGluY2x1 ZGUgb3ZlcmZsb3cgZGVjb3JhdGlvbnMgZnJvbSBpbmNvcnJlY3Qgbm9kZXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNjU2CisKKyAgICAgICAgTWFr ZSBzdXJlIHdlJ3JlIGEgY2hpbGQgb2YgdGhlIHBhaW50aW5nIHJvb3QgYmVmb3JlIGRyYXdpbmcg b3ZlcmZsb3cgZmVhdHVyZXMuCisKKyAgICAgICAgKiBtYW51YWwtdGVzdHMvdXNlci1kcmFnLXdp dGgtZGVjb3JhdGlvbnMuaHRtbDogQWRkZWQuCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJs b2NrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpwYWludCk6CisKIDIwMDkt MTEtMTggIERtaXRyeSBUaXRvdiAgPGRpbWljaEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9XZWJDb3JlL21hbnVhbC10ZXN0cy91 c2VyLWRyYWctd2l0aC1kZWNvcmF0aW9ucy5odG1sIGIvV2ViQ29yZS9tYW51YWwtdGVzdHMvdXNl ci1kcmFnLXdpdGgtZGVjb3JhdGlvbnMuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwLi4xODc4ZDExCi0tLSAvZGV2L251bGwKKysrIGIvV2ViQ29yZS9tYW51YWwtdGVzdHMv dXNlci1kcmFnLXdpdGgtZGVjb3JhdGlvbnMuaHRtbApAQCAtMCwwICsxLDcgQEAKK1RoaXMgdGVz dHMgdGhhdCB3ZSBkb24ndCBpbmNsdWRlIG92ZXJmbG93IGRlY29yYXRpb25zIGZyb20gb3VyIGFu Y2VzdG9yIG5vZGVzIGluIHRoZSBkcmFnIGltYWdlIGZvciAtd2Via2l0LXVzZXItZHJhZzogZWxl bWVudC4gIFRvIHBlcmZvcm0gdGhpcyB0ZXN0IGRyYWcgdGhlIGdyZWVuIHNxdWFyZSBiZWxvdy4g IFRoZSBkcmFnIGltYWdlIHNob3VsZCBub3QgY29udGFpbiBhbnkgcGFydHMgb2YgdGhlIHNjcm9s bGJhciBncmFwaGljcyB2aXNpYmxlIG9uIHRoZSBwYWdlLgorCis8ZGl2IHN0eWxlPSJoZWlnaHQ6 MTAwcHg7IHdpZHRoOjEwMHB4O292ZXJmbG93OnNjcm9sbDsiPgorICAgIDxkaXYgc3R5bGU9Ii13 ZWJraXQtdXNlci1kcmFnOmVsZW1lbnQ7cG9zaXRpb246YWJzb2x1dGU7IGJhY2tncm91bmQ6IHJn YmEoMCwxMjgsMCwwLjUpOyBoZWlnaHQ6MTAwcHg7IHdpZHRoOjEwMHB4OyI+CisgICAgICAgIERy YWcgbWUhCisgICAgPC9kaXY+Cis8L2Rpdj4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCmRp ZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAgYi9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJCbG9jay5jcHAKaW5kZXggYTg0MDdkMS4uZGU0NDI3OCAxMDA2NDQKLS0t IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCisrKyBiL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckJsb2NrLmNwcApAQCAtMTUyMyw3ICsxNTIzLDcgQEAgdm9pZCBSZW5kZXJCbG9j azo6cGFpbnQoUGFpbnRJbmZvJiBwYWludEluZm8sIGludCB0eCwgaW50IHR5KQogICAgIC8vIE91 ciBzY3JvbGxiYXIgd2lkZ2V0cyBwYWludCBleGFjdGx5IHdoZW4gd2UgdGVsbCB0aGVtIHRvLCBz byB0aGF0IHRoZXkgd29yayBwcm9wZXJseSB3aXRoCiAgICAgLy8gei1pbmRleC4gIFdlIHBhaW50 IGFmdGVyIHdlIHBhaW50ZWQgdGhlIGJhY2tncm91bmQvYm9yZGVyLCBzbyB0aGF0IHRoZSBzY3Jv bGxiYXJzIHdpbGwKICAgICAvLyBzaXQgYWJvdmUgdGhlIGJhY2tncm91bmQvYm9yZGVyLgotICAg IGlmIChoYXNPdmVyZmxvd0NsaXAoKSAmJiBzdHlsZSgpLT52aXNpYmlsaXR5KCkgPT0gVklTSUJM RSAmJiAocGhhc2UgPT0gUGFpbnRQaGFzZUJsb2NrQmFja2dyb3VuZCB8fCBwaGFzZSA9PSBQYWlu dFBoYXNlQ2hpbGRCbG9ja0JhY2tncm91bmQpKQorICAgIGlmIChoYXNPdmVyZmxvd0NsaXAoKSAm JiBzdHlsZSgpLT52aXNpYmlsaXR5KCkgPT0gVklTSUJMRSAmJiAocGhhc2UgPT0gUGFpbnRQaGFz ZUJsb2NrQmFja2dyb3VuZCB8fCBwaGFzZSA9PSBQYWludFBoYXNlQ2hpbGRCbG9ja0JhY2tncm91 bmQpICYmIHNob3VsZFBhaW50V2l0aGluUm9vdChwYWludEluZm8pKQogICAgICAgICBsYXllcigp LT5wYWludE92ZXJmbG93Q29udHJvbHMocGFpbnRJbmZvLmNvbnRleHQsIHR4LCB0eSwgcGFpbnRJ bmZvLnJlY3QpOwogfQogCg==