31654 2009-11-18 17:05:48 -0800 [Qt] Rebase Qt results for LayoutTest/fast/table/row-height-recalc2.html 2009-11-24 00:43:57 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED WONTFIX P2 Normal --- 1 dbates webkit-unassigned abecsi bdakin dimich eric gyll hyatt jasneet karinag mitz ossy zoltan oldest_to_newest 164832 0 dbates 2009-11-18 17:05:48 -0800 The pixel-test/render-tree results for LayoutTest/sfast/table/row-height-recalc2.html are incorrect. The tests were originally generated (and passed) using Qt 4.5.2 on Ubuntu. This test case was included in the patch for bug #24971. 164839 1 43473 zoltan 2009-11-18 17:31:10 -0800 Created attachment 43473 proposed patch 164840 2 dimich 2009-11-18 17:33:49 -0800 I wonder if this test could be dumpAsText() variety so there would not be any platform-dependent results. 164935 3 43473 eric 2009-11-19 01:06:50 -0800 Comment on attachment 43473 proposed patch It seems we should just convert this to dump as text, no? And use getComputedStyle() to get the height information we need. 165973 4 dimich 2009-11-23 18:29:33 -0800 I had to add 2 new rebaselines for Chromium so decided to just go ahead and convert this test to dumpAsText(). See bug 31816. I propose to do that conversion and resolve this bug as FIXED (or WONTFIX?) with a comment. 166018 5 43473 zoltan 2009-11-24 00:40:49 -0800 Comment on attachment 43473 proposed patch The test'll be converted to dumpAsTest in bug #31816. 166019 6 zoltan 2009-11-24 00:43:57 -0800 I set it to WONTFIX, because it'll be resolved in another way, in another bug (#31816). 43473 2009-11-18 17:31:10 -0800 2009-11-24 00:40:49 -0800 proposed patch row.patch text/plain 3295 zoltan SW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL3F0L2Zhc3QvdGFibGUvcm93LWhlaWdodC1yZWNh bGMyLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9m YXN0L3RhYmxlL3Jvdy1oZWlnaHQtcmVjYWxjMi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDUxMTU3 KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvZmFzdC90YWJsZS9yb3ctaGVpZ2h0LXJlY2Fs YzItZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDI0ICsxLDI0IEBACiBsYXllciBh dCAoMCwwKSBzaXplIDgwMHg2MDAKICAgUmVuZGVyVmlldyBhdCAoMCwwKSBzaXplIDgwMHg2MDAK LWxheWVyIGF0ICgwLDApIHNpemUgODAweDE5MgotICBSZW5kZXJCbG9jayB7SFRNTH0gYXQgKDAs MCkgc2l6ZSA4MDB4MTkyCi0gICAgUmVuZGVyQm9keSB7Qk9EWX0gYXQgKDgsMTYpIHNpemUgNzg0 eDE2OAotICAgICAgUmVuZGVyQmxvY2sge1B9IGF0ICgwLDApIHNpemUgNzg0eDQyCi0gICAgICAg IFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDU3eDIxCitsYXllciBhdCAoMCwwKSBz aXplIDgwMHgxOTAKKyAgUmVuZGVyQmxvY2sge0hUTUx9IGF0ICgwLDApIHNpemUgODAweDE5MAor ICAgIFJlbmRlckJvZHkge0JPRFl9IGF0ICg4LDE2KSBzaXplIDc4NHgxNjYKKyAgICAgIFJlbmRl ckJsb2NrIHtQfSBhdCAoMCwwKSBzaXplIDc4NHg0MAorICAgICAgICBSZW5kZXJUZXh0IHsjdGV4 dH0gYXQgKDAsMCkgc2l6ZSA1N3gyMAogICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDApIHdpZHRo IDU3OiAiVGVzdCBmb3IgIgotICAgICAgICBSZW5kZXJJbmxpbmUge0l9IGF0ICgwLDApIHNpemUg NzcxeDQyCi0gICAgICAgICAgUmVuZGVySW5saW5lIHtBfSBhdCAoMCwwKSBzaXplIDMzN3gyMSBb Y29sb3I9IzAwMDBFRV0KLSAgICAgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoNTcsMCkg c2l6ZSAzMzd4MjEKKyAgICAgICAgUmVuZGVySW5saW5lIHtJfSBhdCAoMCwwKSBzaXplIDc3M3g0 MAorICAgICAgICAgIFJlbmRlcklubGluZSB7QX0gYXQgKDAsMCkgc2l6ZSAzMzd4MjAgW2NvbG9y PSMwMDAwRUVdCisgICAgICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDU3LDApIHNpemUg MzM3eDIwCiAgICAgICAgICAgICAgIHRleHQgcnVuIGF0ICg1NywwKSB3aWR0aCAzMzc6ICJodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQ5NzEiCi0gICAgICAgICAgUmVu ZGVyVGV4dCB7I3RleHR9IGF0ICgzOTQsMCkgc2l6ZSA3NzF4NDIKKyAgICAgICAgICBSZW5kZXJU ZXh0IHsjdGV4dH0gYXQgKDM5NCwwKSBzaXplIDc3M3g0MAogICAgICAgICAgICAgdGV4dCBydW4g YXQgKDM5NCwwKSB3aWR0aCA0OiAiICIKLSAgICAgICAgICAgIHRleHQgcnVuIGF0ICgzOTgsMCkg d2lkdGggMzczOiAiU2V0dGluZyBzdHlsZS5oZWlnaHQgPSB2YWx1ZSBpbiBqYXZhc2NyaXB0IGRv ZXNuJ3Qgd29yayIKLSAgICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDIxKSB3aWR0aCAxMjM6ICJp biB0YWJsZXJvd3MoPHRyPikiCi0gICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMTIzLDIx KSBzaXplIDUwNXgyMQotICAgICAgICAgIHRleHQgcnVuIGF0ICgxMjMsMjEpIHdpZHRoIDI2Mjog Ii4gVGhpcyB0ZXN0IFBBU1NFRCBpZiBhbmQgb25seSBpZiB5b3UgIgotICAgICAgICAgIHRleHQg cnVuIGF0ICgzODUsMjEpIHdpZHRoIDI0MzogInNlZSBhIHNvbGlkIGdyZWVuIHJlY3RhbmdsZSBi ZWxvdy4iCi0gICAgICBSZW5kZXJCbG9jayB7SFJ9IGF0ICgwLDU4KSBzaXplIDc4NHgyIFtib3Jk ZXI6ICgxcHggaW5zZXQgIzAwMDAwMCldCi0gICAgICBSZW5kZXJUYWJsZSB7VEFCTEV9IGF0ICgw LDY4KSBzaXplIDUweDEwMAorICAgICAgICAgICAgdGV4dCBydW4gYXQgKDM5OCwwKSB3aWR0aCAz NzU6ICJTZXR0aW5nIHN0eWxlLmhlaWdodCA9IHZhbHVlIGluIGphdmFzY3JpcHQgZG9lc24ndCB3 b3JrIgorICAgICAgICAgICAgdGV4dCBydW4gYXQgKDAsMjApIHdpZHRoIDEyMzogImluIHRhYmxl cm93cyg8dHI+KSIKKyAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgxMjMsMjApIHNpemUg NTA1eDIwCisgICAgICAgICAgdGV4dCBydW4gYXQgKDEyMywyMCkgd2lkdGggMjYyOiAiLiBUaGlz IHRlc3QgUEFTU0VEIGlmIGFuZCBvbmx5IGlmIHlvdSAiCisgICAgICAgICAgdGV4dCBydW4gYXQg KDM4NSwyMCkgd2lkdGggMjQzOiAic2VlIGEgc29saWQgZ3JlZW4gcmVjdGFuZ2xlIGJlbG93LiIK KyAgICAgIFJlbmRlckJsb2NrIHtIUn0gYXQgKDAsNTYpIHNpemUgNzg0eDIgW2JvcmRlcjogKDFw eCBpbnNldCAjMDAwMDAwKV0KKyAgICAgIFJlbmRlclRhYmxlIHtUQUJMRX0gYXQgKDAsNjYpIHNp emUgNTB4MTAwCiAgICAgICAgIFJlbmRlclRhYmxlU2VjdGlvbiB7VEJPRFl9IGF0ICgwLDApIHNp emUgNTB4MTAwCiAgICAgICAgICAgUmVuZGVyVGFibGVSb3cge1RSfSBhdCAoMCwwKSBzaXplIDUw eDEwMCBbYmdjb2xvcj0jMDA4MDAwXQogICAgICAgICAgICAgUmVuZGVyVGFibGVDZWxsIHtURH0g YXQgKDAsNTApIHNpemUgNTB4MCBbcj0wIGM9MCBycz0xIGNzPTFdCkluZGV4OiBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lv biA1MTE1NykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDA5LTExLTE4ICBab2x0YW4gSG9ydmF0aCAgPHpvbHRhbkB3ZWJraXQub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vZGlm eSBleHBlY3RlZCBmaWxlIGZvciBmYXN0L3RhYmxlL3Jvdy1oZWlnaHQtcmVjYWxjMi5odG1sCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTY1NAorCisg ICAgICAgIFRoZSB0ZXN0IHBhc3Nlcywgc28gdGhlIGV4cGVjdGVkIGZpbGUgaGFzIGJlZW4gbW9k aWZpZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9mYXN0L3RhYmxlL3Jvdy1oZWlnaHQtcmVj YWxjMi1leHBlY3RlZC50eHQ6CisKIDIwMDktMTEtMTggIFNodSBDaGFuZyAgPENoYW5nLlNodUBu b2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCg==