31652 2009-11-18 16:17:25 -0800 ASSERT thrown when a high value is used for roman numerals in lists 2009-11-19 12:25:33 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 kuchhal webkit-unassigned commit-queue darin oldest_to_newest 164804 0 kuchhal 2009-11-18 16:17:25 -0800 WebKit throws ASSERT for this html: <html> <body> <ol start="3888" type="i"> <li>Foo </li> </ol> </body> </html> Posting one potential fix and a layout test soon. 164807 1 43470 kuchhal 2009-11-18 16:21:57 -0800 Created attachment 43470 potential fix for assert 164936 2 43470 eric 2009-11-19 01:08:02 -0800 Comment on attachment 43470 potential fix for assert This should be a dumpAsText() test since it is just testing for a crash. The test should say something like: PASS: this test did not crash, bug 31652 for the output. 164987 3 43507 kuchhal 2009-11-19 08:52:13 -0800 Created attachment 43507 patch with updated layout test 165053 4 43507 commit-queue 2009-11-19 12:25:28 -0800 Comment on attachment 43507 patch with updated layout test Clearing flags on attachment: 43507 Committed r51201: <http://trac.webkit.org/changeset/51201> 165054 5 commit-queue 2009-11-19 12:25:33 -0800 All reviewed patches have been landed. Closing bug. 43470 2009-11-18 16:21:57 -0800 2009-11-19 01:08:01 -0800 potential fix for assert patch.diff text/plain 3213 kuchhal ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzZDA2ZjcxLi5mYTBlMDAxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTEt MTggIFJhaHVsIEt1Y2hoYWwgIDxrdWNoaGFsQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEbyBub3QgYXNzZXJ0IHdoZW4gYSBo aWdoIG51bWJlciBpcyB1c2VkIGZvciByb21hbiBudW1lcmFscyBpbiBsaXN0cy4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNjUyCisKKyAgICAgICAg KiBmYXN0L2xpc3RzL29sLXN0YXJ0LXJvbWFuLmh0bWw6IEFkZGVkLgorICAgICAgICAqIHBsYXRm b3JtL21hYy9mYXN0L2xpc3RzL29sLXN0YXJ0LXJvbWFuLWV4cGVjdGVkLnR4dDogQWRkZWQuCisK IDIwMDktMTEtMTggIEp1bGllIFBhcmVudCAgPGpwYXJlbnRAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9saXN0cy9vbC1zdGFydC1yb21hbi5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9saXN0cy9vbC1z dGFydC1yb21hbi5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjVlOGI1 YWYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2xpc3RzL29sLXN0YXJ0LXJv bWFuLmh0bWwKQEAgLTAsMCArMSw2IEBACis8b2wgc3RhcnQ9IjM4ODgiIHR5cGU9ImkiPgorPGxp Pk1ha2Ugc3VyZSBubyBjcmFzaDwvbGk+Cis8L29sPgorPG9sIHN0YXJ0PSI0ODg4IiB0eXBlPSJp Ij4KKzxsaT5NYWtlIHN1cmUgbm8gY3Jhc2g8L2xpPgorPC9vbD4KZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L2xpc3RzL29sLXN0YXJ0LXJvbWFuLWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L2xpc3RzL29sLXN0YXJ0LXJvbWFuLWV4 cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5jZTMzZTNlCi0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvbGlzdHMvb2wt c3RhcnQtcm9tYW4tZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTUgQEAKK2xheWVyIGF0ICgwLDAp IHNpemUgODAweDYwMAorICBSZW5kZXJWaWV3IGF0ICgwLDApIHNpemUgODAweDYwMAorbGF5ZXIg YXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgIFJlbmRlckJsb2NrIHtIVE1MfSBhdCAoMCwwKSBzaXpl IDgwMHg2MDAKKyAgICBSZW5kZXJCb2R5IHtCT0RZfSBhdCAoOCw4KSBzaXplIDc4NHg1NzYKKyAg ICAgIFJlbmRlckJsb2NrIHtPTH0gYXQgKDAsMCkgc2l6ZSA3ODR4MTgKKyAgICAgICAgUmVuZGVy TGlzdEl0ZW0ge0xJfSBhdCAoNDAsMCkgc2l6ZSA3NDR4MTgKKyAgICAgICAgICBSZW5kZXJMaXN0 TWFya2VyIGF0ICgtMTI1LDApIHNpemUgMTIxeDE4OiAibW1tZGNjY2x4eHh2aWlpIgorICAgICAg ICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDEyM3gxOAorICAgICAgICAgICAg dGV4dCBydW4gYXQgKDAsMCkgd2lkdGggMTIzOiAiTWFrZSBzdXJlIG5vIGNyYXNoIgorICAgICAg UmVuZGVyQmxvY2sge09MfSBhdCAoMCwzNCkgc2l6ZSA3ODR4MTgKKyAgICAgICAgUmVuZGVyTGlz dEl0ZW0ge0xJfSBhdCAoNDAsMCkgc2l6ZSA3NDR4MTgKKyAgICAgICAgICBSZW5kZXJMaXN0TWFy a2VyIGF0ICgtNDQsMCkgc2l6ZSA0MHgxODogIjQ4ODgiCisgICAgICAgICAgUmVuZGVyVGV4dCB7 I3RleHR9IGF0ICgwLDApIHNpemUgMTIzeDE4CisgICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCww KSB3aWR0aCAxMjM6ICJNYWtlIHN1cmUgbm8gY3Jhc2giCmRpZmYgLS1naXQgYS9XZWJDb3JlL0No YW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDZlMDdlYzQuLjQ0NmNlN2MgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMDktMTEtMTggIFJhaHVsIEt1Y2hoYWwgIDxrdWNoaGFsQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEbyBu b3QgYXNzZXJ0IHdoZW4gYSBoaWdoIG51bWJlciBpcyB1c2VkIGZvciByb21hbiBudW1lcmFscyBp biBsaXN0cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTMxNjUyCisKKyAgICAgICAgVGVzdDogZmFzdC9saXN0cy9vbC1zdGFydC1yb21hbi5odG1sCisK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGlzdE1hcmtlci5jcHA6CisgICAgICAgIChXZWJD b3JlOjp0b1JvbWFuKTogSW5jcmVhc2UgdGhlIGNoYXIgYXJyYXkgc2l6ZS4KKwogMjAwOS0xMS0x OCAgWm9sdGFuIEhvcnZhdGggIDx6b2x0YW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxp c3RNYXJrZXIuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGlzdE1hcmtlci5jcHAKaW5k ZXggNjkyNjY2YS4uMjhhZjQyNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGlzdE1hcmtlci5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGlzdE1hcmtlci5j cHAKQEAgLTQ4LDcgKzQ4LDkgQEAgc3RhdGljIFN0cmluZyB0b1JvbWFuKGludCBudW1iZXIsIGJv b2wgdXBwZXIpCiAgICAgaWYgKG51bWJlciA8IDEgfHwgbnVtYmVyID4gMzk5OSkKICAgICAgICAg cmV0dXJuIFN0cmluZzo6bnVtYmVyKG51bWJlcik7CiAKLSAgICBjb25zdCBpbnQgbGV0dGVyc1Np emUgPSAxMjsgLy8gYmlnIGVub3VnaCBmb3IgdGhyZWUgZWFjaCBvZiBJLCBYLCBDLCBhbmQgTQor ICAgIC8vIEJpZyBlbm91Z2ggdG8gc3RvcmUgbGFyZ2VzdCByb21hbiBudW1iZXIgbGVzcyB0aGFu IDM5OTkgd2hpY2gKKyAgICAvLyBpcyAzODg4IChNTU1EQ0NDTFhYWFZJSUkpCisgICAgY29uc3Qg aW50IGxldHRlcnNTaXplID0gMTU7CiAgICAgVUNoYXIgbGV0dGVyc1tsZXR0ZXJzU2l6ZV07CiAK ICAgICBpbnQgbGVuZ3RoID0gMDsK 43507 2009-11-19 08:52:13 -0800 2009-11-19 12:25:27 -0800 patch with updated layout test patch.diff text/plain 2656 kuchhal ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzZDA2ZjcxLi5mYTBlMDAxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTEt MTggIFJhaHVsIEt1Y2hoYWwgIDxrdWNoaGFsQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEbyBub3QgYXNzZXJ0IHdoZW4gYSBo aWdoIG51bWJlciBpcyB1c2VkIGZvciByb21hbiBudW1lcmFscyBpbiBsaXN0cy4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNjUyCisKKyAgICAgICAg KiBmYXN0L2xpc3RzL29sLXN0YXJ0LXJvbWFuLmh0bWw6IEFkZGVkLgorICAgICAgICAqIHBsYXRm b3JtL21hYy9mYXN0L2xpc3RzL29sLXN0YXJ0LXJvbWFuLWV4cGVjdGVkLnR4dDogQWRkZWQuCisK IDIwMDktMTEtMTggIEp1bGllIFBhcmVudCAgPGpwYXJlbnRAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9saXN0cy9vbC1zdGFydC1yb21hbi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2xp c3RzL29sLXN0YXJ0LXJvbWFuLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwLi44NGJiN2U2Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9s aXN0cy9vbC1zdGFydC1yb21hbi1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwyIEBACitQQVNTOiB0 ZXN0IGRpZCBub3QgY3Jhc2gsIGJ1ZyAzMTY1Mi4KK1BBU1M6IHRlc3QgZGlkIG5vdCBjcmFzaCwg YnVnIDMxNjUyLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9saXN0cy9vbC1zdGFydC1y b21hbi5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9saXN0cy9vbC1zdGFydC1yb21hbi5odG1sCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjZhOTcxNzQKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L2xpc3RzL29sLXN0YXJ0LXJvbWFuLmh0bWwKQEAgLTAsMCAr MSwxMCBAQAorPHNjcmlwdD4KKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQor ICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Cis8L3NjcmlwdD4KKzxv bCBzdGFydD0iMzg4OCIgdHlwZT0iaSI+Cis8bGk+UEFTUzogdGVzdCBkaWQgbm90IGNyYXNoLCBi dWcgMzE2NTIuPC9saT4KKzwvb2w+Cis8b2wgc3RhcnQ9IjQ4ODgiIHR5cGU9ImkiPgorPGxpPlBB U1M6IHRlc3QgZGlkIG5vdCBjcmFzaCwgYnVnIDMxNjUyLjwvbGk+Cis8L29sPgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2ZTA3ZWM0Li40 NDZjZTdjIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDA5LTExLTE4ICBSYWh1bCBLdWNoaGFsICA8a3VjaGhh bEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRG8gbm90IGFzc2VydCB3aGVuIGEgaGlnaCBudW1iZXIgaXMgdXNlZCBmb3Igcm9t YW4gbnVtZXJhbHMgaW4gbGlzdHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zMTY1MgorCisgICAgICAgIFRlc3Q6IGZhc3QvbGlzdHMvb2wtc3RhcnQt cm9tYW4uaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxpc3RNYXJrZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6dG9Sb21hbik6IEluY3JlYXNlIHRoZSBjaGFyIGFycmF5IHNpemUu CisKIDIwMDktMTEtMTggIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJMaXN0TWFya2VyLmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxpc3RN YXJrZXIuY3BwCmluZGV4IDY5MjY2NmEuLjI4YWY0MjUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckxpc3RNYXJrZXIuY3BwCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckxpc3RNYXJrZXIuY3BwCkBAIC00OCw3ICs0OCw5IEBAIHN0YXRpYyBTdHJpbmcgdG9Sb21hbihp bnQgbnVtYmVyLCBib29sIHVwcGVyKQogICAgIGlmIChudW1iZXIgPCAxIHx8IG51bWJlciA+IDM5 OTkpCiAgICAgICAgIHJldHVybiBTdHJpbmc6Om51bWJlcihudW1iZXIpOwogCi0gICAgY29uc3Qg aW50IGxldHRlcnNTaXplID0gMTI7IC8vIGJpZyBlbm91Z2ggZm9yIHRocmVlIGVhY2ggb2YgSSwg WCwgQywgYW5kIE0KKyAgICAvLyBCaWcgZW5vdWdoIHRvIHN0b3JlIGxhcmdlc3Qgcm9tYW4gbnVt YmVyIGxlc3MgdGhhbiAzOTk5IHdoaWNoCisgICAgLy8gaXMgMzg4OCAoTU1NRENDQ0xYWFhWSUlJ KQorICAgIGNvbnN0IGludCBsZXR0ZXJzU2l6ZSA9IDE1OwogICAgIFVDaGFyIGxldHRlcnNbbGV0 dGVyc1NpemVdOwogCiAgICAgaW50IGxlbmd0aCA9IDA7Cg==