31648 2009-11-18 14:52:28 -0800 [Chromium] Remove dependencies to dummy pthreads headers 2009-11-18 16:00:12 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 japhet japhet oldest_to_newest 164735 0 japhet 2009-11-18 14:52:28 -0800 Currently, in order to build JavaScriptCore/wtf/, the Chromium port depends on a couple of dummy headers (pthread.h and sched.h) that live in http://src.chromium.org/viewvc/chrome/trunk/src/webkit/build/ . These dependencies are in fact not necessary, as they are located in wtf's tcmalloc files (which Chromium doesn't use). Ergo, update JavaScriptCore.gyp to exclude wtf/TC*, and update WebKit/chromium/DEPS to not include webkit/build/ from chromium's svn repo. 164738 1 43465 japhet 2009-11-18 14:57:52 -0800 Created attachment 43465 patch 164744 2 43465 fishd 2009-11-18 15:08:34 -0800 Comment on attachment 43465 patch > Index: WebKit/chromium/ChangeLog ... > + Remove Chromium port's dependency on some dummy pthreads header > + files that live in the Chromium repository. nit: please add a bug link here 164792 3 japhet 2009-11-18 16:00:12 -0800 http://trac.webkit.org/changeset/51144 43465 2009-11-18 14:57:52 -0800 2009-11-18 15:08:33 -0800 patch patch.txt text/plain 3036 japhet SW5kZXg6IEphdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmd5cC9KYXZhU2NyaXB0Q29yZS5n eXAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZ3lwL0phdmFT Y3JpcHRDb3JlLmd5cAkocmV2aXNpb24gNTExMzgpCisrKyBKYXZhU2NyaXB0Q29yZS9KYXZhU2Ny aXB0Q29yZS5neXAvSmF2YVNjcmlwdENvcmUuZ3lwCSh3b3JraW5nIGNvcHkpCkBAIC03NSw3ICs3 NSw2IEBACiAgICAgICAgICAgICBdLAogICAgICAgICAgICAgJ2luY2x1ZGVfZGlycyc6IFsKICAg ICAgICAgICAgICAgJy4uL29zLXdpbjMyJywKLSAgICAgICAgICAgICAgJzwoY2hyb21pdW1fc3Jj X2Rpcikvd2Via2l0L2J1aWxkL0phdmFTY3JpcHRDb3JlJywKICAgICAgICAgICAgIF0sCiAgICAg ICAgICAgfV0sCiAgICAgICAgICAgWydPUz09Im1hYyInLCB7CkBAIC0xMTgsNiArMTE3LDcgQEAK ICAgICAgICAgWydleGNsdWRlJywgJy8oR093blB0cnxnbGliLy4qKVxcLihjcHB8aCkkJ10sCiAg ICAgICAgIFsnZXhjbHVkZScsICcoRGVmYXVsdHxHdGt8TWFjfE5vbmV8UXR8V2lufFd4KVxcLihj cHB8bW0pJCddLAogICAgICAgICBbJ2V4Y2x1ZGUnLCAnd3RmL0N1cnJlbnRUaW1lXFwuY3BwJCdd LAorICAgICAgICBbJ2V4Y2x1ZGUnLCAnd3RmL1RDLipcXC4oY3BwfGgpJCddLAogICAgICAgXSwK ICAgICAgICdkaXJlY3RfZGVwZW5kZW50X3NldHRpbmdzJzogewogICAgICAgICAnaW5jbHVkZV9k aXJzJzogWwpAQCAtMTM3LDE4ICsxMzcsNiBAQAogICAgICAgICAgICAgWydleGNsdWRlJywgJ1Ro cmVhZGluZ1B0aHJlYWRzXFwuY3BwJCddLAogICAgICAgICAgICAgWydpbmNsdWRlJywgJ1RocmVh ZChpbmd8U3BlY2lmaWMpV2luXFwuY3BwJCddCiAgICAgICAgICAgXSwKLSAgICAgICAgICAnaW5j bHVkZV9kaXJzJzogWwotICAgICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2Rpcikvd2Via2l0L2J1 aWxkJywKLSAgICAgICAgICAgICcuLi9ranMnLAotICAgICAgICAgICAgJy4uL0FQSScsCi0gICAg ICAgICAgICAjIFRoZXNlIDMgZG8gbm90IHNlZW0gdG8gZXhpc3QuCi0gICAgICAgICAgICAnLi4v YmluZGluZ3MnLAotICAgICAgICAgICAgJy4uL2JpbmRpbmdzL2MnLAotICAgICAgICAgICAgJy4u L2JpbmRpbmdzL2puaScsCi0gICAgICAgICAgICAjIEZJWE1FOiByZW1vdmVkIHRoZXNlIC0gZG9u J3Qgc2VlbSB0byBleGlzdAotICAgICAgICAgICAgJ3BlbmRpbmcnLAotICAgICAgICAgICAgJ3Bl bmRpbmcvd3RmJywKLSAgICAgICAgICBdLAogICAgICAgICAgICdpbmNsdWRlX2RpcnMhJzogWwog ICAgICAgICAgICAgJzwoU0hBUkVEX0lOVEVSTUVESUFURV9ESVIpL3dlYmtpdCcsCiAgICAgICAg ICAgXSwKSW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUxMTM5KQorKysgSmF2YVNjcmlwdENvcmUv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTEtMTggIE5h dGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgQ2hyb21pdW0ncyB1bm5lY2Vzc2FyeSBk ZXBlbmRlbmN5IG9uIHd0ZidzIHRjbWFsbG9jIGZpbGVzLgorCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTY0OAorCisgICAgICAgICogSmF2YVNjcmlw dENvcmUuZ3lwL0phdmFTY3JpcHRDb3JlLmd5cDoKKwogMjAwOS0xMS0xOCAgT2xpdmVyIEh1bnQg IDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3Vy eWFrb3YuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUxMTM5KQorKysgV2ViS2l0L2Nocm9t aXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDA5LTExLTE4 ICBOYXRlIENoYXBpbiAgPGphcGhldEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIENocm9taXVtIHBvcnQncyBkZXBl bmRlbmN5IG9uIHNvbWUgZHVtbXkgcHRocmVhZHMgaGVhZGVyCisgICAgICAgIGZpbGVzIHRoYXQg bGl2ZSBpbiB0aGUgQ2hyb21pdW0gcmVwb3NpdG9yeS4KKworICAgICAgICAqIERFUFM6IFJlbW92 ZSByZWZlcmVuY2UgdG8gY2hyb21pdW0gc3ZuJ3Mgd2Via2l0L2J1aWxkLyBkaXJlY3RvcnkuCisK IDIwMDktMTEtMTcgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEbWl0cnkgVGl0b3YuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vREVQUwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vREVQUwkocmV2aXNpb24gNTExMzgpCisrKyBX ZWJLaXQvY2hyb21pdW0vREVQUwkod29ya2luZyBjb3B5KQpAQCAtNTUsOCArNTUsNiBAQAogICAj IGJ1aWxkIHRvb2xzCiAgICdidWlsZCc6CiAgICAgVmFyKCdjaHJvbWl1bV9zdm4nKSsnL2J1aWxk QCcrVmFyKCdjaHJvbWl1bV9yZXYnKSwKLSAgJ3dlYmtpdC9idWlsZCc6Ci0gICAgICBWYXIoJ2No cm9taXVtX3N2bicpKycvd2Via2l0L2J1aWxkQCcrVmFyKCdjaHJvbWl1bV9yZXYnKSwKICAgJ3Rv b2xzL2d5cCc6CiAgICAgJ2h0dHA6Ly9neXAuZ29vZ2xlY29kZS5jb20vc3ZuL3RydW5rQCcrVmFy KCdneXBfcmV2JyksCiAK