31645 2009-11-18 14:00:38 -0800 CommitQueue should fetch list of patches on every cycle (and not use PatchCollection) 2009-11-18 18:02:13 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth commit-queue oldest_to_newest 164703 0 43457 eric 2009-11-18 14:00:38 -0800 Created attachment 43457 example of broken logging ui workqueue.py results in totally broken commit-queue UI Adam warned me about some functional changes as a result of the new workqueue.py. But it looks like one of them needs to be immediately fixed. commit-queue needs to reload the list of bugs after every failure. I'll attach an example of hte broken UI. 164712 1 43460 eric 2009-11-18 14:17:35 -0800 Created attachment 43460 example of commit re-tries not working Sad! Looks like commit re-tries are broken as a result of this too. :( 164714 2 eric 2009-11-18 14:21:29 -0800 I think the problem is more PatchCollection than the WorkQueue itself. Well, maybe both are at fault. We should be refreshing the patch collection after every iteration (at least for the commit-queue). I'm actually not sure commit-queue really wants to use a PatchCollection at all. 164728 3 43463 eric 2009-11-18 14:46:15 -0800 Created attachment 43463 Patch 164729 4 eric 2009-11-18 14:49:23 -0800 This bug was a bit overly dramatic when I opened it. :) The sky is not falling. But things are definitely better after restoring the old behavior. 164817 5 43463 darin 2009-11-18 16:45:51 -0800 Comment on attachment 43463 Patch rs=me 164858 6 43463 commit-queue 2009-11-18 18:02:07 -0800 Comment on attachment 43463 Patch Clearing flags on attachment: 43463 Committed r51160: <http://trac.webkit.org/changeset/51160> 164859 7 commit-queue 2009-11-18 18:02:13 -0800 All reviewed patches have been landed. Closing bug. 43457 2009-11-18 14:00:38 -0800 2009-11-18 14:00:38 -0800 example of broken logging ui cq_ui.txt text/plain 5371 eric ZXNlaWRlbC1tYWMgWzE4MjA4OkNvbW1pdFF1ZXVlXSUgV2ViS2l0VG9vbHMvU2NyaXB0cy9idWd6 aWxsYS10b29sIGNvbW1pdC1xdWV1ZSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFt+L1Byb2plY3RzL0NvbW1pdFF1 ZXVlXQpDQVVUSU9OOiBjb21taXQtcXVldWUgd2lsbCBkaXNjYXJkIGFsbCBsb2NhbCBjaGFuZ2Vz IGluIC9Vc2Vycy9lc2VpZGVsL1Byb2plY3RzL0NvbW1pdFF1ZXVlLwpBcmUgeW91IHN1cmU/ICBU eXBlICd5ZXMnIHRvIGNvbnRpbnVlOiB5ZXMKUnVubmluZyBXZWJLaXQgY29tbWl0LXF1ZXVlLiAy MDA5LTExLTE4IDEyOjUzOjI0CkZldGNoaW5nOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Mjc1NTImY3R5cGU9eG1sCkZldGNoaW5nOiBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE1MDQmY3R5cGU9eG1sCkZldGNoaW5nOiBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE1MjcmY3R5cGU9eG1sCkZldGNoaW5nOiBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE1NTMmY3R5cGU9eG1sCkZl dGNoaW5nOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE1ODQmY3R5 cGU9eG1sCkZldGNoaW5nOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzE2MjcmY3R5cGU9eG1sCkZldGNoaW5nOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9Mjk0NjkmY3R5cGU9eG1sCkZldGNoaW5nOiBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzA4NjQmY3R5cGU9eG1sCkZldGNoaW5nOiBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE0NDgmY3R5cGU9eG1sCkZldGNoaW5nOiBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE0NjUmY3R5cGU9eG1sCkZldGNo aW5nOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE0OTkmY3R5cGU9 eG1sCkZldGNoaW5nOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE0 MDImY3R5cGU9eG1sCkZldGNoaW5nOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzExODYmY3R5cGU9eG1sCkZldGNoaW5nOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzEyNTgmY3R5cGU9eG1sCjE0IHBhdGNoZXMgaW4gY29tbWl0LXF1ZXVl IFs0MzQzMywgNDMyMjEsIDQzMjYxLCA0MzQxMSwgNDMzNjUsIDQzNDM4LCA0MzM0MiwgNDIwMzMs IDQzMzIwLCA0MzE0OSwgNDMyMTUsIDQzMTUzLCA0MzI1OSwgNDM0MDddCkJ1aWxkZXJzIFsiV2lu ZG93cyBSZWxlYXNlIChCdWlsZCkiXSBhcmUgcmVkLiBTZWUgaHR0cDovL2J1aWxkLndlYmtpdC5v cmcuIFNsZWVwaW5nIHVudGlsIDIwMDktMTEtMTggMTI6NTg6NDYgKDUgbWlucykuCjEzIHBhdGNo ZXMgaW4gY29tbWl0LXF1ZXVlIFs0MzIyMSwgNDMyNjEsIDQzNDExLCA0MzM2NSwgNDM0MzgsIDQz MzQyLCA0MjAzMywgNDMzMjAsIDQzMTQ5LCA0MzIxNSwgNDMxNTMsIDQzMjU5LCA0MzQwN10KQnVp bGRlcnMgWyJXaW5kb3dzIFJlbGVhc2UgKEJ1aWxkKSJdIGFyZSByZWQuIFNlZSBodHRwOi8vYnVp bGQud2Via2l0Lm9yZy4gU2xlZXBpbmcgdW50aWwgMjAwOS0xMS0xOCAxMzowMzo1MiAoNSBtaW5z KS4KMTIgcGF0Y2hlcyBpbiBjb21taXQtcXVldWUgWzQzMjYxLCA0MzQxMSwgNDMzNjUsIDQzNDM4 LCA0MzM0MiwgNDIwMzMsIDQzMzIwLCA0MzE0OSwgNDMyMTUsIDQzMTUzLCA0MzI1OSwgNDM0MDdd CkJ1aWxkZXJzIFsiV2luZG93cyBSZWxlYXNlIChCdWlsZCkiXSBhcmUgcmVkLiBTZWUgaHR0cDov L2J1aWxkLndlYmtpdC5vcmcuIFNsZWVwaW5nIHVudGlsIDIwMDktMTEtMTggMTM6MDg6NTQgKDUg bWlucykuCjExIHBhdGNoZXMgaW4gY29tbWl0LXF1ZXVlIFs0MzQxMSwgNDMzNjUsIDQzNDM4LCA0 MzM0MiwgNDIwMzMsIDQzMzIwLCA0MzE0OSwgNDMyMTUsIDQzMTUzLCA0MzI1OSwgNDM0MDddCkJ1 aWxkZXJzIFsiTGVvcGFyZCBJbnRlbCBSZWxlYXNlIChUZXN0cykiLCAiTGVvcGFyZCBJbnRlbCBE ZWJ1ZyAoVGVzdHMpIiwgIldpbmRvd3MgUmVsZWFzZSAoQnVpbGQpIl0gYXJlIHJlZC4gU2VlIGh0 dHA6Ly9idWlsZC53ZWJraXQub3JnLiBTbGVlcGluZyB1bnRpbCAyMDA5LTExLTE4IDEzOjEzOjU2 ICg1IG1pbnMpLgoxMCBwYXRjaGVzIGluIGNvbW1pdC1xdWV1ZSBbNDMzNjUsIDQzNDM4LCA0MzM0 MiwgNDIwMzMsIDQzMzIwLCA0MzE0OSwgNDMyMTUsIDQzMTUzLCA0MzI1OSwgNDM0MDddCkJ1aWxk ZXJzIFsiTGVvcGFyZCBJbnRlbCBSZWxlYXNlIChUZXN0cykiLCAiTGVvcGFyZCBJbnRlbCBEZWJ1 ZyAoVGVzdHMpIiwgIldpbmRvd3MgUmVsZWFzZSAoQnVpbGQpIl0gYXJlIHJlZC4gU2VlIGh0dHA6 Ly9idWlsZC53ZWJraXQub3JnLiBTbGVlcGluZyB1bnRpbCAyMDA5LTExLTE4IDEzOjE4OjU4ICg1 IG1pbnMpLgo5IHBhdGNoZXMgaW4gY29tbWl0LXF1ZXVlIFs0MzQzOCwgNDMzNDIsIDQyMDMzLCA0 MzMyMCwgNDMxNDksIDQzMjE1LCA0MzE1MywgNDMyNTksIDQzNDA3XQpCdWlsZGVycyBbIkxlb3Bh cmQgSW50ZWwgUmVsZWFzZSAoVGVzdHMpIiwgIkxlb3BhcmQgSW50ZWwgRGVidWcgKFRlc3RzKSIs ICJXaW5kb3dzIFJlbGVhc2UgKEJ1aWxkKSJdIGFyZSByZWQuIFNlZSBodHRwOi8vYnVpbGQud2Vi a2l0Lm9yZy4gU2xlZXBpbmcgdW50aWwgMjAwOS0xMS0xOCAxMzoyMzo1OSAoNSBtaW5zKS4KOCBw YXRjaGVzIGluIGNvbW1pdC1xdWV1ZSBbNDMzNDIsIDQyMDMzLCA0MzMyMCwgNDMxNDksIDQzMjE1 LCA0MzE1MywgNDMyNTksIDQzNDA3XQpCdWlsZGVycyBbIkxlb3BhcmQgSW50ZWwgUmVsZWFzZSAo VGVzdHMpIiwgIkxlb3BhcmQgSW50ZWwgRGVidWcgKFRlc3RzKSIsICJXaW5kb3dzIFJlbGVhc2Ug KEJ1aWxkKSJdIGFyZSByZWQuIFNlZSBodHRwOi8vYnVpbGQud2Via2l0Lm9yZy4gU2xlZXBpbmcg dW50aWwgMjAwOS0xMS0xOCAxMzoyOTowMSAoNSBtaW5zKS4KNyBwYXRjaGVzIGluIGNvbW1pdC1x dWV1ZSBbNDIwMzMsIDQzMzIwLCA0MzE0OSwgNDMyMTUsIDQzMTUzLCA0MzI1OSwgNDM0MDddCkJ1 aWxkZXJzIFsiTGVvcGFyZCBJbnRlbCBSZWxlYXNlIChUZXN0cykiLCAiTGVvcGFyZCBJbnRlbCBE ZWJ1ZyAoVGVzdHMpIiwgIldpbmRvd3MgUmVsZWFzZSAoQnVpbGQpIl0gYXJlIHJlZC4gU2VlIGh0 dHA6Ly9idWlsZC53ZWJraXQub3JnLiBTbGVlcGluZyB1bnRpbCAyMDA5LTExLTE4IDEzOjM0OjAz ICg1IG1pbnMpLgo2IHBhdGNoZXMgaW4gY29tbWl0LXF1ZXVlIFs0MzMyMCwgNDMxNDksIDQzMjE1 LCA0MzE1MywgNDMyNTksIDQzNDA3XQpCdWlsZGVycyBbIkxlb3BhcmQgSW50ZWwgUmVsZWFzZSAo VGVzdHMpIiwgIkxlb3BhcmQgSW50ZWwgRGVidWcgKFRlc3RzKSIsICJXaW5kb3dzIFJlbGVhc2Ug KEJ1aWxkKSJdIGFyZSByZWQuIFNlZSBodHRwOi8vYnVpbGQud2Via2l0Lm9yZy4gU2xlZXBpbmcg dW50aWwgMjAwOS0xMS0xOCAxMzozOTowNiAoNSBtaW5zKS4KNSBwYXRjaGVzIGluIGNvbW1pdC1x dWV1ZSBbNDMxNDksIDQzMjE1LCA0MzE1MywgNDMyNTksIDQzNDA3XQpCdWlsZGVycyBbIkxlb3Bh cmQgSW50ZWwgUmVsZWFzZSAoVGVzdHMpIiwgIkxlb3BhcmQgSW50ZWwgRGVidWcgKFRlc3RzKSIs ICJXaW5kb3dzIFJlbGVhc2UgKEJ1aWxkKSJdIGFyZSByZWQuIFNlZSBodHRwOi8vYnVpbGQud2Vi a2l0Lm9yZy4gU2xlZXBpbmcgdW50aWwgMjAwOS0xMS0xOCAxMzo0NDowNyAoNSBtaW5zKS4KNCBw YXRjaGVzIGluIGNvbW1pdC1xdWV1ZSBbNDMyMTUsIDQzMTUzLCA0MzI1OSwgNDM0MDddCkJ1aWxk ZXJzIFsiTGVvcGFyZCBJbnRlbCBSZWxlYXNlIChUZXN0cykiLCAiTGVvcGFyZCBJbnRlbCBEZWJ1 ZyAoVGVzdHMpIiwgIldpbmRvd3MgUmVsZWFzZSAoQnVpbGQpIl0gYXJlIHJlZC4gU2VlIGh0dHA6 Ly9idWlsZC53ZWJraXQub3JnLiBTbGVlcGluZyB1bnRpbCAyMDA5LTExLTE4IDEzOjQ5OjA4ICg1 IG1pbnMpLgozIHBhdGNoZXMgaW4gY29tbWl0LXF1ZXVlIFs0MzE1MywgNDMyNTksIDQzNDA3XQpC dWlsZGVycyBbIldpbmRvd3MgUmVsZWFzZSAoQnVpbGQpIl0gYXJlIHJlZC4gU2VlIGh0dHA6Ly9i dWlsZC53ZWJraXQub3JnLiBTbGVlcGluZyB1bnRpbCAyMDA5LTExLTE4IDEzOjU0OjEwICg1IG1p bnMpLgoyIHBhdGNoZXMgaW4gY29tbWl0LXF1ZXVlIFs0MzI1OSwgNDM0MDddCkJ1aWxkZXJzIFsi V2luZG93cyBSZWxlYXNlIChCdWlsZCkiXSBhcmUgcmVkLiBTZWUgaHR0cDovL2J1aWxkLndlYmtp dC5vcmcuIFNsZWVwaW5nIHVudGlsIDIwMDktMTEtMTggMTM6NTk6MTIgKDUgbWlucykuCl5DVHJh Y2ViYWNrIChtb3N0IHJlY2VudCBjYWxsIGxhc3QpOgogIEZpbGUgIldlYktpdFRvb2xzL1Njcmlw dHMvYnVnemlsbGEtdG9vbCIsIGxpbmUgOTg5LCBpbiA8bW9kdWxlPgogICAgbWFpbigpCiAgRmls ZSAiV2ViS2l0VG9vbHMvU2NyaXB0cy9idWd6aWxsYS10b29sIiwgbGluZSA5ODYsIGluIG1haW4K ICAgIHJldHVybiB0b29sLm1haW4oKQogIEZpbGUgIldlYktpdFRvb2xzL1NjcmlwdHMvYnVnemls bGEtdG9vbCIsIGxpbmUgOTgxLCBpbiBtYWluCiAgICByZXR1cm4gY29tbWFuZF9vYmplY3QuZXhl Y3V0ZShjb21tYW5kX29wdGlvbnMsIGNvbW1hbmRfYXJncywgc2VsZikKICBGaWxlICJXZWJLaXRU b29scy9TY3JpcHRzL2J1Z3ppbGxhLXRvb2wiLCBsaW5lIDc3OSwgaW4gZXhlY3V0ZQogICAgd29y a19xdWV1ZS5ydW4oKQogIEZpbGUgIi9Vc2Vycy9lc2VpZGVsL1Byb2plY3RzL0NvbW1pdFF1ZXVl L1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy93b3JrcXVldWUucHkiLCBsaW5lIDEwMCwgaW4g cnVuCiAgICBzZWxmLl91cGRhdGVfc3RhdHVzX2FuZF9zbGVlcCh3YWl0aW5nX21lc3NhZ2UpCiAg RmlsZSAiL1VzZXJzL2VzZWlkZWwvUHJvamVjdHMvQ29tbWl0UXVldWUvV2ViS2l0VG9vbHMvU2Ny aXB0cy9tb2R1bGVzL3dvcmtxdWV1ZS5weSIsIGxpbmUgMTQ5LCBpbiBfdXBkYXRlX3N0YXR1c19h bmRfc2xlZXAKICAgIHRpbWUuc2xlZXAoc2VsZi5zZWNvbmRzX3RvX3NsZWVwKQpLZXlib2FyZElu dGVycnVwdAplc2VpZGVsLW1hYyBbMTgyMDk6Q29tbWl0UXVldWVdJSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgW34vUHJvamVjdHMv Q29tbWl0UXVldWVdCg== 43460 2009-11-18 14:17:35 -0800 2009-11-18 14:17:35 -0800 example of commit re-tries not working cq_ui.txt text/plain 2688 eric ZXNlaWRlbC1tYWMgWzE4MjA5OkNvbW1pdFF1ZXVlXSUgV2ViS2l0VG9vbHMvU2NyaXB0cy9idWd6 aWxsYS10b29sIGNvbW1pdC1xdWV1ZSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFt+L1Byb2plY3RzL0NvbW1pdFF1 ZXVlXQpDQVVUSU9OOiBjb21taXQtcXVldWUgd2lsbCBkaXNjYXJkIGFsbCBsb2NhbCBjaGFuZ2Vz IGluIC9Vc2Vycy9lc2VpZGVsL1Byb2plY3RzL0NvbW1pdFF1ZXVlLwpBcmUgeW91IHN1cmU/ICBU eXBlICd5ZXMnIHRvIGNvbnRpbnVlOiB5ZXMKUnVubmluZyBXZWJLaXQgY29tbWl0LXF1ZXVlLiAy MDA5LTExLTE4IDE0OjAwOjU5CkZldGNoaW5nOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Mjc1NTImY3R5cGU9eG1sCkZldGNoaW5nOiBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE1MDQmY3R5cGU9eG1sCkZldGNoaW5nOiBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE1MjcmY3R5cGU9eG1sCkZldGNoaW5nOiBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE1NTMmY3R5cGU9eG1sCkZl dGNoaW5nOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE1ODQmY3R5 cGU9eG1sCkZldGNoaW5nOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzE2MjcmY3R5cGU9eG1sCkZldGNoaW5nOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9Mjk0NjkmY3R5cGU9eG1sCkZldGNoaW5nOiBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzA4NjQmY3R5cGU9eG1sCkZldGNoaW5nOiBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE0NDgmY3R5cGU9eG1sCkZldGNoaW5nOiBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE0NjUmY3R5cGU9eG1sCkZldGNo aW5nOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE1OTkmY3R5cGU9 eG1sCkZldGNoaW5nOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE0 OTkmY3R5cGU9eG1sCkZldGNoaW5nOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzE0MDImY3R5cGU9eG1sCkZldGNoaW5nOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzExODYmY3R5cGU9eG1sCkZldGNoaW5nOiBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzEyNTgmY3R5cGU9eG1sCjE1IHBhdGNoZXMgaW4gY29t bWl0LXF1ZXVlIFs0MzQzMywgNDMyMjEsIDQzMjYxLCA0MzQxMSwgNDMzNjUsIDQzNDM4LCA0MzM0 MiwgNDIwMzMsIDQzMzIwLCA0MzE0OSwgNDMzODIsIDQzMjE1LCA0MzE1MywgNDMyNTksIDQzNDA3 XQpDbGVhbmluZyB3b3JraW5nIGRpcmVjdG9yeQpGZXRjaGluZzogaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvYXR0YWNobWVudC5jZ2k/aWQ9NDM0MzMmYWN0aW9uPWVkaXQKRmV0Y2hpbmc6IGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzU1MiZjdHlwZT14bWwKTGFuZGlu ZyAxIHBhdGNoIGZyb20gMSBidWcuClVwZGF0aW5nIHdvcmtpbmcgZGlyZWN0b3J5CkFwcGx5aW5n IHBhdGNoIDQzNDMzIGZyb20gYnVnIDI3NTUyLgpSdW5uaW5nIGJ1aWxkLXdlYmtpdApQYXJzaW5n IENoYW5nZUxvZzogV2ViQ29yZS9DaGFuZ2VMb2cKQ29tbWl0IGZhaWxlZCBiZWNhdXNlIHRoZSBj aGVja291dCBpcyBvdXQgb2YgZGF0ZS4gIFBsZWFzZSB1cGRhdGUgYW5kIHRyeSBhZ2Fpbi4KWW91 IGNhbiBwYXNzIC0tbm8tYnVpbGQgdG8gc2tpcCBidWlsZGluZy90ZXN0aW5nIGFmdGVyIHVwZGF0 ZSBpZiB5b3UgYmVsaWV2ZSB0aGUgbmV3IGNvbW1pdHMgZGlkIG5vdCBhZmZlY3QgdGhlIHJlc3Vs dHMuCkZhaWxlZCB0byBydW4gIlsnZ2l0JywgJ3N2bicsICdkY29tbWl0J10iIGV4aXRfY29kZTog MQpSdW5uaW5nIGJ1aWxkLWR1bXByZW5kZXJ0cmVlClJ1bm5pbmcgdGVzdHMgZnJvbSAvVXNlcnMv ZXNlaWRlbC9Qcm9qZWN0cy9Db21taXRRdWV1ZS9MYXlvdXRUZXN0cwpUZXN0aW5nIDExNjMxIHRl c3QgY2FzZXMuCgpodHRwZCBpcyBhbHJlYWR5IHJ1bm5pbmc6IHBpZCAzNzUxMywga2lsbGluZy4u LgoKMzk5LjI4cyB0b3RhbCB0ZXN0aW5nIHRpbWUKCmFsbCAxMTYzMSB0ZXN0IGNhc2VzIHN1Y2Nl ZWRlZAoxNCBwYXRjaGVzIGluIGNvbW1pdC1xdWV1ZSBbNDMyMjEsIDQzMjYxLCA0MzQxMSwgNDMz NjUsIDQzNDM4LCA0MzM0MiwgNDIwMzMsIDQzMzIwLCA0MzE0OSwgNDMzODIsIDQzMjE1LCA0MzE1 MywgNDMyNTksIDQzNDA3XQpDbGVhbmluZyB3b3JraW5nIGRpcmVjdG9yeQpGZXRjaGluZzogaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvYXR0YWNobWVudC5jZ2k/aWQ9NDMyMjEmYWN0aW9uPWVkaXQK RmV0Y2hpbmc6IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTUwNCZj dHlwZT14bWwKTGFuZGluZyAxIHBhdGNoIGZyb20gMSBidWcuClVwZGF0aW5nIHdvcmtpbmcgZGly ZWN0b3J5CkFwcGx5aW5nIHBhdGNoIDQzMjIxIGZyb20gYnVnIDMxNTA0LgpSdW5uaW5nIGJ1aWxk LXdlYmtpdAoK 43463 2009-11-18 14:46:15 -0800 2009-11-18 18:02:07 -0800 Patch bug-31645-20091118144612.patch text/plain 1742 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA4MDEyYzMzLi4zMWMxZTJiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTEt MTggIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHdvcmtxdWV1ZS5weSByZXN1bHRzIGluIHRvdGFs bHkgYnJva2VuIGNvbW1pdC1xdWV1ZSBVSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzE2NDUKKworICAgICAgICAqIFNjcmlwdHMvYnVnemlsbGEtdG9v bDoKKyAgICAgICAgIC0gUmVtb3ZlIHVubmVlZGVkIHVzZSBvZiBQYXRjaENvbGxlY3Rpb24uCisg ICAgICAgICAtIEdyYWIgYSBuZXcgY29weSBvZiB0aGUgY3EnZCBwYXRjaGVzIGV2ZXJ5IHJ1biBv ZiB0aGUgcXVldWUuCisKIDIwMDktMTEtMTggIEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuICA8 a2VubmV0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5u LgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWd6aWxsYS10b29sIGIvV2ViS2l0 VG9vbHMvU2NyaXB0cy9idWd6aWxsYS10b29sCmluZGV4IGM5MGM5MzEuLjI2OWI5YjggMTAwNzU1 Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbAorKysgYi9XZWJLaXRUb29s cy9TY3JpcHRzL2J1Z3ppbGxhLXRvb2wKQEAgLTc4NSwxNCArNzg1LDExIEBAIGNsYXNzIENvbW1p dFF1ZXVlKEFic3RyYWN0UXVldWUpOgogCiAgICAgZGVmIGJlZ2luX3dvcmtfcXVldWUoc2VsZik6 CiAgICAgICAgIEFic3RyYWN0UXVldWUuYmVnaW5fd29ya19xdWV1ZShzZWxmKQotICAgICAgICBz ZWxmLl9wYXRjaGVzID0gUGF0Y2hDb2xsZWN0aW9uKHNlbGYudG9vbC5idWdzKQogCiAgICAgZGVm IG5leHRfd29ya19pdGVtKHNlbGYpOgotICAgICAgICBpZiBub3QgbGVuKHNlbGYuX3BhdGNoZXMp OgotICAgICAgICAgICAgIyBGZXRjaCBwYXRjaGVzIGluc3RlYWQgb2YganVzdCBidWcgaWRzIHRv IHRoYXQgd2UgdmFsaWRhdGUgcmV2aWV3ZXIvY29tbWl0dGVyIGZsYWdzIG9uIGV2ZXJ5IHBhdGNo LgotICAgICAgICAgICAgc2VsZi5fcGF0Y2hlcy5hZGRfcGF0Y2hlcyhzZWxmLnRvb2wuYnVncy5m ZXRjaF9wYXRjaGVzX2Zyb21fY29tbWl0X3F1ZXVlKHJlamVjdF9pbnZhbGlkX3BhdGNoZXM9VHJ1 ZSkpCi0gICAgICAgIHNlbGYubG9nX3Byb2dyZXNzKHNlbGYuX3BhdGNoZXMucGF0Y2hfaWRzKCkp Ci0gICAgICAgIHJldHVybiBzZWxmLl9wYXRjaGVzLm5leHQoKQorICAgICAgICBwYXRjaGVzID0g c2VsZi50b29sLmJ1Z3MuZmV0Y2hfcGF0Y2hlc19mcm9tX2NvbW1pdF9xdWV1ZShyZWplY3RfaW52 YWxpZF9wYXRjaGVzPVRydWUpCisgICAgICAgIHNlbGYubG9nX3Byb2dyZXNzKFtwYXRjaFsnaWQn XSBmb3IgcGF0Y2ggaW4gcGF0Y2hlc10pCisgICAgICAgIHJldHVybiBwYXRjaGVzWzBdIGlmIHBh dGNoZXMgZWxzZSBOb25lCiAKICAgICBkZWYgc2hvdWxkX3Byb2NlZWRfd2l0aF93b3JrX2l0ZW0o c2VsZiwgcGF0Y2gpOgogICAgICAgICByZWRfYnVpbGRlcnNfbmFtZXMgPSBzZWxmLnRvb2wuYnVp bGRib3QucmVkX2NvcmVfYnVpbGRlcnNfbmFtZXMoKQo=