31641 2009-11-18 13:13:31 -0800 Web Inspector: Directly Access <head> Instead of Searching for It 2009-11-18 14:06:19 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 joepeck joepeck bweinstein joepeck keishi pfeldman pmuellr rik timothy oldest_to_newest 164683 0 joepeck 2009-11-18 13:13:31 -0800 There is no longer a need for document.getElementsByTagName("head") to get the head element, due to document.head being added in bug 30232. 164685 1 43453 joepeck 2009-11-18 13:15:38 -0800 Created attachment 43453 [PATCH] Use Direct Access 164705 2 joepeck 2009-11-18 14:06:19 -0800 Landed in http://trac.webkit.org/changeset/51134 r51134 = e140ac8a0460c6235fe692fff23faad8e148ac2a 43453 2009-11-18 13:15:38 -0800 2009-11-18 13:34:30 -0800 [PATCH] Use Direct Access head.patch text/plain 3988 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjczN2E0Yi4uZjQxODRhNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAwOS0xMS0xOCAgSm9zZXBoIFBlY29y YXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IERpcmVjdGx5IEFjY2VzcyA8aGVhZD4g SW5zdGVhZCBvZiBTZWFyY2hpbmcgZm9yIEl0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMTY0MQorICAgICAgICAKKyAgICAgICAgQ2hhbmdlZCBvbGQg YWNjZXNzIG9mIHRoZSBoZWFkIGVsZW1lbnQgKGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1l KQorICAgICAgICB0byBqdXN0IHVzZSB0aGUgZG9jdW1lbnQuaGVhZCBhY2Nlc3Nvci4KKworICAg ICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvRm9udFZpZXcuanM6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuRm9udFZpZXcpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRT Y3JpcHQuanM6CisgICAgICAgIChJbmplY3RlZFNjcmlwdC5hZGRTdHlsZVNlbGVjdG9yKToKKyAg ICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1NvdXJjZUZyYW1lLmpzOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLlNvdXJjZUZyYW1lLnByb3RvdHlwZS5fbG9hZGVkKToKKyAgICAgICAgKiBpbnNw ZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qczoKKyAgICAgICAgKHdpbmRvd0xvYWRlZCk6CisK IDIwMDktMTEtMTggIERtaXRyeSBUaXRvdiAgPGRpbWljaEBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvRm9udFZpZXcuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRm9u dFZpZXcuanMKaW5kZXggNGUxYzkzMS4uODQ2OGNjOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0ZvbnRWaWV3LmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9Gb250Vmlldy5qcwpAQCAtMzYsNyArMzYsNyBAQCBXZWJJbnNwZWN0b3IuRm9udFZpZXcg PSBmdW5jdGlvbihyZXNvdXJjZSkKIAogICAgIHRoaXMuZm9udFN0eWxlRWxlbWVudCA9IGRvY3Vt ZW50LmNyZWF0ZUVsZW1lbnQoInN0eWxlIik7CiAgICAgdGhpcy5mb250U3R5bGVFbGVtZW50LnRl eHRDb250ZW50ID0gIkBmb250LWZhY2UgeyBmb250LWZhbWlseTogXCIiICsgdW5pcXVlRm9udE5h bWUgKyAiXCI7IHNyYzogdXJsKCIgKyB0aGlzLnJlc291cmNlLnVybCArICIpOyB9IjsKLSAgICBk b2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgiaGVhZCIpLml0ZW0oMCkuYXBwZW5kQ2hpbGQo dGhpcy5mb250U3R5bGVFbGVtZW50KTsKKyAgICBkb2N1bWVudC5oZWFkLmFwcGVuZENoaWxkKHRo aXMuZm9udFN0eWxlRWxlbWVudCk7CiAKICAgICB0aGlzLmZvbnRQcmV2aWV3RWxlbWVudCA9IGRv Y3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwogICAgIHRoaXMuZm9udFByZXZpZXdFbGVtZW50 LmNsYXNzTmFtZSA9ICJwcmV2aWV3IjsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9JbmplY3RlZFNjcmlwdC5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9J bmplY3RlZFNjcmlwdC5qcwppbmRleCA1ODkzYmM4Li43MTNmMDJjIDEwMDY0NAotLS0gYS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMKKysrIGIvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0luamVjdGVkU2NyaXB0LmpzCkBAIC0yMzgsNyArMjM4LDcgQEAg SW5qZWN0ZWRTY3JpcHQuYWRkU3R5bGVTZWxlY3RvciA9IGZ1bmN0aW9uKG5ld0NvbnRlbnQsIHNl bGVjdGVkTm9kZUlkKQogCiAgICAgdmFyIHN0eWxlc2hlZXQgPSBvd25lckRvY3VtZW50Ll9fc3R5 bGVzaGVldDsKICAgICBpZiAoIXN0eWxlc2hlZXQpIHsKLSAgICAgICAgdmFyIGhlYWQgPSBvd25l ckRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCJoZWFkIilbMF07CisgICAgICAgIHZhciBo ZWFkID0gb3duZXJEb2N1bWVudC5oZWFkOwogICAgICAgICB2YXIgc3R5bGVFbGVtZW50ID0gb3du ZXJEb2N1bWVudC5jcmVhdGVFbGVtZW50KCJzdHlsZSIpOwogICAgICAgICBzdHlsZUVsZW1lbnQu dHlwZSA9ICJ0ZXh0L2NzcyI7CiAgICAgICAgIGhlYWQuYXBwZW5kQ2hpbGQoc3R5bGVFbGVtZW50 KTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VGcmFtZS5q cyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VGcmFtZS5qcwppbmRleCA5ZDlm ZjAzLi5mMjkyOWVlIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU291 cmNlRnJhbWUuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NvdXJjZUZyYW1l LmpzCkBAIC0yMTIsNyArMjEyLDcgQEAgV2ViSW5zcGVjdG9yLlNvdXJjZUZyYW1lLnByb3RvdHlw ZSA9IHsKICAgICAgICAgdmFyIHNob3J0Y3V0ID0gV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRj dXQubWFrZUtleSg2OSAvKiAnRScgKi8sIHBsYXRmb3JtU3BlY2lmaWNNb2RpZmllciB8IFdlYklu c3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVycy5TaGlmdCk7CiAgICAgICAgIHRoaXMu X3Nob3J0Y3V0c1tzaG9ydGN1dF0gPSB0aGlzLl9ldmFsU2VsZWN0aW9uSW5DYWxsRnJhbWUuYmlu ZCh0aGlzKTsKIAotICAgICAgICB2YXIgaGVhZEVsZW1lbnQgPSB0aGlzLmVsZW1lbnQuY29udGVu dERvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCJoZWFkIilbMF07CisgICAgICAgIHZhciBo ZWFkRWxlbWVudCA9IHRoaXMuZWxlbWVudC5jb250ZW50RG9jdW1lbnQuaGVhZDsKICAgICAgICAg aWYgKCFoZWFkRWxlbWVudCkgewogICAgICAgICAgICAgaGVhZEVsZW1lbnQgPSB0aGlzLmVsZW1l bnQuY29udGVudERvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImhlYWQiKTsKICAgICAgICAgICAgIHRo aXMuZWxlbWVudC5jb250ZW50RG9jdW1lbnQuZG9jdW1lbnRFbGVtZW50Lmluc2VydEJlZm9yZSho ZWFkRWxlbWVudCwgdGhpcy5lbGVtZW50LmNvbnRlbnREb2N1bWVudC5kb2N1bWVudEVsZW1lbnQu Zmlyc3RDaGlsZCk7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5z cGVjdG9yLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwppbmRl eCBhNGRkY2NlLi42NjI3YThiIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvaW5zcGVjdG9yLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0 b3IuanMKQEAgLTUwMCw3ICs1MDAsNyBAQCB2YXIgd2luZG93TG9hZGVkID0gZnVuY3Rpb24oKQog ICAgICAgICBsb2NhbGl6ZWRTdHJpbmdzU2NyaXB0RWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJs b2FkIiwgV2ViSW5zcGVjdG9yLmxvYWRlZC5iaW5kKFdlYkluc3BlY3RvciksIGZhbHNlKTsKICAg ICAgICAgbG9jYWxpemVkU3RyaW5nc1NjcmlwdEVsZW1lbnQudHlwZSA9ICJ0ZXh0L2phdmFzY3Jp cHQiOwogICAgICAgICBsb2NhbGl6ZWRTdHJpbmdzU2NyaXB0RWxlbWVudC5zcmMgPSBsb2NhbGl6 ZWRTdHJpbmdzVVJMOwotICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgiaGVh ZCIpLml0ZW0oMCkuYXBwZW5kQ2hpbGQobG9jYWxpemVkU3RyaW5nc1NjcmlwdEVsZW1lbnQpOwor ICAgICAgICBkb2N1bWVudC5oZWFkLmFwcGVuZENoaWxkKGxvY2FsaXplZFN0cmluZ3NTY3JpcHRF bGVtZW50KTsKICAgICB9IGVsc2UKICAgICAgICAgV2ViSW5zcGVjdG9yLmxvYWRlZCgpOwogCg==