31635 2009-11-18 12:22:20 -0800 Interpreter may do an out of range access when throwing an exception in the profiler. 2009-11-18 13:25:02 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 oliver webkit-unassigned eric oldest_to_newest 164656 0 oliver 2009-11-18 12:22:20 -0800 Found this bug while looking at another bug -- the exception handling code assumes it can always look 8 words forward into the instruction stream, which may not be true in some cases. 164658 1 43445 oliver 2009-11-18 12:25:15 -0800 Created attachment 43445 Patch 164670 2 43445 ap 2009-11-18 12:40:30 -0800 Comment on attachment 43445 Patch r=me 164676 3 oliver 2009-11-18 12:46:40 -0800 Committed r51128 164686 4 eric 2009-11-18 13:19:03 -0800 Looks like this may have regressed a test on the bots: http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r51128%20(7372)/fast/profiler/throw-exception-from-eval-pretty-diff.html 164687 5 oliver 2009-11-18 13:25:02 -0800 Gah, i'm a moron and forgot to update the expected output 43445 2009-11-18 12:25:15 -0800 2009-11-18 12:40:29 -0800 Patch bug-31635-20091118122512.patch text/plain 2831 oliver ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBkN2FjYzEwLi4wNTk2NWJiIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMDktMTEtMTggIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbnRlcnByZXRlciBtYXkg ZG8gYW4gb3V0IG9mIHJhbmdlIGFjY2VzcyB3aGVuIHRocm93aW5nIGFuIGV4Y2VwdGlvbiBpbiB0 aGUgcHJvZmlsZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zMTYzNQorCisgICAgICAgIEFkZCBib3VuZHMgY2hlY2suCisKKyAgICAgICAgKiBpbnRl cnByZXRlci9JbnRlcnByZXRlci5jcHA6CisgICAgICAgIChKU0M6OkludGVycHJldGVyOjp0aHJv d0V4Y2VwdGlvbik6CisKIDIwMDktMTEtMTcgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYWNpZWogU3RhY2hvd2lhay4KZGlmZiAtLWdpdCBh L0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVycHJldGVyLmNwcCBiL0phdmFTY3JpcHRD b3JlL2ludGVycHJldGVyL0ludGVycHJldGVyLmNwcAppbmRleCA4ZDMyMzQyLi5iZWExZTBjIDEw MDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHAKKysr IGIvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwCkBAIC01MzcsNyAr NTM3LDcgQEAgTkVWRVJfSU5MSU5FIEhhbmRsZXJJbmZvKiBJbnRlcnByZXRlcjo6dGhyb3dFeGNl cHRpb24oQ2FsbEZyYW1lKiYgY2FsbEZyYW1lLCBKU1YKICNpZiAhRU5BQkxFKEpJVCkKICAgICAg ICAgaWYgKGlzQ2FsbEJ5dGVjb2RlKGNvZGVCbG9jay0+aW5zdHJ1Y3Rpb25zKClbYnl0ZWNvZGVP ZmZzZXRdLnUub3Bjb2RlKSkKICAgICAgICAgICAgIHByb2ZpbGVyLT5kaWRFeGVjdXRlKGNhbGxG cmFtZSwgY2FsbEZyYW1lLT5yKGNvZGVCbG9jay0+aW5zdHJ1Y3Rpb25zKClbYnl0ZWNvZGVPZmZz ZXQgKyAyXS51Lm9wZXJhbmQpLmpzVmFsdWUoKSk7Ci0gICAgICAgIGVsc2UgaWYgKGNvZGVCbG9j ay0+aW5zdHJ1Y3Rpb25zKClbYnl0ZWNvZGVPZmZzZXQgKyA4XS51Lm9wY29kZSA9PSBnZXRPcGNv ZGUob3BfY29uc3RydWN0KSkKKyAgICAgICAgZWxzZSBpZiAoY29kZUJsb2NrLT5pbnN0cnVjdGlv bnMoKS5zaXplKCkgPiAoYnl0ZWNvZGVPZmZzZXQgKyA4KSAmJiBjb2RlQmxvY2stPmluc3RydWN0 aW9ucygpW2J5dGVjb2RlT2Zmc2V0ICsgOF0udS5vcGNvZGUgPT0gZ2V0T3Bjb2RlKG9wX2NvbnN0 cnVjdCkpCiAgICAgICAgICAgICBwcm9maWxlci0+ZGlkRXhlY3V0ZShjYWxsRnJhbWUsIGNhbGxG cmFtZS0+cihjb2RlQmxvY2stPmluc3RydWN0aW9ucygpW2J5dGVjb2RlT2Zmc2V0ICsgMTBdLnUu b3BlcmFuZCkuanNWYWx1ZSgpKTsKICNlbHNlCiAgICAgICAgIGludCBmdW5jdGlvblJlZ2lzdGVy SW5kZXg7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKaW5kZXggNGJiOTg3Yy4uZTM4MDU3ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisy MDA5LTExLTE4ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW50ZXJwcmV0ZXIgbWF5IGRvIGFu IG91dCBvZiByYW5nZSBhY2Nlc3Mgd2hlbiB0aHJvd2luZyBhbiBleGNlcHRpb24gaW4gdGhlIHBy b2ZpbGVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzE2MzUKKworICAgICAgICBDb3JyZWN0IHRoaXMgdGVzdCBzbyB0aGF0IGl0IGlzIGFjdHVhbGx5 IHRlc3Rpbmcgd2hhdCBpdCBpcyBpbnRlbmRlZCB0by4KKworICAgICAgICAqIGZhc3QvcHJvZmls ZXIvdGhyb3ctZXhjZXB0aW9uLWZyb20tZXZhbC5odG1sOgorCiAyMDA5LTExLTE3ICBDc2FiYSBP c3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgTm90IHJldmlld2VkLCBm b2xsb3cgdXAgdG8gcjUxMDcyOiByZW5hbWUgc2tpcHBlZCBlbnRyaWVzCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L3Byb2ZpbGVyL3Rocm93LWV4Y2VwdGlvbi1mcm9tLWV2YWwuaHRtbCBi L0xheW91dFRlc3RzL2Zhc3QvcHJvZmlsZXIvdGhyb3ctZXhjZXB0aW9uLWZyb20tZXZhbC5odG1s CmluZGV4IDNiMzRlODcuLjhiNTdjMDMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvcHJv ZmlsZXIvdGhyb3ctZXhjZXB0aW9uLWZyb20tZXZhbC5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zh c3QvcHJvZmlsZXIvdGhyb3ctZXhjZXB0aW9uLWZyb20tZXZhbC5odG1sCkBAIC03LDEwICs3LDEw IEBAIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKICAgICBsYXlvdXRUZXN0Q29u dHJvbGxlci5zZXRKYXZhU2NyaXB0UHJvZmlsaW5nRW5hYmxlZCh0cnVlKTsKIH0KIAorY29uc29s ZS5wcm9maWxlKCJUaHJvdyB3aXRoaW4gYW4gZXZhbC4iKTsKKwogZnVuY3Rpb24gc3RhcnRUZXN0 KCkKIHsKLSAgICBjb25zb2xlLnByb2ZpbGUoIlRocm93IHdpdGhpbiBhbiBldmFsLiIpOwotCiAg ICAgaW5zZXJ0TmV3VGV4dCgpOwogCiAgICAgZW5kVGVzdCgpOwo=