31634 2009-11-18 12:21:44 -0800 Ignore realm for proxy protection spaces 2009-11-19 09:44:04 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ap ap abarth eric oldest_to_newest 164655 0 ap 2009-11-18 12:21:44 -0800 Realm makes no sense for HTTP(S) proxy authentication. It is not even set in NSURLAuthenticationChallenge's protection space that is sent for HTTP. This makes it difficult to use stored credentials for Web Socket, as servers so actually send realms for proxy auth. One solution is to not set realm when creating a ProtectionSpace object for proxy auth. I think it would be even better to treat proxy protection spaces with different realms. One related data point: it looks like the realm isn't stored in Keychain, even for non-proxy credentials. 164659 1 43446 ap 2009-11-18 12:26:51 -0800 Created attachment 43446 proposed patch 164700 2 ap 2009-11-18 13:51:48 -0800 ...to treat proxy protection spaces with different realms AS EQUAL 164708 3 ap 2009-11-18 14:08:57 -0800 > One related data point: it looks like the realm isn't stored in Keychain, even > for non-proxy credentials. That may be a lie - perhaps it's just not displayed in UI. Not sure yet. 164802 4 43446 darin 2009-11-18 16:14:50 -0800 Comment on attachment 43446 proposed patch > + if (protectionSpace.isProxy()) > + codeCount -= sizeof(UChar); Should be sizeof(hashCodes[0]) / sizeof(UChar) or some similar expression, not sizeof(UChar). 164826 5 43472 ap 2009-11-18 16:54:24 -0800 Created attachment 43472 updated patch 165000 6 ap 2009-11-19 09:44:04 -0800 Committed <http://trac.webkit.org/changeset/51189>. 43446 2009-11-18 12:26:51 -0800 2009-11-18 16:54:24 -0800 proposed patch ProxyRealm.txt text/plain 2619 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTExOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMTEtMTggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNjM0CisgICAgICAgIEln bm9yZSByZWFsbSBmb3IgcHJveHkgcHJvdGVjdGlvbiBzcGFjZXMKKworICAgICAgICBPbmx5IGFm ZmVjdHMgV2ViU29ja2V0IHByb3h5IGF1dGhlbnRpY2F0aW9uLCBjYW5ub3QgYmUgdGVzdGVkIGlu IERSVC4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvUHJvdGVjdGlvblNwYWNlLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6Om9wZXJhdG9yPT0pOgorICAgICAgICAqIHBsYXRmb3JtL25ldHdv cmsvUHJvdGVjdGlvblNwYWNlSGFzaC5oOgorICAgICAgICAoV2ViQ29yZTo6UHJvdGVjdGlvblNw YWNlSGFzaDo6aGFzaCk6CisKIDIwMDktMTEtMTggIEJlbiBNdXJkb2NoICA8YmVubUBnb29nbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL1Byb3RlY3Rpb25TcGFjZS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL1Byb3RlY3Rpb25TcGFjZS5jcHAJKHJldmlzaW9uIDUxMDYxKQor KysgV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Byb3RlY3Rpb25TcGFjZS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTExMSw3ICsxMTEsOCBAQCBib29sIG9wZXJhdG9yPT0oY29uc3QgUHJvdGVjdGlv blNwYWNlJiBhCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBpZiAoYS5zZXJ2ZXJUeXBlKCkg IT0gYi5zZXJ2ZXJUeXBlKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICBpZiAoYS5yZWFs bSgpICE9IGIucmVhbG0oKSkKKyAgICAvLyBJZ25vcmUgcmVhbG0gZm9yIHByb3hpZXMKKyAgICBp ZiAoIWEuaXNQcm94eSgpICYmIGEucmVhbG0oKSAhPSBiLnJlYWxtKCkpCiAgICAgICAgIHJldHVy biBmYWxzZTsKICAgICBpZiAoYS5hdXRoZW50aWNhdGlvblNjaGVtZSgpICE9IGIuYXV0aGVudGlj YXRpb25TY2hlbWUoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwpJbmRleDogV2ViQ29yZS9wbGF0 Zm9ybS9uZXR3b3JrL1Byb3RlY3Rpb25TcGFjZUhhc2guaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvUHJvdGVjdGlvblNwYWNlSGFzaC5oCShyZXZpc2lvbiA1MTA2MSkK KysrIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9Qcm90ZWN0aW9uU3BhY2VIYXNoLmgJKHdvcmtp bmcgY29weSkKQEAgLTM3LDExICszNywxNSBAQCBzdHJ1Y3QgUHJvdGVjdGlvblNwYWNlSGFzaCB7 CiAgICAgICAgICAgICBwcm90ZWN0aW9uU3BhY2UuaG9zdCgpLmltcGwoKSA/IHByb3RlY3Rpb25T cGFjZS5ob3N0KCkuaW1wbCgpLT5oYXNoKCkgOiAwLCAKICAgICAgICAgICAgIHByb3RlY3Rpb25T cGFjZS5wb3J0KCksIAogICAgICAgICAgICAgcHJvdGVjdGlvblNwYWNlLnNlcnZlclR5cGUoKSwK LSAgICAgICAgICAgIHByb3RlY3Rpb25TcGFjZS5yZWFsbSgpLmltcGwoKSA/IHByb3RlY3Rpb25T cGFjZS5yZWFsbSgpLmltcGwoKS0+aGFzaCgpIDogMCwKLSAgICAgICAgICAgIHByb3RlY3Rpb25T cGFjZS5hdXRoZW50aWNhdGlvblNjaGVtZSgpCisgICAgICAgICAgICBwcm90ZWN0aW9uU3BhY2Uu YXV0aGVudGljYXRpb25TY2hlbWUoKSwKKyAgICAgICAgICAgIHByb3RlY3Rpb25TcGFjZS5yZWFs bSgpLmltcGwoKSA/IHByb3RlY3Rpb25TcGFjZS5yZWFsbSgpLmltcGwoKS0+aGFzaCgpIDogMAog ICAgICAgICB9OwogCi0gICAgICAgIHJldHVybiBTdHJpbmdJbXBsOjpjb21wdXRlSGFzaChyZWlu dGVycHJldF9jYXN0PFVDaGFyKj4oaGFzaENvZGVzKSwgc2l6ZW9mKGhhc2hDb2RlcykgLyBzaXpl b2YoVUNoYXIpKTsgICAgCisgICAgICAgIHVuc2lnbmVkIGNvZGVDb3VudCA9IHNpemVvZihoYXNo Q29kZXMpIC8gc2l6ZW9mKFVDaGFyKTsKKyAgICAgICAgLy8gSWdub3JlIHJlYWxtIGZvciBwcm94 aWVzLgorICAgICAgICBpZiAocHJvdGVjdGlvblNwYWNlLmlzUHJveHkoKSkKKyAgICAgICAgICAg IGNvZGVDb3VudCAtPSBzaXplb2YoVUNoYXIpOworICAgICAgICByZXR1cm4gU3RyaW5nSW1wbDo6 Y29tcHV0ZUhhc2gocmVpbnRlcnByZXRfY2FzdDxVQ2hhcio+KGhhc2hDb2RlcyksIGNvZGVDb3Vu dCk7CiAgICAgfQogICAgIAogICAgIHN0YXRpYyBib29sIGVxdWFsKGNvbnN0IFByb3RlY3Rpb25T cGFjZSYgYSwgY29uc3QgUHJvdGVjdGlvblNwYWNlJiBiKSB7IHJldHVybiBhID09IGI7IH0K 43472 2009-11-18 16:54:24 -0800 2009-11-18 17:06:58 -0800 updated patch ProxyRealm.txt text/plain 2642 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTExOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMTEtMTggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNjM0CisgICAgICAgIEln bm9yZSByZWFsbSBmb3IgcHJveHkgcHJvdGVjdGlvbiBzcGFjZXMKKworICAgICAgICBPbmx5IGFm ZmVjdHMgV2ViU29ja2V0IHByb3h5IGF1dGhlbnRpY2F0aW9uLCBjYW5ub3QgYmUgdGVzdGVkIGlu IERSVC4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvUHJvdGVjdGlvblNwYWNlLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6Om9wZXJhdG9yPT0pOgorICAgICAgICAqIHBsYXRmb3JtL25ldHdv cmsvUHJvdGVjdGlvblNwYWNlSGFzaC5oOgorICAgICAgICAoV2ViQ29yZTo6UHJvdGVjdGlvblNw YWNlSGFzaDo6aGFzaCk6CisKIDIwMDktMTEtMTggIEJlbiBNdXJkb2NoICA8YmVubUBnb29nbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL1Byb3RlY3Rpb25TcGFjZS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL1Byb3RlY3Rpb25TcGFjZS5jcHAJKHJldmlzaW9uIDUxMDYxKQor KysgV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Byb3RlY3Rpb25TcGFjZS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTExMSw3ICsxMTEsOCBAQCBib29sIG9wZXJhdG9yPT0oY29uc3QgUHJvdGVjdGlv blNwYWNlJiBhCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBpZiAoYS5zZXJ2ZXJUeXBlKCkg IT0gYi5zZXJ2ZXJUeXBlKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICBpZiAoYS5yZWFs bSgpICE9IGIucmVhbG0oKSkKKyAgICAvLyBJZ25vcmUgcmVhbG0gZm9yIHByb3hpZXMKKyAgICBp ZiAoIWEuaXNQcm94eSgpICYmIGEucmVhbG0oKSAhPSBiLnJlYWxtKCkpCiAgICAgICAgIHJldHVy biBmYWxzZTsKICAgICBpZiAoYS5hdXRoZW50aWNhdGlvblNjaGVtZSgpICE9IGIuYXV0aGVudGlj YXRpb25TY2hlbWUoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwpJbmRleDogV2ViQ29yZS9wbGF0 Zm9ybS9uZXR3b3JrL1Byb3RlY3Rpb25TcGFjZUhhc2guaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvUHJvdGVjdGlvblNwYWNlSGFzaC5oCShyZXZpc2lvbiA1MTA2MSkK KysrIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9Qcm90ZWN0aW9uU3BhY2VIYXNoLmgJKHdvcmtp bmcgY29weSkKQEAgLTM3LDExICszNywxNSBAQCBzdHJ1Y3QgUHJvdGVjdGlvblNwYWNlSGFzaCB7 CiAgICAgICAgICAgICBwcm90ZWN0aW9uU3BhY2UuaG9zdCgpLmltcGwoKSA/IHByb3RlY3Rpb25T cGFjZS5ob3N0KCkuaW1wbCgpLT5oYXNoKCkgOiAwLCAKICAgICAgICAgICAgIHByb3RlY3Rpb25T cGFjZS5wb3J0KCksIAogICAgICAgICAgICAgcHJvdGVjdGlvblNwYWNlLnNlcnZlclR5cGUoKSwK LSAgICAgICAgICAgIHByb3RlY3Rpb25TcGFjZS5yZWFsbSgpLmltcGwoKSA/IHByb3RlY3Rpb25T cGFjZS5yZWFsbSgpLmltcGwoKS0+aGFzaCgpIDogMCwKLSAgICAgICAgICAgIHByb3RlY3Rpb25T cGFjZS5hdXRoZW50aWNhdGlvblNjaGVtZSgpCisgICAgICAgICAgICBwcm90ZWN0aW9uU3BhY2Uu YXV0aGVudGljYXRpb25TY2hlbWUoKSwKKyAgICAgICAgICAgIHByb3RlY3Rpb25TcGFjZS5yZWFs bSgpLmltcGwoKSA/IHByb3RlY3Rpb25TcGFjZS5yZWFsbSgpLmltcGwoKS0+aGFzaCgpIDogMAog ICAgICAgICB9OwogCi0gICAgICAgIHJldHVybiBTdHJpbmdJbXBsOjpjb21wdXRlSGFzaChyZWlu dGVycHJldF9jYXN0PFVDaGFyKj4oaGFzaENvZGVzKSwgc2l6ZW9mKGhhc2hDb2RlcykgLyBzaXpl b2YoVUNoYXIpKTsgICAgCisgICAgICAgIHVuc2lnbmVkIGNvZGVDb3VudCA9IHNpemVvZihoYXNo Q29kZXMpIC8gc2l6ZW9mKFVDaGFyKTsKKyAgICAgICAgLy8gSWdub3JlIHJlYWxtIGZvciBwcm94 aWVzLgorICAgICAgICBpZiAocHJvdGVjdGlvblNwYWNlLmlzUHJveHkoKSkKKyAgICAgICAgICAg IGNvZGVDb3VudCAtPSBzaXplb2YoaGFzaENvZGVzWzBdKSAvIHNpemVvZihVQ2hhcik7CisgICAg ICAgIHJldHVybiBTdHJpbmdJbXBsOjpjb21wdXRlSGFzaChyZWludGVycHJldF9jYXN0PFVDaGFy Kj4oaGFzaENvZGVzKSwgY29kZUNvdW50KTsKICAgICB9CiAgICAgCiAgICAgc3RhdGljIGJvb2wg ZXF1YWwoY29uc3QgUHJvdGVjdGlvblNwYWNlJiBhLCBjb25zdCBQcm90ZWN0aW9uU3BhY2UmIGIp IHsgcmV0dXJuIGEgPT0gYjsgfQo=