31624 2009-11-18 04:05:41 -0800 [Qt] Mac plugins: remove null timer 2009-11-18 04:55:20 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt P2 Normal --- 0 girish webkit-unassigned oldest_to_newest 164525 0 girish 2009-11-18 04:05:41 -0800 On the mac, the null timer is used to send mouse events. Instead, just use mouse events to send null events. This brings down cpu usage by 20-30%. Seems to be no loss in functionality by removing the null timer. 164526 1 43424 girish 2009-11-18 04:11:37 -0800 Created attachment 43424 Remove nullEvent timer 164539 2 girish 2009-11-18 04:55:20 -0800 Landed as http://svn.webkit.org/repository/webkit/trunk@51105 43424 2009-11-18 04:11:37 -0800 2009-11-18 04:19:53 -0800 Remove nullEvent timer patch text/plain 3453 girish Y29tbWl0IGU5NmM0NWU1NTM3OWNkM2YwOWRhNDAxZWEzMGQ2Yzg1YzAxZmEwODMKQXV0aG9yOiBH aXJpc2ggUmFtYWtyaXNobmFuIDxnaXJpc2hATWluaS1NZS5sb2NhbD4KRGF0ZTogICBXZWQgTm92 IDE4IDE2OjUyOjQzIDIwMDkgKzA1MzAKCiAgICBbUXRdIE1hYyBQbHVnaW5zOiBSZW1vdmUgbnVs bCB0aW1lcgogICAgCiAgICBBIG51bGwgdGltZXIgd2FzIHVzZWQgdG8gc2VuZCBtb3VzZSBtb3Zl IGV2ZW50cy4gSW5zdGVhZCwgd2Ugbm93IHVzZQogICAgbW92ZSBldmVudHMgdG8gc2VuZCBudWxs RXZlbnQuIFRoaXMgYnJpbmdzIGRvd24gQ1BVIHVzYWdlIGJ5IDIwLTMwJS4KICAgIAogICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNjI0CgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiMGZhNWFjLi4xNjRh YjcyIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE5IEBACisyMDA5LTExLTE4ICBHaXJpc2ggUmFtYWtyaXNobmFuICA8Z2ly aXNoQE1pbmktTWUubG9jYWw+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW1F0XSBNYWMgUGx1Z2luczogUmVtb3ZlIG51bGwgdGltZXIKKyAgICAgICAg CisgICAgICAgIEEgbnVsbCB0aW1lciB3YXMgdXNlZCB0byBzZW5kIG1vdXNlIG1vdmUgZXZlbnRz LiBJbnN0ZWFkLCB3ZSBub3cgdXNlCisgICAgICAgIG1vdmUgZXZlbnRzIHRvIHNlbmQgbnVsbEV2 ZW50LiBUaGlzIGJyaW5ncyBkb3duIENQVSB1c2FnZSBieSAyMC0zMCUuCisgICAgICAgIAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE2MjQKKworICAg ICAgICAqIHBsdWdpbnMvUGx1Z2luVmlldy5oOgorICAgICAgICAqIHBsdWdpbnMvbWFjL1BsdWdp blZpZXdNYWMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luVmlldzo6cGxhdGZvcm1TdGFy dCk6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3OjpoYW5kbGVNb3VzZUV2ZW50KToKKwog MjAwOS0xMS0xOCAgR2lyaXNoIFJhbWFrcmlzaG5hbiAgPGdpcmlzaEBmb3J3YXJkYmlhcy5pbj4K IAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1dlYkNv cmUvcGx1Z2lucy9QbHVnaW5WaWV3LmggYi9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5oCmlu ZGV4IDExMmQzM2UuLmViOTg4MzMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5W aWV3LmgKKysrIGIvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXcuaApAQCAtMzI4LDcgKzMyOCw2 IEBAIHByaXZhdGU6CiAgICAgICAgIHZvaWQgc2V0TlBXaW5kb3dJZk5lZWRlZCgpOwogI2VsaWYg ZGVmaW5lZChYUF9NQUNPU1gpCiAgICAgICAgIE5QX0NHQ29udGV4dCBtX25wQ2dDb250ZXh0Owot ICAgICAgICBPd25QdHI8VGltZXI8UGx1Z2luVmlldz4gPiBtX251bGxFdmVudFRpbWVyOwogICAg ICAgICBOUERyYXdpbmdNb2RlbCBtX2RyYXdpbmdNb2RlbDsKICAgICAgICAgTlBFdmVudE1vZGVs IG1fZXZlbnRNb2RlbDsKICAgICAgICAgQ0dDb250ZXh0UmVmIG1fY29udGV4dFJlZjsKQEAgLTMz OCw3ICszMzcsNiBAQCBwcml2YXRlOgogI2VuZGlmCiAKICAgICAgICAgdm9pZCBzZXROUFdpbmRv d0lmTmVlZGVkKCk7Ci0gICAgICAgIHZvaWQgbnVsbEV2ZW50VGltZXJGaXJlZChUaW1lcjxQbHVn aW5WaWV3PiopOwogICAgICAgICBQb2ludCBnbG9iYWxNb3VzZVBvc0ZvclBsdWdpbigpIGNvbnN0 OwogI2VuZGlmCiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGx1Z2lucy9tYWMvUGx1Z2luVmlld01h Yy5jcHAgYi9XZWJDb3JlL3BsdWdpbnMvbWFjL1BsdWdpblZpZXdNYWMuY3BwCmluZGV4IDgzYzRj OTYuLjYwNDQzMTMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGx1Z2lucy9tYWMvUGx1Z2luVmlld01h Yy5jcHAKKysrIGIvV2ViQ29yZS9wbHVnaW5zL21hYy9QbHVnaW5WaWV3TWFjLmNwcApAQCAtMTkx LDEwICsxOTEsNiBAQCBib29sIFBsdWdpblZpZXc6OnBsYXRmb3JtU3RhcnQoKQogCiAgICAgc2hv dygpOwogCi0gICAgLy8gVE9ETzogSW1wbGVtZW50IG51bGwgdGltZXIgdGhyb3R0bGluZyBkZXBl bmRpbmcgb24gcGx1Z2luIGFjdGl2YXRpb24KLSAgICBtX251bGxFdmVudFRpbWVyLnNldChuZXcg VGltZXI8UGx1Z2luVmlldz4odGhpcywgJlBsdWdpblZpZXc6Om51bGxFdmVudFRpbWVyRmlyZWQp KTsKLSAgICBtX251bGxFdmVudFRpbWVyLT5zdGFydFJlcGVhdGluZygwLjAyKTsKLQogICAgIHJl dHVybiB0cnVlOwogfQogCkBAIC01NDYsOCArNTQyLDcgQEAgdm9pZCBQbHVnaW5WaWV3OjpoYW5k bGVNb3VzZUV2ZW50KE1vdXNlRXZlbnQqIGV2ZW50KQogICAgIEV2ZW50UmVjb3JkIHJlY29yZDsK IAogICAgIGlmIChldmVudC0+dHlwZSgpID09IGV2ZW50TmFtZXMoKS5tb3VzZW1vdmVFdmVudCkg ewotICAgICAgICAvLyBNb3VzZSBtb3ZlbWVudCBpcyBoYW5kbGVkIGJ5IG51bGwgdGltZXIgZXZl bnRzCi0gICAgICAgIHJldHVybjsKKyAgICAgICAgcmVjb3JkLndoYXQgPSBudWxsRXZlbnQ7CiAg ICAgfSBlbHNlIGlmIChldmVudC0+dHlwZSgpID09IGV2ZW50TmFtZXMoKS5tb3VzZW92ZXJFdmVu dCkgewogICAgICAgICByZWNvcmQud2hhdCA9IGFkanVzdEN1cnNvckV2ZW50OwogICAgIH0gZWxz ZSBpZiAoZXZlbnQtPnR5cGUoKSA9PSBldmVudE5hbWVzKCkubW91c2VvdXRFdmVudCkgewpAQCAt NjU0LDIyICs2NDksNiBAQCB2b2lkIFBsdWdpblZpZXc6OmhhbmRsZUtleWJvYXJkRXZlbnQoS2V5 Ym9hcmRFdmVudCogZXZlbnQpCiAgICAgICAgIGV2ZW50LT5zZXREZWZhdWx0SGFuZGxlZCgpOwog fQogCi12b2lkIFBsdWdpblZpZXc6Om51bGxFdmVudFRpbWVyRmlyZWQoVGltZXI8UGx1Z2luVmll dz4qKQotewotICAgIEV2ZW50UmVjb3JkIHJlY29yZDsKLQotICAgIHJlY29yZC53aGF0ID0gbnVs bEV2ZW50OwotICAgIHJlY29yZC5tZXNzYWdlID0gMDsKLSAgICByZWNvcmQud2hlbiA9IFRpY2tD b3VudCgpOwotICAgIHJlY29yZC53aGVyZSA9IGdsb2JhbE1vdXNlUG9zRm9yUGx1Z2luKCk7Ci0g ICAgcmVjb3JkLm1vZGlmaWVycyA9IEdldEN1cnJlbnRLZXlNb2RpZmllcnMoKTsKLSAgICBpZiAo IUJ1dHRvbigpKQotICAgICAgICByZWNvcmQubW9kaWZpZXJzIHw9IGJ0blN0YXRlOwotCi0gICAg aWYgKCFkaXNwYXRjaE5QRXZlbnQocmVjb3JkKSkKLSAgICAgICAgTE9HKEV2ZW50cywgIlBsdWdp blZpZXc6Om51bGxFdmVudFRpbWVyRmlyZWQoKTogTnVsbCBldmVudCBub3QgYWNjZXB0ZWQiKTsK LX0KLQogc3RhdGljIGludCBtb2RpZmllcnNGb3JFdmVudChVSUV2ZW50V2l0aEtleVN0YXRlKiBl dmVudCkKIHsKICAgICBpbnQgbW9kaWZpZXJzID0gMDsK