31619 2009-11-18 02:01:00 -0800 Whitespaces after a list marker isn't ignored in calcInlinePrefWidths 2009-11-18 08:36:18 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED DUPLICATE 23264 P2 Normal --- 1 hamaji webkit-unassigned mitz oldest_to_newest 164504 0 43416 hamaji 2009-11-18 02:01:00 -0800 Created attachment 43416 test case with ahem As mitz pointed in Bug 23264, whitespace characters after a list marker is added into the preferred width. 164505 1 43417 hamaji 2009-11-18 02:05:36 -0800 Created attachment 43417 Patch v1 164558 2 mitz 2009-11-18 07:12:21 -0800 I’m confused. If you fix this bug independently of bug 23264, you will have an inconsistency between calcPrefWidths() and findNextLineBreak(). I think you should change both at the same time. 164562 3 hamaji 2009-11-18 07:36:47 -0800 It is already inconsistent for normal lists. Bug 23264 only fixes list-style-position:inside case and the rendering of normal lists was OK even before Bug 23264. Here is the summary of cases: 1. rendering of normal list: space is ignored (OK) 2. rendering of inside list: space is not ignored (not OK) 3. prefWidth of normal list: space is not ignored (not OK, inconsistent with case 1) 4. prefWidth of inside list: space is not ignored (not OK) This patch fixes 3 and 4, and Bug 23264 fixes 2. Anyway, if you want to fix them at the same time, I'll combine the patches into one patch. 164564 4 mitz 2009-11-18 07:44:37 -0800 (In reply to comment #3) > 3. prefWidth of normal list: space is not ignored (not OK, inconsistent with > case 1) Do you have a test case showing this? This case seems to behave correctly to me. > This patch fixes 3 and 4, and Bug 23264 fixes 2. Anyway, if you want to fix > them at the same time, I'll combine the patches into one patch. I suggest that you do that. 164565 5 43417 hamaji 2009-11-18 07:47:44 -0800 Comment on attachment 43417 Patch v1 Clearing review? as I'll combine this patch into Bug 23264 164566 6 hamaji 2009-11-18 07:49:11 -0800 (In reply to comment #4) > (In reply to comment #3) > > 3. prefWidth of normal list: space is not ignored (not OK, inconsistent with > > case 1) > > Do you have a test case showing this? This case seems to behave correctly to > me. I think the test case I attached in this bug shows this bug. > I suggest that you do that. Thanks for the quick response. I'll do it soon. 164571 7 mitz 2009-11-18 08:08:22 -0800 (In reply to comment #6) > (In reply to comment #4) > > (In reply to comment #3) > > > 3. prefWidth of normal list: space is not ignored (not OK, inconsistent with > > > case 1) > > > > Do you have a test case showing this? This case seems to behave correctly to > > me. > > I think the test case I attached in this bug shows this bug. You’re right! I was testing the wrong thing :) 164579 8 hamaji 2009-11-18 08:28:39 -0800 > You’re right! I was testing the wrong thing :) Yay, it's a very rare case. When the webkit reviewers disagree with me, almost always I'm wrong :) 164583 9 hamaji 2009-11-18 08:36:18 -0800 *** This bug has been marked as a duplicate of bug 23264 *** 43416 2009-11-18 02:01:00 -0800 2009-11-18 02:01:00 -0800 test case with ahem calc-width-with-space.html text/html 1023 hamaji PGhlYWQ+CjxzdHlsZT4KICAgICBvbCB7IG1hcmdpbjogMHB4OyB9Cjwvc3R5bGU+CjxzY3JpcHQ+ CmZ1bmN0aW9uIHJ1bigpCnsKICAgIHZhciByZWYgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgi cmVmIik7CiAgICB2YXIgdGVzdCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXN0Iik7CiAg ICB2YXIgcmVzdWx0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJlc3VsdCIpOwogICAgaWYg KHJlZi5zY3JvbGxIZWlnaHQgPT0gdGVzdC5zY3JvbGxIZWlnaHQpCiAgICAgICAgcmVzdWx0LmFw cGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKCJTVUNDRVNTIikpOwogICAgZWxzZQog ICAgICAgIHJlc3VsdC5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSgiRkFJTEVE IikpOwp9CgppZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQogICAgbGF5b3V0VGVzdENv bnRyb2xsZXIuZHVtcEFzVGV4dCgpOwo8L3NjcmlwdD4KPC9oZWFkPgoKPGJvZHkgb25sb2FkPSJy dW4oKTsiPgoKVGhlc2UgdHdvIGxpbmVzIGxvb2tzIHNhbWUuIE5vdGUgdGhhdCB0aGlzIHRlc3Qg cmVxdWlyZXMgQWhlbSBmb250LgoKPGRpdiBzdHlsZT0iaGVpZ2h0OiAyMHB4OyBvdmVyZmxvdy15 OiBzY3JvbGw7IiBpZD0icmVmIj4KPHRhYmxlIHN0eWxlPSJ3aWR0aDogMzcwcHg7IGZvbnQ6IDIw cHggQWhlbTsiPgogPHRyPgogIDx0ZD48b2w+PGxpPlhwWCBYcFg8L29sPjwvdGQ+CiAgPHRkPjxv bD48bGk+WHBYIFhwWDwvb2w+PC90ZD4KIDwvdHI+CjwvdGFibGU+CjwvZGl2PgoKPGRpdiBzdHls ZT0iaGVpZ2h0OiAyMHB4OyBvdmVyZmxvdy15OiBzY3JvbGw7IiBpZD0idGVzdCI+Cjx0YWJsZSBz dHlsZT0id2lkdGg6IDM3MHB4OyBmb250OiAyMHB4IEFoZW07Ij4KIDx0cj4KICA8dGQ+PG9sPjxs aT4gWHBYIFhwWDwvb2w+PC90ZD4KICA8dGQ+PG9sPjxsaT5YcFggWHBYPC9vbD48L3RkPgogPC90 cj4KPC90YWJsZT4KPC9kaXY+Cgo8ZGl2IGlkPSJyZXN1bHQiPgo8L2Rpdj4KCjwvYm9keT4K 43417 2009-11-18 02:05:36 -0800 2009-11-18 07:47:43 -0800 Patch v1 bug-31619-20091118190534.patch text/plain 4254 hamaji ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyYTExNjBjLi4xZWJhNDhjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTEt MTggIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGl0ZXNwYWNlcyBhZnRlciBh IGxpc3QgbWFya2VyIGlzbid0IGlnbm9yZWQgaW4gY2FsY0lubGluZVByZWZXaWR0aHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNjE5CisKKyAgICAg ICAgKiBmYXN0L2xpc3RzL2NhbGMtd2lkdGgtd2l0aC1zcGFjZS1leHBlY3RlZC50eHQ6IEFkZGVk LgorICAgICAgICAqIGZhc3QvbGlzdHMvY2FsYy13aWR0aC13aXRoLXNwYWNlLmh0bWw6IEFkZGVk LgorCiAyMDA5LTExLTE3ICBIYXlhdG8gSXRvICA8aGF5YXRvQGdvb2dsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L2xpc3RzL2NhbGMtd2lkdGgtd2l0aC1zcGFjZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9m YXN0L2xpc3RzL2NhbGMtd2lkdGgtd2l0aC1zcGFjZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMDUxOWE3MgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL2Zhc3QvbGlzdHMvY2FsYy13aWR0aC13aXRoLXNwYWNlLWV4cGVjdGVkLnR4dApAQCAt MCwwICsxLDYgQEAKK1RoZXNlIHR3byBsaW5lcyBzaG91bGQgbG9vayBzYW1lIGFzIHNwYWNlcyBh ZnRlciBhIGxpc3QgbWFya2VyIHNob3VsZCBiZSBpZ25vcmVkLiBUaGVyZSBhcmUgMTggY2hhcmFj dGVycyBpbiBlYWNoIGxpbmUuIEFzIHRoZXkgYXJlIDIwcHggd2lkdGgsIHRoZSB0b3RhbCB3aWR0 aCBzaG91bGQgYmUgMzYwcHggKyBhIGZldyBwaXhlbHMgZm9yIHRhYmxlLiBJZiB0aGUgc3BhY2Ug Y2hhcmFjdGVyIGFmdGVyIHRoZSBsaXN0IG1hcmtlciBpbiAidGVzdCIgaXNuJ3QgaWdub3JlZCwg dGhlIG51bWJlciBvZiBjaGFyYWN0ZXJzIGJlY29tZSAxOSBhbmQgMzcwcHggZGl2IHdpbGwgYmUg b3ZlcmZsb3dlZC4gTm90ZSB0aGF0IHRoaXMgdGVzdCByZXF1aXJlcyBBaGVtIGZvbnQuCitYcFgg WHBYCitYcFggWHBYCitYcFggWHBYCitYcFggWHBYCitTVUNDRVNTCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mYXN0L2xpc3RzL2NhbGMtd2lkdGgtd2l0aC1zcGFjZS5odG1sIGIvTGF5b3V0VGVz dHMvZmFzdC9saXN0cy9jYWxjLXdpZHRoLXdpdGgtc3BhY2UuaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwLi42MDdkMjQwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9saXN0cy9jYWxjLXdpZHRoLXdpdGgtc3BhY2UuaHRtbApAQCAtMCwwICsxLDU0IEBA Cis8aGVhZD4KKzxzdHlsZT4KKyAgICAgb2wgeyBtYXJnaW46IDBweDsgfQorPC9zdHlsZT4KKzxz Y3JpcHQ+CitmdW5jdGlvbiBydW4oKQoreworICAgIC8vIENoZWNrIGlmIHRoZSB0d28gZGl2cyBh cmVuJ3Qgb3ZlcmZsb3dlZCBieSBjaGVja2luZyB0aGV5IGhhdmUKKyAgICAvLyB0aGUgc2FtZSBo ZWlnaHQuCisgICAgdmFyIHJlZiA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZWYiKTsKKyAg ICB2YXIgdGVzdCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXN0Iik7CisgICAgdmFyIHJl c3VsdCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHQiKTsKKyAgICBpZiAocmVmLnNj cm9sbEhlaWdodCA9PSB0ZXN0LnNjcm9sbEhlaWdodCkKKyAgICAgICAgcmVzdWx0LmFwcGVuZENo aWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKCJTVUNDRVNTIikpOworICAgIGVsc2UKKyAgICAg ICAgcmVzdWx0LmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKCJGQUlMRUQiKSk7 Cit9CisKK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgbGF5b3V0VGVzdENv bnRyb2xsZXIuZHVtcEFzVGV4dCgpOworPC9zY3JpcHQ+Cis8L2hlYWQ+CisKKzxib2R5IG9ubG9h ZD0icnVuKCk7Ij4KKworVGhlc2UgdHdvIGxpbmVzIHNob3VsZCBsb29rIHNhbWUgYXMgc3BhY2Vz IGFmdGVyIGEgbGlzdCBtYXJrZXIgc2hvdWxkCitiZSBpZ25vcmVkLiBUaGVyZSBhcmUgMTggY2hh cmFjdGVycyBpbiBlYWNoIGxpbmUuIEFzIHRoZXkgYXJlIDIwcHgKK3dpZHRoLCB0aGUgdG90YWwg d2lkdGggc2hvdWxkIGJlIDM2MHB4ICsgYSBmZXcgcGl4ZWxzIGZvciB0YWJsZS4KK0lmIHRoZSBz cGFjZSBjaGFyYWN0ZXIgYWZ0ZXIgdGhlIGxpc3QgbWFya2VyIGluICJ0ZXN0IiBpc24ndCBpZ25v cmVkLAordGhlIG51bWJlciBvZiBjaGFyYWN0ZXJzIGJlY29tZSAxOSBhbmQgMzcwcHggZGl2IHdp bGwgYmUgb3ZlcmZsb3dlZC4KK05vdGUgdGhhdCB0aGlzIHRlc3QgcmVxdWlyZXMgQWhlbSBmb250 LgorCis8ZGl2IHN0eWxlPSJoZWlnaHQ6IDIwcHg7IG92ZXJmbG93LXk6IHNjcm9sbDsiIGlkPSJy ZWYiPgorPHRhYmxlIHN0eWxlPSJ3aWR0aDogMzcwcHg7IGZvbnQ6IDIwcHggQWhlbTsiPgorIDx0 cj4KKyAgPHRkPjxvbD48bGk+WHBYIFhwWDwvb2w+PC90ZD4KKyAgPHRkPjxvbD48bGk+WHBYIFhw WDwvb2w+PC90ZD4KKyA8L3RyPgorPC90YWJsZT4KKzwvZGl2PgorCis8ZGl2IHN0eWxlPSJoZWln aHQ6IDIwcHg7IG92ZXJmbG93LXk6IHNjcm9sbDsiIGlkPSJ0ZXN0Ij4KKzx0YWJsZSBzdHlsZT0i d2lkdGg6IDM3MHB4OyBmb250OiAyMHB4IEFoZW07Ij4KKyA8dHI+CisgIDx0ZD48b2w+PGxpPiBY cFggWHBYPC9vbD48L3RkPgorICA8dGQ+PG9sPjxsaT5YcFggWHBYPC9vbD48L3RkPgorIDwvdHI+ Cis8L3RhYmxlPgorPC9kaXY+CisKKzxkaXYgaWQ9InJlc3VsdCI+Cis8L2Rpdj4KKworPC9ib2R5 PgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCBjMWY1ZWNiLi5hNWZjYjUxIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDA5LTExLTE4ICBTaGluaWNoaXJv IEhhbWFqaSAgPGhhbWFqaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2hpdGVzcGFjZXMgYWZ0ZXIgYSBsaXN0IG1hcmtlciBp c24ndCBpZ25vcmVkIGluIGNhbGNJbmxpbmVQcmVmV2lkdGhzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTYxOQorCisgICAgICAgIFRlc3Q6IGZhc3Qv bGlzdHMvY2FsYy13aWR0aC13aXRoLXNwYWNlLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJCbG9jay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6Y2FsY0lubGlu ZVByZWZXaWR0aHMpOgorCiAyMDA5LTExLTE3ICBOaWNvbGFzIFdlYmVyICA8dGhha2lzQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCmRpZmYgLS1naXQg YS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAgYi9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCbG9jay5jcHAKaW5kZXggYTg0MDdkMS4uOWQ4YzM1MSAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJsb2NrLmNwcApAQCAtNDIwNiw2ICs0MjA2LDEwIEBAIHZvaWQgUmVuZGVyQmxvY2s6OmNhbGNJ bmxpbmVQcmVmV2lkdGhzKCkKICAgICAgICAgICAgICAgICB9IGVsc2UKICAgICAgICAgICAgICAg ICAgICAgaW5saW5lTWF4ICs9IGNoaWxkTWF4OwogICAgICAgICAgICAgfQorCisgICAgICAgICAg ICAvLyBJZ25vcmUgc3BhY2VzIGFmdGVyIGEgbGlzdCBtYXJrZXIuCisgICAgICAgICAgICBpZiAo Y2hpbGQtPmlzTGlzdE1hcmtlcigpKQorICAgICAgICAgICAgICAgIHN0cmlwRnJvbnRTcGFjZXMg PSB0cnVlOwogICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgbV9taW5QcmVmV2lkdGggPSBt YXgoaW5saW5lTWluLCBtX21pblByZWZXaWR0aCk7CiAgICAgICAgICAgICBtX21heFByZWZXaWR0 aCA9IG1heChpbmxpbmVNYXgsIG1fbWF4UHJlZldpZHRoKTsK