31616 2009-11-17 22:43:26 -0800 [Chromium] Some minor cleanup in the Chromium WebKit API 2009-11-18 13:49:28 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fishd fishd oldest_to_newest 164459 0 fishd 2009-11-17 22:43:26 -0800 [Chromium] Some minor cleanup in the Chromium WebKit API There are missing WEBKIT_API decorations in WebNode.h and WebFormElement.h, which are used to annotate methods that should be exported from WebKit.dll. We should make WebNode::action() be a const method. We should utilize WebFrameImpl::fromFrame() to simplify code in WebNode::frame(). 164460 1 43405 fishd 2009-11-17 22:45:36 -0800 Created attachment 43405 v1 patch 164697 2 fishd 2009-11-18 13:49:28 -0800 Landed as http://trac.webkit.org/changeset/51130 43405 2009-11-17 22:45:36 -0800 2009-11-17 23:28:59 -0800 v1 patch wk_1.txt text/plain 3266 fishd SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA1MTEwMSkKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0xMS0xNyAgRGFy aW4gRmlzaGVyICA8ZGFyaW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE1pbm9yIGNsZWFudXAgaW4gV2ViS2l0IEFQSQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE2MTYKKworICAg ICAgICAqIHB1YmxpYy9XZWJGb3JtRWxlbWVudC5oOiBBZGQgbWlzc2luZyBXRUJLSVRfQVBJIHBy ZWZpeC4KKyAgICAgICAgKiBwdWJsaWMvV2ViTm9kZS5oOiBBZGQgbWlzc2luZyBXRUJLSVRfQVBJ IHByZWZpeC4KKyAgICAgICAgKiBzcmMvV2ViRm9ybUVsZW1lbnQuY3BwOgorICAgICAgICAoV2Vi S2l0OjpXZWJGb3JtRWxlbWVudDo6YWN0aW9uKTogTWFrZSBhY3Rpb24gZ2V0dGVyIGNvbnN0Lgor ICAgICAgICAqIHNyYy9XZWJOb2RlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViTm9kZTo6ZnJh bWUpOiBVdGlsaXplIFdlYkZyYW1lSW1wbDo6ZnJvbUZyYW1lLgorCiAyMDA5LTExLTE3ICBOaWNv bGFzIFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBE YXJpbiBGaXNoZXIsIERtaXRyeSBUaXRvdi4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViRm9ybUVsZW1lbnQuaA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViRm9ybUVsZW1lbnQuaAkocmV2aXNpb24gNTExMDEpCisrKyBXZWJLaXQvY2hyb21pdW0vcHVi bGljL1dlYkZvcm1FbGVtZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTU4LDEwICs1OCwxMCBAQCBu YW1lc3BhY2UgV2ViS2l0IHsKICAgICAgICAgb3BlcmF0b3IgV1RGOjpQYXNzUmVmUHRyPFdlYkNv cmU6OkhUTUxGb3JtRWxlbWVudD4oKSBjb25zdDsKICNlbmRpZgogCi0gICAgICAgIGJvb2wgYXV0 b0NvbXBsZXRlKCkgY29uc3Q7Ci0gICAgICAgIFdlYlN0cmluZyBhY3Rpb24oKTsKLSAgICAgICAg dm9pZCBzdWJtaXQoKTsKLSAgICAgICAgdm9pZCBnZXROYW1lZEVsZW1lbnRzKGNvbnN0IFdlYlN0 cmluZyYsIFdlYlZlY3RvcjxXZWJOb2RlPiYpOworICAgICAgICBXRUJLSVRfQVBJIGJvb2wgYXV0 b0NvbXBsZXRlKCkgY29uc3Q7CisgICAgICAgIFdFQktJVF9BUEkgV2ViU3RyaW5nIGFjdGlvbigp IGNvbnN0OworICAgICAgICBXRUJLSVRfQVBJIHZvaWQgc3VibWl0KCk7CisgICAgICAgIFdFQktJ VF9BUEkgdm9pZCBnZXROYW1lZEVsZW1lbnRzKGNvbnN0IFdlYlN0cmluZyYsIFdlYlZlY3RvcjxX ZWJOb2RlPiYpOwogICAgIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdApJbmRleDogV2ViS2l0 L2Nocm9taXVtL3B1YmxpYy9XZWJOb2RlLmgNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYk5vZGUuaAkocmV2aXNpb24gNTExMDEpCisrKyBXZWJLaXQvY2hyb21pdW0v cHVibGljL1dlYk5vZGUuaAkod29ya2luZyBjb3B5KQpAQCAtNjgsNyArNjgsNyBAQCBwdWJsaWM6 CiAKICAgICBXRUJLSVRfQVBJIFdlYk5vZGUgcGFyZW50Tm9kZSgpIGNvbnN0OwogICAgIFdFQktJ VF9BUEkgV2ViU3RyaW5nIG5vZGVOYW1lKCkgY29uc3Q7Ci0gICAgV2ViRnJhbWUqIGZyYW1lKCk7 CisgICAgV0VCS0lUX0FQSSBXZWJGcmFtZSogZnJhbWUoKTsKIAogICAgIHRlbXBsYXRlPHR5cGVu YW1lIFQ+IFQgdG9FbGVtZW50KCkKICAgICB7CkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dl YkZvcm1FbGVtZW50LmNwcA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2Vi Rm9ybUVsZW1lbnQuY3BwCShyZXZpc2lvbiA1MTEwMSkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMv V2ViRm9ybUVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NCw5ICs2NCw5IEBAIGJvb2wg V2ViRm9ybUVsZW1lbnQ6OmF1dG9Db21wbGV0ZSgpIGNvbnMKICAgICByZXR1cm4gY29uc3RVbndy YXA8SFRNTEZvcm1FbGVtZW50PigpLT5hdXRvQ29tcGxldGUoKTsKIH0KIAotV2ViU3RyaW5nIFdl YkZvcm1FbGVtZW50OjphY3Rpb24oKQorV2ViU3RyaW5nIFdlYkZvcm1FbGVtZW50OjphY3Rpb24o KSBjb25zdAogewotICAgIHJldHVybiB1bndyYXA8SFRNTEZvcm1FbGVtZW50PigpLT5hY3Rpb24o KTsKKyAgICByZXR1cm4gY29uc3RVbndyYXA8SFRNTEZvcm1FbGVtZW50PigpLT5hY3Rpb24oKTsK IH0KIAogdm9pZCBXZWJGb3JtRWxlbWVudDo6c3VibWl0KCkKSW5kZXg6IFdlYktpdC9jaHJvbWl1 bS9zcmMvV2ViTm9kZS5jcHANCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL1dl Yk5vZGUuY3BwCShyZXZpc2lvbiA1MTEwMSkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViTm9k ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk3LDEwICs5Nyw3IEBAIHZvaWQgV2ViTm9kZTo6YXNz aWduKFdlYk5vZGVQcml2YXRlKiBwKQogCiBXZWJGcmFtZSogV2ViTm9kZTo6ZnJhbWUoKQogewot ICAgIEZyYW1lTG9hZGVyQ2xpZW50SW1wbCogZnJhbWVfbG9hZGVyX2NsaWVudCA9Ci0gICAgICAg IHN0YXRpY19jYXN0PEZyYW1lTG9hZGVyQ2xpZW50SW1wbCo+KG1fcHJpdmF0ZS0+ZG9jdW1lbnQo KS0+Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZyYW1lKCkt PmxvYWRlcigpLT5jbGllbnQoKSk7Ci0gICAgcmV0dXJuIHN0YXRpY19jYXN0PFdlYkZyYW1lKj4o ZnJhbWVfbG9hZGVyX2NsaWVudC0+d2ViRnJhbWUoKSk7CisgICAgcmV0dXJuIFdlYkZyYW1lSW1w bDo6ZnJvbUZyYW1lKG1fcHJpdmF0ZS0+ZG9jdW1lbnQoKS0+ZnJhbWUoKSk7CiB9CiAKIH0gLy8g bmFtZXNwYWNlIFdlYktpdAo=