<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>316129</bug_id>
          
          <creation_ts>2026-06-02 14:28:54 -0700</creation_ts>
          <short_desc>[CMake] Enable -Wunused-parameter on Cocoa to match Xcode</short_desc>
          <delta_ts>2026-06-03 17:05:15 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CMake</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="zak ridouh">zakr</reporter>
          <assigned_to name="zak ridouh">zakr</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2216907</commentid>
    <comment_count>0</comment_count>
    <who name="zak ridouh">zakr</who>
    <bug_when>2026-06-02 14:28:54 -0700</bug_when>
    <thetext>The Cocoa CMake build globally suppressed -Wunused-parameter via
-Wno-unused-parameter in OptionsCocoa.cmake, even though -Wall -Wextra
already enables it. Xcode enables the warning everywhere (-Wextra in
CommonBase.xcconfig, treated as an error) and opts specific projects out
per-target via WK_FIXME_WARNING_CFLAGS.

Drop the blanket suppression so WTF, JavaScriptCore, WebCore, and PAL
warn like they do under Xcode, and add per-target opt-outs mirroring the
projects Xcode still exempts: WebKit (already present), WebKitLegacy,
DumpRenderTree, ImageDiff, and MiniBrowser. TestWebKitAPI and
WebKitTestRunner already opt out; the third-party targets build with -w.

WebKitLegacy&apos;s existing opt-out used add_compile_options(), which runs
after WEBKIT_FRAMEWORK_DECLARE creates the target and so never applied;
switch it to the target-scoped WEBKIT_ADD_TARGET_CXX_FLAGS form.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2216908</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2026-06-02 14:29:00 -0700</bug_when>
    <thetext>&lt;rdar://problem/178557623&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2216909</commentid>
    <comment_count>2</comment_count>
    <who name="zak ridouh">zakr</who>
    <bug_when>2026-06-02 14:32:04 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/66293</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2217429</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2026-06-03 17:05:14 -0700</bug_when>
    <thetext>Committed 314510@main (8d287629f85e): &lt;https://commits.webkit.org/314510@main&gt;

Reviewed commits have been landed. Closing PR #66293 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>