31612 2009-11-17 19:17:46 -0800 two layout tests assume java is disabled 2009-11-18 11:37:02 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED WONTFIX P2 Normal --- 1 dpranke dpranke mrowe oldest_to_newest 164416 0 dpranke 2009-11-17 19:17:46 -0800 Two layout tests ( fast/replaced/applet-disabled-positioned.html and fast/replaced/applet-rendering-java-disabled.html ) assume that java is disabled by default. This is true for Safari but isn't necessarily true in general (i.e., it isn't true for Chromium). The layoutTestController has hooks to control enabling / disabling Java, so we should use those. 164417 1 43396 dpranke 2009-11-17 19:19:57 -0800 Created attachment 43396 patch to the two test files. 164421 2 43396 mrowe 2009-11-17 19:34:44 -0800 Comment on attachment 43396 patch to the two test files. DumpRenderTree is expected to disable Java. See: WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm:407: [preferences setJavaEnabled:NO]; WebKitTools/DumpRenderTree/win/DumpRenderTree.cpp:723: preferences->setJavaEnabled(FALSE); 164433 3 dpranke 2009-11-17 20:58:32 -0800 That doesn't seem like a good thing. It means you can't actually test anything with applets in it, right? In particular, fast/dom/java-applet-calls.html has expected output that expects java to be disabled. Wouldn't it be better to actually have tests that make sure this works? I also saw a comment that these tests were intentionally done this way because DRT hangs when trying to load the JVM (dom/level2/html/AppletsCollection.html). It seems like it would be better to track that as a bug with failing tests rather than assume that this will never work. 164447 4 mrowe 2009-11-17 21:41:22 -0800 (In reply to comment #3) > That doesn't seem like a good thing. It means you can't actually test anything > with applets in it, right? I’m not sure why you think that. Whatever subset of tests that require Java could easily opt in to enabling it. > In particular, fast/dom/java-applet-calls.html has expected output that expects > java to be disabled. Wouldn't it be better to actually have tests that make > sure this works? > > I also saw a comment that these tests were intentionally done this way because > DRT hangs when trying to load the JVM (dom/level2/html/AppletsCollection.html). > It seems like it would be better to track that as a bug with failing tests > rather than assume that this will never work. I’m not sure how this relates to the statement I made. 164455 5 dpranke 2009-11-17 22:17:23 -0800 Ah, perhaps I misunderstood you. I thought you were saying that java should always be disabled in DRT. You're merely saying that we should assume disabled but can write tests to enable it if we like? 164457 6 mrowe 2009-11-17 22:28:47 -0800 (In reply to comment #5) > Ah, perhaps I misunderstood you. I thought you were saying that java should > always be disabled in DRT. You're merely saying that we should assume disabled > but can write tests to enable it if we like? I’m saying that the Chromium DRT should use the same settings that other ports use. Tests that need to test other functionality should enable it explicitly. 164477 7 dpranke 2009-11-18 00:00:02 -0800 Got it. Thanks for the clarification. 164478 8 dpranke 2009-11-18 00:00:34 -0800 I'll close this as WONTFIX, then. 43396 2009-11-17 19:19:57 -0800 2009-11-17 19:34:44 -0800 patch to the two test files. wk31612.diff text/plain 2108 dpranke SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUxMDk5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTEtMTcgIERpcmsgUHJhbmtlICA8ZHBy YW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkIGxheW91dFRlc3RDb250cm9sbGVyLm92ZXJyaWRlUHJlZmVyZW5jZSgi V2ViS2l0SmF2YUVuYWJsZWQiLCBmYWxzZSkgdG8gdGhlc2UgdHdvIHRlc3RzIHNvIHRoYXQgd2Ug YXJlIG5vdCBkZXBlbmRlbnQgb24gY3VycmVudCBvciBkZWZhdWx0IHByZWZlcmVuY2VzIGZvciB0 aGlzIHRlc3QuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zMTYxMgorCisgICAgICAgICogZmFzdC9yZXBsYWNlZC9hcHBsZXQtZGlzYWJsZWQtcG9zaXRp b25lZC5odG1sOgorICAgICAgICAqIGZhc3QvcmVwbGFjZWQvYXBwbGV0LXJlbmRlcmluZy1qYXZh LWRpc2FibGVkLmh0bWw6CisKIDIwMDktMTEtMTcgIEpvaG5ueSBEaW5nICA8am5kQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IExheW91dFRl c3RzL2Zhc3QvcmVwbGFjZWQvYXBwbGV0LWRpc2FibGVkLXBvc2l0aW9uZWQuaHRtbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3JlcGxhY2VkL2FwcGxldC1kaXNhYmxlZC1wb3NpdGlv bmVkLmh0bWwJKHJldmlzaW9uIDUxMDk3KQorKysgTGF5b3V0VGVzdHMvZmFzdC9yZXBsYWNlZC9h cHBsZXQtZGlzYWJsZWQtcG9zaXRpb25lZC5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEs OCBAQAorPHNjcmlwdD4KK2lmIChsYXlvdXRUZXN0Q29udHJvbGxlcikgeworICBsYXlvdXRUZXN0 Q29udHJvbGxlci5vdmVycmlkZVByZWZlcmVuY2UoIldlYktpdEphdmFFbmFibGVkIiwgZmFsc2Up OworfQorPC9zY3JpcHQ+CiA8cD4KICAgICBUZXN0IGZvciA8aT48YSBocmVmPSJodHRwOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA5MSI+aHR0cDovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTUwOTE8L2E+CiAgICAgQ3Jhc2ggaW4gUmVuZGVyQmxvY2s6OnNr aXBXaGl0ZXNwYWNlICBkdXJpbmcgbGF5b3V0PC9pPi4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qv cmVwbGFjZWQvYXBwbGV0LXJlbmRlcmluZy1qYXZhLWRpc2FibGVkLmh0bWwKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvZmFzdC9yZXBsYWNlZC9hcHBsZXQtcmVuZGVyaW5nLWphdmEtZGlzYWJs ZWQuaHRtbAkocmV2aXNpb24gNTEwOTcpCisrKyBMYXlvdXRUZXN0cy9mYXN0L3JlcGxhY2VkL2Fw cGxldC1yZW5kZXJpbmctamF2YS1kaXNhYmxlZC5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsOCBAQAorPHNjcmlwdD4KK2lmIChsYXlvdXRUZXN0Q29udHJvbGxlcikgeworICBsYXlvdXRU ZXN0Q29udHJvbGxlci5vdmVycmlkZVByZWZlcmVuY2UoIldlYktpdEphdmFFbmFibGVkIiwgZmFs c2UpOworfQorPC9zY3JpcHQ+CiA8cD5UZXN0IGZvciA8YSBocmVmPSJodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI4MSI+aHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4u b3JnL3Nob3dfYnVnLmNnaT9pZD03MjgxPC9hPjwvcD4KIDxwPlRoaXMgdGVzdHMgcmVuZGVyaW5n IG9mIGFuIGFwcGxldCBlbGVtZW50IHdpdGggSmF2YSBkaXNhYmxlZC4gSWYgSmF2YSBpcyBkaXNh YmxlZCBhbmQgU2FmYXJpIHNob3dzIHRoZSBjb250ZW50IGluIHRoZSBhcHBsZXQgdGFnLCB0aGVu IHRoZSB0ZXN0IHBhc3NlZC48L3A+CiA8YXBwbGV0IGNvZGU9IiI+U1VDQ0VTUzwvYXBwbGV0Pgo=