31609 2009-11-17 17:34:28 -0800 Chrome/mac crashes when opening a popup, waiting until the webpage in the background switches, and then clicking the popup 2009-11-17 23:13:18 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 thakis webkit-unassigned fishd mark oldest_to_newest 164406 0 thakis 2009-11-17 17:34:28 -0800 See http://code.google.com/p/chromium/issues/detail?id=23869 for details. 164407 1 43394 thakis 2009-11-17 17:36:21 -0800 Created attachment 43394 Patch. 164438 2 43394 fishd 2009-11-17 21:19:29 -0800 Comment on attachment 43394 Patch. > Index: WebCore/platform/chromium/PopupMenuChromium.cpp ... > + // The popup sends its "closed" notification through its parentx Set the ^^^ typo > + // parent, even though external popups have no real on-screen widget but a > + // native menu (see |PopupListBox::hidePopup()|); > + if (!m_listBox->parent()) > + addChild(m_listBox.get()); Why would m_listBox's parent not be null? R- for the typo 164443 3 43401 thakis 2009-11-17 21:31:48 -0800 Created attachment 43401 Fix type 164444 4 thakis 2009-11-17 21:34:01 -0800 Heh, typo in "Fix typo". Nice. > Why would m_listBox's parent not be null? I was surprised too, but the branch for regular popups (PopupContainer::showPopup()) checks this too. So I figured it's safer to check this here as well. 164461 5 fishd 2009-11-17 22:51:44 -0800 Landed as http://trac.webkit.org/changeset/51102 164471 6 mark 2009-11-17 23:13:18 -0800 I'm working off a tree from yesterday and I just wound up having to make this change to fix http://crbug.com/27723. Then I went to merge my work into WebKit so I could get it landed here and I got a merge conflict because you already hit this. Excellent! (Yeah, this is the correct fix.) 43394 2009-11-17 17:36:21 -0800 2009-11-17 21:31:48 -0800 Patch. webkit_popup.diff text/plain 1600 thakis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTA5OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMTEtMTcgIE5pY29sYXMgV2ViZXIgIDx0aGFraXNAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEZpeCBjcmFzaCBpbiBDaHJvbWl1bS9NYWMgd2hlcmUgZHJvcGRvd25zIHdlcmVuJ3QgZGlzbWlz c2VkIGNvcnJlY3RseQorICAgICAgICBhZnRlciBuYXZpZ2F0aW9uLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE2MDkKKworICAgICAgICAqIHBsYXRm b3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBv cHVwQ29udGFpbmVyOjpzaG93RXh0ZXJuYWwpOgorICAgICAgICBTZXQgcGFyZW50IGZvciBleHRl cm5hbCBkcm9wZG93bnMsIHNvIHRoYXQgfFBvcHVwTGlzdEJveDo6aGlkZVBvcHVwKCl8CisgICAg ICAgIGNhbiBzdWNjZXNzZnVsbHkgbm90aWZ5IGl0cyBwYXJlbnQncyBjbGllbnQuCisKKwogMjAw OS0xMS0xNyAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UnViYmVyLXN0YW1wZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KSW5kZXg6IFdlYkNvcmUvcGxh dGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCShyZXZpc2lvbiA1MTA5 OSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0zNzAsNiArMzcwLDEyIEBAIHZvaWQgUG9wdXBDb250YWluZXI6OnNo b3dFeHRlcm5hbChjb25zdCAKICAgICBDaHJvbWVDbGllbnRDaHJvbWl1bSogY2xpZW50ID0gc3Rh dGljX2Nhc3Q8Q2hyb21lQ2xpZW50Q2hyb21pdW0qPigKICAgICAgICAgIHYtPmZyYW1lKCktPnBh Z2UoKS0+Y2hyb21lKCktPmNsaWVudCgpKTsKICAgICBjbGllbnQtPnBvcHVwT3BlbmVkKHRoaXMs IHBvcHVwUmVjdCwgdHJ1ZSwgdHJ1ZSk7CisKKyAgICAvLyBUaGUgcG9wdXAgc2VuZHMgaXRzICJj bG9zZWQiIG5vdGlmaWNhdGlvbiB0aHJvdWdoIGl0cyBwYXJlbnR4IFNldCB0aGUKKyAgICAvLyBw YXJlbnQsIGV2ZW4gdGhvdWdoIGV4dGVybmFsIHBvcHVwcyBoYXZlIG5vIHJlYWwgb24tc2NyZWVu IHdpZGdldCBidXQgYQorICAgIC8vIG5hdGl2ZSBtZW51IChzZWUgfFBvcHVwTGlzdEJveDo6aGlk ZVBvcHVwKCl8KTsKKyAgICBpZiAoIW1fbGlzdEJveC0+cGFyZW50KCkpCisgICAgICAgIGFkZENo aWxkKG1fbGlzdEJveC5nZXQoKSk7CiB9CiAKIHZvaWQgUG9wdXBDb250YWluZXI6OmhpZGVQb3B1 cCgpCg== 43401 2009-11-17 21:31:48 -0800 2009-11-17 22:47:09 -0800 Fix type webkit_popup.diff text/plain 1566 thakis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTA5OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMTEtMTcgIE5pY29sYXMgV2ViZXIgIDx0aGFraXNAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEZpeCBjcmFzaCBpbiBDaHJvbWl1bS9NYWMgd2hlcmUgZHJvcGRvd25zIHdlcmVuJ3QgZGlzbWlz c2VkIGNvcnJlY3RseQorICAgICAgICBhZnRlciBuYXZpZ2F0aW9uLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE2MDkKKworICAgICAgICAqIHBsYXRm b3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBv cHVwQ29udGFpbmVyOjpzaG93RXh0ZXJuYWwpOgorICAgICAgICBTZXQgcGFyZW50IGZvciBleHRl cm5hbCBkcm9wZG93bnMsIHNvIHRoYXQgfFBvcHVwTGlzdEJveDo6aGlkZVBvcHVwKCl8CisgICAg ICAgIGNhbiBzdWNjZXNzZnVsbHkgbm90aWZ5IGl0cyBwYXJlbnQncyBjbGllbnQuCisKKwogMjAw OS0xMS0xNyAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UnViYmVyLXN0YW1wZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KSW5kZXg6IFdlYkNvcmUvcGxh dGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCShyZXZpc2lvbiA1MTA5 OSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0zNzAsNiArMzcwLDEyIEBAIHZvaWQgUG9wdXBDb250YWluZXI6OnNo b3dFeHRlcm5hbChjb25zdCAKICAgICBDaHJvbWVDbGllbnRDaHJvbWl1bSogY2xpZW50ID0gc3Rh dGljX2Nhc3Q8Q2hyb21lQ2xpZW50Q2hyb21pdW0qPigKICAgICAgICAgIHYtPmZyYW1lKCktPnBh Z2UoKS0+Y2hyb21lKCktPmNsaWVudCgpKTsKICAgICBjbGllbnQtPnBvcHVwT3BlbmVkKHRoaXMs IHBvcHVwUmVjdCwgdHJ1ZSwgdHJ1ZSk7CisKKyAgICAvLyBUaGUgcG9wdXAgc2VuZHMgaXRzICJj bG9zZWQiIG5vdGlmaWNhdGlvbiB0aHJvdWdoIGl0cyBwYXJlbnQuIFNldCB0aGUKKyAgICAvLyBw YXJlbnQsIGV2ZW4gdGhvdWdoIGV4dGVybmFsIHBvcHVwcyBoYXZlIG5vIHJlYWwgb24tc2NyZWVu IHdpZGdldCBidXQgYQorICAgIC8vIG5hdGl2ZSBtZW51IChzZWUgfFBvcHVwTGlzdEJveDo6aGlk ZVBvcHVwKCl8KTsKKyAgICBpZiAoIW1fbGlzdEJveC0+cGFyZW50KCkpCisgICAgICAgIGFkZENo aWxkKG1fbGlzdEJveC5nZXQoKSk7CiB9CiAK