31604 2009-11-17 16:38:27 -0800 WebSocket server should write errors to a log file 2009-12-01 10:57:16 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 31861 1 mrowe webkit-unassigned abarth ap levin yuzo oldest_to_newest 164387 0 mrowe 2009-11-17 16:38:27 -0800 It’s currently difficult to work out what is going wrong if the WebSocket server fails to start. If it wrote its errors to a log file in a similar fashion to what Apache does it would be easier to debug issues that only happen on inaccessible machines (eg, the build bots). 164481 1 yuzo 2009-11-18 00:23:37 -0800 Hi, I've started addressing this upstream: http://code.google.com/p/pywebsocket/issues/detail?id=24 After it is done upstream, I'll upload a WebKit patch to upgrade the pywebsocket copy in WebKitTools to the latest. Yuzo 166661 2 43898 yuzo 2009-11-25 23:32:35 -0800 Created attachment 43898 Make pywebsocket log errors to a file 166662 3 yuzo 2009-11-25 23:34:22 -0800 Hi, reviewers, Can you review this patch? Yuzo 166745 4 levin 2009-11-26 09:50:07 -0800 Since this is perl, I'd prefer if someone else looked at it. (btw, Yuzo, it is a holiday in the US for Thursday and Friday so expect slower responses.) 167104 5 43898 eric 2009-11-29 13:52:02 -0800 Comment on attachment 43898 Make pywebsocket log errors to a file Looks OK, but why are we coyping this code from elsewhere? It should be abstracted into a sub routine. I see this in the file already: 1380 my $absTestResultsDirectory = File::Spec->rel2abs(glob $testResultsDirectory); 1381 my $sslCertificate = "$testDirectory/http/conf/webkit-httpd.pem"; 1382 1383 mkpath $absTestResultsDirectory; 167146 6 43999 yuzo 2009-11-29 17:48:08 -0800 Created attachment 43999 Make pywebsocket log errors to a file 167147 7 yuzo 2009-11-29 17:53:08 -0800 Thank you for reviewing this. Refactored by extracting a method. Can you take another look? Yuzo 167153 8 44002 yuzo 2009-11-29 18:07:14 -0800 Created attachment 44002 Make pywebsocket log errors to a file 167380 9 abarth 2009-11-30 12:48:35 -0800 style-queue ran check-webkit-style on attachment 44002 without any errors. 167674 10 44002 ap 2009-12-01 10:48:29 -0800 Comment on attachment 44002 Make pywebsocket log errors to a file r=me I'll try to think of a better name for makeAbsTestResultsDirectory(), and will land manually. The current name is not great for several reasons: - we don't like abbreviations in names; - it's not an "absolute directory" that this method makes; - nothing in the name suggests that there will be a return value. 167676 11 ap 2009-12-01 10:57:16 -0800 Committed <http://trac.webkit.org/changeset/51550>. I also updated ChangeLog to be more useful to readers. 43898 2009-11-25 23:32:35 -0800 2009-11-29 17:48:01 -0800 Make pywebsocket log errors to a file bug-31604-20091126163233.patch text/plain 1482 yuzo ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBmYmUyNWNkLi5iNjA2ODNjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMDktMTEt MjUgIFl1em8gRnVqaXNoaW1hICA8eXV6b0Bnb29nbGUuY29tPgogCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgcHl3ZWJzb2NrZXQgbG9nIGVycm9y cyB0byBhIGZpbGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTMxNjA0CisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi13ZWJraXQtdGVzdHM6CisKKzIwMDkt MTEtMjUgIFl1em8gRnVqaXNoaW1hICA8eXV6b0Bnb29nbGUuY29tPgorCiAgICAgICAgIFJldmll d2VkIGJ5IEVyaWMgU2VpZGVsLgogCiAgICAgICAgIFVwZGF0ZSBweXdlYnNvY2tldCB0byAwLjQu MgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzIGIvV2Vi S2l0VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzCmluZGV4IGMyNzE1NmUuLjM0OTM5MmEg MTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cworKysgYi9X ZWJLaXRUb29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMKQEAgLTE0MzQsMTEgKzE0MzQsMTcg QEAgc3ViIG9wZW5XZWJTb2NrZXRTZXJ2ZXJJZk5lZWRlZCgpCiAgICAgbXkgJHdlYlNvY2tldEhh bmRsZXJEaXIgPSAiJHRlc3REaXJlY3RvcnkiOwogICAgIG15ICR3ZWJTb2NrZXRIYW5kbGVyU2Nh bkRpciA9ICIkdGVzdERpcmVjdG9yeS93ZWJzb2NrZXQvdGVzdHMiOwogICAgIG15ICRzc2xDZXJ0 aWZpY2F0ZSA9ICIkdGVzdERpcmVjdG9yeS9odHRwL2NvbmYvd2Via2l0LWh0dHBkLnBlbSI7Cisg ICAgbXkgJGFic1Rlc3RSZXN1bHRzRGlyZWN0b3J5ID0gRmlsZTo6U3BlYy0+cmVsMmFicyhnbG9i ICR0ZXN0UmVzdWx0c0RpcmVjdG9yeSk7CisgICAgbXkgJGxvZ0ZpbGUgPSAiJGFic1Rlc3RSZXN1 bHRzRGlyZWN0b3J5L3B5d2Vic29ja2V0X2xvZy50eHQiOworCisgICAgbWtwYXRoICRhYnNUZXN0 UmVzdWx0c0RpcmVjdG9yeTsKKwogICAgIG15IEBhcmdzID0gKAogICAgICAgICAiV2ViS2l0VG9v bHMvcHl3ZWJzb2NrZXQvbW9kX3B5d2Vic29ja2V0L3N0YW5kYWxvbmUucHkiLAogICAgICAgICAi LXAiLCAiJHdlYlNvY2tldFBvcnQiLAogICAgICAgICAiLWQiLCAiJHdlYlNvY2tldEhhbmRsZXJE aXIiLAogICAgICAgICAiLXMiLCAiJHdlYlNvY2tldEhhbmRsZXJTY2FuRGlyIiwKKyAgICAgICAg Ii1sIiwgIiRsb2dGaWxlIiwKICAgICApOwogICAgICMgd3NzIGlzIGRpc2FibGVkIHVudGlsIGFs bCBwbGF0Zm9ybXMgc3VwcG9ydCBweU9wZW5TU0wuCiAgICAgIyBteSBAYXJnc1NlY3VyZSA9ICgK 43999 2009-11-29 17:48:08 -0800 2009-11-29 18:07:08 -0800 Make pywebsocket log errors to a file bug-31604-20091130104806.patch text/plain 2577 yuzo ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBmYmUyNWNkLi5iNjA2ODNjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMDktMTEt MjUgIFl1em8gRnVqaXNoaW1hICA8eXV6b0Bnb29nbGUuY29tPgogCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgcHl3ZWJzb2NrZXQgbG9nIGVycm9y cyB0byBhIGZpbGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTMxNjA0CisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi13ZWJraXQtdGVzdHM6CisKKzIwMDkt MTEtMjUgIFl1em8gRnVqaXNoaW1hICA8eXV6b0Bnb29nbGUuY29tPgorCiAgICAgICAgIFJldmll d2VkIGJ5IEVyaWMgU2VpZGVsLgogCiAgICAgICAgIFVwZGF0ZSBweXdlYnNvY2tldCB0byAwLjQu MgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzIGIvV2Vi S2l0VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzCmluZGV4IGMyNzE1NmUuLjhmYWEwZjYg MTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cworKysgYi9X ZWJLaXRUb29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMKQEAgLTg3LDYgKzg3LDcgQEAgc3Vi IGZpbGVOYW1lV2l0aE51bWJlcigkJCk7CiBzdWIgaHRtbEZvclJlc3VsdHNTZWN0aW9uKFxAJCYp Owogc3ViIGlzVGV4dE9ubHlUZXN0KCQpOwogc3ViIGxhdW5jaFdpdGhDdXJyZW50RW52KEApOwor c3ViIG1ha2VBYnNUZXN0UmVzdWx0c0RpcmVjdG9yeSgpOwogc3ViIG51bWVyaWNjbXAoJCQpOwog c3ViIG9wZW5EaWZmVG9vbCgpOwogc3ViIG9wZW5EdW1wVG9vbCgpOwpAQCAtMTIxNyw2ICsxMjE4 LDEzIEBAIHN1YiBsYXVuY2hXaXRoQ3VycmVudEVudihAKQogICAgIHJldHVybiBAYXJnczsKIH0K IAorc3ViIG1ha2VBYnNUZXN0UmVzdWx0c0RpcmVjdG9yeSgpCit7CisgICAgbXkgJGFic1Rlc3RS ZXN1bHRzRGlyZWN0b3J5ID0gRmlsZTo6U3BlYy0+cmVsMmFicyhnbG9iICR0ZXN0UmVzdWx0c0Rp cmVjdG9yeSk7CisgICAgbWtwYXRoICRhYnNUZXN0UmVzdWx0c0RpcmVjdG9yeTsKKyAgICByZXR1 cm4gJGFic1Rlc3RSZXN1bHRzRGlyZWN0b3J5OworfQorCiBzdWIgb3BlbkRpZmZUb29sKCkKIHsK ICAgICByZXR1cm4gaWYgJGlzRGlmZlRvb2xPcGVuOwpAQCAtMTM3NywxMSArMTM4NSw5IEBAIHN1 YiBvcGVuSFRUUERJZk5lZWRlZCgpCiAgICAgbXkgJGpzVGVzdFJlc291cmNlc0RpcmVjdG9yeSA9 ICR0ZXN0RGlyZWN0b3J5IC4gIi9mYXN0L2pzL3Jlc291cmNlcyI7CiAgICAgbXkgJHR5cGVzQ29u ZmlnID0gIiR0ZXN0RGlyZWN0b3J5L2h0dHAvY29uZi9taW1lLnR5cGVzIjsKICAgICBteSAkbGlz dGVuID0gIjEyNy4wLjAuMTokaHR0cGRQb3J0IjsKLSAgICBteSAkYWJzVGVzdFJlc3VsdHNEaXJl Y3RvcnkgPSBGaWxlOjpTcGVjLT5yZWwyYWJzKGdsb2IgJHRlc3RSZXN1bHRzRGlyZWN0b3J5KTsK KyAgICBteSAkYWJzVGVzdFJlc3VsdHNEaXJlY3RvcnkgPSBtYWtlQWJzVGVzdFJlc3VsdHNEaXJl Y3RvcnkoKTsKICAgICBteSAkc3NsQ2VydGlmaWNhdGUgPSAiJHRlc3REaXJlY3RvcnkvaHR0cC9j b25mL3dlYmtpdC1odHRwZC5wZW0iOwogCi0gICAgbWtwYXRoICRhYnNUZXN0UmVzdWx0c0RpcmVj dG9yeTsKLQogICAgIG15IEBhcmdzID0gKAogICAgICAgICAiLWYiLCAiJGh0dHBkQ29uZmlnIiwK ICAgICAgICAgIi1DIiwgIkRvY3VtZW50Um9vdCBcIiRkb2N1bWVudFJvb3RcIiIsCkBAIC0xNDM0 LDExICsxNDQwLDE1IEBAIHN1YiBvcGVuV2ViU29ja2V0U2VydmVySWZOZWVkZWQoKQogICAgIG15 ICR3ZWJTb2NrZXRIYW5kbGVyRGlyID0gIiR0ZXN0RGlyZWN0b3J5IjsKICAgICBteSAkd2ViU29j a2V0SGFuZGxlclNjYW5EaXIgPSAiJHRlc3REaXJlY3Rvcnkvd2Vic29ja2V0L3Rlc3RzIjsKICAg ICBteSAkc3NsQ2VydGlmaWNhdGUgPSAiJHRlc3REaXJlY3RvcnkvaHR0cC9jb25mL3dlYmtpdC1o dHRwZC5wZW0iOworICAgIG15ICRhYnNUZXN0UmVzdWx0c0RpcmVjdG9yeSA9IG1ha2VBYnNUZXN0 UmVzdWx0c0RpcmVjdG9yeSgpOworICAgIG15ICRsb2dGaWxlID0gIiRhYnNUZXN0UmVzdWx0c0Rp cmVjdG9yeS9weXdlYnNvY2tldF9sb2cudHh0IjsKKwogICAgIG15IEBhcmdzID0gKAogICAgICAg ICAiV2ViS2l0VG9vbHMvcHl3ZWJzb2NrZXQvbW9kX3B5d2Vic29ja2V0L3N0YW5kYWxvbmUucHki LAogICAgICAgICAiLXAiLCAiJHdlYlNvY2tldFBvcnQiLAogICAgICAgICAiLWQiLCAiJHdlYlNv Y2tldEhhbmRsZXJEaXIiLAogICAgICAgICAiLXMiLCAiJHdlYlNvY2tldEhhbmRsZXJTY2FuRGly IiwKKyAgICAgICAgIi1sIiwgIiRsb2dGaWxlIiwKICAgICApOwogICAgICMgd3NzIGlzIGRpc2Fi bGVkIHVudGlsIGFsbCBwbGF0Zm9ybXMgc3VwcG9ydCBweU9wZW5TU0wuCiAgICAgIyBteSBAYXJn c1NlY3VyZSA9ICgK 44002 2009-11-29 18:07:14 -0800 2009-12-01 10:48:28 -0800 Make pywebsocket log errors to a file bug-31604-20091130110712.patch text/plain 2538 yuzo ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBmYmUyNWNkLi4xMDZmYjYwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMTEt MjkgIFl1em8gRnVqaXNoaW1hICA8eXV6b0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgcHl3ZWJzb2NrZXQgbG9nIGVycm9y cyB0byBhIGZpbGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTMxNjA0CisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi13ZWJraXQtdGVzdHM6CisKIDIwMDkt MTEtMjUgIFl1em8gRnVqaXNoaW1hICA8eXV6b0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4t d2Via2l0LXRlc3RzIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzCmluZGV4 IGMyNzE1NmUuLjhmYWEwZjYgMTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdl YmtpdC10ZXN0cworKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMKQEAg LTg3LDYgKzg3LDcgQEAgc3ViIGZpbGVOYW1lV2l0aE51bWJlcigkJCk7CiBzdWIgaHRtbEZvclJl c3VsdHNTZWN0aW9uKFxAJCYpOwogc3ViIGlzVGV4dE9ubHlUZXN0KCQpOwogc3ViIGxhdW5jaFdp dGhDdXJyZW50RW52KEApOworc3ViIG1ha2VBYnNUZXN0UmVzdWx0c0RpcmVjdG9yeSgpOwogc3Vi IG51bWVyaWNjbXAoJCQpOwogc3ViIG9wZW5EaWZmVG9vbCgpOwogc3ViIG9wZW5EdW1wVG9vbCgp OwpAQCAtMTIxNyw2ICsxMjE4LDEzIEBAIHN1YiBsYXVuY2hXaXRoQ3VycmVudEVudihAKQogICAg IHJldHVybiBAYXJnczsKIH0KIAorc3ViIG1ha2VBYnNUZXN0UmVzdWx0c0RpcmVjdG9yeSgpCit7 CisgICAgbXkgJGFic1Rlc3RSZXN1bHRzRGlyZWN0b3J5ID0gRmlsZTo6U3BlYy0+cmVsMmFicyhn bG9iICR0ZXN0UmVzdWx0c0RpcmVjdG9yeSk7CisgICAgbWtwYXRoICRhYnNUZXN0UmVzdWx0c0Rp cmVjdG9yeTsKKyAgICByZXR1cm4gJGFic1Rlc3RSZXN1bHRzRGlyZWN0b3J5OworfQorCiBzdWIg b3BlbkRpZmZUb29sKCkKIHsKICAgICByZXR1cm4gaWYgJGlzRGlmZlRvb2xPcGVuOwpAQCAtMTM3 NywxMSArMTM4NSw5IEBAIHN1YiBvcGVuSFRUUERJZk5lZWRlZCgpCiAgICAgbXkgJGpzVGVzdFJl c291cmNlc0RpcmVjdG9yeSA9ICR0ZXN0RGlyZWN0b3J5IC4gIi9mYXN0L2pzL3Jlc291cmNlcyI7 CiAgICAgbXkgJHR5cGVzQ29uZmlnID0gIiR0ZXN0RGlyZWN0b3J5L2h0dHAvY29uZi9taW1lLnR5 cGVzIjsKICAgICBteSAkbGlzdGVuID0gIjEyNy4wLjAuMTokaHR0cGRQb3J0IjsKLSAgICBteSAk YWJzVGVzdFJlc3VsdHNEaXJlY3RvcnkgPSBGaWxlOjpTcGVjLT5yZWwyYWJzKGdsb2IgJHRlc3RS ZXN1bHRzRGlyZWN0b3J5KTsKKyAgICBteSAkYWJzVGVzdFJlc3VsdHNEaXJlY3RvcnkgPSBtYWtl QWJzVGVzdFJlc3VsdHNEaXJlY3RvcnkoKTsKICAgICBteSAkc3NsQ2VydGlmaWNhdGUgPSAiJHRl c3REaXJlY3RvcnkvaHR0cC9jb25mL3dlYmtpdC1odHRwZC5wZW0iOwogCi0gICAgbWtwYXRoICRh YnNUZXN0UmVzdWx0c0RpcmVjdG9yeTsKLQogICAgIG15IEBhcmdzID0gKAogICAgICAgICAiLWYi LCAiJGh0dHBkQ29uZmlnIiwKICAgICAgICAgIi1DIiwgIkRvY3VtZW50Um9vdCBcIiRkb2N1bWVu dFJvb3RcIiIsCkBAIC0xNDM0LDExICsxNDQwLDE1IEBAIHN1YiBvcGVuV2ViU29ja2V0U2VydmVy SWZOZWVkZWQoKQogICAgIG15ICR3ZWJTb2NrZXRIYW5kbGVyRGlyID0gIiR0ZXN0RGlyZWN0b3J5 IjsKICAgICBteSAkd2ViU29ja2V0SGFuZGxlclNjYW5EaXIgPSAiJHRlc3REaXJlY3Rvcnkvd2Vi c29ja2V0L3Rlc3RzIjsKICAgICBteSAkc3NsQ2VydGlmaWNhdGUgPSAiJHRlc3REaXJlY3Rvcnkv aHR0cC9jb25mL3dlYmtpdC1odHRwZC5wZW0iOworICAgIG15ICRhYnNUZXN0UmVzdWx0c0RpcmVj dG9yeSA9IG1ha2VBYnNUZXN0UmVzdWx0c0RpcmVjdG9yeSgpOworICAgIG15ICRsb2dGaWxlID0g IiRhYnNUZXN0UmVzdWx0c0RpcmVjdG9yeS9weXdlYnNvY2tldF9sb2cudHh0IjsKKwogICAgIG15 IEBhcmdzID0gKAogICAgICAgICAiV2ViS2l0VG9vbHMvcHl3ZWJzb2NrZXQvbW9kX3B5d2Vic29j a2V0L3N0YW5kYWxvbmUucHkiLAogICAgICAgICAiLXAiLCAiJHdlYlNvY2tldFBvcnQiLAogICAg ICAgICAiLWQiLCAiJHdlYlNvY2tldEhhbmRsZXJEaXIiLAogICAgICAgICAiLXMiLCAiJHdlYlNv Y2tldEhhbmRsZXJTY2FuRGlyIiwKKyAgICAgICAgIi1sIiwgIiRsb2dGaWxlIiwKICAgICApOwog ICAgICMgd3NzIGlzIGRpc2FibGVkIHVudGlsIGFsbCBwbGF0Zm9ybXMgc3VwcG9ydCBweU9wZW5T U0wuCiAgICAgIyBteSBAYXJnc1NlY3VyZSA9ICgK