31592 2009-11-17 11:15:26 -0800 commit-queue is failing to set reviewer in ChangeLogs 2009-11-18 12:12:13 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 31632 1 eric webkit-unassigned abarth oldest_to_newest 164275 0 eric 2009-11-17 11:15:26 -0800 commit-queue is failing to set reviewer in ChangeLogs https://bugs.webkit.org/show_bug.cgi?id=31504#c6 bugzilla-tool apply-patches 31504 still works as expected. bugzilla-tool apply-attachment 43221 however does not correctly set the reviewer. I expect those symptoms are related. 164287 1 43372 eric 2009-11-17 11:50:13 -0800 Created attachment 43372 Patch 164289 2 eric 2009-11-17 11:53:36 -0800 I've filed bug 31594 about some of the further cleanup needed here. 164291 3 43372 darin 2009-11-17 11:55:53 -0800 Comment on attachment 43372 Patch rs=me 164292 4 eric 2009-11-17 11:56:59 -0800 Thank you Darin! 164296 5 eric 2009-11-17 11:58:04 -0800 For those playing along at home, this was a regression caused by bug 31546 and bug 31548. 164303 6 eric 2009-11-17 12:11:43 -0800 Committed r51085: <http://trac.webkit.org/changeset/51085> 164573 7 abarth 2009-11-18 08:18:31 -0800 Obligatory test nag. 164651 8 eric 2009-11-18 12:12:13 -0800 Oh true. Thank you Adam. I'll add one shortly on bug 31632. 43372 2009-11-17 11:50:13 -0800 2009-11-18 12:12:07 -0800 Patch bug-31592-20091117115011.patch text/plain 2922 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBhZGQ2NDk2Li5iOWQ2OWI5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTEt MTcgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNvbW1pdC1xdWV1ZSBpcyBmYWlsaW5nIHRvIHNl dCByZXZpZXdlciBpbiBDaGFuZ2VMb2dzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zMTU5MgorCisgICAgICAgICogU2NyaXB0cy9idWd6aWxsYS10b29s OiBDbGFyaWZ5IHRoZSAiYXBwbHlpbmciIGxvZyBtZXNzYWdlLgorICAgICAgICAqIFNjcmlwdHMv bW9kdWxlcy9idWd6aWxsYS5weToKKyAgICAgICAgIC0gQWRkIGEgbmV3IF92YWxpZGF0ZV9jb21t aXR0ZXJfYW5kX3Jldmlld2VyIGZ1bmN0aW9uIGFzIGEKKyAgICAgICAgICAgdGVtcG9yYXJ5IHNv bHV0aW9uIHVudGlsIHdlIGNhbiBtYWtlIGEgcmVhbCBBdHRhY2htZW50IG9iamVjdAorICAgICAg ICAgICB3aGljaCBrbm93cyBob3cgdG8gZmlsbCBpbiBpdHMgY29tbWl0dGVyL3Jldmlld2VyIGZp ZWxkcyBhdXRvbWF0aWNhbGx5LgorCiAyMDA5LTExLTE3ICBKb3NlcGggUGVjb3Jhcm8gIDxqb2Vw ZWNrQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVGltb3RoeSBIYXRjaGVyLgpk aWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWd6aWxsYS10b29sIGIvV2ViS2l0VG9v bHMvU2NyaXB0cy9idWd6aWxsYS10b29sCmluZGV4IDQyN2QwNTQuLmM5MGM5MzEgMTAwNzU1Ci0t LSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbAorKysgYi9XZWJLaXRUb29scy9T Y3JpcHRzL2J1Z3ppbGxhLXRvb2wKQEAgLTMzMCw3ICszMzAsNyBAQCBjbGFzcyBXZWJLaXRMYW5k aW5nU2NyaXB0czoKICAgICBAY2xhc3NtZXRob2QKICAgICBkZWYgX2xhbmRfcGF0Y2goY2xzLCBw YXRjaCwgb3B0aW9ucywgdG9vbCk6CiAgICAgICAgIHRvb2wuc2NtKCkudXBkYXRlX3dlYmtpdCgp ICMgVXBkYXRlIGJlZm9yZSBldmVyeSBwYXRjaCBpbiBjYXNlIHRoZSB0cmVlIGhhcyBjaGFuZ2Vk Ci0gICAgICAgIGxvZygiQXBwbHlpbmcgJXMgZnJvbSBidWcgJXMuIiAlIChwYXRjaFsnaWQnXSwg cGF0Y2hbJ2J1Z19pZCddKSkKKyAgICAgICAgbG9nKCJBcHBseWluZyBwYXRjaCAlcyBmcm9tIGJ1 ZyAlcy4iICUgKHBhdGNoWydpZCddLCBwYXRjaFsnYnVnX2lkJ10pKQogICAgICAgICB0b29sLnNj bSgpLmFwcGx5X3BhdGNoKHBhdGNoLCBmb3JjZT1vcHRpb25zLm5vbl9pbnRlcmFjdGl2ZSkKIAog ICAgICAgICAjIE1ha2Ugc3VyZSB0aGUgdHJlZSBpcyBzdGlsbCBncmVlbiBhZnRlciB1cGRhdGlu ZywgYmVmb3JlIGJ1aWxkaW5nIHRoaXMgcGF0Y2guCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9T Y3JpcHRzL21vZHVsZXMvYnVnemlsbGEucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMv YnVnemlsbGEucHkKaW5kZXggZjMwZGRhMy4uM2E5Y2E2OCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9v bHMvU2NyaXB0cy9tb2R1bGVzL2J1Z3ppbGxhLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMv bW9kdWxlcy9idWd6aWxsYS5weQpAQCAtMjE4LDYgKzIxOCw3IEBAIGNsYXNzIEJ1Z3ppbGxhOgog ICAgICAgICBhdHRhY2htZW50cyA9IHNlbGYuZmV0Y2hfYXR0YWNobWVudHNfZnJvbV9idWcoYnVn X2lkKQogICAgICAgICBmb3IgYXR0YWNobWVudCBpbiBhdHRhY2htZW50czoKICAgICAgICAgICAg IGlmIGF0dGFjaG1lbnRbJ2lkJ10gPT0gYXR0YWNobWVudF9pZDoKKyAgICAgICAgICAgICAgICBz ZWxmLl92YWxpZGF0ZV9jb21taXR0ZXJfYW5kX3Jldmlld2VyKGF0dGFjaG1lbnQpCiAgICAgICAg ICAgICAgICAgcmV0dXJuIGF0dGFjaG1lbnQKICAgICAgICAgcmV0dXJuIE5vbmUgIyBUaGlzIHNo b3VsZCBuZXZlciBiZSBoaXQuCiAKQEAgLTI2Miw2ICsyNjMsMTMgQEAgY2xhc3MgQnVnemlsbGE6 CiAgICAgZGVmIF92YWxpZGF0ZV9jb21taXR0ZXIoc2VsZiwgcGF0Y2gsIHJlamVjdF9pbnZhbGlk X3BhdGNoZXMpOgogICAgICAgICByZXR1cm4gc2VsZi5fdmFsaWRhdGVfc2V0dGVyX2VtYWlsKHBh dGNoLCAnY29tbWl0dGVyJywgc2VsZi5jb21taXR0ZXJzLmNvbW1pdHRlcl9ieV9lbWFpbCwgc2Vs Zi5yZWplY3RfcGF0Y2hfZnJvbV9jb21taXRfcXVldWUsIHJlamVjdF9pbnZhbGlkX3BhdGNoZXMp CiAKKyAgICAjIEZJWE1FOiBUaGlzIGlzIGEgaGFjayB1bnRpbCB3ZSBoYXZlIGEgcmVhbCBBdHRh Y2htZW50IG9iamVjdC4KKyAgICAjIF92YWxpZGF0ZV9jb21taXR0ZXIgYW5kIF92YWxpZGF0ZV9y ZXZpZXdlciBmaWxsIGluIHRoZSAncmV2aWV3ZXInIGFuZCAnY29tbWl0dGVyJworICAgICMga2V5 cyB3aGljaCBvdGhlciBwYXJ0cyBvZiB0aGUgY29kZSBleHBlY3QgdG8gYmUgZmlsbGVkIGluLgor ICAgIGRlZiBfdmFsaWRhdGVfY29tbWl0dGVyX2FuZF9yZXZpZXdlcihzZWxmLCBwYXRjaCk6Cisg ICAgICAgIHNlbGYuX3ZhbGlkYXRlX3Jldmlld2VyKHBhdGNoLCByZWplY3RfaW52YWxpZF9wYXRj aGVzPUZhbHNlKQorICAgICAgICBzZWxmLl92YWxpZGF0ZV9jb21taXR0ZXIocGF0Y2gsIHJlamVj dF9pbnZhbGlkX3BhdGNoZXM9RmFsc2UpCisKICAgICBkZWYgZmV0Y2hfdW5yZXZpZXdlZF9wYXRj aGVzX2Zyb21fYnVnKHNlbGYsIGJ1Z19pZCk6CiAgICAgICAgIHVucmV2aWV3ZWRfcGF0Y2hlcyA9 IFtdCiAgICAgICAgIGZvciBhdHRhY2htZW50IGluIHNlbGYuZmV0Y2hfYXR0YWNobWVudHNfZnJv bV9idWcoYnVnX2lkKToK