31589 2009-11-17 08:19:11 -0800 [Qt] Add support for layout tests on Symbian 2010-02-22 10:46:09 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED Qt P3 Enhancement --- 27065 1 hausmann webkit-unassigned commit-queue koshuin laszlo.gombos s.mathur tonikitoo yael oldest_to_newest 164237 0 hausmann 2009-11-17 08:19:11 -0800 In the long run it would be great to be able to run the layout tests on Symbian. It may be difficult to run them on an actual device due to the memory requirements, but the simulator/emulator might be an option. 164238 1 hausmann 2009-11-17 08:19:37 -0800 This bug is also tracked by the internal Qt bug QT-2515 164240 2 hausmann 2009-11-17 08:21:13 -0800 One issue we'd have with running the DRT on Symbian is the maintenance of the test results. Tor Arne is looking into the use of SVG fonts for all text rendering to produce platform independent metrics for test results. 164344 3 koshuin 2009-11-17 14:02:08 -0800 Problem with the x86 emulator is that it has even less memory than the actual hardware due to how it is ran in single process and emulator addressing space is allocated as a single continous chunk from Windows heap. Qemu port of Symbian might come to rescue but it is in too early phase to run GUI apps on it. Then there is the upcoming platsim that would be interesting to see, but AFAIK that won't be free. Beagleboard and Zoom II are also alternatives, but they would need toned down version of tests due to memory limitations? 171141 4 hausmann 2009-12-12 16:27:55 -0800 Tracked in QtWebKit JIRA requirements at http://bugreports.qt.nokia.com/browse/QTWEBKIT-50 171537 5 yael 2009-12-14 13:19:09 -0800 Since Symbian does not have a perl interpreter, we could use a python version of the test driver instead. Chromium team is upstreaming their python script to webkit.org, see https://bugs.webkit.org/show_bug.cgi?id=31498 . 192180 6 49127 laszlo.gombos 2010-02-20 09:30:26 -0800 Created attachment 49127 Compile DumpRenderTree for Symbian 192459 7 49127 commit-queue 2010-02-22 07:12:40 -0800 Comment on attachment 49127 Compile DumpRenderTree for Symbian Clearing flags on attachment: 49127 Committed r55082: <http://trac.webkit.org/changeset/55082> 192460 8 commit-queue 2010-02-22 07:12:45 -0800 All reviewed patches have been landed. Closing bug. 192502 9 49127 hausmann 2010-02-22 10:04:49 -0800 Comment on attachment 49127 Compile DumpRenderTree for Symbian > -#ifndef Q_OS_WIN > +#if HAVE(SIGNAL_H) > static NO_RETURN void crashHandler(int sig) > { > fprintf(stderr, "%s\n", strsignal(sig)); > @@ -132,7 +132,7 @@ int main(int argc, char* argv[]) > QX11Info::setAppDpiX(0, 96); > #endif > > -#ifndef Q_OS_WIN > +#if HAVE(SIGNAL_H) > signal(SIGILL, crashHandler); /* 4: illegal instruction (not reset when caught) */ > signal(SIGTRAP, crashHandler); /* 5: trace trap (not reset when caught) */ > signal(SIGFPE, crashHandler); /* 8: floating point exception */ I'm unsure about these two hunks. HAVE(SIGNAL_H) comes from the WTF includes that we should not use outside of JavaScriptCore/WebCore. Are you sure that the above HAVE macros evaluate to true on Linux, even though main.cpp isn't directly including config.h? I'm worried that they'll now always evaluate to false, which will make the code still compile and run, but we won't get crash detection. 192519 10 laszlo.gombos 2010-02-22 10:46:09 -0800 > I'm unsure about these two hunks. HAVE(SIGNAL_H) comes from the WTF includes > that we should not use outside of JavaScriptCore/WebCore. I agree; filed a bug https://bugs.webkit.org/show_bug.cgi?id=35248. > Are you sure that the > above HAVE macros evaluate to true on Linux, even though main.cpp isn't > directly including config.h? main.cpp includes wtf/AlwaysInline.h, which includes Platform.h. > I'm worried that they'll now always evaluate to > false, which will make the code still compile and run, but we won't get crash > detection. I double-checked and crash detection gets compiled on Linux. 49127 2010-02-20 09:30:26 -0800 2010-02-22 10:04:49 -0800 Compile DumpRenderTree for Symbian patch-31589-1.patch text/plain 3359 laszlo.gombos SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDU1MDUy KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDIt MjAgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gQWRkIHN1cHBvcnQg Zm9yIGxheW91dCB0ZXN0cyBvbiBTeW1iaWFuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMTU4OQorCisgICAgICAgICogV2ViS2l0LnBybzoKKwogMjAx MC0wMi0xOSAgTWFjaWVqIFN0YWNob3dpYWsgIDxtanNAYXBwbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IERhdmlkIExldmluLgpJbmRleDogV2ViS2l0LnBybwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJLaXQucHJvCShyZXZpc2lvbiA1NTA1MikKKysrIFdlYktpdC5wcm8JKHdvcmtpbmcgY29weSkK QEAgLTEwLDkgKzEwLDggQEAgU1VCRElSUyArPSBcCiAKICFDT05GSUcoc3RhbmRhbG9uZV9wYWNr YWdlKSB7CiAgICAgU1VCRElSUyArPSBKYXZhU2NyaXB0Q29yZS9qc2MucHJvIFwKLSAgICAgICAg V2ViS2l0L3F0L3Rlc3RzCi0KLSAgICAhc3ltYmlhbjogU1VCRElSUyArPSBXZWJLaXRUb29scy9E dW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZS5wcm8KKyAgICAgICAgV2ViS2l0L3F0L3Rl c3RzIFwKKyAgICAgICAgV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRy ZWUucHJvCiAKICAgICAhd2luMzI6IXN5bWJpYW4gewogICAgICAgICBTVUJESVJTICs9IFdlYktp dFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0ltYWdlRGlmZi5wcm8KSW5kZXg6IFdlYktpdFRvb2xz L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9DaGFuZ2VMb2cJKHJldmlzaW9u IDU1MDUyKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTAtMDItMjAgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gQWRkIHN1cHBvcnQgZm9yIGxheW91dCB0ZXN0cyBvbiBTeW1iaWFuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTU4OQorCisgICAgICAgICog RHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWUucHJvOgorICAgICAgICAqIER1bXBSZW5k ZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuY3BwOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVl L3F0L21haW4uY3BwOgorICAgICAgICAobWFpbik6CisKIDIwMTAtMDItMjAgIEd1c3Rhdm8gTm9y b25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgb2J2aW91 cyBmaXggZm9yIHRoZSBweXRob24gZmFpbHVyZSBpbiBvdXIgbmV3IGJ1aWxkYm90CkluZGV4OiBX ZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZS5wcm8KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWUucHJvCShy ZXZpc2lvbiA1NTA1MikKKysrIFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5k ZXJUcmVlLnBybwkod29ya2luZyBjb3B5KQpAQCAtMTcsNyArMTcsNyBAQCBJTkNMVURFUEFUSCAr PSAuLi8uLi8uLi9KYXZhU2NyaXB0Q29yZS9GCiBJTkNMVURFUEFUSCArPSAkJEJBU0VESVIKIERF U1RESVIgPSAuLi8uLi8uLi9iaW4KIAotIXdpbjMyIHsKKyF3aW4zMjohc3ltYmlhbiB7CiAgICAg Q09ORklHICs9IGxpbmtfcGtnY29uZmlnCiAgICAgUEtHQ09ORklHICs9IGZvbnRjb25maWcKIH0K SW5kZXg6IFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJU cmVlUXQuY3BwCShyZXZpc2lvbiA1NTA1MikKKysrIFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVl L3F0L0R1bXBSZW5kZXJUcmVlUXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02Niw2ICs2Niw3IEBA CiAjZW5kaWYKIAogI2luY2x1ZGUgPGxpbWl0cy5oPgorI2luY2x1ZGUgPGxvY2FsZS5oPgogCiAj aWZuZGVmIFFfT1NfV0lOCiAjaW5jbHVkZSA8dW5pc3RkLmg+CkluZGV4OiBXZWJLaXRUb29scy9E dW1wUmVuZGVyVHJlZS9xdC9tYWluLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9EdW1w UmVuZGVyVHJlZS9xdC9tYWluLmNwcAkocmV2aXNpb24gNTUwNTIpCisrKyBXZWJLaXRUb29scy9E dW1wUmVuZGVyVHJlZS9xdC9tYWluLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTMsNyArOTMsNyBA QCBRU3RyaW5nIGdldF9iYWNrdHJhY2UoKSB7CiAgICAgcmV0dXJuIHM7CiB9CiAKLSNpZm5kZWYg UV9PU19XSU4KKyNpZiBIQVZFKFNJR05BTF9IKQogc3RhdGljIE5PX1JFVFVSTiB2b2lkIGNyYXNo SGFuZGxlcihpbnQgc2lnKQogewogICAgIGZwcmludGYoc3RkZXJyLCAiJXNcbiIsIHN0cnNpZ25h bChzaWcpKTsKQEAgLTEzMiw3ICsxMzIsNyBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciogYXJn dltdKQogICAgIFFYMTFJbmZvOjpzZXRBcHBEcGlYKDAsIDk2KTsKICNlbmRpZgogCi0jaWZuZGVm IFFfT1NfV0lOCisjaWYgSEFWRShTSUdOQUxfSCkKICAgICBzaWduYWwoU0lHSUxMLCBjcmFzaEhh bmRsZXIpOyAgICAvKiA0OiAgIGlsbGVnYWwgaW5zdHJ1Y3Rpb24gKG5vdCByZXNldCB3aGVuIGNh dWdodCkgKi8KICAgICBzaWduYWwoU0lHVFJBUCwgY3Jhc2hIYW5kbGVyKTsgICAvKiA1OiAgIHRy YWNlIHRyYXAgKG5vdCByZXNldCB3aGVuIGNhdWdodCkgKi8KICAgICBzaWduYWwoU0lHRlBFLCBj cmFzaEhhbmRsZXIpOyAgICAvKiA4OiAgIGZsb2F0aW5nIHBvaW50IGV4Y2VwdGlvbiAqLwo=