31584 2009-11-17 06:52:36 -0800 [Android] Add shared timer and sound utilities to platform/android 2009-11-18 14:49:49 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 andreip webkit-unassigned android-webkit-unforking commit-queue oldest_to_newest 164221 0 andreip 2009-11-17 06:52:36 -0800 Android is missing utilities for shared timers and sound. 164222 1 43360 andreip 2009-11-17 06:57:33 -0800 Created attachment 43360 Add shared timer and sound utilities for Android. 164244 2 43360 dglazkov 2009-11-17 08:38:37 -0800 Comment on attachment 43360 Add shared timer and sound utilities for Android. > +#define LOG_TAG "Timers" can this go just above "TimerClient" include? I'd like to keep config.h first, for consistency. 164247 3 43365 andreip 2009-11-17 08:59:03 -0800 Created attachment 43365 Add shared timer and sound utilities for Android v2 164248 4 43365 dglazkov 2009-11-17 09:01:36 -0800 Comment on attachment 43365 Add shared timer and sound utilities for Android v2 ok. 164316 5 43365 commit-queue 2009-11-17 12:52:25 -0800 Comment on attachment 43365 Add shared timer and sound utilities for Android v2 Rejecting patch 43365 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11628 test cases. http/tests/xmlhttprequest/workers/close.html -> crashed Exiting early after 1 failures. 9314 tests run. 363.98s total testing time 9313 test cases (99%) succeeded 1 test case (<1%) crashed 5 test cases (<1%) had stderr output 164322 6 43365 eric 2009-11-17 13:05:21 -0800 Comment on attachment 43365 Add shared timer and sound utilities for Android v2 Sigh. Bug 31461. 164730 7 43365 commit-queue 2009-11-18 14:49:44 -0800 Comment on attachment 43365 Add shared timer and sound utilities for Android v2 Clearing flags on attachment: 43365 Committed r51140: <http://trac.webkit.org/changeset/51140> 164731 8 commit-queue 2009-11-18 14:49:49 -0800 All reviewed patches have been landed. Closing bug. 43360 2009-11-17 06:57:33 -0800 2009-11-17 08:59:03 -0800 Add shared timer and sound utilities for Android. 31584.patch text/plain 5420 andreip SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTA3NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDktMTEtMTcgIEFuZHJlaSBQb3Blc2N1ICA8YW5kcmVpcEBnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtBbmRyb2lkXSBBZGQgc2hhcmVkIHRpbWVyIGFuZCBzb3VuZCB1dGlsaXRpZXMgdG8gcGxhdGZv cm0vYW5kcm9pZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzE1ODQKKworICAgICAgICBObyBuZXcgdGVzdHMgcmVxdWlyZWQsIHRoaXMgaXMgcGxhdGZv cm0gc3BlY2lmaWMgY29kZS4KKworICAgICAgICAqIHBsYXRmb3JtL2FuZHJvaWQvU2hhcmVkVGlt ZXJBbmRyb2lkLmNwcDogQWRkZWQuCisgICAgICAgIChXZWJDb3JlOjpzZXRTaGFyZWRUaW1lckZp cmVkRnVuY3Rpb24pOgorICAgICAgICAoV2ViQ29yZTo6c2V0U2hhcmVkVGltZXJGaXJlVGltZSk6 CisgICAgICAgIChXZWJDb3JlOjpzdG9wU2hhcmVkVGltZXIpOgorICAgICAgICAqIHBsYXRmb3Jt L2FuZHJvaWQvU291bmRBbmRyb2lkLmNwcDogQWRkZWQuCisgICAgICAgIChXZWJDb3JlOjpzeXN0 ZW1CZWVwKToKKwogMjAwOS0xMS0xNyAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCkluZGV4OiBXZWJD b3JlL3BsYXRmb3JtL2FuZHJvaWQvU2hhcmVkVGltZXJBbmRyb2lkLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL3BsYXRmb3JtL2FuZHJvaWQvU2hhcmVkVGltZXJBbmRyb2lkLmNwcAkocmV2aXNp b24gMCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vYW5kcm9pZC9TaGFyZWRUaW1lckFuZHJvaWQuY3Bw CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDY1IEBACisvKgorICogQ29weXJpZ2h0IDIwMDcsIFRo ZSBBbmRyb2lkIE9wZW4gU291cmNlIFByb2plY3QKKyAqCisgKiBSZWRpc3RyaWJ1dGlvbiBhbmQg dXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyAqIG1vZGlm aWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0 aW9ucworICogYXJlIG1ldDoKKyAqICAqIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBt dXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisgKiAgICBub3RpY2UsIHRoaXMgbGlzdCBv ZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCisgKiAgKiBSZWRpc3Ry aWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdo dAorICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2lu ZyBkaXNjbGFpbWVyIGluIHRoZQorICogICAgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0 ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlIGRpc3RyaWJ1dGlvbi4KKyAqCisgKiBUSElTIFNPRlRX QVJFIElTIFBST1ZJREVEIEJZIFRIRSBDT1BZUklHSFQgSE9MREVSUyBgYEFTIElTJycgQU5EIEFO WQorICogRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVCBM SU1JVEVEIFRPLCBUSEUKKyAqIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkg QU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUgorICogUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4g IElOIE5PIEVWRU5UIFNIQUxMIFRIRSBDT1BZUklHSFQgT1dORVIgT1IKKyAqIENPTlRSSUJVVE9S UyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLCBTUEVDSUFM LAorICogRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVU IE5PVCBMSU1JVEVEIFRPLAorICogUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUiBT RVJWSUNFUzsgTE9TUyBPRiBVU0UsIERBVEEsIE9SCisgKiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJ TlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkgVEhFT1JZCisgKiBPRiBMSUFC SUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyAq IChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBP VVQgT0YgVEhFIFVTRQorICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRI RSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKyAqLworCisjZGVmaW5lIExPR19UQUcgIlRp bWVycyIKKworI2luY2x1ZGUgImNvbmZpZy5oIgorI2luY2x1ZGUgIlNoYXJlZFRpbWVyLmgiCisK KyNpbmNsdWRlIDxUaW1lckNsaWVudC5oPgorI2luY2x1ZGUgPEphdmFTaGFyZWRDbGllbnQuaD4K KyNpbmNsdWRlIDx1dGlscy9Mb2cuaD4KKyNpbmNsdWRlIDx3dGYvQ3VycmVudFRpbWUuaD4KKwor dXNpbmcgbmFtZXNwYWNlIGFuZHJvaWQ7CisKK25hbWVzcGFjZSBXZWJDb3JlIHsKKworLy8gU2lu Z2xlIHRpbWVyLCBzaGFyZWQgdG8gaW1wbGVtZW50IGFsbCB0aGUgdGltZXJzIG1hbmFnZWQgYnkg dGhlIFRpbWVyIGNsYXNzLgorLy8gTm90IGludGVuZGVkIHRvIGJlIHVzZWQgZGlyZWN0bHk7IHVz ZSB0aGUgVGltZXIgY2xhc3MgaW5zdGVhZC4KK3ZvaWQgc2V0U2hhcmVkVGltZXJGaXJlZEZ1bmN0 aW9uKHZvaWQgKCpmKSgpKQoreworICAgIGlmIChKYXZhU2hhcmVkQ2xpZW50OjpHZXRUaW1lckNs aWVudCgpKQorICAgICAgICBKYXZhU2hhcmVkQ2xpZW50OjpHZXRUaW1lckNsaWVudCgpLT5zZXRT aGFyZWRUaW1lckNhbGxiYWNrKGYpOworfQorCisvLyBUaGUgZmlyZSB0aW1lIGlzIHJlbGF0aXZl IHRvIHRoZSBjbGFzc2ljIFBPU0lYIGVwb2NoIG9mIEphbnVhcnkgMSwgMTk3MCwKKy8vIGFzIHRo ZSByZXN1bHQgb2YgY3VycmVudFRpbWUoKSBpcy4KK3ZvaWQgc2V0U2hhcmVkVGltZXJGaXJlVGlt ZShkb3VibGUgZmlyZVRpbWUpCit7CisgICAgbG9uZyBsb25nIHRpbWVJbk1zID0gc3RhdGljX2Nh c3Q8bG9uZyBsb25nPigoZmlyZVRpbWUgLSBXVEY6OmN1cnJlbnRUaW1lKCkpICogMTAwMCk7CisK KyAgICBMT0dWKCJzZXRTaGFyZWRUaW1lckZpcmVUaW1lOiBpbiAlbGQgbWlsbGlzZWMiLCB0aW1l SW5Ncyk7CisgICAgaWYgKEphdmFTaGFyZWRDbGllbnQ6OkdldFRpbWVyQ2xpZW50KCkpCisgICAg ICAgIEphdmFTaGFyZWRDbGllbnQ6OkdldFRpbWVyQ2xpZW50KCktPnNldFNoYXJlZFRpbWVyKHRp bWVJbk1zKTsKK30KKwordm9pZCBzdG9wU2hhcmVkVGltZXIoKQoreworICAgIGlmIChKYXZhU2hh cmVkQ2xpZW50OjpHZXRUaW1lckNsaWVudCgpKQorICAgICAgICBKYXZhU2hhcmVkQ2xpZW50OjpH ZXRUaW1lckNsaWVudCgpLT5zdG9wU2hhcmVkVGltZXIoKTsKK30KKworfSAgLy8gbmFtZXNwYWNl IFdlYkNvcmUKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vYW5kcm9pZC9Tb3VuZEFuZHJvaWQuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vYW5kcm9pZC9Tb3VuZEFuZHJvaWQuY3Bw CShyZXZpc2lvbiAwKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9hbmRyb2lkL1NvdW5kQW5kcm9pZC5j cHAJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzYgQEAKKy8qCisgKiBDb3B5cmlnaHQgMjAwOSwg VGhlIEFuZHJvaWQgT3BlbiBTb3VyY2UgUHJvamVjdAorICoKKyAqIFJlZGlzdHJpYnV0aW9uIGFu ZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorICogbW9k aWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25k aXRpb25zCisgKiBhcmUgbWV0OgorICogICogUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2Rl IG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0 IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyAqICAqIFJlZGlz dHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJp Z2h0CisgKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93 aW5nIGRpc2NsYWltZXIgaW4gdGhlCisgKiAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBt YXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorICoKKyAqIFRISVMgU09G VFdBUkUgSVMgUFJPVklERUQgQlkgVEhFIENPUFlSSUdIVCBIT0xERVJTIGBgQVMgSVMnJyBBTkQg QU5ZCisgKiBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9U IExJTUlURUQgVE8sIFRIRQorICogSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElU WSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSCisgKiBQVVJQT1NFIEFSRSBESVNDTEFJTUVE LiAgSU4gTk8gRVZFTlQgU0hBTEwgVEhFIENPUFlSSUdIVCBPV05FUiBPUgorICogQ09OVFJJQlVU T1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJ QUwsCisgKiBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBC VVQgTk9UIExJTUlURUQgVE8sCisgKiBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9S IFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwgREFUQSwgT1IKKyAqIFBST0ZJVFM7IE9SIEJVU0lORVNT IElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkKKyAqIE9GIExJ QUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAor ICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZ IE9VVCBPRiBUSEUgVVNFCisgKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0Yg VEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorICovCisKKyNpbmNsdWRlICJjb25maWcu aCIKKyNpbmNsdWRlICJTb3VuZC5oIgorCituYW1lc3BhY2UgV2ViQ29yZSB7CisKK3ZvaWQgc3lz dGVtQmVlcCgpCit7CisgICAgLy8gZG8gbm90aGluZworfQorCit9ICAvLyBuYW1lc3BhY2UgV2Vi Q29yZQo= 43365 2009-11-17 08:59:03 -0800 2009-11-18 14:49:43 -0800 Add shared timer and sound utilities for Android v2 31584.patch.v2 text/plain 0 andreip