<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>31583</bug_id>
          
          <creation_ts>2009-11-17 05:44:25 -0800</creation_ts>
          <short_desc>[Qt] better test coverage for ErrorPageExtension</short_desc>
          <delta_ts>2009-11-17 09:59:04 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Antonio Gomes">tonikitoo</reporter>
          <assigned_to name="Antonio Gomes">tonikitoo</assigned_to>
          <cc>kenneth</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>164208</commentid>
    <comment_count>0</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2009-11-17 05:44:25 -0800</bug_when>
    <thetext>load errors in iframes and framesets are currently not covered by qwebpage&apos;s autotests ...

patch coming...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>164211</commentid>
    <comment_count>1</comment_count>
      <attachid>43357</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2009-11-17 05:49:16 -0800</bug_when>
    <thetext>Created attachment 43357
patch 0.1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>164213</commentid>
    <comment_count>2</comment_count>
      <attachid>43357</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2009-11-17 05:52:59 -0800</bug_when>
    <thetext>Comment on attachment 43357
patch 0.1


&gt; +        (tst_QWebPage::errorPageExtension_withIFrames):
&gt; +        (tst_QWebPage::errorPageExtension_withFrameset):

Strange function naming

&gt;  void tst_QWebPage::infiniteLoopJS()
&gt;  {
&gt; +    return;

Doesn&apos;t seem right


&gt; -    page-&gt;mainFrame()-&gt;load(QUrl(&quot;qrc:///frametest/index.html&quot;));
&gt; +    m_view-&gt;setUrl(QUrl(&quot;data:text/html,foo&quot;));
&gt; +    QTest::qWait(2000);

Can these waits be avoided?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>164217</commentid>
    <comment_count>3</comment_count>
      <attachid>43359</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2009-11-17 06:04:22 -0800</bug_when>
    <thetext>Created attachment 43359
patch 0.2

thx for reviewing.


&gt; +        (tst_QWebPage::errorPageExtension_withIFrames):
&gt; +        (tst_QWebPage::errorPageExtension_withFrameset):
&gt; Strange function naming

fixed. 

&gt;  void tst_QWebPage::infiniteLoopJS()
&gt;  {
&gt; +    return;
&gt; Doesn&apos;t seem right

typo, removed.

&gt; -    page-&gt;mainFrame()-&gt;load(QUrl(&quot;qrc:///frametest/index.html&quot;));
&gt; +    m_view-&gt;setUrl(QUrl(&quot;data:text/html,foo&quot;));
&gt; +    QTest::qWait(2000);
&gt; Can these waits be avoided?

removed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>164218</commentid>
    <comment_count>4</comment_count>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2009-11-17 06:22:28 -0800</bug_when>
    <thetext>
&gt; &gt;  void tst_QWebPage::infiniteLoopJS()
&gt; &gt;  {
&gt; &gt; +    return;
&gt; &gt; Doesn&apos;t seem right
&gt; 
&gt; typo, removed.

If that is a typo, I will need to look very careful at your patches. Please be more careful.

&gt; 
&gt; &gt; -    page-&gt;mainFrame()-&gt;load(QUrl(&quot;qrc:///frametest/index.html&quot;));
&gt; &gt; +    m_view-&gt;setUrl(QUrl(&quot;data:text/html,foo&quot;));
&gt; &gt; +    QTest::qWait(2000);
&gt; &gt; Can these waits be avoided?
&gt; 
&gt; removed.

Why was it there in the first place?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>164219</commentid>
    <comment_count>5</comment_count>
      <attachid>43359</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2009-11-17 06:26:29 -0800</bug_when>
    <thetext>Comment on attachment 43359
patch 0.2

Please respond these questions:

&gt; @@ -1629,12 +1631,8 @@ public:
&gt;          const ErrorPageExtensionOption* info = static_cast&lt;const ErrorPageExtensionOption*&gt;(option);
&gt;          ErrorPageExtensionReturn* errorPage = static_cast&lt;ErrorPageExtensionReturn*&gt;(output);
&gt;  
&gt; -        if (info-&gt;frame == mainFrame()) {
&gt; -            errorPage-&gt;content = &quot;data:text/html,error&quot;;
&gt; -            return true;
&gt; -        }
&gt; -
&gt; -        return false;
&gt; +        errorPage-&gt;content = &quot;data:text/html,error&quot;;
&gt; +        return true;
&gt;      }

This above doesn&apos;t seem to have to do with your new change. If not, please explain that in the changelog.

&gt;  };
&gt;  
&gt; @@ -1645,11 +1643,10 @@ void tst_QWebPage::errorPageExtension()
&gt;  
&gt;      QSignalSpy spyLoadFinished(m_view, SIGNAL(loadFinished(bool)));
&gt;  
&gt; -    page-&gt;mainFrame()-&gt;load(QUrl(&quot;qrc:///frametest/index.html&quot;));
&gt; +    m_view-&gt;setUrl(QUrl(&quot;data:text/html,foo&quot;));

Is the frametest/index.html not needed anymore now?

&gt; -    QCOMPARE(page-&gt;history()-&gt;currentItem().url(), QUrl(&quot;qrc:///frametest/index.html&quot;));
&gt; +    QCOMPARE(page-&gt;history()-&gt;currentItem().url(), QUrl(&quot;data:text/html,foo&quot;));
&gt; +
&gt; +    m_view-&gt;setPage(0);

Why is this needed. Is it part of the test? Add a comment</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>164220</commentid>
    <comment_count>6</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2009-11-17 06:45:35 -0800</bug_when>
    <thetext>&gt; &gt; typo, removed.
&gt; If that is a typo, I will need to look very careful at your patches. Please be
&gt; more careful.

well, it is really a typo. see &apos;infiniteLoop()&apos; test (where i added the &apos;return&apos;) takes ~15 seconds running in my box. I added a &apos;return&apos; there just to speed up my own test execution. so it was a small typo to forget to remove the &apos;return&apos; and hapelly you catch it and it is fixed, so thank you again.

&gt; &gt; &gt; -    page-&gt;mainFrame()-&gt;load(QUrl(&quot;qrc:///frametest/index.html&quot;));
&gt; &gt; &gt; +    m_view-&gt;setUrl(QUrl(&quot;data:text/html,foo&quot;));
&gt; &gt; &gt; +    QTest::qWait(2000);
&gt; &gt; &gt; Can these waits be avoided?
&gt; &gt; removed.
&gt; Why was it there in the first place?

there were not needed. removed.

&gt; &gt;          const ErrorPageExtensionOption* info = static_cast&lt;const ErrorPageExtensionOption*&gt;(option);
&gt; &gt;          ErrorPageExtensionReturn* errorPage = static_cast&lt;ErrorPageExtensionReturn*&gt;(output);
&gt; &gt;  
&gt; &gt; -        if (info-&gt;frame == mainFrame()) {
&gt; &gt; -            errorPage-&gt;content = &quot;data:text/html,error&quot;;
&gt; &gt; -            return true;
&gt; &gt; -        }
&gt; &gt; -
&gt; &gt; -        return false;
&gt; &gt; +        errorPage-&gt;content = &quot;data:text/html,error&quot;;
&gt; &gt; +        return true;
&gt; &gt;      }
&gt; 
&gt; This above doesn&apos;t seem to have to do with your new change. If not, please
&gt; explain that in the changelog.

It is related, yes. We were firstly handling error pages for the mainFrame only. See &quot;if (info-&gt;frame == mainFrame())&quot;. Now the &quot;if&quot; got removed, and we are handling it for all frames (which purpose of the patch).

&gt; &gt; @@ -1645,11 +1643,10 @@ void tst_QWebPage::errorPageExtension()
&gt; &gt;  
&gt; &gt;      QSignalSpy spyLoadFinished(m_view, SIGNAL(loadFinished(bool)));
&gt; &gt;  
&gt; &gt; -    page-&gt;mainFrame()-&gt;load(QUrl(&quot;qrc:///frametest/index.html&quot;));
&gt; &gt; +    m_view-&gt;setUrl(QUrl(&quot;data:text/html,foo&quot;));
&gt; 
&gt; Is the frametest/index.html not needed anymore now?

it is not needed for the test &quot;errorPageExtension&quot; then I replaced it for a simpler URL. It is needed for the newly added &quot;errorPageExtensionForFrameset&quot; test, which specifically tests &apos;framesets&apos;.

&gt; Why is this needed. Is it part of the test? Add a comment
&gt; &gt; -    QCOMPARE(page-&gt;history()-&gt;currentItem().url(), QUrl(&quot;qrc:///frametest/index.html&quot;));
&gt; &gt; +    QCOMPARE(page-&gt;history()-&gt;currentItem().url(), QUrl(&quot;data:text/html,foo&quot;));

since i changed the url (see my answer to the question above ) it is needed.

&gt; &gt; +    m_view-&gt;setPage(0);

it resets the page for the next test.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>164227</commentid>
    <comment_count>7</comment_count>
      <attachid>43359</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2009-11-17 07:14:46 -0800</bug_when>
    <thetext>Comment on attachment 43359
patch 0.2

ChangeLog was not updated!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>164231</commentid>
    <comment_count>8</comment_count>
      <attachid>43364</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2009-11-17 07:43:30 -0800</bug_when>
    <thetext>Created attachment 43364
(committed r51076) patch 0.3

Update changelog, sorry about that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>164257</commentid>
    <comment_count>9</comment_count>
      <attachid>43364</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2009-11-17 09:58:46 -0800</bug_when>
    <thetext>Comment on attachment 43364
(committed r51076) patch 0.3

thx for reviewing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>164258</commentid>
    <comment_count>10</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2009-11-17 09:59:04 -0800</bug_when>
    <thetext>landed r51076</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>43357</attachid>
            <date>2009-11-17 05:49:16 -0800</date>
            <delta_ts>2009-11-17 06:04:22 -0800</delta_ts>
            <desc>patch 0.1</desc>
            <filename>0001--Qt-better-test-coverage-for-ErrorPageExtension.patch</filename>
            <type>text/plain</type>
            <size>4771</size>
            <attacher name="Antonio Gomes">tonikitoo</attacher>
            
              <data encoding="base64">RnJvbSA1NDc4MDA3NWRjZmE3Yjc3MWY4ZjVkZTAyYzc3ZTNlMjljZDMzMDQ5IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K
RGF0ZTogVHVlLCAxNyBOb3YgMjAwOSAwOTo0NzoyOSAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFtR
dF0gYmV0dGVyIHRlc3QgY292ZXJhZ2UgZm9yIEVycm9yUGFnZUV4dGVuc2lvbgogaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNTgzCgpSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KCkltcHJvdmVkIHRoZSBjb3ZlcmFnZSBvZiBjdXJyZW50IEVycm9yUGFnZUV4dGVu
c2lvbiB0ZXN0cyBieQphZGRpbmcgYXV0b3Rlc3RzIGludm9sdmluZyBmcmFtZXNldCBhbmQgaWZy
YW1lcy4KCiogdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcDoKKHRzdF9RV2ViUGFnZTo6
aW5maW5pdGVMb29wSlMpOgooRXJyb3JQYWdlOjpleHRlbnNpb24pOgoodHN0X1FXZWJQYWdlOjpl
cnJvclBhZ2VFeHRlbnNpb24pOgoodHN0X1FXZWJQYWdlOjplcnJvclBhZ2VFeHRlbnNpb25fd2l0
aElGcmFtZXMpOgoodHN0X1FXZWJQYWdlOjplcnJvclBhZ2VFeHRlbnNpb25fd2l0aEZyYW1lc2V0
KToKLS0tCiBXZWJLaXQvcXQvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTcg
KysrKysrKysrKwogV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAgfCAg
IDQ2ICsrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDU1IGlu
c2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0NoYW5n
ZUxvZyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5kZXggODFiNDEyMi4uNjJkZTVhNiAxMDA2NDQK
LS0tIGEvV2ViS2l0L3F0L0NoYW5nZUxvZworKysgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0x
LDMgKzEsMjAgQEAKKzIwMDktMTEtMTcgIEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29Ad2Via2l0
Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb
UXRdIGJldHRlciB0ZXN0IGNvdmVyYWdlIGZvciBFcnJvclBhZ2VFeHRlbnNpb24KKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNTgzCisKKyAgICAgICAg
SW1wcm92ZWQgdGhlIGNvdmVyYWdlIG9mIGN1cnJlbnQgRXJyb3JQYWdlRXh0ZW5zaW9uIHRlc3Rz
IGJ5CisgICAgICAgIGFkZGluZyBhdXRvdGVzdHMgaW52b2x2aW5nIGZyYW1lc2V0IGFuZCBpZnJh
bWVzLgorCisgICAgICAgICogdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcDoKKyAgICAg
ICAgKHRzdF9RV2ViUGFnZTo6aW5maW5pdGVMb29wSlMpOgorICAgICAgICAoRXJyb3JQYWdlOjpl
eHRlbnNpb24pOgorICAgICAgICAodHN0X1FXZWJQYWdlOjplcnJvclBhZ2VFeHRlbnNpb24pOgor
ICAgICAgICAodHN0X1FXZWJQYWdlOjplcnJvclBhZ2VFeHRlbnNpb25fd2l0aElGcmFtZXMpOgor
ICAgICAgICAodHN0X1FXZWJQYWdlOjplcnJvclBhZ2VFeHRlbnNpb25fd2l0aEZyYW1lc2V0KToK
KwogMjAwOS0xMS0xNiAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+
CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCmRpZmYg
LS1naXQgYS9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcCBiL1dlYktp
dC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwCmluZGV4IDA5MDM3OWMuLmJmYzhh
NmQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3Bw
CisrKyBiL1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwCkBAIC0xNDcs
NiArMTQ3LDggQEAgcHJpdmF0ZSBzbG90czoKICAgICB2b2lkIGlucHV0TWV0aG9kcygpOwogICAg
IHZvaWQgZGVmYXVsdFRleHRFbmNvZGluZygpOwogICAgIHZvaWQgZXJyb3JQYWdlRXh0ZW5zaW9u
KCk7CisgICAgdm9pZCBlcnJvclBhZ2VFeHRlbnNpb25fd2l0aElGcmFtZXMoKTsKKyAgICB2b2lk
IGVycm9yUGFnZUV4dGVuc2lvbl93aXRoRnJhbWVzZXQoKTsKIAogICAgIHZvaWQgY3Jhc2hUZXN0
c19MYXp5SW5pdGlhbGl6YXRpb25PZk1haW5GcmFtZSgpOwogCkBAIC0yNTAsNiArMjUyLDcgQEAg
cHVibGljIHNsb3RzOgogCiB2b2lkIHRzdF9RV2ViUGFnZTo6aW5maW5pdGVMb29wSlMoKQogewor
ICAgIHJldHVybjsKICAgICBKU1Rlc3RQYWdlKiBuZXdQYWdlID0gbmV3IEpTVGVzdFBhZ2UobV92
aWV3KTsKICAgICBtX3ZpZXctPnNldFBhZ2UobmV3UGFnZSk7CiAgICAgbV92aWV3LT5zZXRIdG1s
KFFTdHJpbmcoIjxodG1sPjxib2R5dGVzdDwvYm9keT48L2h0bWw+IiksIFFVcmwoKSk7CkBAIC0x
NjI5LDEyICsxNjMyLDggQEAgcHVibGljOgogICAgICAgICBjb25zdCBFcnJvclBhZ2VFeHRlbnNp
b25PcHRpb24qIGluZm8gPSBzdGF0aWNfY2FzdDxjb25zdCBFcnJvclBhZ2VFeHRlbnNpb25PcHRp
b24qPihvcHRpb24pOwogICAgICAgICBFcnJvclBhZ2VFeHRlbnNpb25SZXR1cm4qIGVycm9yUGFn
ZSA9IHN0YXRpY19jYXN0PEVycm9yUGFnZUV4dGVuc2lvblJldHVybio+KG91dHB1dCk7CiAKLSAg
ICAgICAgaWYgKGluZm8tPmZyYW1lID09IG1haW5GcmFtZSgpKSB7Ci0gICAgICAgICAgICBlcnJv
clBhZ2UtPmNvbnRlbnQgPSAiZGF0YTp0ZXh0L2h0bWwsZXJyb3IiOwotICAgICAgICAgICAgcmV0
dXJuIHRydWU7Ci0gICAgICAgIH0KLQotICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIGVy
cm9yUGFnZS0+Y29udGVudCA9ICJkYXRhOnRleHQvaHRtbCxlcnJvciI7CisgICAgICAgIHJldHVy
biB0cnVlOwogICAgIH0KIH07CiAKQEAgLTE2NDUsNyArMTY0NCw4IEBAIHZvaWQgdHN0X1FXZWJQ
YWdlOjplcnJvclBhZ2VFeHRlbnNpb24oKQogCiAgICAgUVNpZ25hbFNweSBzcHlMb2FkRmluaXNo
ZWQobV92aWV3LCBTSUdOQUwobG9hZEZpbmlzaGVkKGJvb2wpKSk7CiAKLSAgICBwYWdlLT5tYWlu
RnJhbWUoKS0+bG9hZChRVXJsKCJxcmM6Ly8vZnJhbWV0ZXN0L2luZGV4Lmh0bWwiKSk7CisgICAg
bV92aWV3LT5zZXRVcmwoUVVybCgiZGF0YTp0ZXh0L2h0bWwsZm9vIikpOworICAgIFFUZXN0Ojpx
V2FpdCgyMDAwKTsKICAgICBRVFJZX0NPTVBBUkUoc3B5TG9hZEZpbmlzaGVkLmNvdW50KCksIDEp
OwogCiAgICAgcGFnZS0+bWFpbkZyYW1lKCktPnNldFVybChRVXJsKCJodHRwOi8vbm9uLmV4aXN0
ZW50L3VybCIpKTsKQEAgLTE2NzEsNyArMTY3MSwzNyBAQCB2b2lkIHRzdF9RV2ViUGFnZTo6ZXJy
b3JQYWdlRXh0ZW5zaW9uKCkKICAgICBRVGVzdDo6cVdhaXQoMjAwMCk7CiAgICAgUUNPTVBBUkUo
cGFnZS0+aGlzdG9yeSgpLT5jYW5Hb0JhY2soKSwgZmFsc2UpOwogICAgIFFDT01QQVJFKHBhZ2Ut
Pmhpc3RvcnkoKS0+Y2FuR29Gb3J3YXJkKCksIHRydWUpOwotICAgIFFDT01QQVJFKHBhZ2UtPmhp
c3RvcnkoKS0+Y3VycmVudEl0ZW0oKS51cmwoKSwgUVVybCgicXJjOi8vL2ZyYW1ldGVzdC9pbmRl
eC5odG1sIikpOworICAgIFFDT01QQVJFKHBhZ2UtPmhpc3RvcnkoKS0+Y3VycmVudEl0ZW0oKS51
cmwoKSwgUVVybCgiZGF0YTp0ZXh0L2h0bWwsZm9vIikpOworCisgICAgbV92aWV3LT5zZXRQYWdl
KDApOworfQorCit2b2lkIHRzdF9RV2ViUGFnZTo6ZXJyb3JQYWdlRXh0ZW5zaW9uX3dpdGhJRnJh
bWVzKCkKK3sKKyAgICBFcnJvclBhZ2UqIHBhZ2UgPSBuZXcgRXJyb3JQYWdlOworICAgIG1fdmll
dy0+c2V0UGFnZShwYWdlKTsKKworICAgIG1fdmlldy0+c2V0SHRtbChRU3RyaW5nKCJkYXRhOnRl
eHQvaHRtbCwiCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIjxoMT5oMTwvaDE+IgorICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICI8aWZyYW1lIHNyYz0nZGF0YTp0ZXh0L2h0bWwsPHAv
PnAnPjwvaWZyYW1lPiIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAiPGlmcmFtZSBzcmM9
J25vbi1leGlzdGVudC5odG1sJz48L2lmcmFtZT4iKSk7CisgICAgUVNpZ25hbFNweSBzcHlMb2Fk
RmluaXNoZWQobV92aWV3LCBTSUdOQUwobG9hZEZpbmlzaGVkKGJvb2wpKSk7CisgICAgUVRSWV9D
T01QQVJFKHNweUxvYWRGaW5pc2hlZC5jb3VudCgpLCAxKTsKKworICAgIFFDT01QQVJFKHBhZ2Ut
Pm1haW5GcmFtZSgpLT5jaGlsZEZyYW1lcygpWzFdLT50b1BsYWluVGV4dCgpLCBRU3RyaW5nKCJk
YXRhOnRleHQvaHRtbCxlcnJvciIpKTsKKyAgICBtX3ZpZXctPnNldFBhZ2UoMCk7Cit9CisKK3Zv
aWQgdHN0X1FXZWJQYWdlOjplcnJvclBhZ2VFeHRlbnNpb25fd2l0aEZyYW1lc2V0KCkKK3sKKyAg
ICBFcnJvclBhZ2UqIHBhZ2UgPSBuZXcgRXJyb3JQYWdlOworICAgIG1fdmlldy0+c2V0UGFnZShw
YWdlKTsKKworICAgIG1fdmlldy0+bG9hZChRVXJsKCJxcmM6Ly8vZnJhbWV0ZXN0L2luZGV4Lmh0
bWwiKSk7CisKKyAgICBRU2lnbmFsU3B5IHNweUxvYWRGaW5pc2hlZChtX3ZpZXcsIFNJR05BTChs
b2FkRmluaXNoZWQoYm9vbCkpKTsKKyAgICBRVFJZX0NPTVBBUkUoc3B5TG9hZEZpbmlzaGVkLmNv
dW50KCksIDEpOworICAgIFFDT01QQVJFKHBhZ2UtPm1haW5GcmFtZSgpLT5jaGlsZEZyYW1lcygp
WzFdLT50b1BsYWluVGV4dCgpLCBRU3RyaW5nKCJkYXRhOnRleHQvaHRtbCxlcnJvciIpKTsKIAog
ICAgIG1fdmlldy0+c2V0UGFnZSgwKTsKIH0KLS0gCjEuNi4wLjQKCg==
</data>
<flag name="review"
          id="25054"
          type_id="1"
          status="-"
          setter="kenneth"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>43359</attachid>
            <date>2009-11-17 06:04:22 -0800</date>
            <delta_ts>2009-11-17 07:43:30 -0800</delta_ts>
            <desc>patch 0.2</desc>
            <filename>0001--Qt-better-test-coverage-for-ErrorPageExtension.patch</filename>
            <type>text/plain</type>
            <size>4696</size>
            <attacher name="Antonio Gomes">tonikitoo</attacher>
            
              <data encoding="base64">RnJvbSBhYWM0YTBjOWUzNGE2MTYyYzM0YTdiYzAwZTEwMTYyNTFhZGY0ZmViIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K
RGF0ZTogVHVlLCAxNyBOb3YgMjAwOSAwOTo0NzoyOSAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFtR
dF0gYmV0dGVyIHRlc3QgY292ZXJhZ2UgZm9yIEVycm9yUGFnZUV4dGVuc2lvbgogaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNTgzCgpSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KCkltcHJvdmVkIHRoZSBjb3ZlcmFnZSBvZiBjdXJyZW50IEVycm9yUGFnZUV4dGVu
c2lvbiB0ZXN0cyBieQphZGRpbmcgYXV0b3Rlc3RzIGludm9sdmluZyBmcmFtZXNldCBhbmQgaWZy
YW1lcy4KCiogdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcDoKKHRzdF9RV2ViUGFnZTo6
aW5maW5pdGVMb29wSlMpOgooRXJyb3JQYWdlOjpleHRlbnNpb24pOgoodHN0X1FXZWJQYWdlOjpl
cnJvclBhZ2VFeHRlbnNpb24pOgoodHN0X1FXZWJQYWdlOjplcnJvclBhZ2VFeHRlbnNpb25fd2l0
aElGcmFtZXMpOgoodHN0X1FXZWJQYWdlOjplcnJvclBhZ2VFeHRlbnNpb25fd2l0aEZyYW1lc2V0
KToKLS0tCiBXZWJLaXQvcXQvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTcg
KysrKysrKysrKysKIFdlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwIHwg
ICA0NSArKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCA1MyBp
bnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFu
Z2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDgxYjQxMjIuLjYyZGU1YTYgMTAwNjQ0
Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAt
MSwzICsxLDIwIEBACisyMDA5LTExLTE3ICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdlYmtp
dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
W1F0XSBiZXR0ZXIgdGVzdCBjb3ZlcmFnZSBmb3IgRXJyb3JQYWdlRXh0ZW5zaW9uCisgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTU4MworCisgICAgICAg
IEltcHJvdmVkIHRoZSBjb3ZlcmFnZSBvZiBjdXJyZW50IEVycm9yUGFnZUV4dGVuc2lvbiB0ZXN0
cyBieQorICAgICAgICBhZGRpbmcgYXV0b3Rlc3RzIGludm9sdmluZyBmcmFtZXNldCBhbmQgaWZy
YW1lcy4KKworICAgICAgICAqIHRlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHA6CisgICAg
ICAgICh0c3RfUVdlYlBhZ2U6OmluZmluaXRlTG9vcEpTKToKKyAgICAgICAgKEVycm9yUGFnZTo6
ZXh0ZW5zaW9uKToKKyAgICAgICAgKHRzdF9RV2ViUGFnZTo6ZXJyb3JQYWdlRXh0ZW5zaW9uKToK
KyAgICAgICAgKHRzdF9RV2ViUGFnZTo6ZXJyb3JQYWdlRXh0ZW5zaW9uX3dpdGhJRnJhbWVzKToK
KyAgICAgICAgKHRzdF9RV2ViUGFnZTo6ZXJyb3JQYWdlRXh0ZW5zaW9uX3dpdGhGcmFtZXNldCk6
CisKIDIwMDktMTEtMTYgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29t
PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpkaWZm
IC0tZ2l0IGEvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAgYi9XZWJL
aXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcAppbmRleCAwOTAzNzljLi5kMjM2
NjI2IDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNw
cAorKysgYi9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcApAQCAtMTQ3
LDYgKzE0Nyw4IEBAIHByaXZhdGUgc2xvdHM6CiAgICAgdm9pZCBpbnB1dE1ldGhvZHMoKTsKICAg
ICB2b2lkIGRlZmF1bHRUZXh0RW5jb2RpbmcoKTsKICAgICB2b2lkIGVycm9yUGFnZUV4dGVuc2lv
bigpOworICAgIHZvaWQgZXJyb3JQYWdlRXh0ZW5zaW9uRm9ySUZyYW1lcygpOworICAgIHZvaWQg
ZXJyb3JQYWdlRXh0ZW5zaW9uRm9yRnJhbWVzZXQoKTsKIAogICAgIHZvaWQgY3Jhc2hUZXN0c19M
YXp5SW5pdGlhbGl6YXRpb25PZk1haW5GcmFtZSgpOwogCkBAIC0xNjI5LDEyICsxNjMxLDggQEAg
cHVibGljOgogICAgICAgICBjb25zdCBFcnJvclBhZ2VFeHRlbnNpb25PcHRpb24qIGluZm8gPSBz
dGF0aWNfY2FzdDxjb25zdCBFcnJvclBhZ2VFeHRlbnNpb25PcHRpb24qPihvcHRpb24pOwogICAg
ICAgICBFcnJvclBhZ2VFeHRlbnNpb25SZXR1cm4qIGVycm9yUGFnZSA9IHN0YXRpY19jYXN0PEVy
cm9yUGFnZUV4dGVuc2lvblJldHVybio+KG91dHB1dCk7CiAKLSAgICAgICAgaWYgKGluZm8tPmZy
YW1lID09IG1haW5GcmFtZSgpKSB7Ci0gICAgICAgICAgICBlcnJvclBhZ2UtPmNvbnRlbnQgPSAi
ZGF0YTp0ZXh0L2h0bWwsZXJyb3IiOwotICAgICAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgICAg
IH0KLQotICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIGVycm9yUGFnZS0+Y29udGVudCA9
ICJkYXRhOnRleHQvaHRtbCxlcnJvciI7CisgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KIH07
CiAKQEAgLTE2NDUsMTEgKzE2NDMsMTAgQEAgdm9pZCB0c3RfUVdlYlBhZ2U6OmVycm9yUGFnZUV4
dGVuc2lvbigpCiAKICAgICBRU2lnbmFsU3B5IHNweUxvYWRGaW5pc2hlZChtX3ZpZXcsIFNJR05B
TChsb2FkRmluaXNoZWQoYm9vbCkpKTsKIAotICAgIHBhZ2UtPm1haW5GcmFtZSgpLT5sb2FkKFFV
cmwoInFyYzovLy9mcmFtZXRlc3QvaW5kZXguaHRtbCIpKTsKKyAgICBtX3ZpZXctPnNldFVybChR
VXJsKCJkYXRhOnRleHQvaHRtbCxmb28iKSk7CiAgICAgUVRSWV9DT01QQVJFKHNweUxvYWRGaW5p
c2hlZC5jb3VudCgpLCAxKTsKIAogICAgIHBhZ2UtPm1haW5GcmFtZSgpLT5zZXRVcmwoUVVybCgi
aHR0cDovL25vbi5leGlzdGVudC91cmwiKSk7Ci0gICAgUVRlc3Q6OnFXYWl0KDIwMDApOwogICAg
IFFUUllfQ09NUEFSRShzcHlMb2FkRmluaXNoZWQuY291bnQoKSwgMik7CiAgICAgUUNPTVBBUkUo
cGFnZS0+bWFpbkZyYW1lKCktPnRvUGxhaW5UZXh0KCksIFFTdHJpbmcoImRhdGE6dGV4dC9odG1s
LGVycm9yIikpOwogICAgIFFDT01QQVJFKHBhZ2UtPmhpc3RvcnkoKS0+Y291bnQoKSwgMik7CkBA
IC0xNjcxLDcgKzE2NjgsMzcgQEAgdm9pZCB0c3RfUVdlYlBhZ2U6OmVycm9yUGFnZUV4dGVuc2lv
bigpCiAgICAgUVRlc3Q6OnFXYWl0KDIwMDApOwogICAgIFFDT01QQVJFKHBhZ2UtPmhpc3Rvcnko
KS0+Y2FuR29CYWNrKCksIGZhbHNlKTsKICAgICBRQ09NUEFSRShwYWdlLT5oaXN0b3J5KCktPmNh
bkdvRm9yd2FyZCgpLCB0cnVlKTsKLSAgICBRQ09NUEFSRShwYWdlLT5oaXN0b3J5KCktPmN1cnJl
bnRJdGVtKCkudXJsKCksIFFVcmwoInFyYzovLy9mcmFtZXRlc3QvaW5kZXguaHRtbCIpKTsKKyAg
ICBRQ09NUEFSRShwYWdlLT5oaXN0b3J5KCktPmN1cnJlbnRJdGVtKCkudXJsKCksIFFVcmwoImRh
dGE6dGV4dC9odG1sLGZvbyIpKTsKKworICAgIG1fdmlldy0+c2V0UGFnZSgwKTsKK30KKwordm9p
ZCB0c3RfUVdlYlBhZ2U6OmVycm9yUGFnZUV4dGVuc2lvbkZvcklGcmFtZXMoKQoreworICAgIEVy
cm9yUGFnZSogcGFnZSA9IG5ldyBFcnJvclBhZ2U7CisgICAgbV92aWV3LT5zZXRQYWdlKHBhZ2Up
OworCisgICAgbV92aWV3LT5zZXRIdG1sKFFTdHJpbmcoImRhdGE6dGV4dC9odG1sLCIKKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAiPGgxPmgxPC9oMT4iCisgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIjxpZnJhbWUgc3JjPSdkYXRhOnRleHQvaHRtbCw8cC8+cCc+PC9pZnJhbWU+Igor
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICI8aWZyYW1lIHNyYz0nbm9uLWV4aXN0ZW50Lmh0
bWwnPjwvaWZyYW1lPiIpKTsKKyAgICBRU2lnbmFsU3B5IHNweUxvYWRGaW5pc2hlZChtX3ZpZXcs
IFNJR05BTChsb2FkRmluaXNoZWQoYm9vbCkpKTsKKyAgICBRVFJZX0NPTVBBUkUoc3B5TG9hZEZp
bmlzaGVkLmNvdW50KCksIDEpOworCisgICAgUUNPTVBBUkUocGFnZS0+bWFpbkZyYW1lKCktPmNo
aWxkRnJhbWVzKClbMV0tPnRvUGxhaW5UZXh0KCksIFFTdHJpbmcoImRhdGE6dGV4dC9odG1sLGVy
cm9yIikpOworICAgIG1fdmlldy0+c2V0UGFnZSgwKTsKK30KKwordm9pZCB0c3RfUVdlYlBhZ2U6
OmVycm9yUGFnZUV4dGVuc2lvbkZvckZyYW1lc2V0KCkKK3sKKyAgICBFcnJvclBhZ2UqIHBhZ2Ug
PSBuZXcgRXJyb3JQYWdlOworICAgIG1fdmlldy0+c2V0UGFnZShwYWdlKTsKKworICAgIG1fdmll
dy0+bG9hZChRVXJsKCJxcmM6Ly8vZnJhbWV0ZXN0L2luZGV4Lmh0bWwiKSk7CisKKyAgICBRU2ln
bmFsU3B5IHNweUxvYWRGaW5pc2hlZChtX3ZpZXcsIFNJR05BTChsb2FkRmluaXNoZWQoYm9vbCkp
KTsKKyAgICBRVFJZX0NPTVBBUkUoc3B5TG9hZEZpbmlzaGVkLmNvdW50KCksIDEpOworICAgIFFD
T01QQVJFKHBhZ2UtPm1haW5GcmFtZSgpLT5jaGlsZEZyYW1lcygpWzFdLT50b1BsYWluVGV4dCgp
LCBRU3RyaW5nKCJkYXRhOnRleHQvaHRtbCxlcnJvciIpKTsKIAogICAgIG1fdmlldy0+c2V0UGFn
ZSgwKTsKIH0KLS0gCjEuNi4wLjQKCg==
</data>
<flag name="review"
          id="25057"
          type_id="1"
          status="-"
          setter="kenneth"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>43364</attachid>
            <date>2009-11-17 07:43:30 -0800</date>
            <delta_ts>2009-11-17 09:58:46 -0800</delta_ts>
            <desc>(committed r51076) patch 0.3</desc>
            <filename>0001--Qt-better-test-coverage-for-ErrorPageExtension.patch</filename>
            <type>text/plain</type>
            <size>5041</size>
            <attacher name="Antonio Gomes">tonikitoo</attacher>
            
              <data encoding="base64">RnJvbSA2NGExNGEwMmE2MzYyN2JkOTc2YmIwMmYxZGRhMDI4ZDAxMmJkNjg5IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K
RGF0ZTogVHVlLCAxNyBOb3YgMjAwOSAxMTo0MToxMCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFtR
dF0gYmV0dGVyIHRlc3QgY292ZXJhZ2UgZm9yIEVycm9yUGFnZUV4dGVuc2lvbgogaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNTgzCgpSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KCkltcHJvdmVkIHRoZSBjb3ZlcmFnZSBvZiBjdXJyZW50IEVycm9yUGFnZUV4dGVu
c2lvbiB0ZXN0cyBieQphZGRpbmcgYXV0b3Rlc3RzIGludm9sdmluZyBmcmFtZXNldCBhbmQgaWZy
YW1lcy4KCiogdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcDoKKEVycm9yUGFnZTo6ZXh0
ZW5zaW9uKTogTWFrZSB0aGUgRXJyb3JQYWdlRXh0ZW5zaW9uCnRvIHdvcmsgZm9yIGFsbCBmcmFt
ZXMsIG5vdCBvbmx5IHRoZSBtYWluIGZyYW1lLgoodHN0X1FXZWJQYWdlOjplcnJvclBhZ2VFeHRl
bnNpb24pOiBTdG9wIHVzaW5nCnRoZSAnZnJhbWVzZXQuaHRtbCcgcmVzb3VjZSBpbiB0aGlzIG1l
dGhvZCBzaW5jZQphbiBhdXRvdGVzdCBzcGVjaWZpYyBmb3IgZnJhbWVzZXQncyBpcyBiZWluZyBh
ZGRlZC4KKHRzdF9RV2ViUGFnZTo6ZXJyb3JQYWdlRXh0ZW5zaW9uSW5JRnJhbWVzKTogQWRkZWQu
Cih0c3RfUVdlYlBhZ2U6OmVycm9yUGFnZUV4dGVuc2lvbkluRnJhbWVzZXQpOiBBZGRlZC4KLS0t
CiBXZWJLaXQvcXQvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTkgKysrKysr
KysrKysrCiBXZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcCB8ICAgNDUg
KysrKysrKysrKysrKysrKysrKysrKystLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgNTUgaW5zZXJ0
aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQ2hhbmdlTG9n
IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwppbmRleCA4MWI0MTIyLi4wMjQzYmI3IDEwMDY0NAotLS0g
YS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyAr
MSwyMiBAQAorMjAwOS0xMS0xNyAgQW50b25pbyBHb21lcyAgPHRvbmlraXRvb0B3ZWJraXQub3Jn
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0g
YmV0dGVyIHRlc3QgY292ZXJhZ2UgZm9yIEVycm9yUGFnZUV4dGVuc2lvbgorICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE1ODMKKworICAgICAgICBJbXBy
b3ZlZCB0aGUgY292ZXJhZ2Ugb2YgY3VycmVudCBFcnJvclBhZ2VFeHRlbnNpb24gdGVzdHMgYnkK
KyAgICAgICAgYWRkaW5nIGF1dG90ZXN0cyBpbnZvbHZpbmcgZnJhbWVzZXQgYW5kIGlmcmFtZXMu
CisKKyAgICAgICAgKiB0ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwOgorICAgICAgICAo
RXJyb3JQYWdlOjpleHRlbnNpb24pOiBNYWtlIHRoZSBFcnJvclBhZ2VFeHRlbnNpb24KKyAgICAg
ICAgdG8gd29yayBmb3IgYWxsIGZyYW1lcywgbm90IG9ubHkgdGhlIG1haW4gZnJhbWUuCisgICAg
ICAgICh0c3RfUVdlYlBhZ2U6OmVycm9yUGFnZUV4dGVuc2lvbik6IFN0b3AgdXNpbmcKKyAgICAg
ICAgdGhlICdmcmFtZXNldC5odG1sJyByZXNvdWNlIGluIHRoaXMgbWV0aG9kIHNpbmNlCisgICAg
ICAgIGFuIGF1dG90ZXN0IHNwZWNpZmljIGZvciBmcmFtZXNldCdzIGlzIGJlaW5nIGFkZGVkLgor
ICAgICAgICAodHN0X1FXZWJQYWdlOjplcnJvclBhZ2VFeHRlbnNpb25JbklGcmFtZXMpOiBBZGRl
ZC4KKyAgICAgICAgKHRzdF9RV2ViUGFnZTo6ZXJyb3JQYWdlRXh0ZW5zaW9uSW5GcmFtZXNldCk6
IEFkZGVkLgorCiAyMDA5LTExLTE2ICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5v
a2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNl
bi4KZGlmZiAtLWdpdCBhL1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3Bw
IGIvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAKaW5kZXggMDkwMzc5
Yy4uY2UxZDdiMSAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2Vi
cGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAK
QEAgLTE0Nyw2ICsxNDcsOCBAQCBwcml2YXRlIHNsb3RzOgogICAgIHZvaWQgaW5wdXRNZXRob2Rz
KCk7CiAgICAgdm9pZCBkZWZhdWx0VGV4dEVuY29kaW5nKCk7CiAgICAgdm9pZCBlcnJvclBhZ2VF
eHRlbnNpb24oKTsKKyAgICB2b2lkIGVycm9yUGFnZUV4dGVuc2lvbkluSUZyYW1lcygpOworICAg
IHZvaWQgZXJyb3JQYWdlRXh0ZW5zaW9uSW5GcmFtZXNldCgpOwogCiAgICAgdm9pZCBjcmFzaFRl
c3RzX0xhenlJbml0aWFsaXphdGlvbk9mTWFpbkZyYW1lKCk7CiAKQEAgLTE2MjksMTIgKzE2MzEs
OCBAQCBwdWJsaWM6CiAgICAgICAgIGNvbnN0IEVycm9yUGFnZUV4dGVuc2lvbk9wdGlvbiogaW5m
byA9IHN0YXRpY19jYXN0PGNvbnN0IEVycm9yUGFnZUV4dGVuc2lvbk9wdGlvbio+KG9wdGlvbik7
CiAgICAgICAgIEVycm9yUGFnZUV4dGVuc2lvblJldHVybiogZXJyb3JQYWdlID0gc3RhdGljX2Nh
c3Q8RXJyb3JQYWdlRXh0ZW5zaW9uUmV0dXJuKj4ob3V0cHV0KTsKIAotICAgICAgICBpZiAoaW5m
by0+ZnJhbWUgPT0gbWFpbkZyYW1lKCkpIHsKLSAgICAgICAgICAgIGVycm9yUGFnZS0+Y29udGVu
dCA9ICJkYXRhOnRleHQvaHRtbCxlcnJvciI7Ci0gICAgICAgICAgICByZXR1cm4gdHJ1ZTsKLSAg
ICAgICAgfQotCi0gICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgZXJyb3JQYWdlLT5jb250
ZW50ID0gImRhdGE6dGV4dC9odG1sLGVycm9yIjsKKyAgICAgICAgcmV0dXJuIHRydWU7CiAgICAg
fQogfTsKIApAQCAtMTY0NSwxMSArMTY0MywxMCBAQCB2b2lkIHRzdF9RV2ViUGFnZTo6ZXJyb3JQ
YWdlRXh0ZW5zaW9uKCkKIAogICAgIFFTaWduYWxTcHkgc3B5TG9hZEZpbmlzaGVkKG1fdmlldywg
U0lHTkFMKGxvYWRGaW5pc2hlZChib29sKSkpOwogCi0gICAgcGFnZS0+bWFpbkZyYW1lKCktPmxv
YWQoUVVybCgicXJjOi8vL2ZyYW1ldGVzdC9pbmRleC5odG1sIikpOworICAgIG1fdmlldy0+c2V0
VXJsKFFVcmwoImRhdGE6dGV4dC9odG1sLGZvbyIpKTsKICAgICBRVFJZX0NPTVBBUkUoc3B5TG9h
ZEZpbmlzaGVkLmNvdW50KCksIDEpOwogCiAgICAgcGFnZS0+bWFpbkZyYW1lKCktPnNldFVybChR
VXJsKCJodHRwOi8vbm9uLmV4aXN0ZW50L3VybCIpKTsKLSAgICBRVGVzdDo6cVdhaXQoMjAwMCk7
CiAgICAgUVRSWV9DT01QQVJFKHNweUxvYWRGaW5pc2hlZC5jb3VudCgpLCAyKTsKICAgICBRQ09N
UEFSRShwYWdlLT5tYWluRnJhbWUoKS0+dG9QbGFpblRleHQoKSwgUVN0cmluZygiZGF0YTp0ZXh0
L2h0bWwsZXJyb3IiKSk7CiAgICAgUUNPTVBBUkUocGFnZS0+aGlzdG9yeSgpLT5jb3VudCgpLCAy
KTsKQEAgLTE2NzEsNyArMTY2OCwzNyBAQCB2b2lkIHRzdF9RV2ViUGFnZTo6ZXJyb3JQYWdlRXh0
ZW5zaW9uKCkKICAgICBRVGVzdDo6cVdhaXQoMjAwMCk7CiAgICAgUUNPTVBBUkUocGFnZS0+aGlz
dG9yeSgpLT5jYW5Hb0JhY2soKSwgZmFsc2UpOwogICAgIFFDT01QQVJFKHBhZ2UtPmhpc3Rvcnko
KS0+Y2FuR29Gb3J3YXJkKCksIHRydWUpOwotICAgIFFDT01QQVJFKHBhZ2UtPmhpc3RvcnkoKS0+
Y3VycmVudEl0ZW0oKS51cmwoKSwgUVVybCgicXJjOi8vL2ZyYW1ldGVzdC9pbmRleC5odG1sIikp
OworICAgIFFDT01QQVJFKHBhZ2UtPmhpc3RvcnkoKS0+Y3VycmVudEl0ZW0oKS51cmwoKSwgUVVy
bCgiZGF0YTp0ZXh0L2h0bWwsZm9vIikpOworCisgICAgbV92aWV3LT5zZXRQYWdlKDApOworfQor
Cit2b2lkIHRzdF9RV2ViUGFnZTo6ZXJyb3JQYWdlRXh0ZW5zaW9uSW5JRnJhbWVzKCkKK3sKKyAg
ICBFcnJvclBhZ2UqIHBhZ2UgPSBuZXcgRXJyb3JQYWdlOworICAgIG1fdmlldy0+c2V0UGFnZShw
YWdlKTsKKworICAgIG1fdmlldy0+c2V0SHRtbChRU3RyaW5nKCJkYXRhOnRleHQvaHRtbCwiCisg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIjxoMT5oMTwvaDE+IgorICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICI8aWZyYW1lIHNyYz0nZGF0YTp0ZXh0L2h0bWwsPHAvPnAnPjwvaWZyYW1l
PiIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAiPGlmcmFtZSBzcmM9J25vbi1leGlzdGVu
dC5odG1sJz48L2lmcmFtZT4iKSk7CisgICAgUVNpZ25hbFNweSBzcHlMb2FkRmluaXNoZWQobV92
aWV3LCBTSUdOQUwobG9hZEZpbmlzaGVkKGJvb2wpKSk7CisgICAgUVRSWV9DT01QQVJFKHNweUxv
YWRGaW5pc2hlZC5jb3VudCgpLCAxKTsKKworICAgIFFDT01QQVJFKHBhZ2UtPm1haW5GcmFtZSgp
LT5jaGlsZEZyYW1lcygpWzFdLT50b1BsYWluVGV4dCgpLCBRU3RyaW5nKCJkYXRhOnRleHQvaHRt
bCxlcnJvciIpKTsKKyAgICBtX3ZpZXctPnNldFBhZ2UoMCk7Cit9CisKK3ZvaWQgdHN0X1FXZWJQ
YWdlOjplcnJvclBhZ2VFeHRlbnNpb25JbkZyYW1lc2V0KCkKK3sKKyAgICBFcnJvclBhZ2UqIHBh
Z2UgPSBuZXcgRXJyb3JQYWdlOworICAgIG1fdmlldy0+c2V0UGFnZShwYWdlKTsKKworICAgIG1f
dmlldy0+bG9hZChRVXJsKCJxcmM6Ly8vZnJhbWV0ZXN0L2luZGV4Lmh0bWwiKSk7CisKKyAgICBR
U2lnbmFsU3B5IHNweUxvYWRGaW5pc2hlZChtX3ZpZXcsIFNJR05BTChsb2FkRmluaXNoZWQoYm9v
bCkpKTsKKyAgICBRVFJZX0NPTVBBUkUoc3B5TG9hZEZpbmlzaGVkLmNvdW50KCksIDEpOworICAg
IFFDT01QQVJFKHBhZ2UtPm1haW5GcmFtZSgpLT5jaGlsZEZyYW1lcygpWzFdLT50b1BsYWluVGV4
dCgpLCBRU3RyaW5nKCJkYXRhOnRleHQvaHRtbCxlcnJvciIpKTsKIAogICAgIG1fdmlldy0+c2V0
UGFnZSgwKTsKIH0KLS0gCjEuNi4wLjQKCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>