31575 2009-11-16 22:01:40 -0800 Fix WebKit build when JAVASCRIPT_DEBUGGER is disabled 2009-11-18 23:56:57 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned commit-queue dglazkov dimich eric mnaganov oliver oldest_to_newest 164155 0 laszlo.gombos 2009-11-16 22:01:40 -0800 Building QtWebKit with --minimal will result in the following linker error: WebKitBuildQt/Release/lib/libQtWebKit.so: undefined reference to `WebCore::JSConsole::profile(JSC::ExecState*, JSC::ArgList const&)' WebKitBuildQt/Release/lib/libQtWebKit.so: undefined reference to `WebCore::JSConsole::profileEnd(JSC::ExecState*, JSC::ArgList const&)' This is probably caused by r50933. 164313 1 43377 mnaganov 2009-11-17 12:40:03 -0800 Created attachment 43377 Proposed fix I tried to make 'console.profile()' and 'console.profileEnd()' declarations platform-dependent, but for some reason this doesn't work. So I took another route and made their implementations empty in the case when there is no debugger. Laszlo, can you try your debuggerless Qt build with this patch, please? 164326 2 laszlo.gombos 2009-11-17 13:12:30 -0800 I can confirm that the proposed patch builds for JSC + ENABLE_JAVASCRIPT_DEBUGGER=0 case (tested with build-webkit --qt --minimal) 164479 3 dimich 2009-11-18 00:08:45 -0800 > I tried to make 'console.profile()' and 'console.profileEnd()' declarations > platform-dependent, but for some reason this doesn't work. So I took another > route and made their implementations empty in the case when there is no > debugger. It seems that defined(V8_BINDING) && V8_BINDING is the way used in IDL files to check if the bindings are generated for V8. It might be a cleaner way to do this. 164507 4 43418 mnaganov 2009-11-18 02:09:20 -0800 Created attachment 43418 an easier way Thanks, Dimich! That's really an easier way, and it works with Chromium. Laszlo, can I ask you to test this patch, please? If it works for you, I'll find someone to review and submit it. 164772 5 43418 eric 2009-11-18 15:35:07 -0800 Comment on attachment 43418 an easier way I don't understand why the chromium build doesn't define ENABLE_JAVASCRIPT_DEBUGGER. Probably because ENABLE_JAVASCRIPT_DEBUGGER depends on JSC? If that's the case then we really should come up with a define for the debugger which would not depend on JSC. 164776 6 eric 2009-11-18 15:37:10 -0800 (I'm not sure who the JSC debugger expert is these days, but ccing Oliver so that someone in JSC land sees this go by.) 164809 7 43418 commit-queue 2009-11-18 16:27:06 -0800 Comment on attachment 43418 an easier way Clearing flags on attachment: 43418 Committed r51153: <http://trac.webkit.org/changeset/51153> 164810 8 commit-queue 2009-11-18 16:27:14 -0800 All reviewed patches have been landed. Closing bug. 164912 9 laszlo.gombos 2009-11-18 22:14:48 -0800 Thanks ! 164923 10 mnaganov 2009-11-18 23:56:57 -0800 (In reply to comment #5) > (From update of attachment 43418 [details]) > I don't understand why the chromium build doesn't define > ENABLE_JAVASCRIPT_DEBUGGER. Probably because ENABLE_JAVASCRIPT_DEBUGGER > depends on JSC? If that's the case then we really should come up with a define > for the debugger which would not depend on JSC. Yes, currently the code under ENABLE_JAVASCRIPT_DEBUGGER defines is tied directly to JSC, so it won't event compile in Chromium. 43377 2009-11-17 12:40:03 -0800 2009-11-18 02:09:20 -0800 Proposed fix fix-qt-build-patch text/plain 1697 mnaganov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTY1ZWU2MS4uYzUyNjdiMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0xMS0xNyAgTWlraGFpbCBOYWdh bm92ICA8bW5hZ2Fub3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZpeCBRdCBidWlsZCB3aXRob3V0IEphdmFTY3JpcHQgZGVi dWdnZXIuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTMxNTc1CisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0NvbnNvbGVDdXN0b20uY3BwOgorICAg ICAgICAoV2ViQ29yZTo6SlNDb25zb2xlOjpwcm9maWxlKToKKyAgICAgICAgKFdlYkNvcmU6OkpT Q29uc29sZTo6cHJvZmlsZUVuZCk6CisKIDIwMDktMTEtMTcgIFBhdmVsIEZlbGRtYW4gIDxwZmVs ZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVGltb3RoeSBIYXRjaGVy LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0NvbnNvbGVDdXN0b20uY3BwIGIv V2ViQ29yZS9iaW5kaW5ncy9qcy9KU0NvbnNvbGVDdXN0b20uY3BwCmluZGV4IDgzNjZiMzkuLmMw ZTFiN2MgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvanMvSlNDb25zb2xlQ3VzdG9tLmNw cAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ29uc29sZUN1c3RvbS5jcHAKQEAgLTUxLDIy ICs1MSwzMiBAQCBKU1ZhbHVlIEpTQ29uc29sZTo6cHJvZmlsZXMoRXhlY1N0YXRlKiBleGVjKSBj b25zdAogICAgIHJldHVybiBjb25zdHJ1Y3RBcnJheShleGVjLCBsaXN0KTsKIH0KIAorI2VuZGlm CisKIEpTVmFsdWUgSlNDb25zb2xlOjpwcm9maWxlKEV4ZWNTdGF0ZSogZXhlYywgY29uc3QgQXJn TGlzdCYgYXJncykKIHsKKyNpZiBFTkFCTEUoSkFWQVNDUklQVF9ERUJVR0dFUikKICAgICBTY3Jp cHRDYWxsU3RhY2sgY2FsbFN0YWNrKGV4ZWMsIGFyZ3MsIDEpOwogICAgIGNvbnN0IFVTdHJpbmcg dGl0bGUgPSB2YWx1ZVRvU3RyaW5nV2l0aFVuZGVmaW5lZE9yTnVsbENoZWNrKGV4ZWMsIGFyZ3Mu YXQoMCkpOwogICAgIGltcGwoKS0+cHJvZmlsZSh0aXRsZSwgJmNhbGxTdGFjayk7CisjZWxzZQor ICAgIFVOVVNFRF9QQVJBTShleGVjKTsKKyAgICBVTlVTRURfUEFSQU0oYXJncyk7CisjZW5kaWYK ICAgICByZXR1cm4ganNVbmRlZmluZWQoKTsKIH0KIAogSlNWYWx1ZSBKU0NvbnNvbGU6OnByb2Zp bGVFbmQoRXhlY1N0YXRlKiBleGVjLCBjb25zdCBBcmdMaXN0JiBhcmdzKQogeworI2lmIEVOQUJM RShKQVZBU0NSSVBUX0RFQlVHR0VSKQogICAgIFNjcmlwdENhbGxTdGFjayBjYWxsU3RhY2soZXhl YywgYXJncywgMSk7CiAgICAgY29uc3QgVVN0cmluZyB0aXRsZSA9IHZhbHVlVG9TdHJpbmdXaXRo VW5kZWZpbmVkT3JOdWxsQ2hlY2soZXhlYywgYXJncy5hdCgwKSk7CiAgICAgaW1wbCgpLT5wcm9m aWxlRW5kKHRpdGxlLCAmY2FsbFN0YWNrKTsKKyNlbHNlCisgICAgVU5VU0VEX1BBUkFNKGV4ZWMp OworICAgIFVOVVNFRF9QQVJBTShhcmdzKTsKKyNlbmRpZgogICAgIHJldHVybiBqc1VuZGVmaW5l ZCgpOwogfQogCi0jZW5kaWYKLQogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo= 43418 2009-11-18 02:09:20 -0800 2009-11-18 16:27:06 -0800 an easier way fix-qt-build-patch text/plain 1205 mnaganov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzFmNWVjYi4uMmYwMDVmYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0xMS0xOCAgTWlraGFpbCBOYWdh bm92ICA8bW5hZ2Fub3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZpeCBRdCBidWlsZCB3aXRob3V0IEphdmFTY3JpcHQgZGVi dWdnZXIuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTMxNTc1CisKKyAgICAgICAgKiBwYWdlL0NvbnNvbGUuaWRsOgorCiAyMDA5LTExLTE3ICBOaWNv bGFzIFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBE YXJpbiBGaXNoZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvQ29uc29sZS5pZGwgYi9XZWJD b3JlL3BhZ2UvQ29uc29sZS5pZGwKaW5kZXggNTc3ZGM3Zi4uYTMxYjYwNSAxMDA2NDQKLS0tIGEv V2ViQ29yZS9wYWdlL0NvbnNvbGUuaWRsCisrKyBiL1dlYkNvcmUvcGFnZS9Db25zb2xlLmlkbApA QCAtNTAsOCArNTAsMTAgQEAgbW9kdWxlIHdpbmRvdyB7CiAgICAgICAgIFtEb250RW51bV0gRE9N U3RyaW5nIGxhc3RXTUxFcnJvck1lc3NhZ2UoKTsKICNlbmRpZgogCisjaWYgZGVmaW5lZChFTkFC TEVfSkFWQVNDUklQVF9ERUJVR0dFUikgJiYgRU5BQkxFX0pBVkFTQ1JJUFRfREVCVUdHRVIgfHwg ZGVmaW5lZChWOF9CSU5ESU5HKSAmJiBWOF9CSU5ESU5HCiAgICAgICAgIFtDdXN0b21dIHZvaWQg cHJvZmlsZShpbiBbQ29udmVydFVuZGVmaW5lZE9yTnVsbFRvTnVsbFN0cmluZ10gRE9NU3RyaW5n IHRpdGxlKTsKICAgICAgICAgW0N1c3RvbV0gdm9pZCBwcm9maWxlRW5kKGluIFtDb252ZXJ0VW5k ZWZpbmVkT3JOdWxsVG9OdWxsU3RyaW5nXSBET01TdHJpbmcgdGl0bGUpOworI2VuZGlmCiAKICAg ICAgICAgdm9pZCB0aW1lKGluIFtDb252ZXJ0VW5kZWZpbmVkT3JOdWxsVG9OdWxsU3RyaW5nXSBE T01TdHJpbmcgdGl0bGUpOwogICAgICAgICBbQ3VzdG9tQXJndW1lbnRIYW5kbGluZ10gdm9pZCB0 aW1lRW5kKGluIFtDb252ZXJ0VW5kZWZpbmVkT3JOdWxsVG9OdWxsU3RyaW5nXSBET01TdHJpbmcg dGl0bGUpOwo=