31571 2009-11-16 18:07:15 -0800 LayoutTests/fast/encoding/char-encoding.html is flaky 2009-11-18 14:12:51 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 jparent jparent oldest_to_newest 164128 0 jparent 2009-11-16 18:07:15 -0800 The test uses a setTimeout of 500 for each test case, which is usually enough, but not always. You can see the flakiness in the Chromium port's flakiness dashboard: http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#tests=LayoutTests%2Ffast%2Fencoding%2Fchar-encoding.html 164132 1 43335 jparent 2009-11-16 18:17:41 -0800 Created attachment 43335 Removes the setTimeout causing the test to be flaky. bdash indicated on irc that it was ok to do so. 164709 2 jparent 2009-11-18 14:12:51 -0800 Committed as http://trac.webkit.org/changeset/51088 43335 2009-11-16 18:17:41 -0800 2009-11-16 18:21:24 -0800 Removes the setTimeout causing the test to be flaky. bdash indicated on irc that it was ok to do so. flakyCharEncoding.txt text/plain 3144 jparent SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUxMDYyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTEtMTYgIEp1bGllIFBhcmVudCAgPGpw YXJlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEVsaW1pbmF0ZSBmbGFraW5lc3MgaW4gY2hhci1lbmNvZGluZyB0ZXN0cyBi eSByZW1vdmluZyBzZXRUaW1lb3V0LAorICAgICAgICB0aGF0IHdhcyB3b3JraW5nIGFyb3VuZCBh biBvbGQgaXNzdWUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zMTU3MQorCisgICAgICAgICogZmFzdC9lbmNvZGluZy9jaGFyLWVuY29kaW5nLW1hYy5o dG1sOgorICAgICAgICAqIGZhc3QvZW5jb2RpbmcvY2hhci1lbmNvZGluZy5odG1sOgorICAgICAg ICAqIGZhc3QvZW5jb2RpbmcvcmVzb3VyY2VzL2NoYXItZW5jb2RpbmctdXRpbHMuanM6CisKIDIw MDktMTEtMTYgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAg RGlzYWJsaW5nIFdlYlNvY2tldCB0ZXN0cyBvbiBUaWdlciBhbmQgV2luZG93cyBhZ2FpbiwgYXMg dGhleSBzdGlsbCB0aW1lIG91dC4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZW5jb2RpbmcvY2hh ci1lbmNvZGluZy1tYWMuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2VuY29k aW5nL2NoYXItZW5jb2RpbmctbWFjLmh0bWwJKHJldmlzaW9uIDUxMDM5KQorKysgTGF5b3V0VGVz dHMvZmFzdC9lbmNvZGluZy9jaGFyLWVuY29kaW5nLW1hYy5odG1sCSh3b3JraW5nIGNvcHkpCkBA IC0yMSw4ICsyMSw2IEBAIHZhciByZXN1bHRzID0gbmV3IE9iamVjdDsKIAogdmFyIGkgPSAwOwog Ci12YXIgdGltZW91dCA9IG51bGw7Ci0KIC8vIExlZ2FjeSBNYWMgZW5jb2RpbmdzLgogdGVzdEVu Y29kZSgnbWFjJywgJ1UrMjIxQScsICclQzMnKTsKIHRlc3RFbmNvZGUoJ21hY2ludG9zaCcsICdV KzIyMUEnLCAnJUMzJyk7CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2VuY29kaW5nL2NoYXItZW5j b2RpbmcuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2VuY29kaW5nL2NoYXIt ZW5jb2RpbmcuaHRtbAkocmV2aXNpb24gNTEwMzkpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2VuY29k aW5nL2NoYXItZW5jb2RpbmcuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMjEsOCArMjEsNiBAQCB2 YXIgcmVzdWx0cyA9IG5ldyBPYmplY3Q7CiAKIHZhciBpID0gMDsKIAotdmFyIHRpbWVvdXQgPSBu dWxsOwotCiB0ZXN0RW5jb2RlKCJVVEYtOCIsICJVKzAwQTAiLCAiJUMyJUEwIik7CiAvL1llbiBz eW1ib2wgaW4gZ2JrCiB0ZXN0RW5jb2RlKCdHQksnLCAnVSswMEE1JywgJyVBMyVBNCcpOwpJbmRl eDogTGF5b3V0VGVzdHMvZmFzdC9lbmNvZGluZy9yZXNvdXJjZXMvY2hhci1lbmNvZGluZy11dGls cy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2VuY29kaW5nL3Jlc291cmNlcy9j aGFyLWVuY29kaW5nLXV0aWxzLmpzCShyZXZpc2lvbiA1MTAzOSkKKysrIExheW91dFRlc3RzL2Zh c3QvZW5jb2RpbmcvcmVzb3VyY2VzL2NoYXItZW5jb2RpbmctdXRpbHMuanMJKHdvcmtpbmcgY29w eSkKQEAgLTI0LDggKzI0LDYgQEAgZnVuY3Rpb24gdGVzdHNEb25lKCkKICAgICAgICAgbGF5b3V0 VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOwogfQogCi12YXIgdGltZW91dCA9IG51bGw7Ci0K IGZ1bmN0aW9uIHByb2Nlc3NSZXN1bHQocmVzdWx0KQogewogICAgIHZhciBjaGFyc2V0UmVzdWx0 cyA9IHJlc3VsdHNbY2hhcnNldHNbaV1dOwpAQCAtMzgsMjQgKzM2LDEyIEBAIGZ1bmN0aW9uIHBy b2Nlc3NSZXN1bHQocmVzdWx0KQogCiBmdW5jdGlvbiBzdWJmcmFtZUxvYWRlZCgpCiB7Ci0gICAg Y2xlYXJUaW1lb3V0KHRpbWVvdXQpOwotICAgIHRpbWVvdXQgPSBudWxsOwogICAgIHZhciBVUkwg PSAiIiArIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdzdWJmcmFtZScpLmNvbnRlbnRXaW5kb3cu bG9jYXRpb247CiAgICAgcHJvY2Vzc1Jlc3VsdChVUkwuc3Vic3RyKFVSTC5pbmRleE9mKCc9Jykg KyAxKSk7CiAgICAgKytpOwogICAgIHJ1blRlc3QoKTsKIH0KIAotLy8gV29ya2Fyb3VuZCBmb3Ig cmRhcjovL3Byb2JsZW0vNTExNDI5NiBuZWVkIHRvIGFsbG93IGZvciAKLS8vIGRvd25sb2FkIG9j Y3VyaW5nLCBhbmQgdGh1cyBub3QgdHJpZ2dlcmluZyBzdWJmcmFtZUxvYWRlZCgpCi1mdW5jdGlv biBsb2FkVGltZWRPdXQoKQotewotICAgIHRpbWVvdXQgPSBudWxsOwotICAgIHByb2Nlc3NSZXN1 bHQoIkZBSUxFRCIpOyAgICAKLSAgICArK2k7Ci0gICAgcnVuVGVzdCgpOwotfQotCiBmdW5jdGlv biBydW5UZXN0KCkKIHsgICAgCiAgICAgaWYgKGkgPj0gY2hhcnNldHMubGVuZ3RoKSB7CkBAIC03 MiwxMCArNTgsNiBAQCBmdW5jdGlvbiBydW5UZXN0KCkKICAgICBzdWJmcmFtZS5vbmxvYWQgPSBz dWJmcmFtZUxvYWRlZDsKICAgICB0ZXh0LnZhbHVlID0gU3RyaW5nLmZyb21DaGFyQ29kZSh1bmlj b2Rlc1tpXS5yZXBsYWNlKCdVKycsICcweCcpKTsKICAgICAKLSAgICAvLyBXb3JrYXJvdW5kIGZv ciByZGFyOi8vcHJvYmxlbS81MTE0Mjk2Ci0gICAgLy8gNTAwIG1pbGxpc2Vjb25kIHRpbWVvdXQu IFRoaXMgd2lsbCBjYXVzZSBhIHNpZ25pZmljYW50IHNsb3dkb3duIG9uIGZhaWx1cmVzLCAKLSAg ICAvLyBidXQgc2hvdWxkIGd1YXJhbnRlZSB3ZSBkb24ndCBmaXJlIHByZW1hdHVyZWx5Ci0gICAg dGltZW91dCA9IHNldFRpbWVvdXQobG9hZFRpbWVkT3V0LCA1MDApOwogICAgIGZvcm0uc3VibWl0 KCk7CiB9CiAK