31566 2009-11-16 14:28:20 -0800 chrome/mac: cmd-left inserts character instead of going back 2009-11-17 16:25:10 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 thakis webkit-unassigned dimich oldest_to_newest 164083 0 thakis 2009-11-16 14:28:20 -0800 Some git regressed that. 164085 1 43326 thakis 2009-11-16 14:31:03 -0800 Created attachment 43326 Revert 50887 This has as consequence that Chrome/mac does not send keypressed() events for keypresses with cmd down. I don't know of any website where this has a negative consequence, but Safari sends keypress() in that case. That's sad, but cmd-left not functioning is even more sad. I'll file a bug on me to read up on the isSystemKey stuff and see if I can find a patch that makes both behaviors work, but not before there are lots of automated tests for our keyboard handling stuff. 164161 2 43326 fishd 2009-11-16 23:00:36 -0800 Comment on attachment 43326 Revert 50887 > Index: WebKit/chromium/ChangeLog > + Revert r50887, it regressed handling of cmd-left when a text box is > + focused. > + nit: Please include a link to this bug report. otherwise, R=me 164270 3 43369 thakis 2009-11-17 10:42:54 -0800 Created attachment 43369 Add link to bug to changelog. 164272 4 thakis 2009-11-17 10:43:20 -0800 Done, thanks. Also, the chromium-side bug is http://crbug.com/27844 . 164379 5 43369 dimich 2009-11-17 16:19:50 -0800 Comment on attachment 43369 Add link to bug to changelog. removing cq+, will land manually 164381 6 dimich 2009-11-17 16:25:10 -0800 landed: http://trac.webkit.org/changeset/51095 43326 2009-11-16 14:31:03 -0800 2009-11-17 10:42:54 -0800 Revert 50887 webkit_revert_key.diff text/plain 1775 thakis SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTEwNTEpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTEtMTYgIE5pY29s YXMgV2ViZXIgIDx0aGFraXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJldmVydCByNTA4ODcsIGl0IHJlZ3Jlc3NlZCBoYW5k bGluZyBvZiBjbWQtbGVmdCB3aGVuIGEgdGV4dCBib3ggaXMKKyAgICAgICAgZm9jdXNlZC4KKwor ICAgICAgICAqIHNyYy9tYWMvV2ViSW5wdXRFdmVudEZhY3RvcnkubW06CisgICAgICAgIChXZWJL aXQ6OldlYklucHV0RXZlbnRGYWN0b3J5OjprZXlib2FyZEV2ZW50KToKKwogMjAwOS0xMS0xNiAg S2VubmV0aCBSdXNzZWxsICA8a2JyQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg T2xpdmVyIEh1bnQuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL21hYy9XZWJJbnB1dEV2ZW50 RmFjdG9yeS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL21hYy9XZWJJbnB1 dEV2ZW50RmFjdG9yeS5tbQkocmV2aXNpb24gNTEwNTEpCisrKyBXZWJLaXQvY2hyb21pdW0vc3Jj L21hYy9XZWJJbnB1dEV2ZW50RmFjdG9yeS5tbQkod29ya2luZyBjb3B5KQpAQCAtOTQ3LDEwICs5 NDcsMTMgQEAgV2ViS2V5Ym9hcmRFdmVudCBXZWJJbnB1dEV2ZW50RmFjdG9yeTo6awogICAgIHJl c3VsdC50ZXh0WzBdID0gY2hhcmFjdGVyOwogICAgIHJlc3VsdC51bm1vZGlmaWVkVGV4dFswXSA9 IGNoYXJhY3RlcjsKIAotICAgIC8vIERvIG5vdCBzZXQgfGlzU3lzdGVtS2V5fCBpbiB0aGlzIGNv bnN0cnVjdG9yLiBUaGlzIGNvbnN0cnVjdG9yIGlzIHVzZWQKLSAgICAvLyB0byBidWlsZCBrZXkg ZXZlbnRzIHRoYXQgZXZlbnR1YWxseSBiZWNvbWUganMgfGtleXByZXNzKCl8IGV2ZW50cywgd2hp Y2gKLSAgICAvLyBkbyBub3QgZmlyZSBpZiB8aXNTeXN0ZW1LZXl8IGlzIHNldC4gU2luY2Ugd2Ug dHJpZ2dlciBzaG9ydGN1dHMgYWZ0ZXIKLSAgICAvLyB8a2V5ZG93bigpfCwgaXQgaXMgb2sgdG8g bm90IHNldCB0aGlzIGFueXdheS4KKyAgICAvLyBXaW5kb3dzIGFuZCBMaW51eCBzZXQgfGlzU3lz dGVtS2V5fCBpZiBhbHQgaXMgZG93bi4gV2ViS2l0IGxvb2tzIGF0IHRoaXMKKyAgICAvLyBmbGFn IHRvIGRlY2lkZSBpZiBpdCBzaG91bGQgaGFuZGxlIGEga2V5IG9yIG5vdC4gRS5nLiBhbHQtbGVm dC9yaWdodAorICAgIC8vIHNob3VsZG4ndCBiZSB1c2VkIGJ5IFdlYktpdCB0byBzY3JvbGwgdGhl IGN1cnJlbnQgcGFnZSwgYmVjYXVzZSB3ZSB3YW50CisgICAgLy8gdG8gZ2V0IHRoYXQga2V5IGJh Y2sgZm9yIGl0IHRvIGRvIGhpc3RvcnkgbmF2aWdhdGlvbi4gSGVuY2UsIHRoZQorICAgIC8vIGNv cnJlc3BvbmRpbmcgc2l0dWF0aW9uIG9uIE9TIFggaXMgdG8gc2V0IHRoaXMgZm9yIGNtZCBrZXkg cHJlc3Nlcy4KKyAgICBpZiAocmVzdWx0Lm1vZGlmaWVycyAmIFdlYklucHV0RXZlbnQ6Ok1ldGFL ZXkpCisgICAgICAgIHJlc3VsdC5pc1N5c3RlbUtleSA9IHRydWU7CiAKICAgICByZXR1cm4gcmVz dWx0OwogfQo= 43369 2009-11-17 10:42:54 -0800 2009-11-17 16:19:49 -0800 Add link to bug to changelog. webkit_revert_key.diff text/plain 1830 thakis SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTEwNTEpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTEtMTYgIE5pY29s YXMgV2ViZXIgIDx0aGFraXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJldmVydCByNTA4ODcsIGl0IHJlZ3Jlc3NlZCBoYW5k bGluZyBvZiBjbWQtbGVmdCB3aGVuIGEgdGV4dCBib3ggaXMKKyAgICAgICAgZm9jdXNlZC4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNTY2CisKKyAg ICAgICAgKiBzcmMvbWFjL1dlYklucHV0RXZlbnRGYWN0b3J5Lm1tOgorICAgICAgICAoV2ViS2l0 OjpXZWJJbnB1dEV2ZW50RmFjdG9yeTo6a2V5Ym9hcmRFdmVudCk6CisKIDIwMDktMTEtMTYgIEtl bm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9s aXZlciBIdW50LgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9tYWMvV2ViSW5wdXRFdmVudEZh Y3RvcnkubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9tYWMvV2ViSW5wdXRF dmVudEZhY3RvcnkubW0JKHJldmlzaW9uIDUxMDUxKQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9t YWMvV2ViSW5wdXRFdmVudEZhY3RvcnkubW0JKHdvcmtpbmcgY29weSkKQEAgLTk0NywxMCArOTQ3 LDEzIEBAIFdlYktleWJvYXJkRXZlbnQgV2ViSW5wdXRFdmVudEZhY3Rvcnk6OmsKICAgICByZXN1 bHQudGV4dFswXSA9IGNoYXJhY3RlcjsKICAgICByZXN1bHQudW5tb2RpZmllZFRleHRbMF0gPSBj aGFyYWN0ZXI7CiAKLSAgICAvLyBEbyBub3Qgc2V0IHxpc1N5c3RlbUtleXwgaW4gdGhpcyBjb25z dHJ1Y3Rvci4gVGhpcyBjb25zdHJ1Y3RvciBpcyB1c2VkCi0gICAgLy8gdG8gYnVpbGQga2V5IGV2 ZW50cyB0aGF0IGV2ZW50dWFsbHkgYmVjb21lIGpzIHxrZXlwcmVzcygpfCBldmVudHMsIHdoaWNo Ci0gICAgLy8gZG8gbm90IGZpcmUgaWYgfGlzU3lzdGVtS2V5fCBpcyBzZXQuIFNpbmNlIHdlIHRy aWdnZXIgc2hvcnRjdXRzIGFmdGVyCi0gICAgLy8gfGtleWRvd24oKXwsIGl0IGlzIG9rIHRvIG5v dCBzZXQgdGhpcyBhbnl3YXkuCisgICAgLy8gV2luZG93cyBhbmQgTGludXggc2V0IHxpc1N5c3Rl bUtleXwgaWYgYWx0IGlzIGRvd24uIFdlYktpdCBsb29rcyBhdCB0aGlzCisgICAgLy8gZmxhZyB0 byBkZWNpZGUgaWYgaXQgc2hvdWxkIGhhbmRsZSBhIGtleSBvciBub3QuIEUuZy4gYWx0LWxlZnQv cmlnaHQKKyAgICAvLyBzaG91bGRuJ3QgYmUgdXNlZCBieSBXZWJLaXQgdG8gc2Nyb2xsIHRoZSBj dXJyZW50IHBhZ2UsIGJlY2F1c2Ugd2Ugd2FudAorICAgIC8vIHRvIGdldCB0aGF0IGtleSBiYWNr IGZvciBpdCB0byBkbyBoaXN0b3J5IG5hdmlnYXRpb24uIEhlbmNlLCB0aGUKKyAgICAvLyBjb3Jy ZXNwb25kaW5nIHNpdHVhdGlvbiBvbiBPUyBYIGlzIHRvIHNldCB0aGlzIGZvciBjbWQga2V5IHBy ZXNzZXMuCisgICAgaWYgKHJlc3VsdC5tb2RpZmllcnMgJiBXZWJJbnB1dEV2ZW50OjpNZXRhS2V5 KQorICAgICAgICByZXN1bHQuaXNTeXN0ZW1LZXkgPSB0cnVlOwogCiAgICAgcmV0dXJuIHJlc3Vs dDsKIH0K