31561 2009-11-16 12:12:49 -0800 [Chromium] Support null NPObject* parameter in _NPN_SetException 2009-11-16 14:41:32 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 japhet japhet oldest_to_newest 164049 0 japhet 2009-11-16 12:12:49 -0800 Currently, if a plugin calls NPN_SetException and passes us a null NPObject*, we would crash. Additionally, if an NPN_SetException is coming from an out of process plugin, it is very likely that the NPObject* is pointing to an object living in the plugin's memory space in the plugin process, rather than in the renderer process where the exception is actually being thrown. This will allow Chromium to just pass in a null NPObject* rather than trying to ferry an object that wouldn't be used anyway between processses. 164050 1 43318 japhet 2009-11-16 12:15:32 -0800 Created attachment 43318 patch 164071 2 43318 fishd 2009-11-16 14:07:18 -0800 Comment on attachment 43318 patch > Index: WebCore/ChangeLog ... > + Handle the case of a null NPObject* in NPN_SetException in > + the V8 bindings. I had to read the bug summary to understand this patch. It would be good to put more of the justification for this change here in the ChangeLog. Otherwise, R=me 164087 3 japhet 2009-11-16 14:41:32 -0800 (In reply to comment #2) > (From update of attachment 43318 [details]) > > Index: WebCore/ChangeLog > ... > > + Handle the case of a null NPObject* in NPN_SetException in > > + the V8 bindings. > > I had to read the bug summary to understand this patch. It would be > good to put more of the justification for this change here in the > ChangeLog. > > Otherwise, R=me Done and committed: http://trac.webkit.org/changeset/51054 43318 2009-11-16 12:15:32 -0800 2009-11-16 14:07:17 -0800 patch patch.txt text/plain 1305 japhet SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTA0NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMTEtMTYgIE5hdGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBI YW5kbGUgdGhlIGNhc2Ugb2YgYSBudWxsIE5QT2JqZWN0KiBpbiBOUE5fU2V0RXhjZXB0aW9uIGlu CisgICAgICAgIHRoZSBWOCBiaW5kaW5ncy4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE1NjEKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L05QVjhP YmplY3QuY3BwOgorICAgICAgICAoX05QTl9TZXRFeGNlcHRpb24pOiBBbGxvdyBudWxsIE5QT2Jq ZWN0KiBhbmQganVzdCB0aHJvdyBhIGdlbmVyYWwgZXJyb3IuCisKIDIwMDktMTEtMTYgIEFsZXhl eSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFy aW4gQWRsZXIuCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3Y4L05QVjhPYmplY3QuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvdjgvTlBWOE9iamVjdC5jcHAJKHJldmlzaW9uIDUx MDQzKQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9OUFY4T2JqZWN0LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNDAwLDcgKzQwMCw3IEBACiAKIHZvaWQgX05QTl9TZXRFeGNlcHRpb24oTlBPYmplY3Qq IG5wT2JqZWN0LCBjb25zdCBOUFVURjggKm1lc3NhZ2UpCiB7Ci0gICAgaWYgKG5wT2JqZWN0LT5f Y2xhc3MgIT0gbnBTY3JpcHRPYmplY3RDbGFzcykgeworICAgIGlmICghbnBPYmplY3QgfHwgbnBP YmplY3QtPl9jbGFzcyAhPSBucFNjcmlwdE9iamVjdENsYXNzKSB7CiAgICAgICAgIC8vIFdlIHdv bid0IGJlIGFibGUgdG8gZmluZCBhIHByb3BlciBzY29wZSBmb3IgdGhpcyBleGNlcHRpb24sIHNv IGp1c3QgdGhyb3cgaXQuCiAgICAgICAgIC8vIFRoaXMgaXMgY29uc2lzdGVudCB3aXRoIEpTQywg d2hpY2ggdGhyb3dzIGEgZ2xvYmFsIGV4Y2VwdGlvbiBhbGwgdGhlIHRpbWUuCiAgICAgICAgIFY4 UHJveHk6OnRocm93RXJyb3IoVjhQcm94eTo6R2VuZXJhbEVycm9yLCBtZXNzYWdlKTsK