31560 2009-11-16 10:42:59 -0800 [Qt] Failing LayoutTests/editing/deleting/5408255.html 2010-03-25 06:46:50 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED P3 Normal --- 5578 1 cshu cshu commit-queue kent.hansen oldest_to_newest 164027 0 cshu 2009-11-16 10:42:59 -0800 Run the following layout test on Qt platform and it fails. LayoutTests/editing/deleting/5408255.html The root cause of the failure is missing deleteButton image support. 164137 1 43336 cshu 2009-11-16 18:30:52 -0800 Created attachment 43336 fix patch 164778 2 43336 eric 2009-11-18 15:39:02 -0800 Comment on attachment 43336 fix patch LGTM. 164811 3 43336 commit-queue 2009-11-18 16:35:12 -0800 Comment on attachment 43336 fix patch Clearing flags on attachment: 43336 Committed r51154: <http://trac.webkit.org/changeset/51154> 164812 4 commit-queue 2009-11-18 16:35:18 -0800 All reviewed patches have been landed. Closing bug. 202527 5 kent.hansen 2010-03-22 09:14:21 -0700 (In reply to comment #1) > Created an attachment (id=43336) [details] > fix patch Hi, Since this adds public API, you should add documentation for the DeleteButtonGraphic value. A "\value DeleteButtonGraphic" line under "\enum QWebSettings::WebGraphic" in qwebsettings.cpp, with an appropriate description, is sufficient. Thanks! 202635 6 cshu 2010-03-22 11:31:50 -0700 Reopen for adding documentation. 202637 7 51315 cshu 2010-03-22 11:33:30 -0700 Created attachment 51315 fix patch Thanks for the comment, Kent. This patch takes care of the documentation. 202767 8 51315 hausmann 2010-03-22 14:42:10 -0700 Comment on attachment 51315 fix patch r+, but feel free to elaborate a bit more where this is used. Users will ask: "What's a delete button?" 204018 9 cshu 2010-03-25 06:45:30 -0700 Manually committed the patch after adding more descriptions as suggested by Simon. Committed revision 56537. 43336 2009-11-16 18:30:52 -0800 2009-11-18 16:35:12 -0800 fix patch bug31560_1.patch text/plain 5904 cshu SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTA0MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMTEtMTYgIFNodSBDaGFuZyAgPENoYW5nLlNodUBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0 XSBBZGQgc3VwcG9ydCBmb3IgZGlzcGxheWluZyBkZWxldGVCdXR0b24uCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTU2MAorCisgICAgICAgIFRlc3Q6 IExheW91dFRlc3RzL2VkaXRpbmcvZGVsZXRpbmcvNTQwODI1NS5odG1sCisKKyAgICAgICAgKiBX ZWJDb3JlLnFyYzoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9JbWFnZVF0LmNwcDoK KyAgICAgICAgKGxvYWRSZXNvdXJjZVBpeG1hcCk6CisKIDIwMDktMTEtMTYgIEFsZXhleSBQcm9z a3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRs ZXIuCkluZGV4OiBXZWJDb3JlL1dlYkNvcmUucXJjCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvV2Vi Q29yZS5xcmMJKHJldmlzaW9uIDUwODg3KQorKysgV2ViQ29yZS9XZWJDb3JlLnFyYwkod29ya2lu ZyBjb3B5KQpAQCAtMTIsNSArMTIsNiBAQAogICAgIDxmaWxlIGFsaWFzPSJjb3B5Q3Vyc29yLnBu ZyI+UmVzb3VyY2VzL2NvcHlDdXJzb3IucG5nPC9maWxlPgogICAgIDxmaWxlIGFsaWFzPSJwcm9n cmVzc0N1cnNvci5wbmciPlJlc291cmNlcy9wcm9ncmVzc0N1cnNvci5wbmc8L2ZpbGU+CiAgICAg PGZpbGUgYWxpYXM9ImFsaWFzQ3Vyc29yLnBuZyI+UmVzb3VyY2VzL2FsaWFzQ3Vyc29yLnBuZzwv ZmlsZT4KKyAgICA8ZmlsZSBhbGlhcz0iZGVsZXRlQnV0dG9uLnBuZyI+UmVzb3VyY2VzL2RlbGV0 ZUJ1dHRvbi5wbmc8L2ZpbGU+CiA8L3FyZXNvdXJjZT4KIDwvUkNDPgpJbmRleDogV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9xdC9JbWFnZVF0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3F0L0ltYWdlUXQuY3BwCShyZXZpc2lvbiA1MDg4NykKKysrIFdlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvSW1hZ2VRdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY0 LDYgKzY0LDggQEAgc3RhdGljIFFQaXhtYXAgbG9hZFJlc291cmNlUGl4bWFwKGNvbnN0IAogICAg ICAgICBwaXhtYXAgPSBRV2ViU2V0dGluZ3M6OndlYkdyYXBoaWMoUVdlYlNldHRpbmdzOjpEZWZh dWx0RnJhbWVJY29uR3JhcGhpYyk7CiAgICAgZWxzZSBpZiAocXN0cmNtcChuYW1lLCAidGV4dEFy ZWFSZXNpemVDb3JuZXIiKSA9PSAwKQogICAgICAgICBwaXhtYXAgPSBRV2ViU2V0dGluZ3M6Ondl YkdyYXBoaWMoUVdlYlNldHRpbmdzOjpUZXh0QXJlYVNpemVHcmlwQ29ybmVyR3JhcGhpYyk7Cisg ICAgZWxzZSBpZiAocXN0cmNtcChuYW1lLCAiZGVsZXRlQnV0dG9uIikgPT0gMCkKKyAgICAgICAg cGl4bWFwID0gUVdlYlNldHRpbmdzOjp3ZWJHcmFwaGljKFFXZWJTZXR0aW5nczo6RGVsZXRlQnV0 dG9uR3JhcGhpYyk7CiAKICAgICByZXR1cm4gcGl4bWFwOwogfQpJbmRleDogV2ViS2l0L3F0L0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiA1MTA0 MCkKKysrIFdlYktpdC9xdC9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBA QAorMjAwOS0xMS0xNiAgU2h1IENoYW5nICA8Q2hhbmcuU2h1QG5va2lhLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEFkZCBzdXBwb3J0 IGZvciBkaXNwbGF5aW5nIGRlbGV0ZUJ1dHRvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNTYwCisKKyAgICAgICAgVGVzdDogTGF5b3V0VGVzdHMv ZWRpdGluZy9kZWxldGluZy81NDA4MjU1Lmh0bWwKKworICAgICAgICAqIEFwaS9xd2Vic2V0dGlu Z3MuY3BwOgorICAgICAgICAoZ3JhcGhpY3MpOgorICAgICAgICAqIEFwaS9xd2Vic2V0dGluZ3Mu aDoKKwogMjAwOS0xMS0xNCAgQW50b25pbyBHb21lcyAgPHRvbmlraXRvb0B3ZWJraXQub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEFudHRpIEtvaXZpc3RvLgpJbmRleDogV2ViS2l0L3F0L0Fw aS9xd2Vic2V0dGluZ3MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9BcGkvcXdlYnNldHRp bmdzLmNwcAkocmV2aXNpb24gNTA4ODcpCisrKyBXZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTc5LDYgKzc5LDcgQEAgc3RhdGljIFdlYkdyYXBoaWNIYXNo KiBncmFwaGljcygpCiAgICAgICAgIGhhc2gtPmluc2VydChRV2ViU2V0dGluZ3M6Ok1pc3NpbmdQ bHVnaW5HcmFwaGljLCBRUGl4bWFwKFFMYXRpbjFTdHJpbmcoIjp3ZWJraXQvcmVzb3VyY2VzL251 bGxQbHVnaW4ucG5nIikpKTsKICAgICAgICAgaGFzaC0+aW5zZXJ0KFFXZWJTZXR0aW5nczo6RGVm YXVsdEZyYW1lSWNvbkdyYXBoaWMsIFFQaXhtYXAoUUxhdGluMVN0cmluZygiOndlYmtpdC9yZXNv dXJjZXMvdXJsSWNvbi5wbmciKSkpOwogICAgICAgICBoYXNoLT5pbnNlcnQoUVdlYlNldHRpbmdz OjpUZXh0QXJlYVNpemVHcmlwQ29ybmVyR3JhcGhpYywgUVBpeG1hcChRTGF0aW4xU3RyaW5nKCI6 d2Via2l0L3Jlc291cmNlcy90ZXh0QXJlYVJlc2l6ZUNvcm5lci5wbmciKSkpOworICAgICAgICBo YXNoLT5pbnNlcnQoUVdlYlNldHRpbmdzOjpEZWxldGVCdXR0b25HcmFwaGljLCBRUGl4bWFwKFFM YXRpbjFTdHJpbmcoIjp3ZWJraXQvcmVzb3VyY2VzL2RlbGV0ZUJ1dHRvbi5wbmciKSkpOwogICAg IH0KIAogICAgIHJldHVybiBoYXNoOwpJbmRleDogV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3Mu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5oCShyZXZpc2lvbiA1 MDg4NykKKysrIFdlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmgJKHdvcmtpbmcgY29weSkKQEAg LTczLDcgKzczLDggQEAgcHVibGljOgogICAgICAgICBNaXNzaW5nSW1hZ2VHcmFwaGljLAogICAg ICAgICBNaXNzaW5nUGx1Z2luR3JhcGhpYywKICAgICAgICAgRGVmYXVsdEZyYW1lSWNvbkdyYXBo aWMsCi0gICAgICAgIFRleHRBcmVhU2l6ZUdyaXBDb3JuZXJHcmFwaGljCisgICAgICAgIFRleHRB cmVhU2l6ZUdyaXBDb3JuZXJHcmFwaGljLAorICAgICAgICBEZWxldGVCdXR0b25HcmFwaGljCiAg ICAgfTsKICAgICBlbnVtIEZvbnRTaXplIHsKICAgICAgICAgTWluaW11bUZvbnRTaXplLApJbmRl eDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5n ZUxvZwkocmV2aXNpb24gNTEwNDApCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcg Y29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0xMS0xNiAgU2h1IENoYW5nICA8Q2hhbmcuU2h1 QG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbUXRdIFVwZGF0ZSBleHBlY3RlZCByZXN1bHQgYWZ0ZXIgUXQ0LjYgdXBncmFkZS4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNTYwCisKKyAg ICAgICAgVGVzdDogTGF5b3V0VGVzdHMvZWRpdGluZy9kZWxldGluZy81NDA4MjU1Lmh0bWwKKwor ICAgICAgICAqIHBsYXRmb3JtL3F0L2VkaXRpbmcvZGVsZXRpbmcvNTQwODI1NS1leHBlY3RlZC50 eHQ6CisKIDIwMDktMTEtMTQgIEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBBbnR0aSBLb2l2aXN0by4KSW5kZXg6IExheW91dFRlc3Rz L3BsYXRmb3JtL3F0L2VkaXRpbmcvZGVsZXRpbmcvNTQwODI1NS1leHBlY3RlZC50eHQKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvZWRpdGluZy9kZWxldGluZy81NDA4MjU1 LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gNTA4ODcpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9x dC9lZGl0aW5nL2RlbGV0aW5nLzU0MDgyNTUtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBA IC0xLDE0ICsxLDE0IEBACi1BTEVSVDogMjAKLUFMRVJUOiA4OAorQUxFUlQ6IDIyCitBTEVSVDog OTYKIGxheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAogICBSZW5kZXJWaWV3IGF0ICgwLDApIHNp emUgODAweDYwMAogbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCiAgIFJlbmRlckJsb2NrIHtI VE1MfSBhdCAoMCwwKSBzaXplIDgwMHg2MDAKICAgICBSZW5kZXJCb2R5IHtCT0RZfSBhdCAoOCw4 KSBzaXplIDc4NHg1ODQKLSAgICAgIFJlbmRlckJsb2NrIHtQfSBhdCAoMCwwKSBzaXplIDc4NHgz OAotICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSA3NzZ4MzgKLSAgICAg ICAgICB0ZXh0IHJ1biBhdCAoMCwwKSB3aWR0aCA3NzY6ICJUaGlzIHRlc3RzIGZvciBhIGJ1ZyB3 aGVyZSB0aGUgZGVsZXRlIGJ1dHRvbiB3b3VsZG4ndCB3b3JrIGJlY2F1c2UgaXQgaGFkIC13ZWJr aXQtdXNlci1zZWxlY3Q6bm9uZSBpbnN0ZWFkIG9mIC13ZWJraXQtdXNlci0iCi0gICAgICAgICAg dGV4dCBydW4gYXQgKDAsMTkpIHdpZHRoIDg5OiAic2VsZWN0Omlnbm9yZS4gIgotICAgICAgICAg IHRleHQgcnVuIGF0ICg4OSwxOSkgd2lkdGggNDUyOiAiVGhlIGxpc3Qgc2hvdWxkIGJlIHJlbW92 ZWQsIHRoZSBlZGl0YWJsZSByZWdpb24gYmVsb3cgc2hvdWxkIGJlIGVtcHR5LiIKLSAgICAgIFJl bmRlckJsb2NrIHtESVZ9IGF0ICgwLDUyKSBzaXplIDc4NHgyOAorICAgICAgUmVuZGVyQmxvY2sg e1B9IGF0ICgwLDApIHNpemUgNzg0eDQwCisgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAo MCwwKSBzaXplIDc3M3g0MAorICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDApIHdpZHRoIDc3Mzog IlRoaXMgdGVzdHMgZm9yIGEgYnVnIHdoZXJlIHRoZSBkZWxldGUgYnV0dG9uIHdvdWxkbid0IHdv cmsgYmVjYXVzZSBpdCBoYWQgLXdlYmtpdC11c2VyLXNlbGVjdDpub25lIGluc3RlYWQgb2YgLSIK KyAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCwyMCkgd2lkdGggMTg2OiAid2Via2l0LXVzZXItc2Vs ZWN0Omlnbm9yZS4gIgorICAgICAgICAgIHRleHQgcnVuIGF0ICgxODYsMjApIHdpZHRoIDUwNDog IlRoZSBsaXN0IHNob3VsZCBiZSByZW1vdmVkLCB0aGUgZWRpdGFibGUgcmVnaW9uIGJlbG93IHNo b3VsZCBiZSBlbXB0eS4iCisgICAgICBSZW5kZXJCbG9jayB7RElWfSBhdCAoMCw1Nikgc2l6ZSA3 ODR4MzIKIGNhcmV0OiBwb3NpdGlvbiAwIG9mIGNoaWxkIDMge0RJVn0gb2YgY2hpbGQgMSB7Qk9E WX0gb2YgY2hpbGQgMCB7SFRNTH0gb2YgZG9jdW1lbnQK 51315 2010-03-22 11:33:30 -0700 2010-03-25 06:46:50 -0700 fix patch bug31560_a1.patch text/plain 1137 cshu SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNTYzNDcpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDMtMjIgIFNodSBDaGFuZyAgPGNoYW5nLnNodUBu b2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW1F0XSBBZGRlZCBkb2N1bWVudGF0aW9uIGZvciBkZWxldGUgYnV0dG9uLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE1NjAKKworICAgICAgICAq IEFwaS9xd2Vic2V0dGluZ3MuY3BwOgorCiAyMDEwLTAzLTIyICBKYWt1YiBXaWVjem9yZWsgIDxq d2llY3pvcmVrQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21h bm4uCkluZGV4OiBXZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3BwCShyZXZpc2lvbiA1NjM0NCkKKysrIFdlYktp dC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzQ3LDYgKzM0Nyw3 IEBAIFFXZWJTZXR0aW5ncyogUVdlYlNldHRpbmdzOjpnbG9iYWxTZXR0aW4KICAgICBcdmFsdWUg TWlzc2luZ1BsdWdpbkdyYXBoaWMgVGhlIHJlcGxhY2VtZW50IGdyYXBoaWMgc2hvd24gd2hlbiBh IHBsdWdpbiBjb3VsZCBub3QgYmUgbG9hZGVkLgogICAgIFx2YWx1ZSBEZWZhdWx0RnJhbWVJY29u R3JhcGhpYyBUaGUgZGVmYXVsdCBpY29uIGZvciBRV2ViRnJhbWU6Omljb24oKS4KICAgICBcdmFs dWUgVGV4dEFyZWFTaXplR3JpcENvcm5lckdyYXBoaWMgVGhlIGdyYXBoaWMgc2hvd24gZm9yIHRo ZSBzaXplIGdyaXAgb2YgdGV4dCBhcmVhcy4KKyAgICBcdmFsdWUgRGVsZXRlQnV0dG9uR3JhcGhp YyBUaGUgZ3JhcGhpYyBzaG93biBmb3IgdGhlIGRlbGV0ZSBidXR0b24uCiAqLwogCiAvKiEK