31549 2009-11-16 05:41:46 -0800 Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment 2009-11-16 05:48:20 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 31548 1 eric webkit-unassigned oldest_to_newest 163966 0 eric 2009-11-16 05:41:46 -0800 Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment Now that we use land-attachment, we don't need any special "look up only the commit-queue bugs" functionality, so --commit-queue can become --non-interactive, and our code thus simpler! 163967 1 43301 eric 2009-11-16 05:42:27 -0800 Created attachment 43301 Patch 163968 2 43301 abarth 2009-11-16 05:43:13 -0800 Comment on attachment 43301 Patch I approve 163969 3 eric 2009-11-16 05:48:20 -0800 Committed r51036: <http://trac.webkit.org/changeset/51036> 43301 2009-11-16 05:42:27 -0800 2009-11-16 05:43:12 -0800 Patch bug-31549-20091116054225.patch text/plain 3619 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbCBiL1dlYktpdFRv b2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbAppbmRleCAzZWM3MmQxLi40MjdkMDU0IDEwMDc1NQot LS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL2J1Z3ppbGxhLXRvb2wKKysrIGIvV2ViS2l0VG9vbHMv U2NyaXB0cy9idWd6aWxsYS10b29sCkBAIC0yMzMsNyArMjMzLDcgQEAgY2xhc3MgV2ViS2l0TGFu ZGluZ1NjcmlwdHM6CiAgICAgICAgICAgICBtYWtlX29wdGlvbigiLS1uby1idWlsZCIsIGFjdGlv bj0ic3RvcmVfZmFsc2UiLCBkZXN0PSJidWlsZCIsIGRlZmF1bHQ9VHJ1ZSwgaGVscD0iQ29tbWl0 IHdpdGhvdXQgYnVpbGRpbmcgZmlyc3QsIGltcGxpZXMgLS1uby10ZXN0LiIpLAogICAgICAgICAg ICAgbWFrZV9vcHRpb24oIi0tbm8tdGVzdCIsIGFjdGlvbj0ic3RvcmVfZmFsc2UiLCBkZXN0PSJ0 ZXN0IiwgZGVmYXVsdD1UcnVlLCBoZWxwPSJDb21taXQgd2l0aG91dCBydW5uaW5nIHJ1bi13ZWJr aXQtdGVzdHMuIiksCiAgICAgICAgICAgICBtYWtlX29wdGlvbigiLS1xdWlldCIsIGFjdGlvbj0i c3RvcmVfdHJ1ZSIsIGRlc3Q9InF1aWV0IiwgZGVmYXVsdD1GYWxzZSwgaGVscD0iUHJvZHVjZSBs ZXNzIGNvbnNvbGUgb3V0cHV0LiIpLAotICAgICAgICAgICAgbWFrZV9vcHRpb24oIi0tY29tbWl0 LXF1ZXVlIiwgYWN0aW9uPSJzdG9yZV90cnVlIiwgZGVzdD0iY29tbWl0X3F1ZXVlIiwgZGVmYXVs dD1GYWxzZSwgaGVscD0iUnVuIGluIGNvbW1pdCBxdWV1ZSBtb2RlIChubyB1c2VyIGludGVyYWN0 aW9uKS4iKSwKKyAgICAgICAgICAgIG1ha2Vfb3B0aW9uKCItLW5vbi1pbnRlcmFjdGl2ZSIsIGFj dGlvbj0ic3RvcmVfdHJ1ZSIsIGRlc3Q9Im5vbl9pbnRlcmFjdGl2ZSIsIGRlZmF1bHQ9RmFsc2Us IGhlbHA9Ik5ldmVyIHByb21wdCB0aGUgdXNlciwgZmFpbCBhcyBmYXN0IGFzIHBvc3NpYmxlLiIp LAogICAgICAgICBdCiAKICAgICBAc3RhdGljbWV0aG9kCkBAIC0zMTAsNyArMzEwLDcgQEAgY2xh c3MgV2ViS2l0TGFuZGluZ1NjcmlwdHM6CiAgICAgICAgICAgICBjbHMuYnVpbGRfd2Via2l0KHF1 aWV0PW9wdGlvbnMucXVpZXQpCiAgICAgICAgICAgICBpZiBvcHRpb25zLnRlc3Q6CiAgICAgICAg ICAgICAgICAgIyBXaGVuIHJ1bm5pbmcgdGhlIGNvbW1pdC1xdWV1ZSB3ZSBkb24ndCB3YW50IHRv IGxhdW5jaCBTYWZhcmkgYW5kIHdlIHdhbnQgdG8gZXhpdCBhZnRlciB0aGUgZmlyc3QgZmFpbHVy ZS4KLSAgICAgICAgICAgICAgICBjbHMucnVuX3dlYmtpdF90ZXN0cyhsYXVuY2hfc2FmYXJpPW5v dCBvcHRpb25zLmNvbW1pdF9xdWV1ZSwgZmFpbF9mYXN0PW9wdGlvbnMuY29tbWl0X3F1ZXVlLCBx dWlldD1vcHRpb25zLnF1aWV0KQorICAgICAgICAgICAgICAgIGNscy5ydW5fd2Via2l0X3Rlc3Rz KGxhdW5jaF9zYWZhcmk9bm90IG9wdGlvbnMubm9uX2ludGVyYWN0aXZlLCBmYWlsX2Zhc3Q9b3B0 aW9ucy5ub25faW50ZXJhY3RpdmUsIHF1aWV0PW9wdGlvbnMucXVpZXQpCiAgICAgICAgIGNvbW1p dF9tZXNzYWdlID0gY29tbWl0X21lc3NhZ2VfZm9yX3RoaXNfY29tbWl0KHNjbSkKICAgICAgICAg Y29tbWl0X2xvZyA9IHNjbS5jb21taXRfd2l0aF9tZXNzYWdlKGNvbW1pdF9tZXNzYWdlLm1lc3Nh Z2UoKSkKICAgICAgICAgcmV0dXJuIGJ1Z19jb21tZW50X2Zyb21fY29tbWl0X3RleHQoc2NtLCBj b21taXRfbG9nKQpAQCAtMzMxLDcgKzMzMSw3IEBAIGNsYXNzIFdlYktpdExhbmRpbmdTY3JpcHRz OgogICAgIGRlZiBfbGFuZF9wYXRjaChjbHMsIHBhdGNoLCBvcHRpb25zLCB0b29sKToKICAgICAg ICAgdG9vbC5zY20oKS51cGRhdGVfd2Via2l0KCkgIyBVcGRhdGUgYmVmb3JlIGV2ZXJ5IHBhdGNo IGluIGNhc2UgdGhlIHRyZWUgaGFzIGNoYW5nZWQKICAgICAgICAgbG9nKCJBcHBseWluZyAlcyBm cm9tIGJ1ZyAlcy4iICUgKHBhdGNoWydpZCddLCBwYXRjaFsnYnVnX2lkJ10pKQotICAgICAgICB0 b29sLnNjbSgpLmFwcGx5X3BhdGNoKHBhdGNoLCBmb3JjZT1vcHRpb25zLmNvbW1pdF9xdWV1ZSkK KyAgICAgICAgdG9vbC5zY20oKS5hcHBseV9wYXRjaChwYXRjaCwgZm9yY2U9b3B0aW9ucy5ub25f aW50ZXJhY3RpdmUpCiAKICAgICAgICAgIyBNYWtlIHN1cmUgdGhlIHRyZWUgaXMgc3RpbGwgZ3Jl ZW4gYWZ0ZXIgdXBkYXRpbmcsIGJlZm9yZSBidWlsZGluZyB0aGlzIHBhdGNoLgogICAgICAgICAj IFRoZSBmaXJzdCBwYXRjaCBlbmRzIHVwIGNoZWNraW5nIHRyZWUgc3RhdHVzIHR3aWNlLCBidXQg dGhhdCdzIE9LLgpAQCAtNDYxLDE1ICs0NjEsOSBAQCBjbGFzcyBMYW5kUGF0Y2hlc0Zyb21CdWdz KEFic3RyYWN0UGF0Y2hMYW5kaW5nQ29tbWFuZCk6CiAgICAgZGVmIF9mZXRjaF9saXN0X29mX3Bh dGNoZXNfdG9fbGFuZChvcHRpb25zLCBhcmdzLCB0b29sKToKICAgICAgICAgYWxsX3BhdGNoZXMg PSBbXQogICAgICAgICBmb3IgYnVnX2lkIGluIGFyZ3M6Ci0gICAgICAgICAgICAjIEZJWE1FOiBU aGlzIGlzIHN0cmFuZ2UgdGhhdCAtLWNvbW1pdC1xdWV1ZSBnZXRzIHNwZWNpYWwgYmVoYXZpb3Ig aGVyZS4KLSAgICAgICAgICAgIGlmIG9wdGlvbnMuY29tbWl0X3F1ZXVlOgotICAgICAgICAgICAg ICAgIHBhdGNoZXMgPSB0b29sLmJ1Z3MuZmV0Y2hfY29tbWl0X3F1ZXVlX3BhdGNoZXNfZnJvbV9i dWcoYnVnX2lkLCByZWplY3RfaW52YWxpZF9wYXRjaGVzPVRydWUpCi0gICAgICAgICAgICBlbHNl OgotICAgICAgICAgICAgICAgIHBhdGNoZXMgPSB0b29sLmJ1Z3MuZmV0Y2hfcmV2aWV3ZWRfcGF0 Y2hlc19mcm9tX2J1ZyhidWdfaWQpCi0KKyAgICAgICAgICAgIHBhdGNoZXMgPSB0b29sLmJ1Z3Mu ZmV0Y2hfcmV2aWV3ZWRfcGF0Y2hlc19mcm9tX2J1ZyhidWdfaWQpCiAgICAgICAgICAgICBsb2co IiVzIGZvdW5kIG9uIGJ1ZyAlcy4iICUgKHBsdXJhbGl6ZSgicmV2aWV3ZWQgcGF0Y2giLCBsZW4o cGF0Y2hlcykpLCBidWdfaWQpKQogICAgICAgICAgICAgYWxsX3BhdGNoZXMgKz0gcGF0Y2hlcwot CiAgICAgICAgIHJldHVybiBhbGxfcGF0Y2hlcwogCiAKQEAgLTgwOCw3ICs4MDIsNyBAQCBjbGFz cyBDb21taXRRdWV1ZShBYnN0cmFjdFF1ZXVlKToKICAgICAgICAgcmV0dXJuIChUcnVlLCAiTGFu ZGluZyBwYXRjaCAlcyBmcm9tIGJ1ZyAlcy4iICUgKHBhdGNoWydpZCddLCBwYXRjaFsnYnVnX2lk J10pLCBwYXRjaFsnYnVnX2lkJ10pCiAKICAgICBkZWYgcHJvY2Vzc193b3JrX2l0ZW0oc2VsZiwg cGF0Y2gpOgotICAgICAgICBzZWxmLnJ1bl9idWd6aWxsYV90b29sKFsnbGFuZC1hdHRhY2htZW50 JywgJy0tZm9yY2UtY2xlYW4nLCAnLS1jb21taXQtcXVldWUnLCAnLS1xdWlldCcsIHBhdGNoWydp ZCddXSkKKyAgICAgICAgc2VsZi5ydW5fYnVnemlsbGFfdG9vbChbJ2xhbmQtYXR0YWNobWVudCcs ICctLWZvcmNlLWNsZWFuJywgJy0tbm9uLWludGVyYWN0aXZlJywgJy0tcXVpZXQnLCBwYXRjaFsn aWQnXV0pCiAKICAgICBkZWYgaGFuZGxlX3VuZXhwZWN0ZWRfZXJyb3Ioc2VsZiwgcGF0Y2gsIG1l c3NhZ2UpOgogICAgICAgICBzZWxmLnRvb2wuYnVncy5yZWplY3RfcGF0Y2hfZnJvbV9jb21taXRf cXVldWUocGF0Y2hbJ2lkJ10sIG1lc3NhZ2UpCg==