31548 2009-11-16 05:32:11 -0800 The commit-queue should use land-attachment 2009-11-16 05:41:46 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 31546 31549 1 eric webkit-unassigned oldest_to_newest 163961 0 eric 2009-11-16 05:32:11 -0800 The commit-queue should use land-attachment Now that we have the magic of land-attachment, we can dump a bunch of junk code in the commit-queue. Previously it had to jump through all sorts of hoops to try and deal with "patches" instead of bugs. Now it can actually use patch ids the whole way through and land one patch at a time instead of all the patches on a bug at once. 163962 1 43299 eric 2009-11-16 05:33:31 -0800 Created attachment 43299 Patch 163963 2 43299 abarth 2009-11-16 05:34:13 -0800 Comment on attachment 43299 Patch yep 163964 3 eric 2009-11-16 05:35:12 -0800 Committed r51034: <http://trac.webkit.org/changeset/51034> 43299 2009-11-16 05:33:31 -0800 2009-11-16 05:34:12 -0800 Patch bug-31548-20091116053330.patch text/plain 2383 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA1ZjY2N2U1Li42NGM4MmJmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMTEt MTYgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBjb21taXQtcXVldWUgc2hvdWxkIHVzZSBs YW5kLWF0dGFjaG1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTMxNTQ4CisKKyAgICAgICAgKiBTY3JpcHRzL2J1Z3ppbGxhLXRvb2w6CisKIDIwMDkt MTEtMTYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVnemls bGEtdG9vbCBiL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbAppbmRleCA1MjIxYjJh Li4zZWM3MmQxIDEwMDc1NQotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL2J1Z3ppbGxhLXRvb2wK KysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWd6aWxsYS10b29sCkBAIC04MDUsMjQgKzgwNSwx MyBAQCBjbGFzcyBDb21taXRRdWV1ZShBYnN0cmFjdFF1ZXVlKToKICAgICAgICAgaWYgcmVkX2J1 aWxkZXJzX25hbWVzOgogICAgICAgICAgICAgcmVkX2J1aWxkZXJzX25hbWVzID0gbWFwKGxhbWJk YSBuYW1lOiAnIiVzIicgJSBuYW1lLCByZWRfYnVpbGRlcnNfbmFtZXMpICMgQWRkIHF1b3RlcyBh cm91bmQgdGhlIG5hbWVzLgogICAgICAgICAgICAgcmV0dXJuIChGYWxzZSwgIkJ1aWxkZXJzIFsl c10gYXJlIHJlZC4gU2VlIGh0dHA6Ly9idWlsZC53ZWJraXQub3JnLiIgJSAiLCAiLmpvaW4ocmVk X2J1aWxkZXJzX25hbWVzKSwgTm9uZSkKLSAgICAgICAgcmV0dXJuIChUcnVlLCAiTGFuZGluZyBw YXRjaGVzIGZyb20gYnVnICVzLiIgJSBwYXRjaFsnYnVnX2lkJ10sIHBhdGNoWydidWdfaWQnXSkK KyAgICAgICAgcmV0dXJuIChUcnVlLCAiTGFuZGluZyBwYXRjaCAlcyBmcm9tIGJ1ZyAlcy4iICUg KHBhdGNoWydpZCddLCBwYXRjaFsnYnVnX2lkJ10pLCBwYXRjaFsnYnVnX2lkJ10pCiAKICAgICBk ZWYgcHJvY2Vzc193b3JrX2l0ZW0oc2VsZiwgcGF0Y2gpOgotICAgICAgICBzZWxmLnJ1bl9idWd6 aWxsYV90b29sKFsnbGFuZC1wYXRjaGVzJywgJy0tZm9yY2UtY2xlYW4nLCAnLS1jb21taXQtcXVl dWUnLCAnLS1xdWlldCcsIHBhdGNoWydidWdfaWQnXV0pCisgICAgICAgIHNlbGYucnVuX2J1Z3pp bGxhX3Rvb2woWydsYW5kLWF0dGFjaG1lbnQnLCAnLS1mb3JjZS1jbGVhbicsICctLWNvbW1pdC1x dWV1ZScsICctLXF1aWV0JywgcGF0Y2hbJ2lkJ11dKQogCiAgICAgZGVmIGhhbmRsZV91bmV4cGVj dGVkX2Vycm9yKHNlbGYsIHBhdGNoLCBtZXNzYWdlKToKLSAgICAgICAgIyBXZSBkb24ndCBoYXZl IGEgcGF0Y2ggaWQgYXQgdGhpcyBwb2ludCwgc28gdHJ5IHRvIGdyYWIgdGhlIGZpcnN0IHBhdGNo IG9mZgotICAgICAgICAjIG9mIHRoZSBidWcgaW4gcXVlc3Rpb24uICBXZSBwbGFuIHRvIHVwZGF0 ZSB0aGUgY29tbWl0LXF1ZXVlIHRvIG9wZWFyYXRlCi0gICAgICAgICMgb2ZmIG9mIHBhdGNoIGlk cyBpbiB0aGUgbmVhciBmdXR1cmUuCi0gICAgICAgIGJ1Z19pZCA9IHBhdGNoWydidWdfaWQnXQot ICAgICAgICBwYXRjaGVzID0gc2VsZi50b29sLmJ1Z3MuZmV0Y2hfY29tbWl0X3F1ZXVlX3BhdGNo ZXNfZnJvbV9idWcoYnVnX2lkKQotICAgICAgICBub25fb2Jzb2xldGVfcGF0Y2hlcyA9IGZpbHRl cihsYW1iZGEgcGF0Y2g6IG5vdCBwYXRjaFsnaXNfb2Jzb2xldGUnXSwgcGF0Y2hlcykKLSAgICAg ICAgaWYgbm90IGxlbihub25fb2Jzb2xldGVfcGF0Y2hlcyk6Ci0gICAgICAgICAgICAjIElmIHRo ZXJlIGFyZSBubyBwYXRjaGVzIGxlZnQgb24gdGhlIGJ1ZywgYXNzdW1lIGxhbmQtcGF0Y2hlcyBh bHJlYWR5IGNsb3NlZCBpdCBiZWZvcmUgZHlpbmcsIGFuZCBqdXN0IGNvbnRpbnVlLgotICAgICAg ICAgICAgbG9nKG1lc3NhZ2UpCi0gICAgICAgICAgICByZXR1cm4KLSAgICAgICAgYnVnX2lkID0g bm9uX29ic29sZXRlX3BhdGNoZXNbMF1bJ2lkJ10KLSAgICAgICAgc2VsZi50b29sLmJ1Z3MucmVq ZWN0X3BhdGNoX2Zyb21fY29tbWl0X3F1ZXVlKGJ1Z19pZCwgbWVzc2FnZSkKKyAgICAgICAgc2Vs Zi50b29sLmJ1Z3MucmVqZWN0X3BhdGNoX2Zyb21fY29tbWl0X3F1ZXVlKHBhdGNoWydpZCddLCBt ZXNzYWdlKQogCiAKIGNsYXNzIFN0eWxlUXVldWUoQWJzdHJhY3RRdWV1ZSk6Cg==