31547 2009-11-16 04:53:15 -0800 Convert CommitQueue over to PatchCollection 2009-11-16 05:05:20 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned eric oldest_to_newest 163949 0 abarth 2009-11-16 04:53:15 -0800 That's what it's for! 163950 1 43295 abarth 2009-11-16 04:54:10 -0800 Created attachment 43295 Patch 163953 2 43295 eric 2009-11-16 05:00:18 -0800 Comment on attachment 43295 Patch So close to victory! These really should have been two separate commits... 163955 3 abarth 2009-11-16 05:05:20 -0800 Committed r51031: <http://trac.webkit.org/changeset/51031> 43295 2009-11-16 04:54:10 -0800 2009-11-16 05:00:18 -0800 Patch bug-31547-20091116045409.patch text/plain 6358 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA1Mzk2Zjg0Li4xYjg5NzZjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMDktMTEt MTYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb252ZXJ0IENvbW1pdFF1ZXVlIG92ZXIgdG8g UGF0Y2hDb2xsZWN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zMTU0NworCisgICAgICAgIEFsc28gZml4ZXMgYSBidWcgaW4gd29ya3F1ZXVlIGFu ZCBhZGRzIGEgdGVzdCEKKworICAgICAgICAqIFNjcmlwdHMvYnVnemlsbGEtdG9vbDoKKyAgICAg ICAgKiBTY3JpcHRzL21vZHVsZXMvd29ya3F1ZXVlLnB5OgorICAgICAgICAqIFNjcmlwdHMvbW9k dWxlcy93b3JrcXVldWVfdW5pdHRlc3QucHk6CisKKzIwMDktMTEtMTYgIEFkYW0gQmFydGggIDxh YmFydGhAd2Via2l0Lm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KIAog ICAgICAgICBNb3ZlIFN0eWxlUXVldWUgb3ZlciB0byB1c2luZyBQYXRjaENvbGxlY3Rpb24KZGlm ZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbCBiL1dlYktpdFRvb2xz L1NjcmlwdHMvYnVnemlsbGEtdG9vbAppbmRleCA3YTYxZGY4Li4yMjNkZWVmIDEwMDc1NQotLS0g YS9XZWJLaXRUb29scy9TY3JpcHRzL2J1Z3ppbGxhLXRvb2wKKysrIGIvV2ViS2l0VG9vbHMvU2Ny aXB0cy9idWd6aWxsYS10b29sCkBAIC03NjYsMjkgKzc2NiwzMiBAQCBjbGFzcyBDb21taXRRdWV1 ZShBYnN0cmFjdFF1ZXVlKToKICAgICBkZWYgX19pbml0X18oc2VsZik6CiAgICAgICAgIEFic3Ry YWN0UXVldWUuX19pbml0X18oc2VsZiwgImNvbW1pdC1xdWV1ZSIpCiAKKyAgICBkZWYgYmVnaW5f d29ya19xdWV1ZShzZWxmKToKKyAgICAgICAgQWJzdHJhY3RRdWV1ZS5iZWdpbl93b3JrX3F1ZXVl KHNlbGYpCisgICAgICAgIHNlbGYuX3BhdGNoZXMgPSBQYXRjaENvbGxlY3Rpb24oc2VsZi50b29s LmJ1Z3MpCisKICAgICBkZWYgbmV4dF93b3JrX2l0ZW0oc2VsZik6Ci0gICAgICAgICMgRmV0Y2gg cGF0Y2hlcyBpbnN0ZWFkIG9mIGp1c3QgYnVnIGlkcyB0byB0aGF0IHdlIHZhbGlkYXRlIHJldmll d2VyL2NvbW1pdHRlciBmbGFncyBvbiBldmVyeSBwYXRjaC4KLSAgICAgICAgcGF0Y2hlcyA9IHNl bGYudG9vbC5idWdzLmZldGNoX3BhdGNoZXNfZnJvbV9jb21taXRfcXVldWUocmVqZWN0X2ludmFs aWRfcGF0Y2hlcz1UcnVlKQotICAgICAgICBpZiBub3QgbGVuKHBhdGNoZXMpOgotICAgICAgICAg ICAgcmV0dXJuIE5vbmUKLSAgICAgICAgcGF0Y2hfaWRzID0gbWFwKGxhbWJkYSBwYXRjaDogcGF0 Y2hbJ2lkJ10sIHBhdGNoZXMpCi0gICAgICAgIGxvZygiJXMgaW4gY29tbWl0IHF1ZXVlIFslc10i ICUgKHBsdXJhbGl6ZSgncGF0Y2gnLCBsZW4ocGF0Y2hlcykpLCAiLCAiLmpvaW4ocGF0Y2hfaWRz KSkpCi0gICAgICAgIHJldHVybiBwYXRjaGVzWzBdWydidWdfaWQnXQorICAgICAgICBpZiBub3Qg bGVuKHNlbGYuX3BhdGNoZXMpOgorICAgICAgICAgICAgIyBGZXRjaCBwYXRjaGVzIGluc3RlYWQg b2YganVzdCBidWcgaWRzIHRvIHRoYXQgd2UgdmFsaWRhdGUgcmV2aWV3ZXIvY29tbWl0dGVyIGZs YWdzIG9uIGV2ZXJ5IHBhdGNoLgorICAgICAgICAgICAgc2VsZi5fcGF0Y2hlcy5hZGRfcGF0Y2hl cyhzZWxmLnRvb2wuYnVncy5mZXRjaF9wYXRjaGVzX2Zyb21fY29tbWl0X3F1ZXVlKHJlamVjdF9p bnZhbGlkX3BhdGNoZXM9VHJ1ZSkpCisgICAgICAgIHNlbGYubG9nX3Byb2dyZXNzKHNlbGYuX3Bh dGNoZXMucGF0Y2hfaWRzKCkpCisgICAgICAgIHJldHVybiBzZWxmLl9wYXRjaGVzLm5leHQoKQog Ci0gICAgZGVmIHNob3VsZF9wcm9jZWVkX3dpdGhfd29ya19pdGVtKHNlbGYsIGJ1Z19pZCk6Cisg ICAgZGVmIHNob3VsZF9wcm9jZWVkX3dpdGhfd29ya19pdGVtKHNlbGYsIHBhdGNoKToKICAgICAg ICAgcmVkX2J1aWxkZXJzX25hbWVzID0gc2VsZi50b29sLmJ1aWxkYm90LnJlZF9jb3JlX2J1aWxk ZXJzX25hbWVzKCkKICAgICAgICAgaWYgcmVkX2J1aWxkZXJzX25hbWVzOgogICAgICAgICAgICAg cmVkX2J1aWxkZXJzX25hbWVzID0gbWFwKGxhbWJkYSBuYW1lOiAnIiVzIicgJSBuYW1lLCByZWRf YnVpbGRlcnNfbmFtZXMpICMgQWRkIHF1b3RlcyBhcm91bmQgdGhlIG5hbWVzLgogICAgICAgICAg ICAgcmV0dXJuIChGYWxzZSwgIkJ1aWxkZXJzIFslc10gYXJlIHJlZC4gU2VlIGh0dHA6Ly9idWls ZC53ZWJraXQub3JnLiIgJSAiLCAiLmpvaW4ocmVkX2J1aWxkZXJzX25hbWVzKSwgTm9uZSkKLSAg ICAgICAgcmV0dXJuIChUcnVlLCAiTGFuZGluZyBwYXRjaGVzIGZyb20gYnVnICVzLiIgJSBidWdf aWQsIGJ1Z19pZCkKKyAgICAgICAgcmV0dXJuIChUcnVlLCAiTGFuZGluZyBwYXRjaGVzIGZyb20g YnVnICVzLiIgJSBwYXRjaFsnYnVnX2lkJ10sIHBhdGNoWydidWdfaWQnXSkKIAotICAgIGRlZiBw cm9jZXNzX3dvcmtfaXRlbShzZWxmLCBidWdfaWQpOgotICAgICAgICBzZWxmLnJ1bl9idWd6aWxs YV90b29sKFsnbGFuZC1wYXRjaGVzJywgJy0tZm9yY2UtY2xlYW4nLCAnLS1jb21taXQtcXVldWUn LCAnLS1xdWlldCcsIGJ1Z19pZF0pCisgICAgZGVmIHByb2Nlc3Nfd29ya19pdGVtKHNlbGYsIHBh dGNoKToKKyAgICAgICAgc2VsZi5ydW5fYnVnemlsbGFfdG9vbChbJ2xhbmQtcGF0Y2hlcycsICct LWZvcmNlLWNsZWFuJywgJy0tY29tbWl0LXF1ZXVlJywgJy0tcXVpZXQnLCBwYXRjaFsnYnVnX2lk J11dKQogCi0gICAgZGVmIGhhbmRsZV91bmV4cGVjdGVkX2Vycm9yKHNlbGYsIGJ1Z19pZCwgbWVz c2FnZSk6CisgICAgZGVmIGhhbmRsZV91bmV4cGVjdGVkX2Vycm9yKHNlbGYsIHBhdGNoLCBtZXNz YWdlKToKICAgICAgICAgIyBXZSBkb24ndCBoYXZlIGEgcGF0Y2ggaWQgYXQgdGhpcyBwb2ludCwg c28gdHJ5IHRvIGdyYWIgdGhlIGZpcnN0IHBhdGNoIG9mZgogICAgICAgICAjIG9mIHRoZSBidWcg aW4gcXVlc3Rpb24uICBXZSBwbGFuIHRvIHVwZGF0ZSB0aGUgY29tbWl0LXF1ZXVlIHRvIG9wZWFy YXRlCiAgICAgICAgICMgb2ZmIG9mIHBhdGNoIGlkcyBpbiB0aGUgbmVhciBmdXR1cmUuCisgICAg ICAgIGJ1Z19pZCA9IHBhdGNoWydidWdfaWQnXQogICAgICAgICBwYXRjaGVzID0gc2VsZi50b29s LmJ1Z3MuZmV0Y2hfY29tbWl0X3F1ZXVlX3BhdGNoZXNfZnJvbV9idWcoYnVnX2lkKQogICAgICAg ICBub25fb2Jzb2xldGVfcGF0Y2hlcyA9IGZpbHRlcihsYW1iZGEgcGF0Y2g6IG5vdCBwYXRjaFsn aXNfb2Jzb2xldGUnXSwgcGF0Y2hlcykKICAgICAgICAgaWYgbm90IGxlbihub25fb2Jzb2xldGVf cGF0Y2hlcyk6CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvd29ya3F1 ZXVlLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL3dvcmtxdWV1ZS5weQppbmRleCA1 Njk4ZjA1Li44ZTcxNDgxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMv d29ya3F1ZXVlLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy93b3JrcXVldWUu cHkKQEAgLTk3LDcgKzk3LDcgQEAgY2xhc3MgV29ya1F1ZXVlOgogICAgICAgICAgICAgICAgICAg ICBjb250aW51ZQogICAgICAgICAgICAgICAgIChzYWZlX3RvX3Byb2NlZWQsIHdhaXRpbmdfbWVz c2FnZSwgYnVnX2lkKSA9IHNlbGYuX2RlbGVnYXRlLnNob3VsZF9wcm9jZWVkX3dpdGhfd29ya19p dGVtKHdvcmtfaXRlbSkKICAgICAgICAgICAgICAgICBpZiBub3Qgc2FmZV90b19wcm9jZWVkOgot ICAgICAgICAgICAgICAgICAgICBzZWxmLl91cGRhdGVfc3RhdHVzX2FuZF9zbGVlcCh3YWl0aW5n X21lc3NhZ2UsIGJ1Z19pZz1idWdfaWQpCisgICAgICAgICAgICAgICAgICAgIHNlbGYuX3VwZGF0 ZV9zdGF0dXNfYW5kX3NsZWVwKHdhaXRpbmdfbWVzc2FnZSkKICAgICAgICAgICAgICAgICAgICAg Y29udGludWUKICAgICAgICAgICAgICAgICBzZWxmLnN0YXR1c19ib3QudXBkYXRlX3N0YXR1cyh3 YWl0aW5nX21lc3NhZ2UsIGJ1Z19pZD1idWdfaWQpCiAgICAgICAgICAgICBleGNlcHQgRXhjZXB0 aW9uLCBlOgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL3dvcmtxdWV1 ZV91bml0dGVzdC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy93b3JrcXVldWVfdW5p dHRlc3QucHkKaW5kZXggZWZhZGRiZi4uN2VkZTVlMiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMv U2NyaXB0cy9tb2R1bGVzL3dvcmtxdWV1ZV91bml0dGVzdC5weQorKysgYi9XZWJLaXRUb29scy9T Y3JpcHRzL21vZHVsZXMvd29ya3F1ZXVlX3VuaXR0ZXN0LnB5CkBAIC05NSw2ICs5NSw3IEBAIGNs YXNzIExvZ2dpbmdEZWxlZ2F0ZShXb3JrUXVldWVEZWxlZ2F0ZSk6CiAgICAgICAgIHNlbGYucmVj b3JkKCJoYW5kbGVfdW5leHBlY3RlZF9lcnJvciIpCiAgICAgICAgIHNlbGYuX3Rlc3QuYXNzZXJ0 RXF1YWxzKHdvcmtfaXRlbSwgIndvcmtfaXRlbSIpCiAKKwogY2xhc3MgVGhyb3dFcnJvckRlbGVn YXRlKExvZ2dpbmdEZWxlZ2F0ZSk6CiAgICAgZGVmIF9faW5pdF9fKHNlbGYsIHRlc3QsIGVycm9y X2NvZGUpOgogICAgICAgICBMb2dnaW5nRGVsZWdhdGUuX19pbml0X18oc2VsZiwgdGVzdCkKQEAg LTEwNCw2ICsxMDUsMjQgQEAgY2xhc3MgVGhyb3dFcnJvckRlbGVnYXRlKExvZ2dpbmdEZWxlZ2F0 ZSk6CiAgICAgICAgIHNlbGYucmVjb3JkKCJwcm9jZXNzX3dvcmtfaXRlbSIpCiAgICAgICAgIHJh aXNlIFNjcmlwdEVycm9yKGV4aXRfY29kZT1zZWxmLmVycm9yX2NvZGUpCiAKKworY2xhc3MgTm90 U2FmZVRvUHJvY2VlZERlbGVnYXRlKExvZ2dpbmdEZWxlZ2F0ZSk6CisgICAgZGVmIHNob3VsZF9w cm9jZWVkX3dpdGhfd29ya19pdGVtKHNlbGYsIHdvcmtfaXRlbSk6CisgICAgICAgIHNlbGYucmVj b3JkKCJzaG91bGRfcHJvY2VlZF93aXRoX3dvcmtfaXRlbSIpCisgICAgICAgIHNlbGYuX3Rlc3Qu YXNzZXJ0RXF1YWxzKHdvcmtfaXRlbSwgIndvcmtfaXRlbSIpCisgICAgICAgIHJldHVybiAoRmFs c2UsICJ3YWl0aW5nX21lc3NhZ2UiLCA0MikKKworCitjbGFzcyBGYXN0V29ya1F1ZXVlKFdvcmtR dWV1ZSk6CisgICAgZGVmIF9faW5pdF9fKHNlbGYsIGRlbGVnYXRlKToKKyAgICAgICAgV29ya1F1 ZXVlLl9faW5pdF9fKHNlbGYsIGRlbGVnYXRlKQorCisgICAgIyBObyBzbGVlcCBmb3IgdGhlIHdp Y2tlZC4KKyAgICBzZWNvbmRzX3RvX3NsZWVwID0gMAorCisgICAgZGVmIF91cGRhdGVfc3RhdHVz X2FuZF9zbGVlcChzZWxmLCBtZXNzYWdlKToKKyAgICAgICAgcGFzcworCiBjbGFzcyBXb3JrUXVl dWVUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICBkZWYgdGVzdF90cml2aWFsKHNlbGYpOgog ICAgICAgICBkZWxlZ2F0ZSA9IExvZ2dpbmdEZWxlZ2F0ZShzZWxmKQpAQCAtMTMwLDYgKzE0OSwx NiBAQCBjbGFzcyBXb3JrUXVldWVUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgd29y a19xdWV1ZS5ydW4oKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhkZWxlZ2F0ZS5fY2FsbGJh Y2tzLCBMb2dnaW5nRGVsZWdhdGUuZXhwZWN0ZWRfY2FsbGJhY2tzKQogCisgICAgZGVmIHRlc3Rf bm90X3NhZmVfdG9fcHJvY2VlZChzZWxmKToKKyAgICAgICAgZGVsZWdhdGUgPSBOb3RTYWZlVG9Q cm9jZWVkRGVsZWdhdGUoc2VsZikKKyAgICAgICAgd29ya19xdWV1ZSA9IEZhc3RXb3JrUXVldWUo ZGVsZWdhdGUpCisgICAgICAgIHdvcmtfcXVldWUucnVuKCkKKyAgICAgICAgZXhwZWN0ZWRfY2Fs bGJhY2tzID0gTG9nZ2luZ0RlbGVnYXRlLmV4cGVjdGVkX2NhbGxiYWNrc1s6XQorICAgICAgICBu ZXh0X3dvcmtfaXRlbV9pbmRleCA9IGV4cGVjdGVkX2NhbGxiYWNrcy5pbmRleCgnbmV4dF93b3Jr X2l0ZW0nKQorICAgICAgICBleHBlY3RlZF9jYWxsYmFja3MgPSBleHBlY3RlZF9jYWxsYmFja3Nb Om5leHRfd29ya19pdGVtX2luZGV4ICsgMl0KKyAgICAgICAgZXhwZWN0ZWRfY2FsbGJhY2tzLmFw cGVuZCgnc2hvdWxkX2NvbnRpbnVlX3dvcmtfcXVldWUnKQorICAgICAgICBzZWxmLmFzc2VydEVx dWFscyhkZWxlZ2F0ZS5fY2FsbGJhY2tzLCBleHBlY3RlZF9jYWxsYmFja3MpCisKICAgICBkZWYg c2V0VXAoc2VsZik6CiAgICAgICAgIHNlbGYudGVtcF9kaXIgPSB0ZW1wZmlsZS5ta2R0ZW1wKHN1 ZmZpeD0id29ya19xdWV1ZV90ZXN0X2xvZ3MiKQogCg==