31542 2009-11-16 03:55:19 -0800 [Qt] Update the plugins manual test to help test show/hide 2009-11-21 02:05:07 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC All RESOLVED FIXED Qt P2 Normal --- 0 girish webkit-unassigned commit-queue kenneth tonikitoo oldest_to_newest 163931 0 girish 2009-11-16 03:55:19 -0800 Helps to check if the plugin really hides/shows correctly. 163932 1 43289 girish 2009-11-16 03:58:54 -0800 Created attachment 43289 Add button to test css display with plugins 163957 2 kenneth 2009-11-16 05:18:36 -0800 Girish will try to change this into a real layout test. 164781 3 43289 eric 2009-11-18 15:40:08 -0800 Comment on attachment 43289 Add button to test css display with plugins Looks sane to me. 164830 4 43289 commit-queue 2009-11-18 17:00:47 -0800 Comment on attachment 43289 Add button to test css display with plugins Clearing flags on attachment: 43289 Committed r51157: <http://trac.webkit.org/changeset/51157> 164831 5 commit-queue 2009-11-18 17:00:53 -0800 All reviewed patches have been landed. Closing bug. 165552 6 tonikitoo 2009-11-20 19:20:43 -0800 (In reply to comment #2) > Girish will try to change this into a real layout test. girish, i believe it will be done in another bug (?) 165594 7 girish 2009-11-21 02:05:07 -0800 (In reply to comment #6) > (In reply to comment #2) > > Girish will try to change this into a real layout test. > > girish, i believe it will be done in another bug (?) Probably, but many of the things are actually already automated. I am not sure how I can test if a plugin does hide/show correctly and if everything is laid out correctly, other than a manual test. 43289 2009-11-16 03:58:54 -0800 2009-11-18 17:00:46 -0800 Add button to test css display with plugins foo text/plain 3125 girish Y29tbWl0IDk3ZjUyNGRhMGE5Mzk1ZDFjZGViNzQxYjc0NmExMjhmOWE1MDEyM2MKQXV0aG9yOiBH aXJpc2ggUmFtYWtyaXNobmFuIDxnaXJpc2hAZm9yd2FyZGJpYXMuaW4+CkRhdGU6ICAgRnJpIE5v diAxMyAyMTozMzo1OCAyMDA5ICswNTMwCgogICAgQWRkIHBsdWdpbiB2aXNpYmlsaXR5IG1hbnVh bCB0ZXN0CgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxv ZwppbmRleCBhNjRjMTQzLi5lNGVlN2I4IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZwor KysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDA5LTExLTE2ICBHaXJp c2ggUmFtYWtyaXNobmFuICA8Z2lyaXNoQGZvcndhcmRiaWFzLmluPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBwbHVnaW4gdmlzaWJpbGl0eSBt YW51YWwgdGVzdAorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zMTU0MgorCisgICAgICAgICogbWFudWFsLXRlc3RzL3BsdWdpbnMvd2luZG93ZWQuaHRt bDoKKyAgICAgICAgKiBtYW51YWwtdGVzdHMvcGx1Z2lucy93aW5kb3dsZXNzLmh0bWw6CisKIDIw MDktMTEtMTQgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvbWFudWFsLXRl c3RzL3BsdWdpbnMvd2luZG93ZWQuaHRtbCBiL1dlYkNvcmUvbWFudWFsLXRlc3RzL3BsdWdpbnMv d2luZG93ZWQuaHRtbAppbmRleCA0MDIwNDA4Li44MDhhMGFkIDEwMDY0NAotLS0gYS9XZWJDb3Jl L21hbnVhbC10ZXN0cy9wbHVnaW5zL3dpbmRvd2VkLmh0bWwKKysrIGIvV2ViQ29yZS9tYW51YWwt dGVzdHMvcGx1Z2lucy93aW5kb3dlZC5odG1sCkBAIC0yMiw2ICsyMiwxNSBAQAogICAgIH0KIDwv c3R5bGU+CiA8c2NyaXB0PgorICAgIGZ1bmN0aW9uIHRlc3RWaXNpYmlsaXR5KCkgeworICAgICAg ICB2YXIgZmxhc2hQbHVnaW4gPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnZmxhc2hQbHVnaW4n KTsKKyAgICAgICAgaWYgKGZsYXNoUGx1Z2luLnN0eWxlLmRpc3BsYXkgPT0gJ25vbmUnKSB7Cisg ICAgICAgICAgICBmbGFzaFBsdWdpbi5zdHlsZS5kaXNwbGF5ID0gJ2Jsb2NrJzsKKyAgICAgICAg fSBlbHNlIHsKKyAgICAgICAgICAgIGZsYXNoUGx1Z2luLnN0eWxlLmRpc3BsYXkgPSAnbm9uZSc7 CisgICAgICAgIH0KKyAgICB9CisKICAgICBmdW5jdGlvbiB0ZXN0UmVzaXplKCkgewogICAgICAg ICB2YXIgZmxhc2hQbHVnaW4gPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnZmxhc2hQbHVnaW4n KTsKICAgICAgICAgZmxhc2hQbHVnaW4ud2lkdGggPSBmbGFzaFBsdWdpbi53aWR0aCA9PSAiMjAw IiA/ICIxMDAiIDogIjIwMCI7CkBAIC02Niw2ICs3NSw5IEBACiAKICAgICA8ZGl2IHN0eWxlPSJj bGVhcjpib3RoIi8+CiAKKyAgICA8aW5wdXQgdHlwZT0iY2hlY2tib3giIG5hbWU9InZpc2liaWxp dHlDaGVja0JveCI+IFZlcmlmeSBpZiB0aGUgZmxhc2ggdG9nZ2xlcyB2aXNpYmlsaXR5CisgICAg ICAgICAgICA8aW5wdXQgdHlwZT0iYnV0dG9uIiBpZD0idmlzaWJpbGl0eUJ1dHRvbiIgdmFsdWU9 IlRlc3QgVmlzaWJpbGl0eSIgb25DbGljaz0idGVzdFZpc2liaWxpdHkoKSIvPjxici8+CisKICAg ICA8aW5wdXQgdHlwZT0iY2hlY2tib3giIG5hbWU9InJlc2l6ZUNoZWNrQm94Ij4gVmVyaWZ5IGlm IHRoZSBmbGFzaCByZXNpemVzIHdoZW4gZWxlbWVudCBpcyByZXNpemVkCiAgICAgICAgICAgICA8 aW5wdXQgdHlwZT0iYnV0dG9uIiBpZD0icmVzaXplQnV0dG9uIiB2YWx1ZT0iVGVzdCBSZXNpemUi IG9uQ2xpY2s9InRlc3RSZXNpemUoKSIvPjxici8+CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvbWFu dWFsLXRlc3RzL3BsdWdpbnMvd2luZG93bGVzcy5odG1sIGIvV2ViQ29yZS9tYW51YWwtdGVzdHMv cGx1Z2lucy93aW5kb3dsZXNzLmh0bWwKaW5kZXggYjU1MzUyNi4uMTAyMGFiYiAxMDA2NDQKLS0t IGEvV2ViQ29yZS9tYW51YWwtdGVzdHMvcGx1Z2lucy93aW5kb3dsZXNzLmh0bWwKKysrIGIvV2Vi Q29yZS9tYW51YWwtdGVzdHMvcGx1Z2lucy93aW5kb3dsZXNzLmh0bWwKQEAgLTIyLDYgKzIyLDE1 IEBACiAgICAgfQogPC9zdHlsZT4KIDxzY3JpcHQ+CisgICAgZnVuY3Rpb24gdGVzdFZpc2liaWxp dHkoKSB7CisgICAgICAgIHZhciBmbGFzaFBsdWdpbiA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCdmbGFzaFBsdWdpbicpOworICAgICAgICBpZiAoZmxhc2hQbHVnaW4uc3R5bGUuZGlzcGxheSA9 PSAnbm9uZScpIHsKKyAgICAgICAgICAgIGZsYXNoUGx1Z2luLnN0eWxlLmRpc3BsYXkgPSAnYmxv Y2snOworICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgZmxhc2hQbHVnaW4uc3R5bGUuZGlz cGxheSA9ICdub25lJzsKKyAgICAgICAgfQorICAgIH0KKwogICAgIGZ1bmN0aW9uIHRlc3RSZXNp emUoKSB7CiAgICAgICAgIHZhciBmbGFzaFBsdWdpbiA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCdmbGFzaFBsdWdpbicpOwogICAgICAgICBmbGFzaFBsdWdpbi53aWR0aCA9IGZsYXNoUGx1Z2lu LndpZHRoID09ICIyMDAiID8gIjEwMCIgOiAiMjAwIjsKQEAgLTY3LDYgKzc2LDkgQEAKIAogICAg IDxkaXYgc3R5bGU9ImNsZWFyOmJvdGgiLz4KIAorICAgIDxpbnB1dCB0eXBlPSJjaGVja2JveCIg bmFtZT0idmlzaWJpbGl0eUNoZWNrQm94Ij4gVmVyaWZ5IGlmIHRoZSBmbGFzaCB0b2dnbGVzIHZp c2liaWxpdHkKKyAgICAgICAgICAgIDxpbnB1dCB0eXBlPSJidXR0b24iIGlkPSJ2aXNpYmlsaXR5 QnV0dG9uIiB2YWx1ZT0iVGVzdCBWaXNpYmlsaXR5IiBvbkNsaWNrPSJ0ZXN0VmlzaWJpbGl0eSgp Ii8+PGJyLz4KKwogICAgIDxpbnB1dCB0eXBlPSJjaGVja2JveCIgbmFtZT0icmVzaXplQ2hlY2tC b3giPiBWZXJpZnkgaWYgdGhlIGZsYXNoIHJlc2l6ZXMgd2hlbiBlbGVtZW50IGlzIHJlc2l6ZWQK ICAgICAgICAgICAgIDxpbnB1dCB0eXBlPSJidXR0b24iIGlkPSJyZXNpemVCdXR0b24iIHZhbHVl PSJUZXN0IFJlc2l6ZSIgb25DbGljaz0idGVzdFJlc2l6ZSgpIi8+PGJyLz4KIAo=