31540 2009-11-16 03:19:16 -0800 bugzilla-tool check-style should work with attachment ids instead of bug ids 2009-11-16 03:31:47 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth oldest_to_newest 163920 0 eric 2009-11-16 03:19:16 -0800 bugzilla-tool check-style should work with attachment ids instead of bug ids Now that bugzilla.py can fetch attachment objects directly from attachment ids instead of bugs, we should update check-style to work with a single attachment at a time. 163922 1 43286 eric 2009-11-16 03:20:25 -0800 Created attachment 43286 Patch 163923 2 43286 abarth 2009-11-16 03:25:02 -0800 Comment on attachment 43286 Patch + ATTACHEMENT_ID spelling 163924 3 eric 2009-11-16 03:31:47 -0800 Committed r51025: <http://trac.webkit.org/changeset/51025> 43286 2009-11-16 03:20:25 -0800 2009-11-16 03:25:02 -0800 Patch bug-31540-20091116032023.patch text/plain 4717 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA4ZTlmZjA0Li4yOTAwYjU1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMDktMTEt MTYgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGJ1Z3ppbGxhLXRvb2wgY2hlY2stc3R5bGUgc2hv dWxkIHdvcmsgd2l0aCBhdHRhY2htZW50IGlkcyBpbnN0ZWFkIG9mIGJ1ZyBpZHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNTQwCisKKyAgICAgICAg KiBTY3JpcHRzL2J1Z3ppbGxhLXRvb2w6CisKKzIwMDktMTEtMTYgIEVyaWMgU2VpZGVsICA8ZXJp Y0B3ZWJraXQub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCiAKICAgICAg ICAgV29ya1F1ZXVlIGlzIHRoZSBvbmx5IHBsYWNlIHRoYXQgc2hvdWxkIGtub3cgYWJvdXQgc3Bl Y2lhbCBleGl0IGNvZGVzCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL2J1Z3ppbGxh LXRvb2wgYi9XZWJLaXRUb29scy9TY3JpcHRzL2J1Z3ppbGxhLXRvb2wKaW5kZXggNjBjYjM0Yy4u N2Y0ZDc5MCAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWd6aWxsYS10b29sCisr KyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbApAQCAtMTM2LDIwICsxMzYsMjEg QEAgY2xhc3MgUmV2aWV3ZWRQYXRjaGVzT25CdWcoQ29tbWFuZCk6CiAgICAgICAgICAgICBwcmlu dCAiJXMiICUgcGF0Y2hbJ3VybCddCiAKIAotY2xhc3MgQ2hlY2tTdHlsZU9uQnVnKENvbW1hbmQp OgorY2xhc3MgQ2hlY2tTdHlsZShDb21tYW5kKToKICAgICBkZWYgX19pbml0X18oc2VsZik6CiAg ICAgICAgIG9wdGlvbnMgPSBXZWJLaXRMYW5kaW5nU2NyaXB0cy5jbGVhbmluZ19vcHRpb25zKCkK LSAgICAgICAgQ29tbWFuZC5fX2luaXRfXyhzZWxmLCAnUnVucyBjaGVjay13ZWJraXQtc3R5bGUg b24gdGhlIHI/IHBhdGNoZXMgb24gYSBidWcnLCAnQlVHSUQnLCBvcHRpb25zPW9wdGlvbnMpCisg ICAgICAgIENvbW1hbmQuX19pbml0X18oc2VsZiwgJ1J1bnMgY2hlY2std2Via2l0LXN0eWxlIG9u IHRoZSBzcGVjaWZpZWQgYXR0YWNobWVudCcsICdBVFRBQ0hFTUVOVF9JRCcsIG9wdGlvbnM9b3B0 aW9ucykKIAogICAgIEBjbGFzc21ldGhvZAotICAgIGRlZiBjaGVja19zdHlsZShjbHMsIGJ1Z19p ZCwgcGF0Y2gsIG9wdGlvbnMsIHRvb2wpOgorICAgIGRlZiBjaGVja19zdHlsZShjbHMsIHBhdGNo LCBvcHRpb25zLCB0b29sKToKICAgICAgICAgdG9vbC5zY20oKS51cGRhdGVfd2Via2l0KCkKLSAg ICAgICAgbG9nKCJDaGVja2luZyBzdHlsZSBmb3IgcGF0Y2ggJXMgZnJvbSBidWcgJXMuIiAlIChw YXRjaFsnaWQnXSwgYnVnX2lkKSkKKyAgICAgICAgbG9nKCJDaGVja2luZyBzdHlsZSBmb3IgcGF0 Y2ggJXMgZnJvbSBidWcgJXMuIiAlIChwYXRjaFsnaWQnXSwgcGF0Y2hbJ2J1Z19pZCddKSkKICAg ICAgICAgdHJ5OgorICAgICAgICAgICAgIyBGSVhNRTogY2hlY2std2Via2l0LXN0eWxlIHNob3Vs ZG4ndCByZWFsbHkgaGF2ZSB0byBhcHBseSB0aGUgcGF0Y2ggdG8gY2hlY2sgdGhlIHN0eWxlLgog ICAgICAgICAgICAgdG9vbC5zY20oKS5hcHBseV9wYXRjaChwYXRjaCkKICAgICAgICAgICAgIFdl YktpdExhbmRpbmdTY3JpcHRzLnJ1bl93ZWJraXRfc2NyaXB0KCJjaGVjay13ZWJraXQtc3R5bGUi KQogICAgICAgICBleGNlcHQgU2NyaXB0RXJyb3IsIGU6Ci0gICAgICAgICAgICBsb2coIlBhdGNo IGZhaWxlZCB0byBhcHBseSBhbmQgY2hlY2sgc3R5bGUiKQorICAgICAgICAgICAgbG9nKCJQYXRj aCAlcyBmcm9tIGJ1ZyAlcyBmYWlsZWQgdG8gYXBwbHkgYW5kIGNoZWNrIHN0eWxlLiIgJSAocGF0 Y2hbJ2lkJ10sIHBhdGNoWydidWdfaWQnXSkpCiAgICAgICAgICAgICBsb2coZS5vdXRwdXQpCiAK ICAgICAgICAgIyBUaGlzIGlzIHNhZmUgYmVjYXVzZSBpbiBvcmRlciB0byBnZXQgaGVyZSB0aGUg d29ya2luZyBkaXJlY3RvcnkgaGFkIHRvIGJlCkBAIC0xNTcsMTMgKzE1OCwxMSBAQCBjbGFzcyBD aGVja1N0eWxlT25CdWcoQ29tbWFuZCk6CiAgICAgICAgIHRvb2wuc2NtKCkuZW5zdXJlX2NsZWFu X3dvcmtpbmdfZGlyZWN0b3J5KGZvcmNlX2NsZWFuPVRydWUpCiAKICAgICBkZWYgZXhlY3V0ZShz ZWxmLCBvcHRpb25zLCBhcmdzLCB0b29sKToKLSAgICAgICAgYnVnX2lkID0gYXJnc1swXQotICAg ICAgICBwYXRjaGVzID0gdG9vbC5idWdzLmZldGNoX3VucmV2aWV3ZWRfcGF0Y2hlc19mcm9tX2J1 ZyhidWdfaWQpCisgICAgICAgIGF0dGFjaG1lbnRfaWQgPSBhcmdzWzBdCisgICAgICAgIGF0dGFj aG1lbnQgPSB0b29sLmJ1Z3MuZmV0Y2hfYXR0YWNobWVudChhdHRhY2htZW50X2lkKQogCiAgICAg ICAgIFdlYktpdExhbmRpbmdTY3JpcHRzLnByZXBhcmVfY2xlYW5fd29ya2luZ19kaXJlY3Rvcnko dG9vbC5zY20oKSwgb3B0aW9ucykKLQotICAgICAgICBmb3IgcGF0Y2ggaW4gcGF0Y2hlczoKLSAg ICAgICAgICAgIHNlbGYuY2hlY2tfc3R5bGUoYnVnX2lkLCBwYXRjaCwgb3B0aW9ucywgdG9vbCkK KyAgICAgICAgc2VsZi5jaGVja19zdHlsZShhdHRhY2htZW50LCBvcHRpb25zLCB0b29sKQogCiAK IGNsYXNzIEFwcGx5QXR0YWNobWVudChDb21tYW5kKToKQEAgLTc5NiwyMSArNzk1LDIxIEBAIGNs YXNzIFN0eWxlUXVldWUoQWJzdHJhY3RRdWV1ZSk6CiAgICAgICAgIEFic3RyYWN0UXVldWUuX19p bml0X18oc2VsZiwgInN0eWxlLXF1ZXVlIikKIAogICAgIGRlZiBuZXh0X3dvcmtfaXRlbShzZWxm KToKLSAgICAgICAgaWYgbm90IGxlbihzZWxmLnBhdGNoZXMpOgorICAgICAgICBpZiBub3Qgc2Vs Zi5wYXRjaGVzOgogICAgICAgICAgICAgc2VsZi5wYXRjaGVzID0gc2VsZi50b29sLmJ1Z3MuZmV0 Y2hfcGF0Y2hlc19mcm9tX3Jldmlld19xdWV1ZShsaW1pdD0xMCkKLSAgICAgICAgICAgIGlmIG5v dCBsZW4oc2VsZi5wYXRjaGVzKToKKyAgICAgICAgICAgIGlmIG5vdCBzZWxmLnBhdGNoZXM6CiAg ICAgICAgICAgICAgICAgcmV0dXJuIE5vbmUKICAgICAgICAgcGF0Y2hfaWRzID0gbWFwKGxhbWJk YSBwYXRjaDogcGF0Y2hbJ2lkJ10sIHNlbGYucGF0Y2hlcykKICAgICAgICAgbG9nKCIlcyBpbiBy ZXZpZXcgcXVldWUgWyVzXSIgJSAocGx1cmFsaXplKCdwYXRjaCcsIGxlbihzZWxmLnBhdGNoZXMp KSwgIiwgIi5qb2luKHBhdGNoX2lkcykpKQotICAgICAgICByZXR1cm4gc2VsZi5wYXRjaGVzLnBv cCgwKVsnYnVnX2lkJ10KKyAgICAgICAgcmV0dXJuIHNlbGYucGF0Y2hlcy5wb3AoMCkKIAotICAg IGRlZiBzaG91bGRfcHJvY2VlZF93aXRoX3dvcmtfaXRlbShzZWxmLCBidWdfaWQpOgotICAgICAg ICByZXR1cm4gKFRydWUsICJDaGVja2luZyBzdHlsZSBmb3IgYnVnICVzLiIgJSBidWdfaWQsIGJ1 Z19pZCkKKyAgICBkZWYgc2hvdWxkX3Byb2NlZWRfd2l0aF93b3JrX2l0ZW0oc2VsZiwgcGF0Y2gp OgorICAgICAgICByZXR1cm4gKFRydWUsICJDaGVja2luZyBzdHlsZSBmb3IgcGF0Y2ggJXMgb24g YnVnICVzLiIgJSBwYXRjaFsnaWQnXSwgcGF0Y2hbJ2J1Z19pZCddKQogCi0gICAgZGVmIHByb2Nl c3Nfd29ya19pdGVtKHNlbGYsIGJ1Z19pZCk6Ci0gICAgICAgIHNlbGYucnVuX2J1Z3ppbGxhX3Rv b2woWydjaGVjay1zdHlsZScsICctLWZvcmNlLWNsZWFuJywgYnVnX2lkXSkKKyAgICBkZWYgcHJv Y2Vzc193b3JrX2l0ZW0oc2VsZiwgcGF0Y2gpOgorICAgICAgICBzZWxmLnJ1bl9idWd6aWxsYV90 b29sKFsnY2hlY2stc3R5bGUnLCAnLS1mb3JjZS1jbGVhbicsIHBhdGNoWydpZCddXSkKIAotICAg IGRlZiBoYW5kbGVfdW5leHBlY3RlZF9lcnJvcihzZWxmLCBidWdfaWQsIG1lc3NhZ2UpOgorICAg IGRlZiBoYW5kbGVfdW5leHBlY3RlZF9lcnJvcihzZWxmLCBwYXRjaCwgbWVzc2FnZSk6CiAgICAg ICAgIGxvZyhtZXNzYWdlKQogCiAKQEAgLTg0Nyw3ICs4NDYsNyBAQCBjbGFzcyBCdWd6aWxsYVRv b2w6CiAgICAgICAgICAgICB7ICduYW1lJyA6ICdhcHBseS1wYXRjaGVzJywgJ29iamVjdCcgOiBB cHBseVBhdGNoZXNGcm9tQnVnKCkgfSwKICAgICAgICAgICAgIHsgJ25hbWUnIDogJ2xhbmQtZGlm ZicsICdvYmplY3QnIDogTGFuZEFuZFVwZGF0ZUJ1ZygpIH0sCiAgICAgICAgICAgICB7ICduYW1l JyA6ICdsYW5kLXBhdGNoZXMnLCAnb2JqZWN0JyA6IExhbmRQYXRjaGVzRnJvbUJ1Z3MoKSB9LAot ICAgICAgICAgICAgeyAnbmFtZScgOiAnY2hlY2stc3R5bGUnLCAnb2JqZWN0JyA6IENoZWNrU3R5 bGVPbkJ1ZygpIH0sCisgICAgICAgICAgICB7ICduYW1lJyA6ICdjaGVjay1zdHlsZScsICdvYmpl Y3QnIDogQ2hlY2tTdHlsZSgpIH0sCiAgICAgICAgICAgICB7ICduYW1lJyA6ICdjb21taXQtbWVz c2FnZScsICdvYmplY3QnIDogQ29tbWl0TWVzc2FnZUZvckN1cnJlbnREaWZmKCkgfSwKICAgICAg ICAgICAgIHsgJ25hbWUnIDogJ29ic29sZXRlLWF0dGFjaG1lbnRzJywgJ29iamVjdCcgOiBPYnNv bGV0ZUF0dGFjaG1lbnRzT25CdWcoKSB9LAogICAgICAgICAgICAgeyAnbmFtZScgOiAncG9zdC1k aWZmJywgJ29iamVjdCcgOiBQb3N0RGlmZkFzUGF0Y2hUb0J1ZygpIH0sCg==