31539 2009-11-16 02:45:29 -0800 Form Reset : Press Back Button and Reset , TextareaElemnt is not set to Default Value 2010-01-12 03:48:20 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED http://spe.mobilephone.net/wit/witroot.com P1 Normal --- 1 amolasia.18 benm adele amolasia.18 ap benm commit-queue darin mjs webkit.review.bot oldest_to_newest 163912 0 amolasia.18 2009-11-16 02:45:29 -0800 I visited the formreset link(http://spe.mobilephone.net/wit/xhtmlv2/formreset.xhtml ). All Radio button , checkbox , TextArea has some defalut value . After modifying it and pressing Submit , the data gets submitted , If we press back and Press a Reset Button . The textarea feild is not getting reset to default valu e, I observer the same behavior in other Browser(Mozilla) , its resets the same . Regards , Amol 164127 1 ap 2009-11-16 17:38:27 -0800 I cannot reproduce this with Safari 4.0.3 on Mac OS X. What browser are you seeing this with? 164151 2 amolasia.18 2009-11-16 21:22:33 -0800 Hi Alexey, Thanks for the reply . I can see this issue in Google Chrome(3.0.195.33) which i have installed . I have ported the Webkit Browser code and the same issue i can see in Google android phone . Thanks and Regards , Amol 166895 3 benm 2009-11-27 06:45:16 -0800 I had a look at this on Android, and the problem seems to be when TextAreaElement::restoreFormControlElementState is called when we navigate back to the page. This resets the *default* value of the element to the state of the form before the submit (using TextAreaElement::setDefaultValue), so when we click reset, the default value to reset to matches the current state rather than the default value stipulated by the HTML. Setting breakpoints in Safari, it seems restoreFormControlElementState isn't getting called because it's being pulled out of the cache and short circuiting some code, whereas on Android we are triggering a new load. If after submitting the form you clear Safari's cache and then go back, the bug surfaces and you cannot reset the text area to it's default value of 123. I think the fix therefore is to call setValue rather than setDefaultValue in restoreFormControlElementState. I can send a patch for this. Thanks, Ben 167210 4 benm 2009-11-30 03:04:57 -0800 I have a patch ready to fix this bug, but before I upload it I've been trying to write a layout test for it. It's tricky because to expose the bug on Safari, you need to clear the cache between submitting the form and hitting back. Is there a way to turn off or clear the cache through the layout test controller? Thanks, Ben 167243 5 ap 2009-11-30 08:35:28 -0800 Maybe setCacheModel(0) will work? 167633 6 benm 2009-12-01 08:29:17 -0800 I have written a reduced test case that exposes the bug on Safari which is perfect for the layout test. However, I'm having trouble getting the test to execute automatically. If you open the test page and manually click the 'submit' button on the form in the iframe, then the test will expose the bug. When I try to automate this by programattically clicking the button, the test does not run correctly. I think I've tracked the problem down to the fact that it seems that for events from script that trigger navigation, no history items are created and so the call to history.back() in the form handler fails. I will attach the test as I have it right now; does any one have any advice as to how I could fully automate it? I've tried using the eventSender object in DRT, calling the submit button's click() method, instantiating an Event object and dispatching it to the submit button, altering location.hash to try and create history entries, calling the submit() function on the form itself, but nothing seems to work... The fix for the bug is a very simple one line change in HTMLTextAreaElement.cpp. Thanks, Ben 167638 7 44083 benm 2009-12-01 08:40:39 -0800 Created attachment 44083 Test part 1 First part of the test 167639 8 44084 benm 2009-12-01 08:41:56 -0800 Created attachment 44084 Test part 2 - place in resources directory under part 1 169392 9 benm 2009-12-07 11:22:12 -0800 I haven't had any luck getting the test to automate - I wonder if we could consider adding the fix without a test? I have attached a patch... 169393 10 44422 benm 2009-12-07 11:22:57 -0800 Created attachment 44422 Proposed patch 169743 11 44422 darin 2009-12-08 11:46:45 -0800 Comment on attachment 44422 Proposed patch > void HTMLTextAreaElement::restoreFormControlState(const String& state) > { > - setDefaultValue(state); > + setValue(state); > } Sure, we want to set the value. But don't we want to set the default value too? 169744 12 webkit.review.bot 2009-12-08 11:47:35 -0800 style-queue ran check-webkit-style on attachment 44422 without any errors. 169747 13 benm 2009-12-08 11:54:14 -0800 (In reply to comment #11) > > Sure, we want to set the value. But don't we want to set the default value too? I don't think so -- not to the value that was stored as the state of the text area, anyway? 175520 14 mjs 2009-12-29 05:45:50 -0800 (In reply to comment #11) > (From update of attachment 44422 [details]) > > void HTMLTextAreaElement::restoreFormControlState(const String& state) > > { > > - setDefaultValue(state); > > + setValue(state); > > } > > Sure, we want to set the value. But don't we want to set the default value too? I don't think that's right - when saving form control state, what we saved originally was the value, not the default value. We could save the default value as well (in case it was changed e.g. by altering the <textarea>'s DOM children) but in general our form control state saving code doesn't try to do that type of thing. 178960 15 adele 2010-01-08 23:48:04 -0800 How about adding the test as a manual test? 179335 16 benm 2010-01-11 04:50:57 -0800 (In reply to comment #15) > How about adding the test as a manual test? That would do it I should think, thanks for the tip! I've never written or used manual tests in WebKit -- is it as one would expect, a layout test that is designed to be run by hand? A quick look at current tests inside WebCore/manual-tests would suggest so and that the body of the test page should include instructions for running the test and the expected results. Are there any other guidelines or tips for writing a manual test? Are these tests run with any regularity? Thanks, Ben 179408 17 46286 benm 2010-01-11 09:58:22 -0800 Created attachment 46286 Fix with manual test Here's the same patch with a manual test. 179756 18 46286 benm 2010-01-12 02:29:15 -0800 Comment on attachment 46286 Fix with manual test cq+ for landing. 179776 19 46286 commit-queue 2010-01-12 03:48:12 -0800 Comment on attachment 46286 Fix with manual test Clearing flags on attachment: 46286 Committed r53132: <http://trac.webkit.org/changeset/53132> 179777 20 commit-queue 2010-01-12 03:48:20 -0800 All reviewed patches have been landed. Closing bug. 44083 2009-12-01 08:40:39 -0800 2010-01-11 09:58:22 -0800 Test part 1 restore-textarea-state.html text/html 2635 benm PGh0bWw+DQo8aGVhZD4NCjx0aXRsZT5UZXN0IGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzE1Mzk8L3RpdGxlPg0KDQo8IS0tIExheW91dCB0ZXN0IGZvciBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE1MzkuDQogICAgIEVuc3VyZSB0 aGF0IHRoZSB2YWx1ZSBhbmQgZGVmYXVsdFZhbHVlIG9uIGEgdGV4dGFyZWEgaXMgcmVzdG9yZWQg Y29ycmVjdGx5IHdoZW4gDQogICAgIHdlIHJlc3RvcmUgZm9ybSBzdGF0ZSAoZS5nLiBieSBoaXR0 aW5nIGJhY2sgYWZ0ZXIgc3VibWl0dGluZyBhIGZvcm0pLiAtLT4NCg0KPHNjcmlwdCB0eXBlPSJ0 ZXh0L2phdmFzY3JpcHQiPg0KdmFyIEVYUEVDVEVEX1ZBTFVFID0gIkhlbGxvISI7DQp2YXIgRVhQ RUNURURfREVGQVVMVFZBTFVFID0gIjEyMyI7DQoNCmZ1bmN0aW9uIHJ1blRlc3QoKQ0Kew0KICAg IGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsNCiAgICAgICAgbGF5b3V0VGVzdENv bnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOw0KICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5j bGVhckJhY2tGb3J3YXJkTGlzdCgpOw0KICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5rZWVw V2ViSGlzdG9yeSgpOw0KICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7 DQogICAgfQ0KICANCiAgICB2YXIgaWZyYW1lRG9jdW1lbnQgPSBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgnZnJhbWUnKS5jb250ZW50RG9jdW1lbnQ7DQogICAgDQogICAgaWZyYW1lRG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoJ3RleHRhcmVhJykudmFsdWUgPSBFWFBFQ1RFRF9WQUxVRTsNCiAgDQog ICAgLy8gVW5jb21tZW50aW5nIHRoaXMgbGluZSBzaG91bGQgYXV0b21hdGUgdGhlIHRlc3QuIEhv d2V2ZXIsIGl0IHNlZW1zIGRpc3BhdGNoaW5nDQogICAgLy8gYW4gZXZlbnQgbGlrZSB0aGlzIGZy b20gc2NyaXB0IGRvZXMgbm90IGNyZWF0ZSBhIGhpc3RvcnkgZW50cnkgYW5kIHNvIHRoZQ0KICAg IC8vIGhpc3RvcnkuYmFjaygpIGNhbGwgaW4gdGhlIGFjdGlvbiBhdHRyaWJ1dGUgb2YgcmVzb3Vy Y2VzL2Zvcm1yZXNldC5odG1sIGRvZXNuJ3QNCiAgICAvLyBicmluZyB1cyBiYWNrIHRvIHRoZSBm b3JtLiBXZSBuZWVkIHRvIGdvIGJhY2sgc28gdGhhdCB3ZSB0cmlnZ2VyIHJlc3RvcmluZyB0aGUg Zm9ybSBzdGF0ZS4NCiAgICAvLyBJZiB5b3UgY29tbWVudCBvdXQgdGhpcyBsaW5lIGFuZCBydW4g dGhlIHRlc3QgaW4gU2FmYXJpIGFuZCBjbGljayB0aGUgYnV0dG9uIG1hbnVhbGx5LA0KICAgIC8v IHRoZSBoaXN0b3J5IGlzIHBvcHVsYXRlZCBjb3JyZWN0bHkgYW5kIHRoZSBidWcgaXMgZXhwb3Nl ZC4gTm90ZSB5b3UgbXVzdCBjbGljayB0aGUNCiAgICAvLyBidXR0b24gYmVmb3JlIHRoZSAycyB0 aW1lb3V0IGJlbG93IGV4cGlyZXMhDQogICAgLy8gSG93IGRvIHdlIGZvcmNlIFNhZmFyaSAob3Ig YXQgbGVhc3QgRFJUKSB0byBjcmVhdGUgYSBoaXN0b3J5IGl0ZW0gd2hlbiBwZXJmb3JtaW5nDQog ICAgLy8gc2NyaXB0IGFjdGlvbnMgdGhhdCByZXN1bHQgaW4gYSBuYXZpZ2F0aW9uPw0KICAgIC8v aWZyYW1lRG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3N1Ym1pdF9idXR0b24nKS5jbGljaygpOw0K ICANCiAgICB3aW5kb3cuc2V0VGltZW91dChmdW5jdGlvbigpIHsgZG9uZSgpOyB9LCAyMDAwKTsN Cn0NCg0KZnVuY3Rpb24gZG9uZSgpDQp7DQogICAgdmFyIGlmcmFtZURvY3VtZW50ID0gZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoJ2ZyYW1lJykuY29udGVudERvY3VtZW50Ow0KICAgIHZhciB2YWx1 ZSA9IGlmcmFtZURvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd0ZXh0YXJlYScpLnZhbHVlOw0KICAg IHZhciBkZWZhdWx0VmFsdWUgPSBpZnJhbWVEb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndGV4dGFy ZWEnKS5kZWZhdWx0VmFsdWU7DQogICAgbG9nKCJWYWx1ZSA9ICIgKyB2YWx1ZSArICI7IGV4cGVj dGVkICIgKyBFWFBFQ1RFRF9WQUxVRSk7DQogICAgbG9nKCJkZWZhdWx0VmFsdWUgPSAiICsgZGVm YXVsdFZhbHVlICsgIjsgZXhwZWN0ZWQgIiArIEVYUEVDVEVEX0RFRkFVTFRWQUxVRSk7DQogIA0K ICAgIGlmICh2YWx1ZSA9PSBFWFBFQ1RFRF9WQUxVRSAmJiBkZWZhdWx0VmFsdWUgPT0gRVhQRUNU RURfREVGQVVMVFZBTFVFKQ0KICAgICAgICBsb2coIlBBU1MiKTsNCiAgICBlbHNlDQogICAgICAg IGxvZygiRkFJTCIpOw0KICANCiAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQ0K ICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOw0KfQ0KDQpmdW5jdGlvbiBs b2cobXNnKQ0Kew0KICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdsb2cnKS5pbm5lckhUTUwg Kz0gbXNnICsgJzxici8+JzsNCn0NCg0KPC9zY3JpcHQ+DQo8L2hlYWQ+DQo8Ym9keSBvbmxvYWQ9 InJ1blRlc3QoKTsiPg0KPHA+VGVzdCBmb3JtIHJlc2V0PC9wPg0KPGlmcmFtZSBzcmM9InJlc291 cmNlcy90ZXh0YXJlYS1mb3JtLWJhY2stb24tc3VibWl0Lmh0bWwiIHdpZHRoPSI4MDAiIGhlaWdo dD0iMjAwIiBpZD0iZnJhbWUiPjwvaWZyYW1lPg0KPGRpdiBpZD0ibG9nIj48L2Rpdj4NCg0KPC9i b2R5Pg0KPC9odG1sPg== 44084 2009-12-01 08:41:56 -0800 2010-01-11 09:58:22 -0800 Test part 2 - place in resources directory under part 1 textarea-form-back-on-submit.html text/html 409 benm PGh0bWw+DQo8aGVhZD4NCjx0aXRsZT5Gb3JtIHdpdGggYSB0ZXh0YXJlYSB0aGF0IGdvZXMgYmFj ayBvbiBzdWJtaXQ8L3RpdGxlPg0KPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPg0KPC9z Y3JpcHQ+DQo8L2hlYWQ+DQo8Ym9keT4NCjxmb3JtIGlkPSJmb3JtIiBtZXRob2Q9ImdldCIgYWN0 aW9uPSJkYXRhOnRleHQvaHRtbCw8Ym9keSBvbmxvYWQ9J2hpc3RvcnkuYmFjaygpJz48L2JvZHk+ Ij4NCiAgPHA+DQogIDx0ZXh0YXJlYSBuYW1lPSJ0ZXh0IiByb3dzPSIxIiBjb2xzPSIxMCIgaWQ9 InRleHRhcmVhIj4xMjM8L3RleHRhcmVhPjxiciAvPg0KICA8YnIgLz4NCiAgPGlucHV0IHR5cGU9 InN1Ym1pdCIgaWQ9InN1Ym1pdF9idXR0b24iIC8+DQogIDwvcD4NCjwvZm9ybT4NCg0KPC9ib2R5 Pg0KPC9odG1sPg== 44422 2009-12-07 11:22:57 -0800 2010-01-11 09:58:22 -0800 Proposed patch 31539-patch.txt text/plain 1384 benm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTc2NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMTItMDcgIEJlbiBNdXJkb2NoICA8YmVubUBnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvcm0g UmVzZXQgOiBQcmVzcyBCYWNrIEJ1dHRvbiBhbmQgUmVzZXQgLCBUZXh0YXJlYUVsZW1udCBpcyBu b3Qgc2V0IHRvIERlZmF1bHQgVmFsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTMxNTM5CisKKyAgICAgICAgU2VlIGJ1ZyBmb3IgdGVzdGluZyBkaXNj dXNzaW9uLgorCisgICAgICAgICogaHRtbC9IVE1MVGV4dEFyZWFFbGVtZW50LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkhUTUxUZXh0QXJlYUVsZW1lbnQ6OnJlc3RvcmVGb3JtQ29udHJvbFN0YXRl KTogc2V0IHRoZSB2YWx1ZSwgcmF0aGVyIHRoYW4gZGVmYXVsdCB2YWx1ZSBvZiBhIHRleHQgYXJl YSB3aGVuIHJlc3RvcmluZyBpdHMgc3RhdGUuIFRoaXMgYWxsb3dzIHJlc2V0dGluZyBhIGZvcm0g d2l0aCBhIHRleHRhcmVhIHRvIHdvcmsgY29ycmVjdGx5IGFmdGVyIGl0cyBzdGF0ZSBoYXMgYmVl biByZXN0b3JlZC4KKwogMjAwOS0xMi0wNyAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25zQGdu b21lLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXouCkluZGV4OiBXZWJDb3Jl L2h0bWwvSFRNTFRleHRBcmVhRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1s L0hUTUxUZXh0QXJlYUVsZW1lbnQuY3BwCShyZXZpc2lvbiA1MTc1NCkKKysrIFdlYkNvcmUvaHRt bC9IVE1MVGV4dEFyZWFFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTEsNyArOTEsNyBA QCBib29sIEhUTUxUZXh0QXJlYUVsZW1lbnQ6OnNhdmVGb3JtQ29udHJvCiAKIHZvaWQgSFRNTFRl eHRBcmVhRWxlbWVudDo6cmVzdG9yZUZvcm1Db250cm9sU3RhdGUoY29uc3QgU3RyaW5nJiBzdGF0 ZSkKIHsKLSAgICBzZXREZWZhdWx0VmFsdWUoc3RhdGUpOworICAgIHNldFZhbHVlKHN0YXRlKTsK IH0KIAogdm9pZCBIVE1MVGV4dEFyZWFFbGVtZW50OjpjaGlsZHJlbkNoYW5nZWQoYm9vbCBjaGFu Z2VkQnlQYXJzZXIsIE5vZGUqIGJlZm9yZUNoYW5nZSwgTm9kZSogYWZ0ZXJDaGFuZ2UsIGludCBj aGlsZENvdW50RGVsdGEpCg== 46286 2010-01-11 09:58:22 -0800 2010-01-12 03:48:12 -0800 Fix with manual test 31539.txt text/plain 3914 benm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzA3NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDEtMTEgIEJlbiBNdXJkb2NoICA8YmVubUBnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvcm0g UmVzZXQgOiBQcmVzcyBCYWNrIEJ1dHRvbiBhbmQgUmVzZXQgLCBUZXh0YXJlYUVsZW1udCBpcyBu b3Qgc2V0IHRvIERlZmF1bHQgVmFsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTMxNTM5CisKKyAgICAgICAgQWRkZWQgbWFudWFsIHRlc3Q6IG1hbnVh bC10ZXN0cy90ZXh0YXJlYS1yZXNldC1kZWZhdWx0LXZhbHVlLmh0bWwuCisKKyAgICAgICAgKiBo dG1sL0hUTUxUZXh0QXJlYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRleHRB cmVhRWxlbWVudDo6cmVzdG9yZUZvcm1Db250cm9sU3RhdGUpOiBzZXQgdGhlIHZhbHVlLCByYXRo ZXIgdGhhbiBkZWZhdWx0IHZhbHVlIG9mIGEgdGV4dCBhcmVhIHdoZW4gcmVzdG9yaW5nIGl0cyBz dGF0ZS4gVGhpcyBhbGxvd3MgcmVzZXR0aW5nIGEgZm9ybSB3aXRoIGEgdGV4dGFyZWEgdG8gd29y ayBjb3JyZWN0bHkgYWZ0ZXIgaXRzIHN0YXRlIGhhcyBiZWVuIHJlc3RvcmVkLgorICAgICAgICAq IG1hbnVhbC10ZXN0cy9yZXNvdXJjZXMvdGV4dGFyZWEtZm9ybS1iYWNrLW9uLXN1Ym1pdC5odG1s OiBBZGRlZC4KKyAgICAgICAgKiBtYW51YWwtdGVzdHMvdGV4dGFyZWEtcmVzZXQtZGVmYXVsdC12 YWx1ZS5odG1sOiBBZGRlZC4KKwogMjAxMC0wMS0xMSAgSm9hbm1hcmllIERpZ2dzICA8am9hbm1h cmllLmRpZ2dzQGdtYWlsLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXouCklu ZGV4OiBXZWJDb3JlL2h0bWwvSFRNTFRleHRBcmVhRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9odG1sL0hUTUxUZXh0QXJlYUVsZW1lbnQuY3BwCShyZXZpc2lvbiA1MzA3NSkKKysr IFdlYkNvcmUvaHRtbC9IVE1MVGV4dEFyZWFFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAt OTIsNyArOTIsNyBAQCBib29sIEhUTUxUZXh0QXJlYUVsZW1lbnQ6OnNhdmVGb3JtQ29udHJvCiAK IHZvaWQgSFRNTFRleHRBcmVhRWxlbWVudDo6cmVzdG9yZUZvcm1Db250cm9sU3RhdGUoY29uc3Qg U3RyaW5nJiBzdGF0ZSkKIHsKLSAgICBzZXREZWZhdWx0VmFsdWUoc3RhdGUpOworICAgIHNldFZh bHVlKHN0YXRlKTsKIH0KIAogdm9pZCBIVE1MVGV4dEFyZWFFbGVtZW50OjpjaGlsZHJlbkNoYW5n ZWQoYm9vbCBjaGFuZ2VkQnlQYXJzZXIsIE5vZGUqIGJlZm9yZUNoYW5nZSwgTm9kZSogYWZ0ZXJD aGFuZ2UsIGludCBjaGlsZENvdW50RGVsdGEpCkluZGV4OiBXZWJDb3JlL21hbnVhbC10ZXN0cy90 ZXh0YXJlYS1yZXNldC1kZWZhdWx0LXZhbHVlLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9t YW51YWwtdGVzdHMvdGV4dGFyZWEtcmVzZXQtZGVmYXVsdC12YWx1ZS5odG1sCShyZXZpc2lvbiAw KQorKysgV2ViQ29yZS9tYW51YWwtdGVzdHMvdGV4dGFyZWEtcmVzZXQtZGVmYXVsdC12YWx1ZS5o dG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDI0IEBACis8aHRtbD4KKzxoZWFkPgorPHRpdGxl PlRlc3QgZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTUzOTwv dGl0bGU+CisKKzwhLS0gTWFudWFsIHRlc3QgZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zMTUzOS4KKyAgICAgRW5zdXJlIHRoYXQgdGhlIHZhbHVlIGFuZCBkZWZh dWx0VmFsdWUgb24gYSB0ZXh0YXJlYSBpcyByZXN0b3JlZCBjb3JyZWN0bHkgd2hlbiAKKyAgICAg d2UgcmVzdG9yZSBmb3JtIHN0YXRlIChlLmcuIGJ5IGhpdHRpbmcgYmFjayBhZnRlciBzdWJtaXR0 aW5nIGEgZm9ybSkuIC0tPgorCis8L2hlYWQ+Cis8Ym9keT4KKzxoMj5NYW51YWwgdGVzdCBmb3Ig aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNTM5LjwvaDI+Cis8cD5U byBydW4gdGhpcyB0ZXN0OjwvcD4KKzx1bD4KKyAgPGxpPkNoYW5nZSB0aGUgdGV4dCBpbiB0aGUg Jmx0O3RleHRhcmVhJmd0OyBiZWxvdy48L2xpPgorICA8bGk+U3VibWl0IHRoZSBmb3JtLiBUaGUg Zm9ybSBzaG91bGQgbmF2aWdhdGUgYmFjayBpbW1lZGlhdGVseS48L2xpPgorICA8bGk+Tm90ZSB0 aGF0IHRoZSB2YWx1ZSBpbiB0aGUgdGV4dCBhcmVhIG1hdGNoZXMgd2hhdCB5b3UgZW50ZXJlZCBi ZWZvcmUgc3VibWl0dGluZyB0aGUgZm9ybSwgdGhpcyBpcyBjb3JyZWN0LjwvbGk+CisgIDxsaT5O b3cgY2xpY2sgdGhlIHJlc2V0IGJ1dHRvbiBmb3IgdGhlIGZvcm0uCisgIDxsaT5UaGUgdGV4dCBp biB0aGUgJmx0O3RleHRhcmVhJmd0OyBzaG91bGQgbm93IG1hdGNoICcxMjMnLCB0aGUgZGVmYXVs dCB0ZXh0IGZvciB0aGUgJmx0O3RleHRhcmVhJmd0Oy48L2xpPgorPC91bD4KKworPGlmcmFtZSBz cmM9InJlc291cmNlcy90ZXh0YXJlYS1mb3JtLWJhY2stb24tc3VibWl0Lmh0bWwiIHdpZHRoPSI4 MDAiIGhlaWdodD0iMjAwIiBpZD0iZnJhbWUiPjwvaWZyYW1lPgorCis8L2JvZHk+Cis8L2h0bWw+ CgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBXZWJDb3JlL21hbnVhbC10ZXN0cy90ZXh0YXJlYS1yZXNl dC1kZWZhdWx0LXZhbHVlLmh0bWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBZGRlZDogc3ZuOmVvbC1zdHlsZQogICAr IG5hdGl2ZQoKSW5kZXg6IFdlYkNvcmUvbWFudWFsLXRlc3RzL3Jlc291cmNlcy90ZXh0YXJlYS1m b3JtLWJhY2stb24tc3VibWl0Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9tYW51YWwtdGVz dHMvcmVzb3VyY2VzL3RleHRhcmVhLWZvcm0tYmFjay1vbi1zdWJtaXQuaHRtbAkocmV2aXNpb24g MCkKKysrIFdlYkNvcmUvbWFudWFsLXRlc3RzL3Jlc291cmNlcy90ZXh0YXJlYS1mb3JtLWJhY2st b24tc3VibWl0Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTYgQEAKKzxodG1sPgorPGhl YWQ+Cis8dGl0bGU+Rm9ybSB3aXRoIGEgdGV4dGFyZWEgdGhhdCBnb2VzIGJhY2sgb24gc3VibWl0 PC90aXRsZT4KKzwvaGVhZD4KKzxib2R5PgorPGZvcm0gaWQ9ImZvcm0iIG1ldGhvZD0iZ2V0IiBh Y3Rpb249ImRhdGE6dGV4dC9odG1sLDxib2R5IG9ubG9hZD0naGlzdG9yeS5iYWNrKCknPjwvYm9k eT4iPgorICA8cD4KKyAgPHRleHRhcmVhIG5hbWU9InRleHQiIHJvd3M9IjMiIGNvbHM9IjEwIiBp ZD0idGV4dGFyZWEiPjEyMzwvdGV4dGFyZWE+PGJyIC8+CisgIDxiciAvPgorICA8aW5wdXQgdHlw ZT0ic3VibWl0IiAvPgorICA8aW5wdXQgdHlwZT0icmVzZXQiIC8+CisgIDwvcD4KKzwvZm9ybT4K KworPC9ib2R5PgorPC9odG1sPgoKUHJvcGVydHkgY2hhbmdlcyBvbjogV2ViQ29yZS9tYW51YWwt dGVzdHMvcmVzb3VyY2VzL3RleHRhcmVhLWZvcm0tYmFjay1vbi1zdWJtaXQuaHRtbApfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkFkZGVkOiBzdm46ZW9sLXN0eWxlCiAgICsgbmF0aXZlCgo=