31535 2009-11-16 02:02:34 -0800 Re-factor workqueue_unittest to allow for more than one test 2009-11-16 03:02:58 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 31534 1 eric webkit-unassigned abarth levin oldest_to_newest 163897 0 eric 2009-11-16 02:02:34 -0800 Re-factor workqueue_unittest to allow for more than one test 163898 1 43279 eric 2009-11-16 02:04:40 -0800 Created attachment 43279 2009-11-16 Eric Seidel <eric@webkit.org> 163900 2 43279 abarth 2009-11-16 02:06:50 -0800 Comment on attachment 43279 2009-11-16 Eric Seidel <eric@webkit.org> Thanks! 163916 3 43279 eric 2009-11-16 03:02:51 -0800 Comment on attachment 43279 2009-11-16 Eric Seidel <eric@webkit.org> Clearing flags on attachment: 43279 Committed r51023: <http://trac.webkit.org/changeset/51023> 163917 4 eric 2009-11-16 03:02:58 -0800 All reviewed patches have been landed. Closing bug. 43279 2009-11-16 02:04:40 -0800 2009-11-16 03:02:50 -0800 2009-11-16 Eric Seidel <eric@webkit.org> bug-31535-20091116020438.patch text/plain 4095 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBmZTk0Yzc5Li42MDEwNWU1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMTEt MTYgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlLWZhY3RvciB3b3JrcXVldWVfdW5pdHRlc3Qg dG8gYWxsb3cgZm9yIG1vcmUgdGhhbiBvbmUgdGVzdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNTM1CisKKyAgICAgICAgKiBTY3JpcHRzL21vZHVs ZXMvd29ya3F1ZXVlX3VuaXR0ZXN0LnB5OgorCiAyMDA5LTExLTE2ICBBZGFtIEJhcnRoICA8YWJh cnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYg LS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvd29ya3F1ZXVlX3VuaXR0ZXN0LnB5 IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL3dvcmtxdWV1ZV91bml0dGVzdC5weQppbmRl eCBmM2ZhMzEwLi5lZDdkMGIyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVs ZXMvd29ya3F1ZXVlX3VuaXR0ZXN0LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxl cy93b3JrcXVldWVfdW5pdHRlc3QucHkKQEAgLTM0LDQwICszNCwxOSBAQCBpbXBvcnQgdW5pdHRl c3QKIAogZnJvbSBtb2R1bGVzLndvcmtxdWV1ZSBpbXBvcnQgV29ya1F1ZXVlLCBXb3JrUXVldWVE ZWxlZ2F0ZQogCi1jbGFzcyBXb3JrUXVldWVUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlLCBXb3JrUXVl dWVEZWxlZ2F0ZSk6Ci0gICAgZGVmIHRlc3RfdHJpdmlhbChzZWxmKToKLSAgICAgICAgc2VsZi5z ZXRfdXAoKQotICAgICAgICB3b3JrX3F1ZXVlID0gV29ya1F1ZXVlKHNlbGYpCi0gICAgICAgIHdv cmtfcXVldWUucnVuKCkKLSAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoc2VsZi5jYWxsYmFja3Ms IFsKLSAgICAgICAgICAgICdxdWV1ZV9sb2dfcGF0aCcsCi0gICAgICAgICAgICAnc3RhdHVzX2hv c3QnLAotICAgICAgICAgICAgJ2JlZ2luX3dvcmtfcXVldWUnLAotICAgICAgICAgICAgJ3Nob3Vs ZF9jb250aW51ZV93b3JrX3F1ZXVlJywKLSAgICAgICAgICAgICduZXh0X3dvcmtfaXRlbScsCi0g ICAgICAgICAgICAnc2hvdWxkX3Byb2NlZWRfd2l0aF93b3JrX2l0ZW0nLAotICAgICAgICAgICAg J3dvcmtfbG9nc19kaXJlY3RvcnknLAotICAgICAgICAgICAgJ3Byb2Nlc3Nfd29ya19pdGVtJywK LSAgICAgICAgICAgICdzaG91bGRfY29udGludWVfd29ya19xdWV1ZSddKQotICAgICAgICBzZWxm LmNsZWFuX3VwKCkKLQotICAgIGRlZiBzZXRfdXAoc2VsZik6CitjbGFzcyBMb2dnaW5nRGVsZWdh dGUoV29ya1F1ZXVlRGVsZWdhdGUpOgorICAgIGRlZiBfX2luaXRfXyhzZWxmLCB0ZXN0KToKKyAg ICAgICAgc2VsZi50ZXN0ID0gdGVzdAogICAgICAgICBzZWxmLmNhbGxiYWNrcyA9IFtdCiAgICAg ICAgIHNlbGYucnVuX2JlZm9yZSA9IEZhbHNlCi0gICAgICAgIHNlbGYudGVtcF9kaXIgPSB0ZW1w ZmlsZS5ta2R0ZW1wKHN1ZmZpeD0id29ya19xdWV1ZV90ZXN0X2xvZ3MiKQotCi0gICAgZGVmIGNs ZWFuX3VwKHNlbGYpOgotICAgICAgICBvcy5wYXRoLmV4aXN0cyhzZWxmLnF1ZXVlX2xvZ19wYXRo KCkpCi0gICAgICAgIG9zLnBhdGguZXhpc3RzKG9zLnBhdGguam9pbihzZWxmLndvcmtfbG9nc19k aXJlY3RvcnkoKSwgIjQyLmxvZyIpKQotICAgICAgICBzaHV0aWwucm10cmVlKHNlbGYudGVtcF9k aXIpCiAKICAgICBkZWYgcXVldWVfbG9nX3BhdGgoc2VsZik6CiAgICAgICAgIHNlbGYuY2FsbGJh Y2tzLmFwcGVuZCgicXVldWVfbG9nX3BhdGgiKQotICAgICAgICByZXR1cm4gb3MucGF0aC5qb2lu KHNlbGYudGVtcF9kaXIsICJxdWV1ZV9sb2dfcGF0aCIpCisgICAgICAgIHJldHVybiBvcy5wYXRo LmpvaW4oc2VsZi50ZXN0LnRlbXBfZGlyLCAicXVldWVfbG9nX3BhdGgiKQogCiAgICAgZGVmIHdv cmtfbG9nc19kaXJlY3Rvcnkoc2VsZik6CiAgICAgICAgIHNlbGYuY2FsbGJhY2tzLmFwcGVuZCgi d29ya19sb2dzX2RpcmVjdG9yeSIpCi0gICAgICAgIHJldHVybiBvcy5wYXRoLmpvaW4oc2VsZi50 ZW1wX2RpciwgIndvcmtfbG9nX3BhdGgiKQorICAgICAgICByZXR1cm4gb3MucGF0aC5qb2luKHNl bGYudGVzdC50ZW1wX2RpciwgIndvcmtfbG9nX3BhdGgiKQogCiAgICAgZGVmIHN0YXR1c19ob3N0 KHNlbGYpOgogICAgICAgICBzZWxmLmNhbGxiYWNrcy5hcHBlbmQoInN0YXR1c19ob3N0IikKQEAg LTg5LDE2ICs2OCw0MCBAQCBjbGFzcyBXb3JrUXVldWVUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlLCBX b3JrUXVldWVEZWxlZ2F0ZSk6CiAKICAgICBkZWYgc2hvdWxkX3Byb2NlZWRfd2l0aF93b3JrX2l0 ZW0oc2VsZiwgd29ya19pdGVtKToKICAgICAgICAgc2VsZi5jYWxsYmFja3MuYXBwZW5kKCJzaG91 bGRfcHJvY2VlZF93aXRoX3dvcmtfaXRlbSIpCi0gICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKHdv cmtfaXRlbSwgIndvcmtfaXRlbSIpCisgICAgICAgIHNlbGYudGVzdC5hc3NlcnRFcXVhbHMod29y a19pdGVtLCAid29ya19pdGVtIikKICAgICAgICAgcmV0dXJuIChUcnVlLCAid2FpdGluZ19tZXNz YWdlIiwgNDIpCiAKICAgICBkZWYgcHJvY2Vzc193b3JrX2l0ZW0oc2VsZiwgd29ya19pdGVtKToK ICAgICAgICAgc2VsZi5jYWxsYmFja3MuYXBwZW5kKCJwcm9jZXNzX3dvcmtfaXRlbSIpCi0gICAg ICAgIHNlbGYuYXNzZXJ0RXF1YWxzKHdvcmtfaXRlbSwgIndvcmtfaXRlbSIpCisgICAgICAgIHNl bGYudGVzdC5hc3NlcnRFcXVhbHMod29ya19pdGVtLCAid29ya19pdGVtIikKIAogICAgIGRlZiBo YW5kbGVfdW5leHBlY3RlZF9lcnJvcihzZWxmLCB3b3JrX2l0ZW0sIG1lc3NhZ2UpOgogICAgICAg ICBzZWxmLmNhbGxiYWNrcy5hcHBlbmQoImhhbmRsZV91bmV4cGVjdGVkX2Vycm9yIikKLSAgICAg ICAgc2VsZi5hc3NlcnRFcXVhbHMod29ya19pdGVtLCAid29ya19pdGVtIikKKyAgICAgICAgc2Vs Zi50ZXN0LmFzc2VydEVxdWFscyh3b3JrX2l0ZW0sICJ3b3JrX2l0ZW0iKQorCitjbGFzcyBXb3Jr UXVldWVUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKKyAgICBkZWYgdGVzdF90cml2aWFsKHNlbGYp OgorICAgICAgICBkZWxlZ2F0ZSA9IExvZ2dpbmdEZWxlZ2F0ZShzZWxmKQorICAgICAgICB3b3Jr X3F1ZXVlID0gV29ya1F1ZXVlKGRlbGVnYXRlKQorICAgICAgICB3b3JrX3F1ZXVlLnJ1bigpCisg ICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKGRlbGVnYXRlLmNhbGxiYWNrcywgWworICAgICAgICAg ICAgJ3F1ZXVlX2xvZ19wYXRoJywKKyAgICAgICAgICAgICdzdGF0dXNfaG9zdCcsCisgICAgICAg ICAgICAnYmVnaW5fd29ya19xdWV1ZScsCisgICAgICAgICAgICAnc2hvdWxkX2NvbnRpbnVlX3dv cmtfcXVldWUnLAorICAgICAgICAgICAgJ25leHRfd29ya19pdGVtJywKKyAgICAgICAgICAgICdz aG91bGRfcHJvY2VlZF93aXRoX3dvcmtfaXRlbScsCisgICAgICAgICAgICAnd29ya19sb2dzX2Rp cmVjdG9yeScsCisgICAgICAgICAgICAncHJvY2Vzc193b3JrX2l0ZW0nLAorICAgICAgICAgICAg J3Nob3VsZF9jb250aW51ZV93b3JrX3F1ZXVlJ10pCisgICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZShv cy5wYXRoLmV4aXN0cyhkZWxlZ2F0ZS5xdWV1ZV9sb2dfcGF0aCgpKSkKKyAgICAgICAgc2VsZi5h c3NlcnRUcnVlKG9zLnBhdGguZXhpc3RzKG9zLnBhdGguam9pbihkZWxlZ2F0ZS53b3JrX2xvZ3Nf ZGlyZWN0b3J5KCksICI0Mi5sb2ciKSkpCisKKyAgICBkZWYgc2V0VXAoc2VsZik6CisgICAgICAg IHNlbGYudGVtcF9kaXIgPSB0ZW1wZmlsZS5ta2R0ZW1wKHN1ZmZpeD0id29ya19xdWV1ZV90ZXN0 X2xvZ3MiKQorCisgICAgZGVmIHRlYXJEb3duKHNlbGYpOgorICAgICAgICBzaHV0aWwucm10cmVl KHNlbGYudGVtcF9kaXIpCiAKIAogaWYgX19uYW1lX18gPT0gJ19fbWFpbl9fJzoK