31532 2009-11-16 01:13:59 -0800 land-patches needs to be re-factored into smaller chunks 2009-11-16 03:00:43 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth oldest_to_newest 163885 0 eric 2009-11-16 01:13:59 -0800 land-patches needs to be re-factored into smaller chunks This is in preparation for adding a land-attachment command. 163886 1 43276 eric 2009-11-16 01:16:06 -0800 Created attachment 43276 Patch 163888 2 43276 abarth 2009-11-16 01:21:59 -0800 Comment on attachment 43276 Patch This looks fine. 163914 3 43276 eric 2009-11-16 02:51:15 -0800 Comment on attachment 43276 Patch Clearing flags on attachment: 43276 Committed r51021: <http://trac.webkit.org/changeset/51021> 163915 4 eric 2009-11-16 03:00:43 -0800 Committed r51022: <http://trac.webkit.org/changeset/51022> 43276 2009-11-16 01:16:06 -0800 2009-11-16 02:51:15 -0800 Patch bug-31532-20091116011604.patch text/plain 4417 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA0Y2M4MjkxLi4xNjBmMjdkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMDktMTEt MTYgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGxhbmQtcGF0Y2hlcyBuZWVkcyB0byBiZSByZS1m YWN0b3JlZCBpbnRvIHNtYWxsZXIgY2h1bmtzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMTUzMgorCisgICAgICAgIFRoZSBuZXh0IHBhdGNoIHdpbGwg bW92ZSB0aGVzZSBtZXRob2RzIGludG8gV2ViS2l0TGFuZGluZ1NjcmlwdHMuCisKKyAgICAgICAg KiBTY3JpcHRzL2J1Z3ppbGxhLXRvb2w6CisgICAgICAgICAtIFNwbGl0IG91dCBfbGFuZF9wYXRj aCBhbmQgX2Nsb3NlX2J1Z19pZl9ub19hY3RpdmVfcGF0Y2hlcy4KKworMjAwOS0xMS0xNiAgRXJp YyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBC YXJ0aC4KIAogICAgICAgICBidWd6aWxsYS10b29sIGxhbmQtZGlmZiBzaG91bGQga25vdyBob3cg dG8gcGFyc2UgYnVnIGlkcyBvdXQgb2YgQ2hhbmdlTG9ncwpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9v bHMvU2NyaXB0cy9idWd6aWxsYS10b29sIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWd6aWxsYS10 b29sCmluZGV4IDY4YjI0NGMuLjc1MzhhNWYgMTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL1Njcmlw dHMvYnVnemlsbGEtdG9vbAorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL2J1Z3ppbGxhLXRvb2wK QEAgLTM4MiwyMSArMzgyLDMwIEBAIGNsYXNzIExhbmRQYXRjaGVzRnJvbUJ1Z3MoQ29tbWFuZCk6 CiAgICAgICAgIGV4aXQoMikgIyBFeGl0IDIgaW5zdGVkIG9mIDEgdG8gaW5kaWNhdGUgdG8gdGhl IGNvbW1pdC1xdWV1ZSB0byBpbmRpY2F0ZSB3ZSBoYW5kbGVkIHRoZSBlcnJvciwgYW5kIHRoYXQg dGhlIHF1ZXVlIHNob3VsZCBrZWVwIGxvb3BpbmcuCiAKICAgICBAY2xhc3NtZXRob2QKLSAgICBk ZWYgbGFuZF9wYXRjaGVzKGNscywgYnVnX2lkLCBwYXRjaGVzLCBvcHRpb25zLCB0b29sKToKKyAg ICBkZWYgX2Nsb3NlX2J1Z19pZl9ub19hY3RpdmVfcGF0Y2hlcyhjbHMsIHBhdGNoLCBvcHRpb24s IHRvb2wpOgorICAgICAgICAjIFRoaXMgc2hvdWxkIGNoZWNrIHRvIG1ha2Ugc3VyZSB0aGVyZSBh cmUgbm8gcj8gb3IgcisgcGF0Y2hlcyBvbiB0aGUgYnVnIGJlZm9yZSBjbG9zaW5nLgorICAgICAg ICAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODIzMAorICAgICAg ICB0b29sLmJ1Z3MuY2xvc2VfYnVnX2FzX2ZpeGVkKGJ1Z19pZCwgIkFsbCByZXZpZXdlZCBwYXRj aGVzIGhhdmUgYmVlbiBsYW5kZWQuICBDbG9zaW5nIGJ1Zy4iKQorCisgICAgQGNsYXNzbWV0aG9k CisgICAgZGVmIF9sYW5kX3BhdGNoKGNscywgcGF0Y2gsIG9wdGlvbnMsIHRvb2wpOgorICAgICAg ICB0b29sLnNjbSgpLnVwZGF0ZV93ZWJraXQoKSAjIFVwZGF0ZSBiZWZvcmUgZXZlcnkgcGF0Y2gg aW4gY2FzZSB0aGUgdHJlZSBoYXMgY2hhbmdlZAorICAgICAgICBsb2coIkFwcGx5aW5nICVzIGZy b20gYnVnICVzLiIgJSAocGF0Y2hbJ2lkJ10sIHBhdGNoWydidWdfaWQnXSkpCisgICAgICAgIHRv b2wuc2NtKCkuYXBwbHlfcGF0Y2gocGF0Y2gsIGZvcmNlPW9wdGlvbnMuY29tbWl0X3F1ZXVlKQor CisgICAgICAgICMgTWFrZSBzdXJlIHRoZSB0cmVlIGlzIHN0aWxsIGdyZWVuIGFmdGVyIHVwZGF0 aW5nLCBiZWZvcmUgYnVpbGRpbmcgdGhpcyBwYXRjaC4KKyAgICAgICAgIyBUaGUgZmlyc3QgcGF0 Y2ggZW5kcyB1cCBjaGVja2luZyB0cmVlIHN0YXR1cyB0d2ljZSwgYnV0IHRoYXQncyBPSy4KKyAg ICAgICAgV2ViS2l0TGFuZGluZ1NjcmlwdHMuZW5zdXJlX2J1aWxkZXJzX2FyZV9ncmVlbih0b29s LmJ1aWxkYm90LCBvcHRpb25zKQorICAgICAgICBjb21tZW50X3RleHQgPSBXZWJLaXRMYW5kaW5n U2NyaXB0cy5idWlsZF9hbmRfY29tbWl0KHRvb2wuc2NtKCksIG9wdGlvbnMpCisgICAgICAgIHRv b2wuYnVncy5jbGVhcl9hdHRhY2htZW50X2ZsYWdzKHBhdGNoWydpZCddLCBjb21tZW50X3RleHQp CisKKyAgICBAY2xhc3NtZXRob2QKKyAgICBkZWYgbGFuZF9wYXRjaGVzKGNscywgcGF0Y2hlcywg b3B0aW9ucywgdG9vbCk6CiAgICAgICAgIHRyeToKLSAgICAgICAgICAgIGNvbW1lbnRfdGV4dCA9 ICIiCiAgICAgICAgICAgICBmb3IgcGF0Y2ggaW4gcGF0Y2hlczoKLSAgICAgICAgICAgICAgICB0 b29sLnNjbSgpLnVwZGF0ZV93ZWJraXQoKSAjIFVwZGF0ZSBiZWZvcmUgZXZlcnkgcGF0Y2ggaW4g Y2FzZSB0aGUgdHJlZSBoYXMgY2hhbmdlZAotICAgICAgICAgICAgICAgIGxvZygiQXBwbHlpbmcg JXMgZnJvbSBidWcgJXMuIiAlIChwYXRjaFsnaWQnXSwgYnVnX2lkKSkKLSAgICAgICAgICAgICAg ICB0b29sLnNjbSgpLmFwcGx5X3BhdGNoKHBhdGNoLCBmb3JjZT1vcHRpb25zLmNvbW1pdF9xdWV1 ZSkKLSAgICAgICAgICAgICAgICAjIE1ha2Ugc3VyZSB0aGUgdHJlZSBpcyBzdGlsbCBncmVlbiBh ZnRlciB1cGRhdGluZywgYmVmb3JlIGJ1aWxkaW5nIHRoaXMgcGF0Y2guCi0gICAgICAgICAgICAg ICAgIyBUaGUgZmlyc3QgcGF0Y2ggZW5kcyB1cCBjaGVja2luZyB0cmVlIHN0YXR1cyB0d2ljZSwg YnV0IHRoYXQncyBPSy4KLSAgICAgICAgICAgICAgICBXZWJLaXRMYW5kaW5nU2NyaXB0cy5lbnN1 cmVfYnVpbGRlcnNfYXJlX2dyZWVuKHRvb2wuYnVpbGRib3QsIG9wdGlvbnMpCi0gICAgICAgICAg ICAgICAgY29tbWVudF90ZXh0ID0gV2ViS2l0TGFuZGluZ1NjcmlwdHMuYnVpbGRfYW5kX2NvbW1p dCh0b29sLnNjbSgpLCBvcHRpb25zKQotICAgICAgICAgICAgICAgIHRvb2wuYnVncy5jbGVhcl9h dHRhY2htZW50X2ZsYWdzKHBhdGNoWydpZCddLCBjb21tZW50X3RleHQpCi0KLSAgICAgICAgICAg IGlmIG9wdGlvbnMuY2xvc2VfYnVnOgotICAgICAgICAgICAgICAgIHRvb2wuYnVncy5jbG9zZV9i dWdfYXNfZml4ZWQoYnVnX2lkLCAiQWxsIHJldmlld2VkIHBhdGNoZXMgaGF2ZSBiZWVuIGxhbmRl ZC4gIENsb3NpbmcgYnVnLiIpCisgICAgICAgICAgICAgICAgY2xzLl9sYW5kX3BhdGNoKHBhdGNo LCBvcHRpb25zLCB0b29sKQorICAgICAgICAgICAgaWYgb3B0aW9ucy5jbG9zZV9idWcgYW5kIHBh dGNoZXM6CisgICAgICAgICAgICAgICAgY2xzLl9jbG9zZV9idWdfaWZfbm9fYWN0aXZlX3BhdGNo ZXMocGF0Y2hlc1swXVsnYnVnX2lkJ10pCiAgICAgICAgIGV4Y2VwdCBDaGVja291dE5lZWRzVXBk YXRlLCBlOgogICAgICAgICAgICAgbG9nKCJDb21taXQgZmFpbGVkIGJlY2F1c2UgdGhlIGNoZWNr b3V0IGlzIG91dCBvZiBkYXRlLiAgUGxlYXNlIHVwZGF0ZSBhbmQgdHJ5IGFnYWluLiIpCiAgICAg ICAgICAgICBsb2coIllvdSBjYW4gcGFzcyAtLW5vLWJ1aWxkIHRvIHNraXAgYnVpbGRpbmcvdGVz dGluZyBhZnRlciB1cGRhdGUgaWYgeW91IGJlbGlldmUgdGhlIG5ldyBjb21taXRzIGRpZCBub3Qg YWZmZWN0IHRoZSByZXN1bHRzLiIpCkBAIC00MzEsMTUgKzQ0MCwxMyBAQCBjbGFzcyBMYW5kUGF0 Y2hlc0Zyb21CdWdzKENvbW1hbmQpOgogICAgICAgICBpZiBub3QgbGVuKGFyZ3MpOgogICAgICAg ICAgICAgZXJyb3IoImJ1Zy1pZChzKSByZXF1aXJlZCIpCiAKLSAgICAgICAgIyBDaGVjayB0aGUg dHJlZSBzdGF0dXMgaGVyZSBzbyB3ZSBjYW4gZmFpbCBlYXJseQorICAgICAgICAjIENoZWNrIHRo ZSB0cmVlIHN0YXR1cyBmaXJzdCBzbyB3ZSBjYW4gZmFpbCBlYXJseS4KICAgICAgICAgV2ViS2l0 TGFuZGluZ1NjcmlwdHMuZW5zdXJlX2J1aWxkZXJzX2FyZV9ncmVlbih0b29sLmJ1aWxkYm90LCBv cHRpb25zKQotCiAgICAgICAgIGJ1Z3NfdG9fcGF0Y2hlcyA9IHNlbGYuX2ZldGNoX2xpc3Rfb2Zf cGF0Y2hlc190b19sYW5kKG9wdGlvbnMsIGFyZ3MsIHRvb2wpCiAKICAgICAgICAgV2ViS2l0TGFu ZGluZ1NjcmlwdHMucHJlcGFyZV9jbGVhbl93b3JraW5nX2RpcmVjdG9yeSh0b29sLnNjbSgpLCBv cHRpb25zKQotCiAgICAgICAgIGZvciBidWdfaWQgaW4gYnVnc190b19wYXRjaGVzLmtleXMoKToK LSAgICAgICAgICAgIHNlbGYubGFuZF9wYXRjaGVzKGJ1Z19pZCwgYnVnc190b19wYXRjaGVzW2J1 Z19pZF0sIG9wdGlvbnMsIHRvb2wpCisgICAgICAgICAgICBzZWxmLmxhbmRfcGF0Y2hlcyhidWdz X3RvX3BhdGNoZXNbYnVnX2lkXSwgb3B0aW9ucywgdG9vbCkKIAogCiBjbGFzcyBDb21taXRNZXNz YWdlRm9yQ3VycmVudERpZmYoQ29tbWFuZCk6Cg==