<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>31527</bug_id>
          
          <creation_ts>2009-11-15 18:58:53 -0800</creation_ts>
          <short_desc>QWebPageClient.h needs in some cases QCursor, but it does not include it</short_desc>
          <delta_ts>2026-05-25 12:14:26 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Carol Szabo">carol</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>163834</commentid>
    <comment_count>0</comment_count>
    <who name="Carol Szabo">carol</who>
    <bug_when>2009-11-15 18:58:53 -0800</bug_when>
    <thetext>WebKit Style specifies that a header file should include all header files it relies on except for config.h
QWebPageClient.h does not adhere to this standard in regards to QCursor
Patch coming soon.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163835</commentid>
    <comment_count>1</comment_count>
      <attachid>43261</attachid>
    <who name="Carol Szabo">carol</who>
    <bug_when>2009-11-15 19:22:21 -0800</bug_when>
    <thetext>Created attachment 43261
Proposed Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>164315</commentid>
    <comment_count>2</comment_count>
      <attachid>43261</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-11-17 12:45:39 -0800</bug_when>
    <thetext>Comment on attachment 43261
Proposed Patch

Rejecting patch 43261 from commit-queue.

Failed to run &quot;[&apos;WebKitTools/Scripts/run-webkit-tests&apos;, &apos;--no-launch-safari&apos;, &apos;--quiet&apos;, &apos;--exit-after-n-failures=1&apos;]&quot; exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11628 test cases.
inspector/console-dir.html -&gt; crashed

Exiting early after 1 failures. 9322 tests run.
367.50s total testing time

9321 test cases (99%) succeeded
1 test case (&lt;1%) crashed
5 test cases (&lt;1%) had stderr output</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>164321</commentid>
    <comment_count>3</comment_count>
      <attachid>43261</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-11-17 13:05:08 -0800</bug_when>
    <thetext>Comment on attachment 43261
Proposed Patch

Sigh.  Bug 31461.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>164722</commentid>
    <comment_count>4</comment_count>
      <attachid>43261</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-11-18 14:33:54 -0800</bug_when>
    <thetext>Comment on attachment 43261
Proposed Patch

Clearing flags on attachment: 43261

Committed r51137: &lt;http://trac.webkit.org/changeset/51137&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>164723</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-11-18 14:33:59 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2213905</commentid>
    <comment_count>6</comment_count>
    <who name="Mike Wyrzykowski">mwyrzykowski</who>
    <bug_when>2026-05-25 12:14:26 -0700</bug_when>
    <thetext>&lt;rdar://problem/177664498&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>43261</attachid>
            <date>2009-11-15 19:22:21 -0800</date>
            <delta_ts>2009-11-18 14:33:54 -0800</delta_ts>
            <desc>Proposed Patch</desc>
            <filename>patchFor31527-1.patch</filename>
            <type>text/plain</type>
            <size>1102</size>
            <attacher name="Carol Szabo">carol</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA1MTAwNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTYgQEAKKzIwMDktMTEtMTUgIENhcm9sIFN6YWJvICA8Y2Fyb2wuc3phYm9Abm9r
aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IFtRdF0gUVdlYlBhZ2VDbGllbnQuaCBuZWVkcyBpbiBzb21lIGNhc2VzIFFDdXJzb3IsIGJ1dCBp
dCBkb2VzIG5vdAorICAgICAgICBpbmNsdWRlIGl0IAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE1MjcKKworICAgICAgICBObyBuZXcgdGVzdHMgYXMg
dGhpcyBpcyBqdXN0IGEgY29kaW5nIHN0eWxlIGZpeCB0aGF0IGFmZmVjdHMgdGhlIAorICAgICAg
ICBidWlsZCBvZiBzb21lIG5vdCB5ZXQgc3VibWl0dGVkIHBhdGNoZXMgKGkuZS4gZm9yIGJ1ZyAz
MDE3MykuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9RV2ViUGFnZUNsaWVudC5oOgorCiAyMDA5
LTExLTE0ICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAgICAg
UmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL3F0L1FXZWJQ
YWdlQ2xpZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9xdC9RV2ViUGFnZUNs
aWVudC5oCShyZXZpc2lvbiA1MDc4MykKKysrIFdlYkNvcmUvcGxhdGZvcm0vcXQvUVdlYlBhZ2VD
bGllbnQuaAkod29ya2luZyBjb3B5KQpAQCAtMjYsNiArMjYsOSBAQAogI2lmbmRlZiBRV2ViUGFn
ZUNsaWVudF9oCiAjZGVmaW5lIFFXZWJQYWdlQ2xpZW50X2gKIAorI2lmbmRlZiBRVF9OT19DVVJT
T1IKKyNpbmNsdWRlIDxRQ3Vyc29yPjsKKyNlbmRpZgogI2luY2x1ZGUgPFFSZWN0PgogCiBjbGFz
cyBRV2ViUGFnZUNsaWVudCB7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>