<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>315200</bug_id>
          
          <creation_ts>2026-05-20 08:55:42 -0700</creation_ts>
          <short_desc>[WPE][GTK] Rationalize Vulkan types and their base wrapper templates</short_desc>
          <delta_ts>2026-05-21 00:05:13 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>312990</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Adrian Perez">aperez</reporter>
          <assigned_to name="Adrian Perez">aperez</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2212548</commentid>
    <comment_count>0</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2026-05-20 08:55:42 -0700</bug_when>
    <thetext>Currently we have the BaseStruct&lt;T&gt; and Structure&lt;T, C&gt; templates defined directly in VulkanTypes.h; but:

* Structure&lt;T, C&gt; does not need to inherit from BaseStruct&lt;T&gt;, because in reality Vulkan
  handles and structures are used differently. Inheritance for convenience of (very little)
  reuse here is not a good idea because we cannot pass a Structure where a Handle is expected.

  - While at it, these should be called “Structure” and “Handle”.

* Handles may be owned by other objects in some cases (for example VkPhysicalDevice) and
  instead of making each class override methods is not great.

  - Instead, we should be defining a different type for a handle that is “borrowed” and
    owned by some other object. This kind of handle would be copyable.

* It would be nicer to have separate VulkanHandle.h / VulkanStructure.h files for these types.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2212562</commentid>
    <comment_count>1</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2026-05-20 09:12:08 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/65296</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2212837</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2026-05-21 00:04:23 -0700</bug_when>
    <thetext>Committed 313650@main (f5514504e1ab): &lt;https://commits.webkit.org/313650@main&gt;

Reviewed commits have been landed. Closing PR #65296 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2212838</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2026-05-21 00:05:13 -0700</bug_when>
    <thetext>&lt;rdar://problem/177596999&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>