31509 2009-11-14 15:06:03 -0800 [Qt] Implement error pages handling support to DRT. 2009-11-16 08:17:32 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt P2 Normal --- 30573 1 tonikitoo tonikitoo oldest_to_newest 163677 0 tonikitoo 2009-11-14 15:06:03 -0800 It turns out that none of the current DRT implementations (mac, win, gtk and qt) support "error pages" when an unsuccessful load happens. IMO, such feature could make DRTs to act more like a real browser, and then is a good thing to have, and give tests more accurate. I got dumbs-up on IRC for moving forward on that implementation (see below), and I am making it for the QT DRT in advance. (...) <tonikitoo> (well, darin showed no objection based on the lack of a better suggestion for my problem) <tonikitoo> my plan: <tonikitoo> 1) make sure my FrameLoader patch does not break current gtk, mac and win tests. <tonikitoo> 2) put my specific test in other DRT Skipped list for now (mac, gtk and win). <tonikitoo> 3) and file follow up bugs to these ports to implement support for error pages in their DRT's <tonikitoo> ap,aroben: what do you think ? <aroben> tonikitoo: that sounds pretty good to me <ap> tonikitoo: you don't have access to Mac or Windows, do you? it would be nice to implement this for at least one platform where Safari works <ap> tonikitoo: otherwise, sounds good (...) <ap> tonikitoo: I'm not sure why you want this to be configurable. isn't it always good for DRT to show error pages? <ap> tonikitoo: making DRT behave more like a real browser is certainly good (...) patch coming ... 163678 1 43231 tonikitoo 2009-11-14 15:11:15 -0800 Created attachment 43231 (landed in r51037) patch 0.1 patch implements error page handling support to Qt's DRT, when an unsuccessful load happends. feature is OFF by default (so same behavior as current in all DRT), but can be enabled by called 'layoutTestController.handleErrorPages();' from layout test JS sourcecode. please comments are welcome about namings here 163745 2 43231 kenneth 2009-11-15 07:25:34 -0800 Comment on attachment 43231 (landed in r51037) patch 0.1 > + QWebPage::ErrorPageExtensionReturn* errorPage = static_cast<QWebPage::ErrorPageExtensionReturn*>(output); > + > + errorPage->content = QString("data:text/html,<body/>").toUtf8(); Wouldn't it make sense to actually print the error code? 163754 3 tonikitoo 2009-11-15 09:08:48 -0800 (In reply to comment #2) > (From update of attachment 43231 [details]) > > > + QWebPage::ErrorPageExtensionReturn* errorPage = static_cast<QWebPage::ErrorPageExtensionReturn*>(output); > > + > > + errorPage->content = QString("data:text/html,<body/>").toUtf8(); > > Wouldn't it make sense to actually print the error code? I think we could although error codes can be platform dependent too. we can improve it later, also. thx kenneth. 163989 4 tonikitoo 2009-11-16 07:44:33 -0800 r51037 163998 5 tonikitoo 2009-11-16 08:17:32 -0800 > <tonikitoo> 3) and file follow up bugs to these ports to implement support for > error pages in their DRT's > <tonikitoo> ap,aroben: what do you think ? > <aroben> tonikitoo: that sounds pretty good to me > (...) FYI, filed follow up bugs for win, gtk and mac's implementations of error pages support into their DRTs: * MAC -> https://bugs.webkit.org/show_bug.cgi?id=31555 * GTK -> https://bugs.webkit.org/show_bug.cgi?id=31556 * WIN -> https://bugs.webkit.org/show_bug.cgi?id=31557 43231 2009-11-14 15:11:15 -0800 2009-11-16 07:47:07 -0800 (landed in r51037) patch 0.1 0001--Qt-Implement-load-error-pages-support-for-Qt-s-DRT.patch text/plain 6304 tonikitoo RnJvbSBiMDBhOGRjNDcwN2ZiN2FhNTIyZWExZDVhZjQ0N2QyNjVmYzdkNjI5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogU2F0LCAxNCBOb3YgMjAwOSAxNjowMjo0NiAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFtR dF0gSW1wbGVtZW50IGxvYWQgZXJyb3IgcGFnZXMgc3VwcG9ydCBmb3IgUXQncyBEUlQuCiBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE1MDkKClJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKRm9yIG5vdywgaXQgd2lsbCBub3QgYmUgYSBkZWZhdWx0IGZlYXR1cmUs IGFuZCBsYXlvdXQgdGVzdHMKdGhhdCB3YW50IHRvIG1ha2UgdXNlIG9mIHRoaXMgaGF2ZSB0byBl eHBsaWNpdGlseSBjYWxsCidoYW5kbGVFcnJvclBhZ2VzKCk7JyBmb3IgdGhlIHRlc3Qgc291cmNl LgoKQW55IG9mIHRoZSBvdGhlciBEdW1wUmVuZGVyVHJlZSdzIChtYWMsIHdpbiBhbmQgZ3RrKQpz dXBwb3J0IGhhbmRsaW5nIGVycm9yIHBhZ2VzLiBRdCdzIHdpbGwgYmUgdGhlIGZpcnN0LgoKKiBE dW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZS5jcHA6CihXZWJDb3JlOjpXZWJQYWdlOjpz dXBwb3J0c0V4dGVuc2lvbik6CihXZWJDb3JlOjpXZWJQYWdlOjpleHRlbnNpb24pOgoqIER1bXBS ZW5kZXJUcmVlL3F0L0xheW91dFRlc3RDb250cm9sbGVyUXQuY3BwOgooTGF5b3V0VGVzdENvbnRy b2xsZXI6OnJlc2V0KToKKiBEdW1wUmVuZGVyVHJlZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0 Lmg6CihMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2hvdWxkSGFuZGxlRXJyb3JQYWdlcyk6CihMYXlv dXRUZXN0Q29udHJvbGxlcjo6aGFuZGxlRXJyb3JQYWdlcyk6Ci0tLQogV2ViS2l0VG9vbHMvQ2hh bmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDIzICsrKysrKysrKysrKysr KysrKysrCiBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZS5jcHAg ICB8ICAgMjMgKysrKysrKysrKysrKysrKysrKysKIFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVl L3F0L0R1bXBSZW5kZXJUcmVlLmggICAgIHwgICAgMyArKwogLi4uL0R1bXBSZW5kZXJUcmVlL3F0 L0xheW91dFRlc3RDb250cm9sbGVyUXQuY3BwICAgfCAgICAxICsKIC4uLi9EdW1wUmVuZGVyVHJl ZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0LmggICAgIHwgICAgMyArKwogNSBmaWxlcyBjaGFu Z2VkLCA1MyBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktp dFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwppbmRleCBlMTZhNTFmLi4x YTViZmIxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9v bHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMDktMTEtMTQgIEFudG9uaW8gR29tZXMg IDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBbUXRdIEltcGxlbWVudCBsb2FkIGVycm9yIHBhZ2VzIHN1cHBvcnQg Zm9yIFF0J3MgRFJULgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzE1MDkKKworICAgICAgICBGb3Igbm93LCBpdCB3aWxsIG5vdCBiZSBhIGRlZmF1bHQg ZmVhdHVyZSwgYW5kIGxheW91dCB0ZXN0cworICAgICAgICB0aGF0IHdhbnQgdG8gbWFrZSB1c2Ug b2YgdGhpcyBoYXZlIHRvIGV4cGxpY2l0aWx5IGNhbGwKKyAgICAgICAgJ2hhbmRsZUVycm9yUGFn ZXMoKTsnIGZvciB0aGUgdGVzdCBzb3VyY2UuCisKKyAgICAgICAgQW55IG9mIHRoZSBvdGhlciBE dW1wUmVuZGVyVHJlZSdzIChtYWMsIHdpbiBhbmQgZ3RrKQorICAgICAgICBzdXBwb3J0IGhhbmRs aW5nIGVycm9yIHBhZ2VzLiBRdCdzIHdpbGwgYmUgdGhlIGZpcnN0LgorCisgICAgICAgICogRHVt cFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2Vi UGFnZTo6c3VwcG9ydHNFeHRlbnNpb24pOgorICAgICAgICAoV2ViQ29yZTo6V2ViUGFnZTo6ZXh0 ZW5zaW9uKToKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxl clF0LmNwcDoKKyAgICAgICAgKExheW91dFRlc3RDb250cm9sbGVyOjpyZXNldCk6CisgICAgICAg ICogRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5oOgorICAgICAgICAo TGF5b3V0VGVzdENvbnRyb2xsZXI6OnNob3VsZEhhbmRsZUVycm9yUGFnZXMpOgorICAgICAgICAo TGF5b3V0VGVzdENvbnRyb2xsZXI6OmhhbmRsZUVycm9yUGFnZXMpOgorCiAyMDA5LTExLTEzICBL ZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1 bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlLmNwcCBiL1dlYktpdFRvb2xzL0R1bXBSZW5k ZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlLmNwcAppbmRleCA2MTY2YTU3Li44ODM4NzRiIDEwMDY0 NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZS5jcHAK KysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWUuY3BwCkBA IC0yMTQsNiArMjE0LDI5IEBAIGJvb2wgV2ViUGFnZTo6YWNjZXB0TmF2aWdhdGlvblJlcXVlc3Qo UVdlYkZyYW1lKiBmcmFtZSwgY29uc3QgUU5ldHdvcmtSZXF1ZXN0JiByCiAgICAgcmV0dXJuIFFX ZWJQYWdlOjphY2NlcHROYXZpZ2F0aW9uUmVxdWVzdChmcmFtZSwgcmVxdWVzdCwgdHlwZSk7CiB9 CiAKK2Jvb2wgV2ViUGFnZTo6c3VwcG9ydHNFeHRlbnNpb24oUVdlYlBhZ2U6OkV4dGVuc2lvbiBl eHRlbnNpb24pIGNvbnN0Cit7CisgICAgaWYgKGV4dGVuc2lvbiA9PSBRV2ViUGFnZTo6RXJyb3JQ YWdlRXh0ZW5zaW9uKQorICAgICAgICByZXR1cm4gbV9kcnQtPmxheW91dFRlc3RDb250cm9sbGVy KCktPnNob3VsZEhhbmRsZUVycm9yUGFnZXMoKTsKKworICAgIHJldHVybiBmYWxzZTsKK30KKwor Ym9vbCBXZWJQYWdlOjpleHRlbnNpb24oRXh0ZW5zaW9uIGV4dGVuc2lvbiwgY29uc3QgRXh0ZW5z aW9uT3B0aW9uICpvcHRpb24sIEV4dGVuc2lvblJldHVybiAqb3V0cHV0KQoreworICAgIGNvbnN0 IFFXZWJQYWdlOjpFcnJvclBhZ2VFeHRlbnNpb25PcHRpb24qIGluZm8gPSBzdGF0aWNfY2FzdDxj b25zdCBRV2ViUGFnZTo6RXJyb3JQYWdlRXh0ZW5zaW9uT3B0aW9uKj4ob3B0aW9uKTsKKworICAg IC8vIExldHMgaGFuZGxlIGVycm9yIHBhZ2VzIGZvciB0aGUgbWFpbiBmcmFtZSBmb3Igbm93Lgor ICAgIGlmIChpbmZvLT5mcmFtZSAhPSBtYWluRnJhbWUoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNl OworCisgICAgUVdlYlBhZ2U6OkVycm9yUGFnZUV4dGVuc2lvblJldHVybiogZXJyb3JQYWdlID0g c3RhdGljX2Nhc3Q8UVdlYlBhZ2U6OkVycm9yUGFnZUV4dGVuc2lvblJldHVybio+KG91dHB1dCk7 CisKKyAgICBlcnJvclBhZ2UtPmNvbnRlbnQgPSBRU3RyaW5nKCJkYXRhOnRleHQvaHRtbCw8Ym9k eS8+IikudG9VdGY4KCk7CisKKyAgICByZXR1cm4gdHJ1ZTsKK30KKwogRHVtcFJlbmRlclRyZWU6 OkR1bXBSZW5kZXJUcmVlKCkKICAgICA6IG1fZHVtcFBpeGVscyhmYWxzZSkKICAgICAsIG1fc3Rk aW4oMCkKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5k ZXJUcmVlLmggYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZS5o CmluZGV4IGM3N2QxYTIuLjQ2YTc0YWIgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5k ZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlLmgKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRy ZWUvcXQvRHVtcFJlbmRlclRyZWUuaApAQCAtNjgsNiArNjgsOSBAQCBwdWJsaWM6CiAgICAgdm9p ZCByZXNldFNldHRpbmdzKCk7CiAgICAgdm9pZCBlbmFibGVUZXh0T3V0cHV0KGJvb2wgZW5hYmxl KSB7IG1fZW5hYmxlVGV4dE91dHB1dCA9IGVuYWJsZTsgfQogCisgICAgdmlydHVhbCBib29sIHN1 cHBvcnRzRXh0ZW5zaW9uKFFXZWJQYWdlOjpFeHRlbnNpb24gZXh0ZW5zaW9uKSBjb25zdDsKKyAg ICB2aXJ0dWFsIGJvb2wgZXh0ZW5zaW9uKEV4dGVuc2lvbiBleHRlbnNpb24sIGNvbnN0IEV4dGVu c2lvbk9wdGlvbiAqb3B0aW9uLCBFeHRlbnNpb25SZXR1cm4gKm91dHB1dCk7CisKIHB1YmxpYyBz bG90czoKICAgICBib29sIHNob3VsZEludGVycnVwdEphdmFTY3JpcHQoKSB7IHJldHVybiBmYWxz ZTsgfQogCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9MYXlvdXRU ZXN0Q29udHJvbGxlclF0LmNwcCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0xheW91 dFRlc3RDb250cm9sbGVyUXQuY3BwCmluZGV4IGVmNTc0YmQuLmQ2NDY2NGUgMTAwNjQ0Ci0tLSBh L1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0xheW91dFRlc3RDb250cm9sbGVyUXQuY3Bw CisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0xheW91dFRlc3RDb250cm9sbGVy UXQuY3BwCkBAIC02NCw2ICs2NCw3IEBAIHZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OnJlc2V0 KCkKICAgICBtX3RpbWVvdXRUaW1lci5zdG9wKCk7CiAgICAgbV90b3BMb2FkaW5nRnJhbWUgPSAw OwogICAgIG1fd2FpdEZvclBvbGljeSA9IGZhbHNlOworICAgIG1faGFuZGxlRXJyb3JQYWdlcyA9 IGZhbHNlOwogICAgIHF0X2R1bXBfZWRpdGluZ19jYWxsYmFja3MoZmFsc2UpOwogICAgIHF0X2R1 bXBfcmVzb3VyY2VfbG9hZF9jYWxsYmFja3MoZmFsc2UpOwogfQpkaWZmIC0tZ2l0IGEvV2ViS2l0 VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5oIGIvV2ViS2l0 VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5oCmluZGV4IGRk NTA0YTYuLmUwYWRkNjEgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0 L0xheW91dFRlc3RDb250cm9sbGVyUXQuaAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJl ZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0LmgKQEAgLTYzLDYgKzYzLDcgQEAgcHVibGljOgog ICAgIGJvb2wgc2hvdWxkRHVtcERhdGFiYXNlQ2FsbGJhY2tzKCkgY29uc3QgeyByZXR1cm4gbV9k dW1wRGF0YWJhc2VDYWxsYmFja3M7IH0KICAgICBib29sIHNob3VsZER1bXBTdGF0dXNDYWxsYmFj a3MoKSBjb25zdCB7IHJldHVybiBtX2R1bXBTdGF0dXNDYWxsYmFja3M7IH0KICAgICBib29sIHNo b3VsZFdhaXRVbnRpbERvbmUoKSBjb25zdCB7IHJldHVybiBtX3dhaXRGb3JEb25lOyB9CisgICAg Ym9vbCBzaG91bGRIYW5kbGVFcnJvclBhZ2VzKCkgY29uc3QgeyByZXR1cm4gbV9oYW5kbGVFcnJv clBhZ2VzOyB9CiAgICAgYm9vbCBjYW5PcGVuV2luZG93cygpIGNvbnN0IHsgcmV0dXJuIG1fY2Fu T3BlbldpbmRvd3M7IH0KICAgICBib29sIHNob3VsZER1bXBUaXRsZUNoYW5nZXMoKSBjb25zdCB7 IHJldHVybiBtX2R1bXBUaXRsZUNoYW5nZXM7IH0KICAgICBib29sIHdhaXRGb3JQb2xpY3koKSBj b25zdCB7IHJldHVybiBtX3dhaXRGb3JQb2xpY3k7IH0KQEAgLTg3LDYgKzg4LDcgQEAgcHVibGlj IHNsb3RzOgogICAgIHZvaWQga2VlcFdlYkhpc3RvcnkoKTsKICAgICB2b2lkIG5vdGlmeURvbmUo KTsKICAgICB2b2lkIGR1bXBCYWNrRm9yd2FyZExpc3QoKSB7IG1fZHVtcEJhY2tGb3J3YXJkTGlz dCA9IHRydWU7IH0KKyAgICB2b2lkIGhhbmRsZUVycm9yUGFnZXMoKSB7IG1faGFuZGxlRXJyb3JQ YWdlcyA9IHRydWU7IH0KICAgICB2b2lkIGR1bXBFZGl0aW5nQ2FsbGJhY2tzKCk7CiAgICAgdm9p ZCBkdW1wUmVzb3VyY2VMb2FkQ2FsbGJhY2tzKCk7CiAgICAgdm9pZCBxdWV1ZUJhY2tOYXZpZ2F0 aW9uKGludCBob3dGYXJCYWNrd2FyZCk7CkBAIC0xNDAsNiArMTQyLDcgQEAgcHJpdmF0ZToKICAg ICBib29sIG1fZHVtcERhdGFiYXNlQ2FsbGJhY2tzOwogICAgIGJvb2wgbV9kdW1wU3RhdHVzQ2Fs bGJhY2tzOwogICAgIGJvb2wgbV93YWl0Rm9yUG9saWN5OworICAgIGJvb2wgbV9oYW5kbGVFcnJv clBhZ2VzOwogCiAgICAgUUJhc2ljVGltZXIgbV90aW1lb3V0VGltZXI7CiAgICAgUVdlYkZyYW1l KiBtX3RvcExvYWRpbmdGcmFtZTsKLS0gCjEuNi4wLjQKCg==