<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>315043</bug_id>
          
          <creation_ts>2026-05-18 13:58:06 -0700</creation_ts>
          <short_desc>DiagnosticLoggingClient.h: add missing StringHash.h include</short_desc>
          <delta_ts>2026-05-18 14:41:08 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CMake</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Simon Lewis">simon.lewis</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2211806</commentid>
    <comment_count>0</comment_count>
    <who name="Simon Lewis">simon.lewis</who>
    <bug_when>2026-05-18 13:58:06 -0700</bug_when>
    <thetext>ValuePayload uses HashMap&lt;String, ...&gt;::set(), which instantiates DefaultHash&lt;String&gt; -- defined in StringHash.h, not included here. After 296773@main put this header in the WebCore_Private clang module, building that module fails on the cmake-mac path (swiftc&apos;s clang importer):

  HashTable.h:893:27: error: definition of &apos;DefaultHash&lt;WTF::String&gt;&apos; must be imported from module &apos;wtf.Core.text.StringHash&apos; before it is required

Non-modular builds and xcodebuild are unaffected because some earlier header in the TU pulls in StringHash.h.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2211807</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2026-05-18 13:58:12 -0700</bug_when>
    <thetext>&lt;rdar://problem/177373691&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2211823</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2026-05-18 14:41:06 -0700</bug_when>
    <thetext>Committed 313440@main (756f5f9832b5): &lt;https://commits.webkit.org/313440@main&gt;

Reviewed commits have been landed. Closing PR #65129 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>