31502 2009-11-13 17:55:27 -0800 IME looks suboptimal on Chromium/Mac 2013-04-08 14:13:26 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC OS X 10.5 RESOLVED WONTFIX P2 Normal --- 1 thakis webkit-unassigned hbono ojan schenney suzhe oldest_to_newest 163616 0 thakis 2009-11-13 17:55:27 -0800 While the glyph selection popup is active with the Kotoeri IME, the cursor is still visible. Safari hides it. It is not possible to move the cursor the the rightmost position in the current editing range, which means hiding the cursor is prettier. Also, it matches the system behavior better. However, the lines I'm changing were probably there for a reason (they're in the initial commit of the chromium tree; I'll see if I can find an older repo somewhere). Chromium/Mac seems to work with the patch. Maybe the reason these lines were introduced is no longer valid? Can someone test this on windows / linux? 163617 1 43217 thakis 2009-11-13 17:57:11 -0800 Created attachment 43217 Patch. 163622 2 thakis 2009-11-13 18:08:56 -0800 Oh, and I discovered this while writing http://codereview.chromium.org/386032 . 163633 3 evan 2009-11-13 19:14:37 -0800 changelog description isn't descriptive 163836 4 hbono 2009-11-15 20:43:42 -0800 (In reply to comment #0) > While the glyph selection popup is active with the Kotoeri IME, the cursor is > still visible. Safari hides it. It is not possible to move the cursor the the > rightmost position in the current editing range, which means hiding the cursor > is prettier. Also, it matches the system behavior better. > > However, the lines I'm changing were probably there for a reason (they're in > the initial commit of the chromium tree; I'll see if I can find an older repo > somewhere). Chromium/Mac seems to work with the patch. Maybe the reason these > lines were introduced is no longer valid? Can someone test this on windows / > linux? It seems the problem written in my comment (deleted by this change) still happens on Windows, i.e. Windows Chromium does not render characters between |targetStart| and |targetEnd| when applying this change. On the other hand, it seems this problem does not happen either on Linux or on Mac. So, is it better to figure out why this problem happens only on Windows before applying this change? Regards, Hironori Bono 163840 5 thakis 2009-11-15 21:34:29 -0800 Thanks for your comment. I agree that there's no reason to rush this. Sounds like I need to get a windows system with an IME and a chromium build set up :-/ I will ping this bug when I know more. 43217 2009-11-13 17:57:11 -0800 2010-06-10 19:53:10 -0700 Patch. webkit_ime.diff text/plain 1754 thakis SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTA5ODYpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTEtMTMgIE5pY29s YXMgV2ViZXIgIDx0aGFraXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgSU1FIGJlaGF2ZSBtb3JlIG5pY2VseS4KKwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE1MDIKKwor ICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJ bXBsOjpoYW5kbGVDb21wb3NpdGlvbkV2ZW50KToKKwogMjAwOS0xMS0xMyAgWWFhciBTY2huaXRt YW4gIDx5YWFyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEds YXprb3YuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAkocmV2aXNpb24gNTA5 ODUpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMTAyMCwxMyArMTAyMCw5IEBAIGJvb2wgV2ViVmlld0ltcGw6OmhhbmRsZUNvbXBvc2l0 aW9uRXZlbnQKICAgICAgICAgdW5kZXJsaW5lc1syXS5lbmRPZmZzZXQgPSBzdGF0aWNfY2FzdDxp bnQ+KGltZVN0cmluZy5sZW5ndGgoKSk7CiAgICAgICAgIHVuZGVybGluZXNbMl0udGhpY2sgPSB0 cnVlOwogICAgICAgICB1bmRlcmxpbmVzWzJdLmNvbG9yLnNldFJHQigweGQzLCAweGQzLCAweGQz KTsKLSAgICAgICAgLy8gV2hlbiB3ZSB1c2UgY3VzdG9tIHVuZGVybGluZXMsIFdlYktpdCAoIklu bGluZVRleHRCb3guY3BwIiBMaW5lIDI4MikKLSAgICAgICAgLy8gcHJldmVudHMgZnJvbSB3cml0 aW5nIGEgdGV4dCBpbiBiZXR3ZWVuICdzZWxlY3Rpb25TdGFydCcgYW5kCi0gICAgICAgIC8vICdz ZWxlY3Rpb25FbmQnIHNvbWVob3cuCi0gICAgICAgIC8vIFRoZXJlZm9yZSwgd2UgdXNlIHRoZSAn Y3Vyc29yUG9zaXRpb24nIGZvciB0aGVzZSBhcmd1bWVudHMgc28gdGhhdAotICAgICAgICAvLyB0 aGVyZSBhcmUgbm90IGFueSBjaGFyYWN0ZXJzIGluIHRoZSBhYm92ZSByZWdpb24uCisKICAgICAg ICAgZWRpdG9yLT5zZXRDb21wb3NpdGlvbihjb21wb3NpdGlvblN0cmluZywgdW5kZXJsaW5lcywK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjdXJzb3JQb3NpdGlvbiwgY3Vyc29yUG9z aXRpb24pOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRhcmdldFN0YXJ0LCB0YXJn ZXRFbmQpOwogICAgICAgICAvLyBUaGUgZ2l2ZW4gc3RyaW5nIGlzIGEgcmVzdWx0IHN0cmluZywg d2hpY2ggbWVhbnMgdGhlIG9uZ29pbmcKICAgICAgICAgLy8gY29tcG9zaXRpb24gaGFzIGJlZW4g Y29tcGxldGVkLiBJIGhhdmUgdG8gY2FsbCB0aGUKICAgICAgICAgLy8gRWRpdG9yOjpjb25maXJt Q29tcGxldGlvbigpIGFuZCBjb21wbGV0ZSB0aGlzIGNvbXBvc2l0aW9uLgo=